mrowe@apple.com [Tue, 16 Sep 2008 17:02:09 +0000 (17:02 +0000)]
Fix typo in Dimitri's email address.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 16 Sep 2008 16:59:57 +0000 (16:59 +0000)]
2008-09-16 Dimitri Glazkov <dlglazkov@chromium.org>
Fix the Windows build.
Add some extra parentheses to stop MSVC from complaining so much.
* VM/Machine.cpp:
(JSC::Machine::privateExecute):
(JSC::Machine::cti_op_stricteq):
(JSC::Machine::cti_op_nstricteq):
* kjs/operations.cpp:
(JSC::strictEqual):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 16 Sep 2008 16:59:18 +0000 (16:59 +0000)]
2008-09-16 Dirk Schulze <vbs85@gmx.de>
Reviewed by Oliver Hunt and Alp Toker.
Implemented toDataURL in Cairo. Only PNG support
at the moment.
Qt, Cairo and wx require toDataURL implementations
https://bugs.webkit.org/show_bug.cgi?id=17719
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::writeFunction):
(WebCore::ImageBuffer::toDataURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 16 Sep 2008 16:47:44 +0000 (16:47 +0000)]
Revert r36505 ("Only forward events to media element controls if they are visible")
Sorry, it snuck in while trying to commit something else.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 16 Sep 2008 16:45:20 +0000 (16:45 +0000)]
2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Hide unused media element controls in the QtWebKit port
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Tue, 16 Sep 2008 16:40:57 +0000 (16:40 +0000)]
Only forward events to media element controls if they are visible
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 16 Sep 2008 14:19:16 +0000 (14:19 +0000)]
2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix compilation of the Qt scrollbar code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Tue, 16 Sep 2008 14:15:29 +0000 (14:15 +0000)]
Reviewed by Anders Carlsson.
Prevent accesses off of the end of the buffer introduced in r36450
and when checking for descriptions of mime. Also, coding style fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 16 Sep 2008 11:12:52 +0000 (11:12 +0000)]
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20634
SVG transform attribute is ignored by <use> in <clipPath>
Transform the paths with the local transform when part
of a clip path.
Test: svg/custom/use-clipped-transform.svg
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Sep 2008 11:07:41 +0000 (11:07 +0000)]
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
Move more instance variables down to the C++ class.
* Plugins/WebBaseNetscapePluginStream.h:
(WebNetscapePluginStream::WebNetscapePluginStream):
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream dealloc]):
(-[WebBaseNetscapePluginStream finalize]):
(-[WebBaseNetscapePluginStream transferMode]):
(-[WebBaseNetscapePluginStream plugin]):
(-[WebBaseNetscapePluginStream setPlugin:]):
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
(-[WebBaseNetscapePluginStream wantsAllStreams]):
(-[WebBaseNetscapePluginStream _destroyStream]):
(-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
(-[WebBaseNetscapePluginStream _deliverData]):
(-[WebBaseNetscapePluginStream _deliverDataToFile:]):
(-[WebBaseNetscapePluginStream finishedLoading]):
(-[WebBaseNetscapePluginStream receivedData:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Sep 2008 09:48:07 +0000 (09:48 +0000)]
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Move a bunch of instance variables into the C++ class.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]):
(-[WebBaseNetscapePluginStream errorForReason:]):
(-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream dealloc]):
(-[WebBaseNetscapePluginStream setRequestURL:]):
(-[WebBaseNetscapePluginStream setResponseURL:]):
(-[WebBaseNetscapePluginStream setMIMEType:]):
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
(-[WebBaseNetscapePluginStream _destroyStream]):
(-[WebBaseNetscapePluginStream _destroyStreamWithReason:]):
(-[WebBaseNetscapePluginStream _deliverData]):
(-[WebBaseNetscapePluginStream receivedData:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:47:35 +0000 (09:47 +0000)]
Fix Qt build bustage in PlatformScrollbarQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Sep 2008 09:33:09 +0000 (09:33 +0000)]
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Add a new WebNetscapePluginStream C++ class. The idea is that it is supposed to replace the Obj-C
WebBaseNetscapePluginStream class. The plan is to gradually move/rewrite code from the Obj-C class to the C++ class
until the C++ class can replace the Obj-C class.
* Plugins/WebBaseNetscapePluginStream.h:
(WebNetscapePluginStream::create):
(WebNetscapePluginStream::WebNetscapePluginStream):
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream initWithFrameLoader:]):
(-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream dealloc]):
(-[WebBaseNetscapePluginStream finalize]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:27:27 +0000 (09:27 +0000)]
Fix Qt build bustage in ScrollbarThemeQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:21:56 +0000 (09:21 +0000)]
Speculative fix for scrollbar issues on GTK.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:17:35 +0000 (09:17 +0000)]
Fix Qt build bustage in ScrollbarThemeQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:16:07 +0000 (09:16 +0000)]
Fix Qt build bustage in ScrollbarThemeQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Sep 2008 09:15:38 +0000 (09:15 +0000)]
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Instead of storing a pointer to NPP method individually, just store a pointer to the NPNetscapeFuncs vtable.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream setPlugin:]):
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
(-[WebBaseNetscapePluginStream wantsAllStreams]):
(-[WebBaseNetscapePluginStream _destroyStream]):
(-[WebBaseNetscapePluginStream _deliverData]):
* Plugins/WebNetscapePluginPackage.h:
* Plugins/WebNetscapePluginPackage.m:
(-[WebNetscapePluginPackage pluginFuncs]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:11:15 +0000 (09:11 +0000)]
Fix Qt build bustage in PlatformScrollbarQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Sep 2008 09:06:45 +0000 (09:06 +0000)]
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Remove references to WebNetscapePluginStream.
* Plugins/WebBaseNetscapePluginView.h:
* Plugins/WebNetscapePluginEmbeddedView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 09:00:47 +0000 (09:00 +0000)]
Fix GTK bustage. Maybe. Cleaning up after Chris Fleizach's checkin...
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 06:53:34 +0000 (06:53 +0000)]
Convert Qt to ScrollbarTheme. Add cross-platform support for jumping a scrollbar thumb directly to a position on the track (Shift+Click on Windows, Middle Click on Qt)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 06:48:05 +0000 (06:48 +0000)]
Fix Qt build bustage in Localizations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 16 Sep 2008 06:39:39 +0000 (06:39 +0000)]
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=20860
REGRESSION: Crash in RenderLayer::hasVisibleContent() loading wavy.com
* WebView/WebFrame.mm:
(-[WebFrame _getVisibleRect:]): Changed to check if the RenderPart has
layout before accessing it, instead of checking if the frame inside it
has layout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Tue, 16 Sep 2008 06:14:22 +0000 (06:14 +0000)]
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20180
Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
* GNUmakefile.am: Add CSSNthSelector
* WebCore.pro: Add CSSNthSelector
* WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
* WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
* css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
* css/CSSNthSelector.cpp: Added.
(WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache
(WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
* css/CSSNthSelector.h: Added.
(WebCore::CSSNthSelector::CSSNthSelector):
(WebCore::CSSNthSelector::~CSSNthSelector):
* css/CSSParser.cpp:
(WebCore::CSSParser::createFloatingNthSelector):
* css/CSSParser.h:
* css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector
(WebCore::CSSSelector::CSSSelector):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 16 Sep 2008 06:12:02 +0000 (06:12 +0000)]
Complete my previous changelog entry
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 16 Sep 2008 06:08:51 +0000 (06:08 +0000)]
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up the === and !== operators by choosing the fast cases better
No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
* VM/Machine.cpp:
(JSC::Machine::privateExecute):
(JSC::Machine::cti_op_stricteq):
(JSC::Machine::cti_op_nstricteq):
* kjs/JSImmediate.h:
(JSC::JSImmediate::areBothImmediate):
* kjs/operations.cpp:
(JSC::strictEqual):
(JSC::strictEqualSlowCase):
* kjs/operations.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 16 Sep 2008 06:06:23 +0000 (06:06 +0000)]
Coding style cleanup.
RS=Sam
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Tue, 16 Sep 2008 05:54:22 +0000 (05:54 +0000)]
2008-09-15 Alice Liu <alice.liu@apple.com>
A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
Reviewed by Stephanie Lewis.
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
but not Intel. Add a check for nil before calling.
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 16 Sep 2008 05:53:15 +0000 (05:53 +0000)]
Bug 20874: op_resolve does not do any form of caching
<https://bugs.webkit.org/show_bug.cgi?id=20874>
Reviewed by Cameron Zwarich
This patch adds an op_resolve_global opcode to handle (and cache)
property lookup we can statically determine must occur on the global
object (if at all).
3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
10% in math-partial-sums
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 05:39:06 +0000 (05:39 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36478. It did little to help the issue either.
* fast/js/resources/garbage-collect-after-string-appends.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 05:14:28 +0000 (05:14 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Avoid the single character optimization.
* fast/js/resources/garbage-collect-after-string-appends.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 04:34:17 +0000 (04:34 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36476. It did little to help the issue.
* fast/js/resources/garbage-collect-after-string-appends.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 03:59:32 +0000 (03:59 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Make this test a little more forgiving.
* fast/js/resources/garbage-collect-after-string-appends.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 03:46:58 +0000 (03:46 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36462. It broke document.all.
* VM/CTI.cpp:
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
* VM/CTI.h:
* VM/Machine.cpp:
(JSC::Machine::Machine):
(JSC::Machine::cti_op_eq_null):
(JSC::Machine::cti_op_neq_null):
* VM/Machine.h:
(JSC::Machine::isJSString):
* kjs/JSCell.h:
* kjs/JSWrapperObject.h:
* kjs/StringObject.h:
* kjs/StringObjectThatMasqueradesAsUndefined.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 16 Sep 2008 03:27:37 +0000 (03:27 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
now passes on Leopard in 10.5.5.
* platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Tue, 16 Sep 2008 02:46:39 +0000 (02:46 +0000)]
2008-09-15 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Clean up some inspector JS callbacks to remove an extra return.
* page/InspectorController.cpp:
(WebCore::hideDOMNodeHighlight):
(WebCore::loaded):
(WebCore::unloading):
(WebCore::attach):
(WebCore::detach):
(WebCore::startDebuggingAndReloadInspectedPage):
(WebCore::stopDebugging):
(WebCore::debuggerAttached):
(WebCore::pauseOnExceptions):
(WebCore::pauseInDebugger):
(WebCore::resumeDebugger):
(WebCore::stepOverStatementInDebugger):
(WebCore::stepIntoStatementInDebugger):
(WebCore::stepOutOfFunctionInDebugger):
(WebCore::isWindowVisible):
(WebCore::closeWindow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Tue, 16 Sep 2008 02:44:34 +0000 (02:44 +0000)]
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
<https://bugs.webkit.org/show_bug.cgi?id=20863>
r36427 changed the number of arguments to op_construct without changing
the argument index for the vPC in the call to initializeCallFrame() in
the CTI case. This caused a JSC test failure. Correcting the argument
index fixes the test failure.
* VM/Machine.cpp:
(JSC::Machine::cti_op_construct_JSConstruct):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 02:30:22 +0000 (02:30 +0000)]
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Sep 2008 02:29:09 +0000 (02:29 +0000)]
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Tue, 16 Sep 2008 01:34:20 +0000 (01:34 +0000)]
Fix GCC 4.2 build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 16 Sep 2008 00:46:10 +0000 (00:46 +0000)]
2008-09-15 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
* transitions/transform-op-list-match-expected.txt: Added.
* transitions/transform-op-list-match.html: Added.
* transitions/transform-op-list-no-match-expected.txt: Added.
* transitions/transform-op-list-no-match.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Tue, 16 Sep 2008 00:17:58 +0000 (00:17 +0000)]
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
https://bugs.webkit.org/show_bug.cgi?id=20808
Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
Inside the definition list, each <dt> "term" has an accessibility description ("term"),
as does each <dd> tag ("definition")
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 16 Sep 2008 00:01:11 +0000 (00:01 +0000)]
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
Several renames:
dispatchHTMLEvent -> dispatchEventForType
setHTMLEventListener -> setEventListenerForType
getHTMLEventListener -> eventListenerForType
removeHTMLEventListener -> removeEventListenerForType
isHTMLEventListener -> isAttachedToEventTargetNode
...
Similar renames for the dispatch/get/set/*Window*Event functions.
Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
SVG is able to use the code as well now. This affects most files in html/.
No functional changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 23:44:10 +0000 (23:44 +0000)]
Switch PlatformScrollbarWin's hit testing to use ScrollbarTheme. The file is now nearly completely empty. PlatformScrollbarSafari and PlatformScrollbarQt still need to be converted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 15 Sep 2008 23:38:43 +0000 (23:38 +0000)]
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a typo in op_get_by_id_chain that caused it to miss every time
in the interpreter.
Also, a little cleanup.
* VM/Machine.cpp:
(JSC::Machine::privateExecute): Set up baseObject before entering the
loop, so we compare against the right values.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 15 Sep 2008 23:37:31 +0000 (23:37 +0000)]
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the CalledAsConstructor flag from the call frame header. Now,
we use an explicit opcode at the call site to fix up constructor results.
SunSpider says 0.4% faster.
cti_op_construct_verify is an out-of-line function call for now, but we
can fix that once StructureID holds type information like isObject.
* VM/CTI.cpp:
(JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
* VM/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* VM/CodeGenerator.cpp: Codegen for the new opcode. Also...
(JSC::CodeGenerator::emitCall): ... don't test for known non-zero value.
(JSC::CodeGenerator::emitConstruct): ... ditto.
* VM/Machine.cpp: No more CalledAsConstructor
(JSC::Machine::privateExecute): Implementation for the new opcode.
(JSC::Machine::cti_op_ret): The speedup: no need to check whether we were
called as a constructor.
(JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
* VM/Machine.h:
* VM/Opcode.h: Declare new opcode.
* VM/RegisterFile.h:
(JSC::RegisterFile::): No more CalledAsConstructor
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Sep 2008 23:33:25 +0000 (23:33 +0000)]
2008-09-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
masquerading may be handled differently (through the StructureIDs - see bug
#20823).
>1% on v8-tests.
* VM/CTI.cpp:
(JSC::CTI::emitJumpSlowCaseIfIsJSCell):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
* VM/CTI.h:
* VM/Machine.cpp:
(JSC::Machine::Machine):
(JSC::Machine::cti_op_eq_null):
(JSC::Machine::cti_op_neq_null):
* VM/Machine.h:
(JSC::Machine::doesMasqueradesAsUndefined):
* kjs/JSWrapperObject.h:
(JSC::JSWrapperObject::):
(JSC::JSWrapperObject::JSWrapperObject):
* kjs/StringObject.h:
(JSC::StringObject::StringObject):
* kjs/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Mon, 15 Sep 2008 23:08:07 +0000 (23:08 +0000)]
2008-09-15 David Smith <catfish.man@gmail.com>
"Just do it"'d by Mark Rowe
https://bugs.webkit.org/show_bug.cgi?id=20856
Add missing license header
* dom/NodeRenderStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 15 Sep 2008 22:17:16 +0000 (22:17 +0000)]
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Oliver Hunt.
r36427 broke CodeBlock::dump() by changing the number of arguments to
op_construct without changing the code that prints it. This patch fixes
it by printing the additional argument.
* JavaScriptCore.xcodeproj/project.pbxproj:
* VM/CodeBlock.cpp:
(JSC::CodeBlock::dump):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 21:52:23 +0000 (21:52 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Add default constructor for ShadowData
https://bugs.webkit.org/show_bug.cgi?id=20757
Test: transitions/shadow.html
* rendering/style/RenderStyle.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 21:40:52 +0000 (21:40 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
RenderStyle should update keyframes.
http://bugs.webkit.org/show_bug.cgi?id=20756
* rendering/style/RenderStyle.cpp:
(WebCore::StyleRareNonInheritedData::updateKeyframes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 21:31:43 +0000 (21:31 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Unnecessary ASSERT in ImplicitAnimation destructor.
https://bugs.webkit.org/show_bug.cgi?id=20817
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::~ImplicitAnimation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 15 Sep 2008 21:27:18 +0000 (21:27 +0000)]
WebKit:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(-[WebBaseNetscapePluginStream initWithFrameLoader:]):
(-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
(-[WebBaseNetscapePluginStream dealloc]):
(-[WebBaseNetscapePluginStream finalize]):
(-[WebBaseNetscapePluginStream start]):
(-[WebBaseNetscapePluginStream stop]):
(-[WebBaseNetscapePluginStream cancelLoadWithError:]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
(-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
* Plugins/WebNetscapePluginEmbeddedView.mm:
* Plugins/WebNetscapePluginStream.h: Removed.
* Plugins/WebNetscapePluginStream.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 21:22:25 +0000 (21:22 +0000)]
Oops. Forgot this file in previous commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 21:21:15 +0000 (21:21 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Tests for -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=20771
* transforms/2d/compound-2d-transforms-expected.txt: Added.
* transforms/2d/compound-2d-transforms.html: Added.
* transforms/2d/compound-transforms-vs-containers.html: Added.
* transforms/2d/transform-2d-expected.txt: Added.
* transforms/2d/transform-2d.html: Added.
* transforms/2d/transform-accuracy-expected.txt: Added.
* transforms/2d/transform-accuracy.html: Added.
* transforms/2d/transform-borderbox.html: Added.
* transforms/2d/transform-origin-borderbox.html: Added.
* transforms/2d/resources/transform-test-utils.js: Added.
* platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
* platform/mac/transforms/2d/transform-borderbox-expected.txt: Added.
* platform/mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 21:06:38 +0000 (21:06 +0000)]
Fix Win build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 15 Sep 2008 21:02:15 +0000 (21:02 +0000)]
Reviewed by Simon.
Yahoo assumes non-RFC compliant HTTP redirect behaviour. QtWebKit is (more)
compliant, so broken. I think the Yahoo-assumed behaviour is real-world standard.
Basically, Yahoo's login procedure for flickr looks like this:
1. load flickr.com, click "sign in"
2. this is a Yahoo page with a form
(https://login.yahoo.com/config/login?.src=flickr...)
when you click the "Sign In" button, the form submits to a yahoo.com POST URL
3. The POST returns with a 302 (redirect) to another yahoo.com URL
4. If you POST the redirected Location:, it all breaks. Yahoo assumes you will
convert the method to GET, which works fine but is definitely not
RFC-compliant. It would be compliant for 303, and the RFC says that many
implementations treat 302 and 303 the same way (for HTTP/1.0 compliance), but
converting to GET is explicitly wrong for 302.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 20:59:50 +0000 (20:59 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Tests for animations.
https://bugs.webkit.org/show_bug.cgi?id=20789
* animations/animation-test-helpers.js: Added.
* animations/generic-from-to-expected.txt: Added.
* animations/generic-from-to.html: Added.
* animations/multiple-animations-expected.txt: Added.
* animations/multiple-animations.html: Added.
* animations/multiple-keyframes-expected.txt: Added.
* animations/multiple-keyframes.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
treat@webkit.org [Mon, 15 Sep 2008 20:53:49 +0000 (20:53 +0000)]
Reviewed by Simon.
Fix plugin extension info. It was returning the mimetype where the
extension was given.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Mon, 15 Sep 2008 20:40:28 +0000 (20:40 +0000)]
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Coding style violation!!!! Cleanup AnimationBase.cpp
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 20:03:25 +0000 (20:03 +0000)]
2008-09-15 David Hyatt <hyatt@apple.com>
Move all hit testing code for scrollbars into the base class. Refactor
it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
functions.
No platform is using this code yet. Although it has been moved and compiles
(even on Mac), it is not being used on any platform.
Reviewed by Sam Weinig
* platform/ScrollBar.cpp:
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::startTimerIfNeeded):
(WebCore::Scrollbar::handleMouseMoveEvent):
(WebCore::Scrollbar::handleMouseOutEvent):
(WebCore::Scrollbar::handleMouseReleaseEvent):
(WebCore::Scrollbar::handleMousePressEvent):
* platform/ScrollBar.h:
(WebCore::Scrollbar::handleContextMenuEvent):
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::hitTest):
(WebCore::ScrollbarTheme::invalidateOnMouseEnterExit):
(WebCore::ScrollbarTheme::invalidatePart):
(WebCore::ScrollbarTheme::shouldCenterOnThumb):
(WebCore::ScrollbarTheme::centerOnThumb):
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackLength):
(WebCore::ScrollbarTheme::initialAutoscrollTimerDelay):
(WebCore::ScrollbarTheme::autoscrollTimerDelay):
* platform/Widget.h:
(WebCore::Widget::parent):
* platform/mac/PlatformScrollBar.h:
(WebCore::PlatformScrollbar::handleMouseMoveEvent):
(WebCore::PlatformScrollbar::handleMouseOutEvent):
(WebCore::PlatformScrollbar::handleMousePressEvent):
(WebCore::PlatformScrollbar::handleMouseReleaseEvent):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::convertFromContainingWindow):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
* platform/win/ScrollbarThemeWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 15 Sep 2008 18:48:20 +0000 (18:48 +0000)]
Reviewed by Sam Weinig.
- fix <rdar://problem/5842247> Single long breakable word takes O(n^2) to lay out
Cache the next breakable position for text nodes in InlineIterator.
* rendering/bidi.cpp:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::increment):
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 15 Sep 2008 17:10:48 +0000 (17:10 +0000)]
2008-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Fix assertion and integral pixel issue when creating subimages.
https://bugs.webkit.org/show_bug.cgi?id=20786
* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::draw):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 15 Sep 2008 15:16:15 +0000 (15:16 +0000)]
Build fix
* kjs/StructureID.cpp: Removed a stray semicolon.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 12:43:37 +0000 (12:43 +0000)]
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Implment seek() and clean up and improve debugging output
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 11:40:22 +0000 (11:40 +0000)]
2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
m_mediaObject, m_audioOutput, m_videoWidget get created in the
c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
only check if we use the MediaPlayerPrivate after it has been deleted.
Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 15 Sep 2008 11:35:22 +0000 (11:35 +0000)]
WebCore:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Check the width and height and throw an exception if any of them are 0.
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern):
LayoutTests:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Add test for createPattern where the canvas passed in has a zero height/width.
* fast/canvas/canvas-with-incorrect-args-expected.txt:
* fast/canvas/canvas-with-incorrect-args.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 11:28:59 +0000 (11:28 +0000)]
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Render media element controls with antialiasing enabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 11:27:25 +0000 (11:27 +0000)]
2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Upon non fatal error, switch to the pause state (so that playback can continue)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 11:22:05 +0000 (11:22 +0000)]
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Mon, 15 Sep 2008 11:16:13 +0000 (11:16 +0000)]
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Make QtInstance::create() private and fix caching
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 15 Sep 2008 10:43:14 +0000 (10:43 +0000)]
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Fix a crash in fast/js/exception-expression-offset.html caused by not
updating all mentions of the length of op_construct in r36427.
* VM/Machine.cpp:
(JSC::Machine::cti_op_construct_NotJSConstruct):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 10:20:59 +0000 (10:20 +0000)]
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix layout test failure introduced by fix for 20849
(The failing test was fast/js/delete-then-put.html)
* kjs/JSObject.cpp:
(JSC::JSObject::removeDirect): Clear enumeration cache
in the dictionary case.
* kjs/JSObject.h:
(JSC::JSObject::putDirect): Ditto.
* kjs/StructureID.h:
(JSC::StructureID::clearEnumerationCache): Inline to handle the
clear.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 10:02:56 +0000 (10:02 +0000)]
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix JSC test failures introduced by fix for 20849
* kjs/PropertyMap.cpp:
(JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 15 Sep 2008 09:39:26 +0000 (09:39 +0000)]
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20851>
r36410 introduced an optimization for parseInt() that is incorrect when
its argument is larger than the range of a 32-bit integer. If the
argument is a number that is not an immediate integer, then the correct
behaviour is to return the floor of its value, unless it is an infinite
value, in which case the correct behaviour is to return 0.
JavaScriptCore:
* kjs/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
LayoutTests:
* fast/js/numeric-conversion-expected.txt:
* fast/js/resources/numeric-conversion.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 09:13:11 +0000 (09:13 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dsmith@webkit.org [Mon, 15 Sep 2008 08:45:35 +0000 (08:45 +0000)]
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=20180
>2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
* css/CSSStyleSelector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 08:34:07 +0000 (08:34 +0000)]
Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 08:31:24 +0000 (08:31 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 15 Sep 2008 07:27:14 +0000 (07:27 +0000)]
2008-09-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.
~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.
* kjs/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
* kjs/PropertyMap.cpp:
(JSC::PropertyMap::getEnumerablePropertyNames):
* kjs/PropertyMap.h:
* kjs/StructureID.cpp:
(JSC::StructureID::StructureID):
(JSC::StructureID::getEnumerablePropertyNames):
* kjs/StructureID.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 06:33:40 +0000 (06:33 +0000)]
Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 06:26:15 +0000 (06:26 +0000)]
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up JS construction by extracting "prototype" lookup so PIC applies.
~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.
* VM/CTI.cpp:
(JSC::CTI::compileOpCall): Account for extra arg for prototype.
(JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
* VM/CodeGenerator.cpp:
(JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
* VM/Machine.cpp:
(JSC::Machine::privateExecute): Expect prototype arg in op_construct.
(JSC::Machine::cti_op_construct_JSConstruct): ditto
(JSC::Machine::cti_op_construct_NotJSConstruct): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Mon, 15 Sep 2008 05:38:00 +0000 (05:38 +0000)]
Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.
https://bugs.webkit.org/show_bug.cgi?id=20555
Reviewed by Timothy Hatcher.
* page/inspector/ResourcesPanel.js: Added a container for all resource graphs.
Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
* page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 15 Sep 2008 05:05:17 +0000 (05:05 +0000)]
Reviewed by Eric Seidel.
Add a protected destructor for RefCounted.
It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.
No change in behavior.
* wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 05:00:29 +0000 (05:00 +0000)]
Fix Qt bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Mon, 15 Sep 2008 04:52:44 +0000 (04:52 +0000)]
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results
Test: fast/dom/Range/compareBoundaryPoints-2.html
* dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END
and END_TO_START.
* page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 03:10:35 +0000 (03:10 +0000)]
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Trying again.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 02:55:16 +0000 (02:55 +0000)]
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Blind attempt to fix build. Correct parameters for hasInstance.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::hasInstance):
* bindings/js/JSQuarantinedObjectWrapper.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 15 Sep 2008 02:23:24 +0000 (02:23 +0000)]
WebCore:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed
<https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
on Tiger.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getLastResortFallbackFont):
LayoutTests:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed
<https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes
on Tiger.
* platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
* platform/mac/fast/text/last-resort-font-expected.png: Removed.
* platform/mac/fast/text/last-resort-font-expected.txt: Removed.
* platform/mac/fast/text/last-resort-font.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Sep 2008 02:21:42 +0000 (02:21 +0000)]
Now with all new and improved Changelog in the correct order.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Sep 2008 02:18:13 +0000 (02:18 +0000)]
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
* API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance): Ditto.
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor): Look up and pass in prototype.
* JavaScriptCore.exp:
* VM/CTI.cpp:
(JSC::CTI::privateCompileMainPass): Pass along prototype.
* VM/CodeBlock.cpp:
(JSC::CodeBlock::dump): Print third arg.
* VM/CodeGenerator.cpp:
(JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
is a third argument.
* VM/CodeGenerator.h:
* VM/Machine.cpp:
(JSC::Machine::privateExecute): Pass along the prototype.
(JSC::Machine::cti_op_instanceof): ditto
* kjs/JSObject.cpp:
(JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
* kjs/JSObject.h:
* kjs/nodes.cpp:
(JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
property and pass that register to instanceof.
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 15 Sep 2008 02:13:10 +0000 (02:13 +0000)]
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
* API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance): Ditto.
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor): Look up and pass in prototype.
* JavaScriptCore.exp:
* VM/CTI.cpp:
(JSC::CTI::privateCompileMainPass): Pass along prototype.
* VM/CodeBlock.cpp:
(JSC::CodeBlock::dump): Print third arg.
* VM/CodeGenerator.cpp:
(JSC::CodeGenerator::emitInstanceOf): Implement this, now that there
is a third argument.
* VM/CodeGenerator.h:
* VM/Machine.cpp:
(JSC::Machine::privateExecute): Pass along the prototype.
(JSC::Machine::cti_op_instanceof): ditto
* kjs/JSObject.cpp:
(JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
* kjs/JSObject.h:
* kjs/nodes.cpp:
(JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype
property and pass that register to instanceof.
* kjs/nodes.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 00:56:11 +0000 (00:56 +0000)]
Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 00:53:12 +0000 (00:53 +0000)]
Fix Qt build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Mon, 15 Sep 2008 00:36:07 +0000 (00:36 +0000)]
Fix Win build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 15 Sep 2008 00:35:40 +0000 (00:35 +0000)]
2008-09-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
* VM/Machine.cpp:
(JSC::Machine::cti_op_call_JSFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Mon, 15 Sep 2008 00:26:08 +0000 (00:26 +0000)]
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>
Optimize the 'typeof' operator when its result is compared to a constant
string.
This is a 5.5% speedup on the V8 Earley-Boyer test.
JavaScriptCore:
* VM/CTI.cpp:
(JSC::CTI::privateCompileMainPass):
* VM/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* VM/CodeGenerator.cpp:
(JSC::CodeGenerator::emitEqualityOp):
* VM/CodeGenerator.h:
* VM/Machine.cpp:
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
(JSC::Machine::privateExecute):
(JSC::Machine::cti_op_is_undefined):
(JSC::Machine::cti_op_is_boolean):
(JSC::Machine::cti_op_is_number):
(JSC::Machine::cti_op_is_string):
(JSC::Machine::cti_op_is_object):
(JSC::Machine::cti_op_is_function):
* VM/Machine.h:
* VM/Opcode.h:
* kjs/nodes.cpp:
(JSC::BinaryOpNode::emitCode):
(JSC::EqualNode::emitCode):
(JSC::StrictEqualNode::emitCode):
* kjs/nodes.h:
LayoutTests:
* fast/js/resources/typeof-codegen-crash.js: Added.
* fast/js/typeof-codegen-crash-expected.txt: Added.
* fast/js/typeof-codegen-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 15 Sep 2008 00:20:15 +0000 (00:20 +0000)]
2008-09-14 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners
Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).
Requested by Michael Monreal.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::RenderThemeGtk):
* platform/gtk/gtk2drawing.c:
(moz_gtk_set_widget_name):
(ensure_window_widget):
(setup_widget_prototype):
(ensure_button_arrow_widget):
(moz_gtk_get_combo_box_inner_button):
(moz_gtk_get_combo_box_button_inner_widgets):
(ensure_combo_box_widgets):
(moz_gtk_get_combo_box_entry_inner_widgets):
(moz_gtk_get_combo_box_entry_arrow):
(ensure_combo_box_entry_widgets):
(ensure_toolbar_widget):
(ensure_tooltip_widget):
(ensure_menu_bar_widget):
(ensure_menu_bar_item_widget):
(ensure_menu_popup_widget):
(ensure_menu_item_widget):
(ensure_image_menu_item_widget):
(ensure_menu_separator_widget):
(ensure_check_menu_item_widget):
(ensure_tree_header_cell_widget):
(ensure_scrolled_window_widget):
(moz_gtk_button_paint):
(moz_gtk_init):
(moz_gtk_button_get_inner_border):
(moz_gtk_toggle_paint):
(calculate_button_inner_rect):
(calculate_arrow_rect):
(moz_gtk_scrollbar_button_paint):
(moz_gtk_scrollbar_thumb_paint):
(moz_gtk_caret_paint):
(moz_gtk_entry_paint):
(moz_gtk_treeview_paint):
(moz_gtk_tree_header_cell_paint):
(moz_gtk_combo_box_paint):
(moz_gtk_downarrow_paint):
(moz_gtk_combo_box_entry_button_paint):
(moz_gtk_toolbar_paint):
(moz_gtk_tab_scroll_arrow_paint):
(moz_gtk_menu_bar_paint):
(moz_gtk_menu_item_paint):
(moz_gtk_get_widget_border):
(moz_gtk_get_combo_box_entry_button_size):
(moz_gtk_get_tab_scroll_arrow_size):
(moz_gtk_get_downarrow_size):
(moz_gtk_images_in_menus):
(moz_gtk_widget_paint):
(moz_gtk_shutdown):
* platform/gtk/gtkdrawing.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 15 Sep 2008 00:12:00 +0000 (00:12 +0000)]
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers
Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.
* kjs/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt): Don't convert numbers to strings just to
convert them back to numbers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log