WebKit-https.git
6 years agoMerge database-common.js and utility.js into run-tests.js.
rniwa@webkit.org [Sat, 8 Feb 2014 03:11:53 +0000 (03:11 +0000)]
Merge database-common.js and utility.js into run-tests.js.

Reviewed by Matthew Hanson.

Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
Also moved init-database.sql out of the database directory and removed the directory entirely.

* database: Removed.
* database/database-common.js: Removed.
* database/utility.js: Removed.
* init-database.sql: Moved from database/init-database.sql.
* run-tests.js:
(connect): Moved from database-common.js.
(pathToDatabseSQL): Extracted from pathToLocalScript.
(pathToTests): Moved from database-common.js.
(config): Ditto.
(TaskQueue): Ditto.
(SerializedTaskQueue): Ditto.
(main):
(initializeDatabase):
(TestEnvironment.it):
(TestEnvironment.queryAndFetchAll):
(sendHttpRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for the GTK+ CMake build
mrobinson@webkit.org [Sat, 8 Feb 2014 03:11:49 +0000 (03:11 +0000)]
Build fix for the GTK+ CMake build

* PlatformGTK.cmake: VTTCue.idl was unintentionally added to the list of GObject DOM bindings
output files. Remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPer CSSOM, computed rect() function values must be comma separated
krit@webkit.org [Sat, 8 Feb 2014 03:01:19 +0000 (03:01 +0000)]
Per CSSOM, computed rect() function values must be comma separated
https://bugs.webkit.org/show_bug.cgi?id=128401

Reviewed by Simon Fraser.

Updated tests.

* css/Rect.h:
(WebCore::Rect::generateCSSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnify JSLock implementation for iOS and non-iOS ports.
mark.lam@apple.com [Sat, 8 Feb 2014 02:52:05 +0000 (02:52 +0000)]
Unify JSLock implementation for iOS and non-iOS ports.
<https://webkit.org/b/128409>

Reviewed by Michael Saboff.

The iOS and non-iOS implementations of dropAllLocks(),
dropAllLocksUnconditionally(), and grabAllLocks() effectively do the
same work. The main difference is that the iOS implementation acquires
the JSLock spin lock in the DropAllLocks class while the other ports
acquire it when it calls JSLock::lock() and unlock().

The other difference is that the iOS implementation will only increment
m_locksDropDepth if it actually drops locks, whereas other ports will
increment it unconditionally. Analogously, iOS decrements the depth only
when needed while other ports will decrement it unconditionally when
re-grabbing locks.

We can unify the 2 implementations by having both use the iOS
implementation for a start.

* runtime/JSLock.cpp:
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd better comments to code that boosts the NetworkProcess
barraclough@apple.com [Sat, 8 Feb 2014 02:51:15 +0000 (02:51 +0000)]
Add better comments to code that boosts the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=128431

Rubber stamped by Tim Horton

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler):
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
timothy_horton@apple.com [Sat, 8 Feb 2014 02:42:43 +0000 (02:42 +0000)]
Build fix.

* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithFrame:configuration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Add initial performance tests for inset shape
zoltan@webkit.org [Sat, 8 Feb 2014 02:39:12 +0000 (02:39 +0000)]
[CSS Shapes] Add initial performance tests for inset shape
https://bugs.webkit.org/show_bug.cgi?id=128378

Reviewed by Ryosuke Niwa.

* Layout/Shapes/ShapeOutsideContentBox.html: Move js to shapes.js.
* Layout/Shapes/ShapeOutsideInset.html: Added.
* Layout/Shapes/resources/shapes.js: Added.
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPass the preferences through from the WKWebViewConfiguration object
andersca@apple.com [Sat, 8 Feb 2014 02:38:02 +0000 (02:38 +0000)]
Pass the preferences through from the WKWebViewConfiguration object
https://bugs.webkit.org/show_bug.cgi?id=128430

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
Don't return nil if [super init] returns a valid object.

(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):
Change this property to be unsigned.

* UIProcess/API/Cocoa/WKPreferencesInternal.h:
Use @package.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
Set up a WebKit::WebPageConfiguration and use the new -[WKView initWithFrame:context:configuration:] method.

* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithFrame:configuration:]):
Set the preferences.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:]):
Add a new initializer that takes a WebContext and a WebPageConfiguration.

(-[WKView _registerDraggedTypes]):
This shouldn't be in the private category.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Call the new initializer.

* UIProcess/API/mac/WKViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the WebKit2 build after r163671.
timothy_horton@apple.com [Sat, 8 Feb 2014 02:28:08 +0000 (02:28 +0000)]
Fix the WebKit2 build after r163671.

* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove isInitialState flag from Page::setViewState
barraclough@apple.com [Sat, 8 Feb 2014 02:25:03 +0000 (02:25 +0000)]
Remove isInitialState flag from Page::setViewState
https://bugs.webkit.org/show_bug.cgi?id=128428

Reviewed by Sam Weinig.

Source/WebCore:

* WebCore.exp.in:
    - removed isInitialState.
* page/Page.cpp:
(WebCore::Page::setViewState):
    - removed isInitialState.
(WebCore::Page::setIsVisible):
    - removed isInitialState.
(WebCore::Page::setIsVisibleInternal):
    - removed isInitialState.
* page/Page.h:
    - removed isInitialState.

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
    - don't pass isInitialState to setViewState.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setPageVisibility):
    - don't pass isInitialState to setViewState.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _updateVisibilityState]):
(-[WebView _setIsVisible:]):
(-[WebView _setVisibilityState:isInitialState:]):
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):
    - don't pass isInitialState to setViewState.

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
    - don't pass isInitialState to setViewState.
(WebKit::WebPage::reinitializeWebPage):
    - if the viewState changes this should fire a visibility event.
(WebKit::WebPage::setViewState):
    - merged with setViewStateInternal.
* WebProcess/WebPage/WebPage.h:
    - removed setViewStateInternal.

LayoutTests:

* fast/events/page-visibility-iframe-delete-test.html:
* fast/events/page-visibility-iframe-move-test.html:
    - resetPageVisibility will now cause additional visibiliy events to fire;
      clean up the event listeners to avoid this affecting the test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEncode requestedScrollPosition on ScrollingStateScrollingNodes to send to the UI...
simon.fraser@apple.com [Sat, 8 Feb 2014 02:19:42 +0000 (02:19 +0000)]
Encode requestedScrollPosition on ScrollingStateScrollingNodes to send to the UI process
https://bugs.webkit.org/show_bug.cgi?id=128416

Source/WebCore:

Reviewed by Tim Horton.

Change requestedScrollPosition() to be a FloatPoint, and export
ScrollingStateScrollingNode::setRequestedScrollPosition(WebCore::FloatPoint const&, bool)
for WK2.

* WebCore.exp.in:
* page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
* page/scrolling/ScrollingStateScrollingNode.h:

Source/WebKit2:

Reviewed by Tim Horton.

Encode and decode requestedScrollPosition() and requestedScrollPositionRepresentsProgrammaticScroll(),
which can't use the macros because the setter takes both arguments.

The UI process needs this to notice programmatic scrolls.

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd typesafe casts for DrawingAreaProxy classes
simon.fraser@apple.com [Sat, 8 Feb 2014 02:19:39 +0000 (02:19 +0000)]
Add typesafe casts for DrawingAreaProxy classes
https://bugs.webkit.org/show_bug.cgi?id=128419

Reviewed by Andreas Kling.

Add typesafe casts, and use one in RemoteScrollingCoordinatorProxy::layerTreeHost().

* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShould get rid of TileController's CoverageForSlowScrolling mode
bdakin@apple.com [Sat, 8 Feb 2014 02:12:43 +0000 (02:12 +0000)]
Should get rid of TileController's CoverageForSlowScrolling mode
https://bugs.webkit.org/show_bug.cgi?id=128339

Reviewed by Simon Fraser.

Source/WebCore:

This patch gets rid of CoverageForSlowScrolling in the TileController. It also
makes sure that margin tiles are properly invalidated on pages with slow repaint
objects that cause slow scrolling.

When we invalidate because of slow scrolling, don’t clip the update rect to the
layer bounds.
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsSlowPath):

Call new RenderObject paint function repaintSlowRepaintObject() instead of the
more-generic repaint().
(WebCore::FrameView::repaintSlowRepaintObjects):

Remove CoverageForSlowScrolling.
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
* rendering/RenderLayerBacking.cpp:
(WebCore::computeTileCoverage):

Handle repainting a slow repaint object. Don’t clip when we shouldn’t, use the
RenderView’s backgroundRect as a repaintRect when this is the root background
since that will take the extended background rect into consideration.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintSlowRepaintObject):
* rendering/RenderObject.h:

LayoutTests:

Slow scrolling no longer creates tiles of a different size.

* platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore FTL build scaffolding
fpizlo@apple.com [Sat, 8 Feb 2014 02:11:22 +0000 (02:11 +0000)]
More FTL build scaffolding
https://bugs.webkit.org/show_bug.cgi?id=128330

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
* llvm/library/LLVMAnchor.cpp:

Source/WebCore:

The FTL already has tests.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/Platform.h:

Tools:

* Scripts/copy-webkitlibraries-to-product-directory:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove allowsBackForwardNavigationGestures back to private because apparently our build...
timothy_horton@apple.com [Sat, 8 Feb 2014 02:02:22 +0000 (02:02 +0000)]
Move allowsBackForwardNavigationGestures back to private because apparently our build systems are broken.

* UIProcess/API/Cocoa/WKView.h:
* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS port needs to clear VM::stackPointerAtVMEntry when it drops locks.
mark.lam@apple.com [Sat, 8 Feb 2014 02:01:22 +0000 (02:01 +0000)]
iOS port needs to clear VM::stackPointerAtVMEntry when it drops locks.
<https://webkit.org/b/128424>

Reviewed by Geoffrey Garen.

The iOS code path for dropping locks differ from the non-iOS code path
in that it (iOS) does not clear m_vm->stackPointerAtVMEntry nor reset the
VM stack limit. This is now fixed by copying that snippit from
JSLock::unlock().

* runtime/JSLock.cpp:
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify web page creation
andersca@apple.com [Sat, 8 Feb 2014 01:57:02 +0000 (01:57 +0000)]
Simplify web page creation
https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTouch Minibrowser for a hopeful build fix.
timothy_horton@apple.com [Sat, 8 Feb 2014 01:49:17 +0000 (01:49 +0000)]
Touch Minibrowser for a hopeful build fix.

* MiniBrowser/mac/WK2BrowserWindowController.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix. Wrong section of the file.
timothy_horton@apple.com [Sat, 8 Feb 2014 01:25:04 +0000 (01:25 +0000)]
Build fix. Wrong section of the file.

* UIProcess/API/mac/WKView.mm:
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] The WebPageProxy's copy of pageScaleFactor is not update when the scale is...
benjamin@webkit.org [Sat, 8 Feb 2014 01:10:52 +0000 (01:10 +0000)]
[WK2] The WebPageProxy's copy of pageScaleFactor is not update when the scale is changed from the viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128415

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::viewportConfigurationChanged):
The scale needs to be updated through WebPage::scalePage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some unused functions from SerializedScriptValue
ap@apple.com [Sat, 8 Feb 2014 01:09:56 +0000 (01:09 +0000)]
Remove some unused functions from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Anders Carlsson.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):
* bindings/js/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit2 View Gestures (Swipe): Support for iOS
timothy_horton@apple.com [Sat, 8 Feb 2014 00:58:08 +0000 (00:58 +0000)]
WebKit2 View Gestures (Swipe): Support for iOS
https://bugs.webkit.org/show_bug.cgi?id=128363
<rdar://problem/15194194>

Reviewed by Anders Carlsson.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::renderTreeSize):
(WebKit::RemoteLayerTreeTransaction::setRenderTreeSize):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Send the render tree size along with remote layer tree commits,
so that we can act upon it (to hide snapshots) in the UI process
in sync with layer commits.

* UIProcess/API/Cocoa/WKViewPrivate.h:
We want allowsBackForwardNavigationGestures for both platforms.

* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _takeViewSnapshot]):
* UIProcess/API/ios/WKContentViewInternal.h:
Plumb snapshotting through to WKViewIOS.

* UIProcess/API/ios/WKViewIOS.mm:
(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
Create/destroy the gesture controller when we turn on/off back-forward swipe.
Tell WebPageProxy to save snapshots if swipe is enabled.

(-[WKView contentView:didCommitLayerTree:]):
Forward the current transaction's render tree size to ViewGestureController.

(-[WKView takeViewSnapshotForContentView:]):
Snapshot the view. This is not the best SPI to use, we should consider
using one of those which returns an IOSurface and plumbing it through
to ViewSnapshotStore, but all of our PageClient abstraction makes that annoying.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::recordNavigationSnapshot):
Record snapshots on iOS as well.

* UIProcess/ios/ViewGestureControllerIOS.mm: Added.
(-[WKSwipeInteractiveTransitionDelegate initWithViewGestureController:WebKit::swipingView:]):
(-[WKSwipeInteractiveTransitionDelegate WebKit::ViewGestureController::directionForTransition:]):
(-[WKSwipeInteractiveTransitionDelegate startInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate shouldBeginInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldReceiveTouch:]):
(-[WKSwipeInteractiveTransitionDelegate gestureRecognizerForInteractiveTransition:WithTarget:action:]):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::installSwipeHandler):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):

* UIProcess/mac/ViewGestureController.h:
Add iOS-specific methods, and don't include all of the Mac-specific code.
We can move towards sharing more logic in the future.

* UIProcess/mac/ViewGestureController.messages.in:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
* UIProcess/mac/ViewSnapshotStore.h:
* UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Make ViewSnapshotStore build/work without IOSurface.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved superflous JSLock::entryStackPointer field.
mark.lam@apple.com [Sat, 8 Feb 2014 00:55:15 +0000 (00:55 +0000)]
Removed superflous JSLock::entryStackPointer field.
<https://webkit.org/b/128413>

Reviewed by Geoffrey Garen.

* runtime/JSLock.cpp:
(JSC::JSLock::lock):
* runtime/JSLock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert workaround committed in http://trac.webkit.org/r163595.
mark.lam@apple.com [Sat, 8 Feb 2014 00:46:28 +0000 (00:46 +0000)]
Revert workaround committed in trac.webkit.org/r163595.
<https://webkit.org/b/128408>

Reviewed by Geoffrey Garen.

Now that we have fixed the bugs in JSLock's stack limit adjusments
in https://bugs.webkit.org/show_bug.cgi?id=128406, we can revert the
workaround in r163595.

* API/JSContextRef.cpp:
(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):
* API/tests/testapi.js:
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement more of WKPreferences
andersca@apple.com [Sat, 8 Feb 2014 00:37:32 +0000 (00:37 +0000)]
Implement more of WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=128411

Reviewed by Tim Horton.

Give WKPreferences an underlying WebKit::WebPreferences object, add a minimumFontSize preference
and make sure that WKWebView's initializer creates a WKPreferences object if the configuration doesn't specify one.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):
* UIProcess/API/Cocoa/WKPreferencesInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: Some Mozilla cursor mutation tests fail
beidson@apple.com [Sat, 8 Feb 2014 00:30:50 +0000 (00:30 +0000)]
IDB: Some Mozilla cursor mutation tests fail
<rdar://problem/16011680> and https://bugs.webkit.org/show_bug.cgi?id=128374

Reviewed by Sam Weinig.

Source/WebCore:

Tested by:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html
storage/indexeddb/mozilla/cursor-mutation.html

The previous comment about LevelDB was wrong.
Apparently calling onSuccess() with a null SharedBuffer means the cursor reached the end.
Update to distinguish between an error and reaching the end:
* Modules/indexeddb/IDBCursorBackendOperations.cpp:
(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

Add a new IDBKey type - Maximum - To be used in comparisons between keys.
This will allow the DatabaseProcess to operate on the range of all keys:
* Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::compare):
* Modules/indexeddb/IDBKey.h:

* Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):
* Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):

* bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyToJSValue):

Remove an unused callback:
* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBRequest.h:

Source/WebKit2:

After a SQLite statement is prepared, stepping it will not pick up any subsequent changes
to the object store.

By keeping track of the current record we’re looking at in the object store and being told
that the object store changed its contents, we can reset the statement to pick up where it
left off but with the new object store contents.

* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecordInBackingStore): Tell the backing store to notify
  its cursors that the object store changed its records.
(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore): Ditto.

* DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges): Tell the transaction
  to notify its cursors that the object store changed its records.
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
(WebKit::SQLiteIDBTransaction::notifyCursorsOfChanges): Tell the relevant cursors that their
  object store changed its records.
* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:

* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::SQLiteIDBCursor::SQLiteIDBCursor):
(WebKit::getIndexStatement): All statements now have a lower and upper range. By default we bind
  IDBKey::Minimum to the lower range and IDBKey::Maximum to the upper range.
(WebKit::getObjectStoreStatement): Ditto.
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::SQLiteIDBCursor::createSQLiteStatement):
(WebKit::SQLiteIDBCursor::objectStoreRecordsChanged): Set the flag indicating the statement
  needs to be reset and rebound.
(WebKit::SQLiteIDBCursor::resetAndRebindStatement):
(WebKit::SQLiteIDBCursor::bindArguments): Factored out to be shared between statement prepare()
  and statement reset().
(WebKit::SQLiteIDBCursor::advance):
(WebKit::SQLiteIDBCursor::advanceOnce): If the statement needs to be reset, do so before advancing it.
(WebKit::SQLiteIDBCursor::internalAdvanceOnce): In a few cases, tell advanceOnce that it needs to
  try again because it is on a missing record or is repeating a record.
* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:
(WebKit::SQLiteIDBCursor::objectStoreID):

Make sure Maximum and Minimum keys are never sent across IPC, as that doesn’t make sense:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

LayoutTests:

* platform/mac-wk2/TestExpectations: Add two tests that now pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix bug in stack limit adjustments in JSLock.
mark.lam@apple.com [Sat, 8 Feb 2014 00:24:13 +0000 (00:24 +0000)]
Fix bug in stack limit adjustments in JSLock.
<https://webkit.org/b/128406>

Reviewed by Geoffrey Garen.

1. JSLock::unlock() was only clearing the VM::stackPointerAtEntry when
   m_vm->stackPointerAtVMEntry == entryStackPointer. FYI,
   entryStackPointer is a field in JSLock.

   When DropAllLocks::~DropAllLocks() will call JSLock::grabAllLocks()
   to relock the JSLock, JSLock::grabAllLocks() will set a new
   entryStackPointer value. Thereafter, DropAllLocks::~DropAllLocks() will
   restore the saved VM::stackPointerAtEntry, which will now defer from
   the JSLock's entryStackPointer value.

   It turns out that when m_vm->stackPointerAtVMEntry was initialized,
   it was set to whatever value entryStackPointer is set to. At no time
   do we ever expect the 2 values to differ. The only time it differs is
   when this bug manifests.

   The fix is to remove the entryStackPointer field in JSLock and its uses
   altogether.

2. DropAllLocks was unconditionally clearing VM::stackPointerAtEntry in
   its constructor instead of letting JSLock::unlock() do the clearing.

   However, DropAllLocks will not actually drop locks if it isn't required
   to (e.g. when alwaysDropLocks is DontAlwaysDropLocks), and when we've
   already drop locks once (i.e. JSLock::m_lockDropDepth is not 0).

   We should not have cleared VM::stackPointerAtEntry here if we don't
   actually drop the locks.

* runtime/JSLock.cpp:
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS build fix.
mitz@apple.com [Sat, 8 Feb 2014 00:19:49 +0000 (00:19 +0000)]
iOS build fix.

* Misc/WebElementDictionary.mm:
(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _image]):
(-[WebElementDictionary _imageRect]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
roger_fong@apple.com [Sat, 8 Feb 2014 00:16:51 +0000 (00:16 +0000)]
CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
https://bugs.webkit.org/show_bug.cgi?id=128395.

Rubberstamped by Zalan Bujtas.

The call essentially returns 0 and causes an assertion failure when running many layout tests.

* platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.
(WebCore::GraphicsContext::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS build fix.
mitz@apple.com [Sat, 8 Feb 2014 00:07:48 +0000 (00:07 +0000)]
iOS build fix.

* platform/PlatformKeyboardEvent.h: Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop using PLATFORM(MAC) in WebCore/platform except where it means “OS X but not...
mitz@apple.com [Fri, 7 Feb 2014 23:37:54 +0000 (23:37 +0000)]
Stop using PLATFORM(MAC) in WebCore/platform except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128404

Reviewed by Anders Carlsson.

* Configurations/WebCore.xcconfig: Removed KeyEventMac.mm from
EXCLUDED_SOURCE_FILE_NAMES_iphoneos, because that file contains !PLATFORM(IOS) guards.
Removed WheelEventMac.mm from the same definition, because that file no longer exists.
* platform/ContentFilter.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/ContextMenu.h: Ditto.
* platform/ContextMenuItem.h: Ditto.
* platform/Cursor.cpp: Ditto.
* platform/Cursor.h: Ditto.
* platform/DragData.cpp: Ditto.
* platform/DragImage.cpp: Ditto.
* platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): Changed PLATFORM(MAC) to USE(CF) && !PLATFORM(WIN).
* platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::contextMenuItemTagSearchWeb):
* platform/LocalizedStrings.h: Ditto.
* platform/MIMETypeRegistry.cpp: Ditto.
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/PasteboardStrategy.h: Ditto.
* platform/PlatformKeyboardEvent.h: Ditto.
* platform/PlatformMenuDescription.h: Ditto.
* platform/PlatformSpeechSynthesizer.h: Ditto.
* platform/PlatformWheelEvent.h: Ditto.
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/SchemeRegistry.cpp: Ditto.
(WebCore::localURLSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):
* platform/ScrollAnimator.cpp: Ditto.
(WebCore::ScrollAnimator::handleWheelEvent):
* platform/ScrollAnimator.h: Ditto.
* platform/ScrollView.cpp: Ditto.
* platform/ScrollView.h: Ditto.
* platform/ScrollbarThemeComposite.h: Ditto.
* platform/SharedBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSData-related
code.
* platform/URL.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSURL-related code.
* platform/Widget.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/Widget.h: Ditto.
* platform/audio/AudioSession.cpp: Changed !PLATFORM(MAC) && !PLATFORM(IOS) to
!PLATFORM(COCOA).
* platform/audio/HRTFElevation.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/audio/MediaSessionManager.cpp: Ditto.
* platform/audio/mac/AudioSessionMac.cpp: Updated comment.
* platform/audio/mac/MediaSessionManagerMac.cpp: Removed PLATFORM(MAC) from Cocoa-only file.
* platform/cf/SharedBufferCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION) and updated
comment.
* platform/cf/URLCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION).
* platform/graphics/BitmapImage.h: Changed one instance of PLATFORM(MAC) to
USE(CG) || USE(APPKIT), and another to PLATFORM(COCOA).
* platform/graphics/DisplayRefreshMonitor.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
* platform/graphics/DisplayRefreshMonitor.h: Ditto.
* platform/graphics/FloatPoint.h: Collapsed nested #ifs into a single #if.
* platform/graphics/FloatRect.h: Ditto.
* platform/graphics/FloatSize.h: Ditto.
* platform/graphics/Font.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/graphics/Font.h: Ditto.
* platform/graphics/FontCache.cpp: Ditto.
(WebCore::FontCache::getFontData):
* platform/graphics/FontCache.h: Ditto. Also removed redundant friend class declaration.
* platform/graphics/FontGlyphs.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
* platform/graphics/GlyphPage.h: Ditto.
* platform/graphics/GraphicsContext3D.h: Ditto.
* platform/graphics/Image.h: Changed PLATFORM(MAC) to USE(APPKIT) around use of NSImage.
Changed another PLATFORM(MAC) to PLATFORM(COCOA).
* platform/graphics/IntRect.h: Collapsed nested #ifs into a single #if.
* platform/graphics/IntSize.h: Ditto.
* platform/graphics/MediaPlayer.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::supportsType):
* platform/graphics/SimpleFontData.cpp: Ditto.
(WebCore::SimpleFontData::nonSyntheticItalicFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
* platform/graphics/SimpleFontData.h: Ditto.
* platform/graphics/TiledBacking.h: Ditto.
* platform/graphics/ca/GraphicsLayerCA.cpp: Ditto.
(WebCore::GraphicsLayerCA::filtersCanBeComposited):
(WebCore::GraphicsLayerCA::createPlatformCALayer):
* platform/graphics/ca/LayerFlushScheduler.h: Ditto.
* platform/graphics/ca/PlatformCAAnimation.h: Ditto.
* platform/graphics/ca/PlatformCAFilters.h: Ditto.
* platform/graphics/ca/PlatformCALayer.h: Ditto.
* platform/graphics/cg/BitmapImageCG.cpp: Ditto.
* platform/graphics/cg/GraphicsContextCG.cpp: Ditto.
(WebCore::GraphicsContext::setAllowsFontSmoothing):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Ditto.
* platform/graphics/cg/ImageBufferCG.cpp: Ditto.
* platform/graphics/cg/ImageBufferDataCG.h: Ditto.
* platform/graphics/cg/ImageCG.cpp: Ditto.
* platform/graphics/cg/ImageSourceCG.cpp: Ditto.
(WebCore::ImageSource::setData):
* platform/graphics/cg/ImageSourceCG.h: Ditto.
* platform/graphics/cg/PathCG.cpp: Ditto.
(WebCore::Path::platformAddPathForRoundedRect):
* platform/graphics/cg/PatternCG.cpp: Ditto.
* platform/graphics/gpu/DrawingBuffer.h: Ditto.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView): Removed PLATFORM(MAC) guards, since
this file is only used on Mac and iOS.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Changed the GL_EXT_draw_buffers check to
match the implementation.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Changed PLATFORM(MAC) to
PLATFORM(COCOA).
* platform/mac/KeyEventMac.mm: Added !PLATFORM(IOS).
* platform/mac/PlatformEventFactoryMac.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/mac/WebCoreSystemInterface.h: Ditto. Removed redundant check for PLATFORM(MAC).
* platform/mac/WebCoreSystemInterface.mm: Removed redundant check for PLATFORM(MAC).
* platform/network/Credential.h: Changed PLATFORM(IOS) || PLATFORM(MAC) to PLATFORM(COCOA).
* platform/network/NetworkStateNotifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
* platform/network/NetworkStorageSession.h: Ditto.
* platform/network/NetworkingContext.h: Ditto.
* platform/network/ProtectionSpace.cpp: Ditto.
(WebCore::ProtectionSpace::receivesCredentialSecurely):
* platform/network/ResourceHandle.cpp: Ditto.
(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::shouldContentSniffURL):
* platform/network/ResourceHandle.h: Ditto.
* platform/network/ResourceHandleClient.cpp: Ditto.
* platform/network/ResourceHandleClient.h: Ditto.
* platform/network/ResourceHandleInternal.h: Ditto.
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/ResourceRequestBase.cpp: Ditto.
* platform/network/cf/AuthenticationCF.h: Ditto.
* platform/network/cf/CookieStorageCFNet.cpp: Ditto.
* platform/network/cf/CredentialStorageCFNet.cpp: Ditto.
* platform/network/cf/FormDataStreamCFNet.cpp: Ditto.
* platform/network/cf/NetworkStorageSessionCFNet.cpp: Ditto.
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
* platform/network/cf/ResourceError.h: Ditto.
* platform/network/cf/ResourceHandleCFNet.cpp: Ditto.
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
* platform/network/cf/ResourceRequest.h: Ditto.
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/cf/ResourceRequestCFNet.cpp: Ditto.
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
* platform/network/cf/ResourceResponse.h: Ditto.
* platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
* platform/network/mac/ResourceResponseMac.mm: Ditto.
* platform/posix/FileSystemPOSIX.cpp: Changed PLATFORM(MAC) to OS(DARWIN) &&
!PLATFORM(EFL) && !PLATFORM(GTK).
* platform/text/TextBoundaries.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake it possible for each web page to have different preferences
andersca@apple.com [Fri, 7 Feb 2014 23:26:25 +0000 (23:26 +0000)]
Make it possible for each web page to have different preferences
https://bugs.webkit.org/show_bug.cgi?id=128403

Reviewed by Tim Horton.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setDatabasePath):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::setPreferences):
(WebKit::WebPageProxy::preferencesDidChange):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::~WebPreferences):
(WebKit::WebPreferences::addPage):
(WebKit::WebPreferences::removePage):
(WebKit::WebPreferences::update):
(WebKit::WebPreferences::updatePrivateBrowsingValue):
(WebKit::WebPreferences::anyPagesAreUsingPrivateBrowsing):
* UIProcess/WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r154384 and r154674 as they broke selection rect computations for text with...
rniwa@webkit.org [Fri, 7 Feb 2014 23:07:29 +0000 (23:07 +0000)]
Revert r154384 and r154674 as they broke selection rect computations for text with ligatures.

Source/WebCore:

* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
* platform/graphics/GlyphBuffer.h:
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):
* platform/graphics/WidthIterator.h:

LayoutTests:

* fast/text/partial-textruns-expected.html: Removed.
* fast/text/partial-textruns.html: Removed.
* fast/text/resources/PTS55F-webfont.ttf: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Add support for text document viewport configuration
benjamin@webkit.org [Fri, 7 Feb 2014 23:03:03 +0000 (23:03 +0000)]
[WK2] Add support for text document viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128359

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Source/WebCore:

Define a set of ViewportParameters suitable for displaying text documents.
Add a documents class for text document to differentiate them from other type of documents.

* WebCore.exp.in:
* dom/Document.h:
(WebCore::Document::isTextDocument):
* html/TextDocument.cpp:
(WebCore::TextDocument::TextDocument):
* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::plainTextParameters):
* page/ViewportConfiguration.h:

Source/WebKit2:

When a text document is being loaded, use the plainText viewport parameters.

* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFloatingObject::unsafeClone should not copy m_originatingLine
bjonesbe@adobe.com [Fri, 7 Feb 2014 23:01:19 +0000 (23:01 +0000)]
FloatingObject::unsafeClone should not copy m_originatingLine
https://bugs.webkit.org/show_bug.cgi?id=128381

Reviewed by Andreas Kling.

Copying the originatingLine allows to break the invariant that the
floating object must only contain lines that are owned by the renderer
it is attached to.

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::unsafeClone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate TextTrack API to current spec
b.long@cablelabs.com [Fri, 7 Feb 2014 22:32:45 +0000 (22:32 +0000)]
Update TextTrack API to current spec
https://bugs.webkit.org/show_bug.cgi?id=122218

Refactoring VTTCue out of TextTrackCue.

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-vttcue.html

* CMakeLists.txt: Add VTTCue and rename RenderTextTrackCue to RenderVTTCue.
* DerivedSources.cpp: Same.
* DerivedSources.make: Same.
* GNUmakefile.list.am: Same.
* PlatformGTK.cmake:  Same.
* WebCore.vcxproj/WebCore.vcxproj: Same.
* WebCore.vcxproj/WebCore.vcxproj.filters: Same.
* WebCore.xcodeproj/project.pbxproj: Same.
* bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::toJS): Use VTTCue DOM wrapper for VTTCue and its subclasses.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Convert to VTTCue as needed.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.
* html/HTMLMediaElement.h: Only print cue.text in debug output if the cue type has a .text attribute
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Convert to VTTCue as needed, and fix TextTrackCueBox to VTTCueBox.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Convert to VTTCue as needed.
* html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::addGenericCue): Use refactored VTTCue attributes.
* html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::newCuesParsed): Use VTTCue's constructor instead of deprecated TextTrackCue constructor.
* html/track/TextTrack.cpp:
(WebCore::TextTrack::setMode): Convert to VTTCue as needed.
(WebCore::TextTrack::hasCue): Make this function only accept VTTCues, since it's only used for them anyway, and convert existing cues to VTTCues as needed.
* html/track/TextTrack.h: Same as hasCue above.
* html/track/TextTrackCue.cpp: Refactor a lot of code out. Everything that was removed went to VTTCue.cpp.
(WebCore::TextTrackCue::create): For backwards compatibility, just call VTTCue::create().
(WebCore::TextTrackCue::TextTrackCue): Refactor a lot of code out.
(WebCore::TextTrackCue::~TextTrackCue): Same.
(WebCore::TextTrackCue::didChange): Same.
(WebCore::TextTrackCue::setIsActive): Same.
* html/track/TextTrackCue.h: Same.
* html/track/TextTrackCue.idl: Remove VTTCue attributes and add custom toJS function.
* html/track/TextTrackCueGeneric.cpp: Use VTTCue instead of TextTrackCue.
* html/track/TextTrackCueGeneric.h: Same.
* html/track/VTTCue.cpp: Copied from Source/WebCore/html/track/TextTrackCue.cpp.
* html/track/VTTCue.h: Copied from Source/WebCore/html/track/TextTrackCue.h.
* html/track/VTTCue.idl: Copied from Source/WebCore/html/track/TextTrackCue.idl.
* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues): Use VTTCue instead of TextTrackCue.
* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride): Use VTTCueBox instead of TextTrackCueBox.
* rendering/RenderVTTCue.cpp: Renamed from Source/WebCore/rendering/RenderTextTrackCue.cpp. Changed to use VTTCue instead of TextTrackCue.
* rendering/RenderVTTCue.h: Renamed from Source/WebCore/rendering/RenderTextTrackCue.h. Changed to use VTTCue instead of TextTrackCue.
* rendering/RenderingAllInOne.cpp: Rename RenderTextTrackCue to RenderVTTCue.

LayoutTests:

* js/dom/constructor-length.html: Add VTTCue constructor.
* platform/efl/js/dom/global-constructors-attributes-expected.txt: Same.
* platform/efl/js/dom/constructor-length-expected.txt: Same.
* js/dom/global-constructors-attributes-expected.txt: Same.
* platform/gtk-wk2/js/dom/constructor-length-expected.txt:  Same.
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Same.
* platform/gtk/js/dom/constructor-length-expected.txt: Same.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt: Same.
* platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Same.
* platform/mac/js/dom/constructor-length-expected.txt: Same.
* platform/mac/js/dom/global-constructors-attributes-expected.txt: Same.
* platform/win/js/dom/global-constructors-attributes-expected.txt: Same.
* media/track/track-cues-cuechange-expected.txt: Cues are of type VTTCue now.
* media/track/track-cues-enter-exit-expected.txt: Same.
* media/track/track-vttcue-expected.txt: Test VTTCue interface.
* media/track/track-vttcue.html: Same.
* media/video-test.js:
(testExpected): Add "instanceof" as a valid operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Eliminate race between XPC connection queue and Notification queue
commit-queue@webkit.org [Fri, 7 Feb 2014 22:31:00 +0000 (22:31 +0000)]
[iOS] Eliminate race between XPC connection queue and Notification queue
https://bugs.webkit.org/show_bug.cgi?id=128384

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-02-07
Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.h:
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
Create the queue to use for RemoteInspector xpc connection
management and the connection itself.

* inspector/remote/RemoteInspectorXPCConnection.h:
* inspector/remote/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
Use the passed in queue instead of creating one for itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShould report user input to PageThrottler
barraclough@apple.com [Fri, 7 Feb 2014 22:27:06 +0000 (22:27 +0000)]
Should report user input to PageThrottler
https://bugs.webkit.org/show_bug.cgi?id=128398

Reviewed by Tim Horton.

Make sure we wake from AppNap if there is user interaction.

Source/WebCore:

* page/PageThrottler.h:
(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):
    - added, these call reportInterestingEvent()

Source/WebKit2:

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
    - reportInterestingEvent() -> pluginDidEvaluate()
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
    - call didReceiveUserInput()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebGL doesn't update with remotely hosted layers
dino@apple.com [Fri, 7 Feb 2014 22:12:03 +0000 (22:12 +0000)]
WebGL doesn't update with remotely hosted layers
https://bugs.webkit.org/show_bug.cgi?id=128390

Reviewed by Simon Fraser.

PlatformCALayerRemote was intercepting the setNeedsDisplay calls to
WebGL layers, and thus causing them to not draw. Fix this by adding an
override in PlatformCALayerRemoteCustom to check if it is a WebGLLayer
and call setNeedsDisplay directly.

* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::setNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Fitler touch events only based on touch start
benjamin@webkit.org [Fri, 7 Feb 2014 22:01:38 +0000 (22:01 +0000)]
[WK2] Fitler touch events only based on touch start
https://bugs.webkit.org/show_bug.cgi?id=128354

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Touch Events track their target, we should not test the touch regions
again after a touch sequence starts.

This patch adds a boolean flag to know if we are sending events to the WebProcess
(m_isTrackingTouchEvents). The flag is updated every time a touch sequence starts.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents):
(WebKit::WebPageProxy::handleTouchEvent):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify WebPreferences creation inside WebPageGroup
andersca@apple.com [Fri, 7 Feb 2014 21:42:30 +0000 (21:42 +0000)]
Simplify WebPreferences creation inside WebPageGroup
https://bugs.webkit.org/show_bug.cgi?id=128392

Reviewed by Andreas Kling.

Always create a WebPreferences object when creating the web page group.
This is another step towards letting WebPageProxy manage web preferences.

* UIProcess/WebPageGroup.cpp:
(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
* UIProcess/WebPageGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReenable AppNap
barraclough@apple.com [Fri, 7 Feb 2014 21:39:16 +0000 (21:39 +0000)]
Reenable AppNap
https://bugs.webkit.org/show_bug.cgi?id=128394

Reviewed by Tim Horton.

* Shared/WebPreferencesStore.h:
    - pageVisibilityBasedProcessSuppressionEnabled shoud default to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after r163632
k.czech@samsung.com [Fri, 7 Feb 2014 21:23:58 +0000 (21:23 +0000)]
Build fix after r163632

Unreviewed EFL build fix

Added empty stub to WKTR to not break EFL build.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for 32-bit iOS.
jer.noble@apple.com [Fri, 7 Feb 2014 21:17:08 +0000 (21:17 +0000)]
Unreviewed build fix for 32-bit iOS.

Use magic ? values to allow the exported symbol to be different on 32- and 64-bit builds.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename ViewGestureController.mm to ViewGestureControllerMac.mm
timothy_horton@apple.com [Fri, 7 Feb 2014 20:14:13 +0000 (20:14 +0000)]
Rename ViewGestureController.mm to ViewGestureControllerMac.mm
https://bugs.webkit.org/show_bug.cgi?id=128387

Reviewed by Anders Carlsson.

As a precursor to having a second nearly completely divergent
ViewGestureController implementation for iOS.

* UIProcess/mac/ViewGestureControllerMac.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.mm.
* WebKit2.xcodeproj/project.pbxproj:
Rename ViewGestureController.mm to ViewGestureControllerMac.mm.
Unfortunately, since we're not renaming the class, the header
has to keep its name (and will be the recipient of a giant #if in a later
patch), because the message receiver generated code will try to import
ViewGestureController.h (without the Mac suffix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r160628): LLint does not appear to handle impure get own property properly
oliver@apple.com [Fri, 7 Feb 2014 19:59:58 +0000 (19:59 +0000)]
REGRESSION (r160628): LLint does not appear to handle impure get own property properly
https://bugs.webkit.org/show_bug.cgi?id=127943

Reviewed by Filip Pizlo.

Make sure the LLINT doesn't attempt to cache property
access on structures with impureGetOwnPropertySlot set.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert ProgressTracker to std::chrono
andersca@apple.com [Fri, 7 Feb 2014 19:57:09 +0000 (19:57 +0000)]
Convert ProgressTracker to std::chrono
https://bugs.webkit.org/show_bug.cgi?id=128377

Reviewed by Andreas Kling.

* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
* loader/ProgressTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Clean up DataGrid and add table columns incrementally
bburg@apple.com [Fri, 7 Feb 2014 19:49:41 +0000 (19:49 +0000)]
Web Inspector: Clean up DataGrid and add table columns incrementally
https://bugs.webkit.org/show_bug.cgi?id=128332

Reviewed by Timothy Hatcher.

Miscellaneous improvements to DataGrid to make it more maintainable.
In particular, it now uses a `Map` to store column settings, and the
construction sequence has been simplified so that it is safe to add
columns at the end of the constructor (or any later time).

DataGrid stores a bunch of settings per-column, but before this was done
by both storing properties on the provided `column` objects as well as
keeping several `columnIdentifier`-keyed maps for properties like `group`
and `hidden`.

Improve code readability by using for..of loops, destructuring assignment,
`Node.createElement`, and updating variable names. All variables that refer
to DOM nodes now have a `Element` suffix to distinguish them from model objects.

* UserInterface/DataGrid.js:
(.sortDataGrid):
(WebInpector.DataGrid): Create all DOM elements before populating columns.
Remove redundant objects for storing per-column values. Copy column settings
into a map rather than mutating the passed-in JSON-like settings data structure.

(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.get length):
(WebInspector.DataGrid.prototype.updateLayout):
(WebInspector.DataGrid.prototype.get scrollContainer):
(WebInspector.DataGrid.prototype.isScrolledToLastRow):
(WebInspector.DataGrid.prototype.scrollToLastRow):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype.addCreationNode):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
(WebInspector.DataGrid.prototype._clickInHeaderCell):
(WebInspector.DataGrid.prototype.isColumnSortColumn):
(WebInspector.DataGrid.prototype.headerTableHeader):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.createCells):
(WebInspector.DataGridNode.prototype.createCell.get var):
(WebInspector.DataGridNode.prototype.elementWithColumnIdentifier):
(WebInspector.DataGridNode.prototype._attach):
* UserInterface/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get scopeBar):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCopying a WebPreferences object should be done through a member function
andersca@apple.com [Fri, 7 Feb 2014 19:43:26 +0000 (19:43 +0000)]
Copying a WebPreferences object should be done through a member function
https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateCopy):
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::copy):
* UIProcess/WebPreferences.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebPageGroup::setPreferences should set the preferences on all pages in the group
andersca@apple.com [Fri, 7 Feb 2014 19:10:47 +0000 (19:10 +0000)]
WebPageGroup::setPreferences should set the preferences on all pages in the group
https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::setPreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago32-bit build fix.
ap@apple.com [Fri, 7 Feb 2014 18:53:01 +0000 (18:53 +0000)]
32-bit build fix.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Background Blending] Unprefix the -webkit-background-blend-mode property
commit-queue@webkit.org [Fri, 7 Feb 2014 18:46:47 +0000 (18:46 +0000)]
[CSS Background Blending] Unprefix the -webkit-background-blend-mode property

https://bugs.webkit.org/show_bug.cgi?id=128270

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-07
Reviewed by Dean Jackson.

Source/WebCore:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

Source/WebInspectorUI:

* UserInterface/CSSKeywordCompletions.js: Refactor -webkit-background-blend-mode to background-blend-mode.

LayoutTests:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

* css3/compositing/background-blend-mode-background-attachement-fixed-expected.html:
* css3/compositing/background-blend-mode-background-attachement-fixed.html:
* css3/compositing/background-blend-mode-background-clip-content-box-expected.html:
* css3/compositing/background-blend-mode-background-clip-content-box.html:
* css3/compositing/background-blend-mode-background-clip-padding-box-expected.html:
* css3/compositing/background-blend-mode-background-clip-padding-box.html:
* css3/compositing/background-blend-mode-background-origin-border-box-expected.html:
* css3/compositing/background-blend-mode-background-origin-border-box.html:
* css3/compositing/background-blend-mode-background-position-percentage-expected.html:
* css3/compositing/background-blend-mode-background-position-percentage.html:
* css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html:
* css3/compositing/background-blend-mode-background-repeat-no-repeat.html:
* css3/compositing/background-blend-mode-background-size-contain-expected.html:
* css3/compositing/background-blend-mode-background-size-contain.html:
* css3/compositing/background-blend-mode-background-size-cover-expected.html:
* css3/compositing/background-blend-mode-background-size-cover.html:
* css3/compositing/background-blend-mode-crossfade-image.html:
* css3/compositing/background-blend-mode-data-uri-svg-image.html:
* css3/compositing/background-blend-mode-default-value.html:
* css3/compositing/background-blend-mode-different-image-formats.html:
* css3/compositing/background-blend-mode-gif-color-2.html:
* css3/compositing/background-blend-mode-gif-color.html:
* css3/compositing/background-blend-mode-gradient-color.html:
* css3/compositing/background-blend-mode-gradient-gradient.html:
* css3/compositing/background-blend-mode-gradient-image.html:
* css3/compositing/background-blend-mode-image-color.html:
* css3/compositing/background-blend-mode-image-image.html:
* css3/compositing/background-blend-mode-image-svg.html:
* css3/compositing/background-blend-mode-multiple-background-layers.html:
* css3/compositing/background-blend-mode-property-expected.txt:
* css3/compositing/background-blend-mode-property-parsing-expected.txt:
* css3/compositing/background-blend-mode-separate-layer-declaration.html:
* css3/compositing/background-blend-mode-single-layer-no-blending.html:
* css3/compositing/background-blend-mode-svg-color.html:
* css3/compositing/background-blend-mode-svg.html:
* css3/compositing/background-blend-mode-tiled-layers.html:
* css3/compositing/blend-mode-layers.html:
* css3/compositing/effect-background-blend-mode-stacking.html:
* css3/compositing/effect-background-blend-mode-tiled.html:
* css3/compositing/effect-background-blend-mode.html:
* css3/compositing/script-tests/background-blend-mode-property-parsing.js:
(testBlendModeRule):
* css3/compositing/script-tests/background-blend-mode-property.js:
(testblendmode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Find and select text with respect to insertion point using accessibility API.
samuel_white@apple.com [Fri, 7 Feb 2014 18:43:38 +0000 (18:43 +0000)]
AX: Find and select text with respect to insertion point using accessibility API.
https://bugs.webkit.org/show_bug.cgi?id=128026

Reviewed by Chris Fleizach.

Source/WebCore:

Added facilities to support semi-ambiguous text selection through the accessibility API. All
requests are handled with respect to the current selection. The requests are disambiguated in
WebCore using passed parameters such as: SelectStringAfterSelection , ..Before.., ..ClosestTo...,
etc. Callers can also supply an array of strings to select and the closest that matches the
disambiguation criteria will be used.

Test: platform/mac/accessibility/select-text.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::frame):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* dom/Position.cpp:
(WebCore::Position::positionCountBetweenPositions):
* dom/Position.h:

Tools:

Added method to AccessibilityUIElement to enable testing of accessibility text selection.

* DumpRenderTree/AccessibilityUIElement.cpp:
(selectTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

Tests that text selection via the accessibility API works as expected.

* platform/mac/accessibility/bounds-for-range-expected.txt:
* platform/mac/accessibility/select-text-expected.txt: Added.
* platform/mac/accessibility/select-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFloatingObject m_paginationStrut should be LayoutUnit
bjonesbe@adobe.com [Fri, 7 Feb 2014 18:37:55 +0000 (18:37 +0000)]
FloatingObject m_paginationStrut should be LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=119808

Reviewed by Andreas Kling.

Make the paginationStrut in FloatingObject have the same type as all
of the other paginationStruts in the code.

* rendering/FloatingObjects.h:
(WebCore::FloatingObject::paginationStrut):
(WebCore::FloatingObject::setPaginationStrut):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::positionNewFloatOnLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
mitz@apple.com [Fri, 7 Feb 2014 18:32:38 +0000 (18:32 +0000)]
[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
https://bugs.webkit.org/show_bug.cgi?id=128368

Reviewed by Anders Carlsson.

* Shared/API/Cocoa/WKRemoteObjectInterface.h: Declared new methods.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(propertyListClasses): Removed NSNull, which is not really a property list class.
(classesForSelectorArgument): Added helper function.
(-[WKRemoteObjectInterface classesForSelector:argumentIndex:]): Added.
(-[WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] API::FrameHandle has a generic wrapper
mitz@apple.com [Fri, 7 Feb 2014 18:32:04 +0000 (18:32 +0000)]
[Cocoa] API::FrameHandle has a generic wrapper
https://bugs.webkit.org/show_bug.cgi?id=128366

Reviewed by Anders Carlsson.

Added WKFrameHandle.

* Shared/API/Cocoa/WKFrameHandle.h: Added.
* Shared/API/Cocoa/WKFrameHandle.mm: Added.
(-[WKFrameHandle dealloc]): Calls the API::FrameHandle destructor.
(-[WKFrameHandle isEqual:]): Checks for frame ID equality.
(-[WKFrameHandle hash]): Returns the frame ID.
(-[WKFrameHandle _frameID]): Ditto.
(-[WKFrameHandle copyWithZone:]): Retains self.
(+[WKFrameHandle supportsSecureCoding]): Returns YES.
(-[WKFrameHandle initWithCoder:]): Decodes the frame ID and constructs an API::FrameHandle
with it.
(-[WKFrameHandle encodeWithCoder:]): Encodes the frame ID.
(-[WKFrameHandle _apiObject]): Returns the wrapped API::FrameHandle.
* Shared/API/Cocoa/WKFrameHandleInternal.h: Added.
(WebKit::wrapper): Added. Returns an API::FrameHandle’s wrapper as a WKFrameHandle.

* Shared/APIFrameHandle.cpp:
(API::FrameHandle::create): Changed to return a PassRefPtr.
* Shared/APIFrameHandle.h: Made the constructor public for -[WKFrameHandle initWithCoder:].

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate a WKFrameHandle if the object is an API::FrameHandle.

* WebKit2.xcodeproj/project.pbxproj: Added references to new files.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared handle property.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]): Added. Calls WebProcess::webFrame to
look up a frame with the given handle’s frame ID.
(-[WKWebProcessPlugInFrame handle]): Added. Returns a new handle with the frame’s ID.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Updated #import.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] WKWebProcessPlugInNodeHandle methods leak and may crash
mitz@apple.com [Fri, 7 Feb 2014 18:31:29 +0000 (18:31 +0000)]
[Cocoa] WKWebProcessPlugInNodeHandle methods leak and may crash
https://bugs.webkit.org/show_bug.cgi?id=128365

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]): Null-check the result
of InjectedBundleNodeHandle::getOrCreate, and autorelease the return value.
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]): Null-check the result of
InjectedBundleNodeHandle::htmlIFrameElementContentFrame, and autorelease the return value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: storage/indexeddb/create-index-with-integer-keys.html fails
beidson@apple.com [Fri, 7 Feb 2014 18:26:48 +0000 (18:26 +0000)]
IDB: storage/indexeddb/create-index-with-integer-keys.html fails
<rdar://problem/16002857> and https://bugs.webkit.org/show_bug.cgi?id=128316

Reviewed by Geoff Garen.

Source/WebCore:

Tested by storage/indexeddb/create-index-with-integer-keys.html (and probably some others)

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Update createIDBKeyFromScriptValueAndKeyPath usage.
(WebCore::IDBCursor::setValueReady): Update createIDBKeyFromScriptValueAndKeyPath usage.

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put): Update usage of binding utilities.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess): Update createIDBKeyFromScriptValueAndKeyPath usage.

* bindings/js/IDBBindingUtilities.cpp:
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath): Changed to take an ExecState*.
(WebCore::deserializeIDBValueBuffer): Added new version that starts with ExecState* and Vector<uint8_t>
  instead of RequestState and SharedBuffer.
(WebCore::generateIndexKeysForValue): Moved from IDBObjectStore.cpp and changed to take an ExecState*
* bindings/js/IDBBindingUtilities.h:

Added new blob fetcher that works with uint8_t buffers:
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::getColumnBlobAsVector):
* platform/sql/SQLiteStatement.h:

* WebCore.exp.in:

Source/WebKit2:

Update Vector<char> to Vector<uint8_t> throughout:
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Update Vector<char> to Vector<uint8_t> throughout:
* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::SQLiteIDBCursor::advanceOnce):
* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:
(WebKit::SQLiteIDBCursor::currentValueBuffer):

* DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex): Create a script value from the value data, use
  generateIndexKeysForValue to get the index keys, and then write the resulting index records.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord): Call through to uncheckedPutIndexRecord.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Version of putIndexRecord that doesn’t
  validate the transaction or its mode.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor): Update Vector<char> to Vector<uint8_t>.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor): Ditto.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor): Ditto.
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

LayoutTests:

* platform/mac-wk2/TestExpectations: Enable the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agochildShouldCreateRenderer should return false for the mspace element
commit-queue@webkit.org [Fri, 7 Feb 2014 18:20:01 +0000 (18:20 +0000)]
childShouldCreateRenderer should return false for the mspace element
https://bugs.webkit.org/show_bug.cgi?id=128325

Patch by Frédéric Wang <fred.wang@free.fr> on 2014-02-07
Reviewed by Chris Fleizach.

Source/WebCore:

The mspace element can not have children so this makes its
childShouldCreateRenderer always return false.

Test: mathml/presentation/mspace-children.html

* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::childShouldCreateRenderer):

LayoutTests:

Add tests to ensure that the mspace element does not have renderer
children.

* mathml/presentation/mspace-children-expected.png: Added.
* mathml/presentation/mspace-children-expected.txt: Added.
* mathml/presentation/mspace-children.html: Added.
* platform/mathml/presentation/mspace-children-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
commit-queue@webkit.org [Fri, 7 Feb 2014 17:45:49 +0000 (17:45 +0000)]
[CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
https://bugs.webkit.org/show_bug.cgi?id=127989

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-07
Reviewed by Andreas Kling.

In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

LayoutTests:

* fast/css-grid-layout/auto-content-resolution-columns.html:
* fast/css-grid-layout/auto-content-resolution-rows.html:
* fast/css-grid-layout/breadth-size-resolution-grid.html:
* fast/css-grid-layout/calc-resolution-grid-item.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
* fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
* fast/css-grid-layout/flex-content-resolution-columns.html:
* fast/css-grid-layout/flex-content-resolution-rows.html:
* fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
* fast/css-grid-layout/grid-auto-columns-rows-update.html:
* fast/css-grid-layout/grid-auto-flow-resolution.html:
* fast/css-grid-layout/grid-auto-flow-update.html:
* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-dynamic-updates-relayout.html:
* fast/css-grid-layout/grid-element-border-grid-item.html:
* fast/css-grid-layout/grid-element-border-padding-grid-item.html:
* fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
* fast/css-grid-layout/grid-element-change-columns-repaint.html:
* fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
* fast/css-grid-layout/grid-element-change-rows-repaint.html:
* fast/css-grid-layout/grid-element-empty-row-column.html:
* fast/css-grid-layout/grid-element-min-max-width.html:
* fast/css-grid-layout/grid-element-padding-grid-item.html:
* fast/css-grid-layout/grid-element-padding-margin.html:
* fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
* fast/css-grid-layout/grid-element-repeat-get-set.html:
* fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
* fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
* fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
* fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
* fast/css-grid-layout/grid-item-change-column-repaint.html:
* fast/css-grid-layout/grid-item-change-row-repaint.html:
* fast/css-grid-layout/grid-item-margin-resolution.html:
* fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
* fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
* fast/css-grid-layout/grid-item-negative-position-resolution.html:
* fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
* fast/css-grid-layout/grid-item-order-paint-order.html:
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
* fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
* fast/css-grid-layout/grid-item-spanning-resolution.html:
* fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
* fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
* fast/css-grid-layout/grid-preferred-logical-widths.html:
* fast/css-grid-layout/implicit-columns-auto-resolution.html:
* fast/css-grid-layout/implicit-position-dynamic-change.html:
* fast/css-grid-layout/implicit-rows-auto-resolution.html:
* fast/css-grid-layout/minmax-fixed-logical-height-only.html:
* fast/css-grid-layout/minmax-fixed-logical-width-only.html:
* fast/css-grid-layout/minmax-max-content-resolution-columns.html:
* fast/css-grid-layout/minmax-max-content-resolution-rows.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
* fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
* fast/css-grid-layout/minmax-spanning-resolution-columns.html:
* fast/css-grid-layout/minmax-spanning-resolution-rows.html:
* fast/css-grid-layout/named-grid-line-get-set-expected.txt:
* fast/css-grid-layout/named-grid-line-get-set.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/non-grid-columns-rows-get-set.html:
* fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
* fast/css-grid-layout/non-grid-element-repeat-get-set.html:
* fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
* fast/css-grid-layout/non-named-grid-line-get-set.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
* fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
* fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
* fast/css-grid-layout/percent-resolution-grid-item.html:
* fast/css-grid-layout/place-cell-by-index.html:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
(testInherit):
(testInitial):
* fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:
(testGridTemplatesValues):
(testGridTemplatesSetJSValues):
(testNonGridTemplatesSetJSValues):
(checkGridTemplatesSetJSValues):
(testGridTemplatesSetBadJSValues):
* fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:
(testInherit):
(testInitial):
* fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:
(testInherit):
(testInitial):
* ietestcenter/css3/grid/display-grid-001-expected.htm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoanimations/suspend-resume-animation.html is flakey
dino@apple.com [Fri, 7 Feb 2014 17:43:12 +0000 (17:43 +0000)]
animations/suspend-resume-animation.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=128379

Marking it as such.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 7 Feb 2014 16:11:04 +0000 (16:11 +0000)]
Unreviewed EFL gardening

Remove test expectations after r163586 and skip two http tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCTTE: DocumentThreadableLoader always has a Document.
akling@apple.com [Fri, 7 Feb 2014 12:02:15 +0000 (12:02 +0000)]
CTTE: DocumentThreadableLoader always has a Document.
<https://webkit.org/b/128364>

DocumentThreadableLoader always has an "owner" Document, so store
that as a reference instead of a pointer. Removed some unnecessary
assertions exposed by this change.

Reviewed by Antti Koivisto.

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously):
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::securityOrigin):
* loader/DocumentThreadableLoader.h:
* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Disable gtk-doc in EWS
rego@igalia.com [Fri, 7 Feb 2014 11:44:31 +0000 (11:44 +0000)]
[GTK] Disable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128370

Reviewed by Carlos Garcia Campos.

Disable gtk-doc generation in EWS due to http://webkit.org/b/128369.

* Scripts/webkitpy/common/config/ports.py:
(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] editing/style/block-style-005.html failing
commit-queue@webkit.org [Fri, 7 Feb 2014 10:52:08 +0000 (10:52 +0000)]
[EFL] editing/style/block-style-005.html failing
https://bugs.webkit.org/show_bug.cgi?id=114612

Patch by Lukasz Bialek <l.bialek@samsung.com> on 2014-02-07
Reviewed by Ryosuke Niwa.

After r148378 editing/style/block-style-005.htm test stopped passing.
Number of "moveSelectionByLineCommand" is changed to 4 to match intended
test behaviour. Test is confirmed to pass in EFL and GTK ports now.

* editing/style/block-style-005.html:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Remove style-scoped tests
mihnea@adobe.com [Fri, 7 Feb 2014 10:49:59 +0000 (10:49 +0000)]
[CSSRegions] Remove style-scoped tests
https://bugs.webkit.org/show_bug.cgi?id=128361

Reviewed by Andrei Bucur.

Remove tests combining style-scoped and regions. The support was removed from code base
and the tests were skipped from a long time.

* fast/regions/style-scoped/style-scoped-in-flow-expected.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Removed.
* fast/regions/style-scoped/style-scoped-in-flow.html: Removed.
* platform/efl/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVector-effect updates require a re-layout
commit-queue@webkit.org [Fri, 7 Feb 2014 10:44:10 +0000 (10:44 +0000)]
Vector-effect updates require a re-layout
https://bugs.webkit.org/show_bug.cgi?id=127553

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

As noted in the stale SVGRenderStyle::diff() comment, now that layout() observes vector-effect
we need to trigger a re-layout on attribute changes.

Blink: https://src.chromium.org/viewvc/blink?revision=152570&view=revision
Source/WebCore:

Tests: svg/custom/non-scaling-stroke-update-expected.svg
       svg/custom/non-scaling-stroke-update.svg

* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):

LayoutTests:

* svg/custom/non-scaling-stroke-update-expected.svg: Added.
* svg/custom/non-scaling-stroke-update.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenaming isTableElement() to isRenderedTable() as per the FIXME comment
commit-queue@webkit.org [Fri, 7 Feb 2014 10:21:15 +0000 (10:21 +0000)]
Renaming isTableElement() to isRenderedTable() as per the FIXME comment
https://bugs.webkit.org/show_bug.cgi?id=127769

Patch by Laszlo Vidacs <lvidacs.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

Rename method and use IsTable() instead of local type checking.

* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphWithClones):
* editing/FrameSelection.cpp:
(WebCore::caretRendersInsideNode):
* editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
* editing/htmlediting.cpp:
(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::isRenderedTable):
* editing/htmlediting.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK port gardening
changseok.oh@collabora.com [Fri, 7 Feb 2014 10:10:55 +0000 (10:10 +0000)]
Unreviewed GTK port gardening

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVerify misspellings after lines merge/split asynchronously
g.czajkowski@samsung.com [Fri, 7 Feb 2014 09:20:03 +0000 (09:20 +0000)]
Verify misspellings after lines merge/split asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128305

Reviewed by Ryosuke Niwa.

Adapt two spelling tests to use asynchronous spellchecking.

* editing/spelling/script-tests/spelling-backspace-between-lines.js:
(testTwoLinesMisspellings):
(testMisspellingsAfterLineMergeUsingDelete):
(testMisspellingsAfterLineMergeUsingForwardDelete):
Group test cases into separated methods.
Use shouldBeEqualToString to compare strings.
Add newly created div elements instead of overriding
the previous one in order that non DumpRenderTree users
can see what has been tested.

* editing/spelling/spelling-backspace-between-lines-expected.txt:
* editing/spelling/spelling-linebreak-expected.txt:
* editing/spelling/spelling-linebreak.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] WebView should be able to configure to set fixed layout
jinwoo7.song@samsung.com [Fri, 7 Feb 2014 08:32:30 +0000 (08:32 +0000)]
[EFL][WK2] WebView should be able to configure to set fixed layout
https://bugs.webkit.org/show_bug.cgi?id=128300

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.

* UIProcess/API/efl/ewk_view.cpp:
(EWKViewCreate): Do not set to use fixed layout as default.
(ewk_view_layout_fixed_set):
(ewk_view_layout_fixed_get):
* UIProcess/API/efl/ewk_view.h: Add ewk APIs to set fixed layout.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

Tools:

* MiniBrowser/efl/main.c:
(window_create):
(elm_main): Add command argument option to use fixed layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r163612.
beidson@apple.com [Fri, 7 Feb 2014 07:23:35 +0000 (07:23 +0000)]
Unreviewed build fix after r163612.

* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: Remove the entirely unnecessary "Value Key" concept
beidson@apple.com [Fri, 7 Feb 2014 06:37:48 +0000 (06:37 +0000)]
IDB: Remove the entirely unnecessary "Value Key" concept
https://bugs.webkit.org/show_bug.cgi?id=128360

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests (No change in behavior)

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

* Modules/indexeddb/IDBCallbacks.h:

* Modules/indexeddb/IDBCursorBackend.cpp:
(WebCore::IDBCursorBackend::updateCursorData):
(WebCore::IDBCursorBackend::clear):
* Modules/indexeddb/IDBCursorBackend.h:

* Modules/indexeddb/IDBCursorBackendOperations.cpp:
(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
* Modules/indexeddb/IDBRequest.h:

* Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::OpenCursorOperation::perform):

* Modules/indexeddb/IDBServerConnection.h:
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

* DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

* DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):
* DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::SQLiteIDBCursor::advanceOnce): Clean this logic up to not need temporaries,
  and also to save the correct primary key (previously the 'value key')
* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

* DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor):
* DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

* WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix on GTK build since r163597
ryuan.choi@samsung.com [Fri, 7 Feb 2014 06:32:05 +0000 (06:32 +0000)]
Unreviewed build fix on GTK build since r163597

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNeed a ObjC SPI to get the process identifier for web process.
commit-queue@webkit.org [Fri, 7 Feb 2014 05:38:52 +0000 (05:38 +0000)]
Need a ObjC SPI to get the process identifier for web process.
https://bugs.webkit.org/show_bug.cgi?id=128356

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-02-06
Reviewed by Dan Bernstein.

Add a SPI for WKBrowsingContextController to return the process identifier of web
process in the current page.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController processIdentifier]):
* UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix on EFL build since r163597
ryuan.choi@samsung.com [Fri, 7 Feb 2014 05:14:43 +0000 (05:14 +0000)]
Unreviewed build fix on EFL build since r163597

preferences() changed return type from pointer to reference.

* UIProcess/API/efl/ewk_settings.cpp:
(EwkSettings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):
(EwkSettings::setDefaultTextEncodingName):
* UIProcess/API/efl/ewk_settings_private.h:
(EwkSettings::EwkSettings):
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] make should build WebKit2
joepeck@webkit.org [Fri, 7 Feb 2014 04:11:15 +0000 (04:11 +0000)]
[iOS] make should build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128351

Reviewed by Daniel Bates.

* Source/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a test case for navigator.isProtocolHandlerRegistered
gyuyoung.kim@samsung.com [Fri, 7 Feb 2014 03:12:06 +0000 (03:12 +0000)]
Add a test case for navigator.isProtocolHandlerRegistered
https://bugs.webkit.org/show_bug.cgi?id=128302

Reviewed by Anders Carlsson.

Add a test case for navigator.isProtocolHandlerRegistered. This new test will
check if "navigator.isProtocolHandlerRegistered" throws the proper exceptions
and returns a proper state of handler.

Currently, this function is only supported by EFL WK1 port.

* fast/dom/is-protocol-handler-registered-expected.txt: Added.
* fast/dom/is-protocol-handler-registered.html: Added.
* platform/efl-wk2/TestExpectations: Skip this test.
* platform/gtk/TestExpectations: ditto.
* platform/mac/TestExpectations: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in MiniBrowser when using Command-W to close a WK2 window
andersca@apple.com [Fri, 7 Feb 2014 02:41:10 +0000 (02:41 +0000)]
Crash in MiniBrowser when using Command-W to close a WK2 window
https://bugs.webkit.org/show_bug.cgi?id=128355
<rdar://problem/16008531>

Reviewed by Simon Fraser.

Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
Too much code depends on the clients never being null.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] iOS should use accelerated drawing by default, except in the simulator
timothy_horton@apple.com [Fri, 7 Feb 2014 02:30:11 +0000 (02:30 +0000)]
[wk2] iOS should use accelerated drawing by default, except in the simulator
https://bugs.webkit.org/show_bug.cgi?id=128140
<rdar://problem/15974171>

Reviewed by Anders Carlsson.

* Shared/WebPreferencesStore.h:
Turn full-page accelerated drawing on for iOS, except the simulator which doesn't support it.
Turn canvas accelerated drawing on for all platforms except the iOS simulator, for the same reason.
The defaults remain the same for non-iOS platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix DoYouEvenBench after r163429.
rniwa@webkit.org [Fri, 7 Feb 2014 02:29:51 +0000 (02:29 +0000)]
Fix DoYouEvenBench after r163429.

* Scripts/webkitpy/performance_tests/perftest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd support for AVKit fullscreen to WebKit2
commit-queue@webkit.org [Fri, 7 Feb 2014 02:19:55 +0000 (02:19 +0000)]
Add support for AVKit fullscreen to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128143

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-06
Reviewed by Simon Fraser.

Source/WebCore:

Rename overloaded functions to prevent ambiguous template parameter
compile error in generated code.

Rename overloaded exitFullscreen to exitFullscreenWithCompletionHandler.
Rename overloaded enterFullscreen to enterFullscreenWithCompletionHandler.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController exitFullscreen]):
* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::exitFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
* platform/ios/WebVideoFullscreenModelMediaElement.h:

Source/WebKit2:

Add WebVideoFullscreenManager and WebVideoFullscreenManagerProxy that implement
WebVideoFullscreenModel and WebVideoFullscreenInterface.

* DerivedSources.make:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
    initialize member m_videoFullscreenManager

(WebKit::WebPageProxy::videoFullscreenManager):
    add accessor for videoFullscreenManager

* UIProcess/WebPageProxy.h:
* UIProcess/WebVideoFullscreenManagerProxy.cpp: Added.
(WebKit::WebVideoFullscreenManagerProxy::create):
(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy):
    add basic creation for object.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
(WebKit::WebVideoFullscreenManagerProxy::requestExitFullScreen):
(WebKit::WebVideoFullscreenManagerProxy::play):
(WebKit::WebVideoFullscreenManagerProxy::pause):
(WebKit::WebVideoFullscreenManagerProxy::togglePlayState):
(WebKit::WebVideoFullscreenManagerProxy::seekToTime):
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):
    implement WebVideoFullscreenModel to send IPC message.

* UIProcess/WebVideoFullscreenManagerProxy.h: Added.
* UIProcess/WebVideoFullscreenManagerProxy.messages.in: Added.
    this interface closely matches WebVideoFullscreenInterface

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsFullscreenForNode):
(WebKit::WebChromeClient::enterFullscreenForNode):
(WebKit::WebChromeClient::exitFullscreenForNode):
    Forward these requests onto the videoFullscreenManager

* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::videoFullscreenManager):
    accessor for m_videoFullscreenManager

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebVideoFullscreenManager.cpp: Added.
(WebKit::WebVideoFullscreenManager::create):
(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager):
(WebKit::WebVideoFullscreenManager::~WebVideoFullscreenManager):
    add basic creation for object.

(WebKit::WebVideoFullscreenManager::supportsFullscreen):
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
(WebKit::WebVideoFullscreenManager::exitFullscreenForNode):
    implement interface called by WebChromeClient

(WebKit::WebVideoFullscreenManager::setDuration):
(WebKit::WebVideoFullscreenManager::setCurrentTime):
(WebKit::WebVideoFullscreenManager::setRate):
(WebKit::WebVideoFullscreenManager::setVideoDimensions):
(WebKit::WebVideoFullscreenManager::setVideoLayer):
(WebKit::WebVideoFullscreenManager::setVideoLayerID):
(WebKit::WebVideoFullscreenManager::enterFullscreen):
(WebKit::WebVideoFullscreenManager::exitFullscreen):
    implement WebVideoFullscreenInterface to send IPC message.

* WebProcess/WebVideoFullscreenManager.h: Added.
* WebProcess/WebVideoFullscreenManager.messages.in: Added.
    this interface closely matches WebVideoFullscreenModel

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoloadSubframe can return null in SubframeLoader::loadOrRedirectSubframe
jpfau@apple.com [Fri, 7 Feb 2014 02:18:32 +0000 (02:18 +0000)]
loadSubframe can return null in SubframeLoader::loadOrRedirectSubframe
https://bugs.webkit.org/show_bug.cgi?id=128344

Reviewed by Ryosuke Niwa.

Source/WebCore:

* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

* TestExpectations: Unskipped tests that were previously crashing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBegin work on making preferences per page instead of per page group
andersca@apple.com [Fri, 7 Feb 2014 02:12:18 +0000 (02:12 +0000)]
Begin work on making preferences per page instead of per page group
https://bugs.webkit.org/show_bug.cgi?id=128349

Reviewed by Andreas Kling.

* UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupGetPreferences):
* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(WKPageIsURLKnownHSTSHost):
* UIProcess/API/mac/WKView.mm:
(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createWebPage):
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::setAttachedWindowHeight):
(WebKit::WebInspectorProxy::setAttachedWindowWidth):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::preferences):
* UIProcess/WebPageGroup.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isProcessSuppressible):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::preferences):
(WebKit::WebPageProxy::setPreferences):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/mac/ViewGestureController.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):
(WebKit::WebInspectorProxy::platformAttach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse child iterator in HTMLDetailsElement::findMainSummary().
akling@apple.com [Fri, 7 Feb 2014 02:04:27 +0000 (02:04 +0000)]
Use child iterator in HTMLDetailsElement::findMainSummary().
<https://webkit.org/b/128335>

Reviewed by Antti Koivisto.

* html/HTMLDetailsElement.h:
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::findMainSummary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWorkaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException...
msaboff@apple.com [Fri, 7 Feb 2014 02:03:26 +0000 (02:03 +0000)]
Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
https://bugs.webkit.org/show_bug.cgi?id=128347

Reviewed by Geoffrey Garen.

Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks.
We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup().

Disabled stack overflow tests in testapi.js since it uses these paths.

THis patch will be reverted as part of a comprehensive solution to the problem.

* API/JSContextRef.cpp:
(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):
* API/tests/testapi.js:
* runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):
* runtime/VM.h:
(JSC::VM::ignoreStackLimit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd missing &.
antti@apple.com [Fri, 7 Feb 2014 02:01:45 +0000 (02:01 +0000)]
Add missing &.

* css/StyleInvalidationAnalysis.cpp:
(WebCore::shouldDirtyAllStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheck selectors exactly when invalidating style
antti@apple.com [Fri, 7 Feb 2014 01:58:40 +0000 (01:58 +0000)]
Check selectors exactly when invalidating style
https://bugs.webkit.org/show_bug.cgi?id=128321

Reviewed by Andreas Kling.

Selectors are now really fast to match with the JIT. Take advantage of this by invalidating
the document style exactly when a new stylesheet arrives (instead of using heuristics).

This reduces need for large style recalculations in some common cases.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
* css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::hasMatchedRules):
* css/RuleSet.h:
(WebCore::RuleSet::hasShadowPseudoElementRules):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
* css/SelectorChecker.h:

    Add new mode where all pseudo elements match so we can invalidate their element.

* css/StyleInvalidationAnalysis.cpp:
(WebCore::shouldDirtyAllStyle):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::invalidateStyleRecursively):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):

    Switch to real selector checker.

* css/StyleInvalidationAnalysis.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):
* css/StyleResolver.h:
(WebCore::StyleResolver::mediaQueryEvaluator):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove ChildProcess::m_activeTasks
barraclough@apple.com [Fri, 7 Feb 2014 01:57:37 +0000 (01:57 +0000)]
Remove ChildProcess::m_activeTasks
https://bugs.webkit.org/show_bug.cgi?id=128342

Reviewed by Anders Carlson.

Currently we funnel a number of different user activities
to a single UserActivity object, which requires a call down
from WebCore to WebKit2. Split these out so we can track
them separately.

Source/WebCore:

* page/ChromeClient.h:
    - removed [inc|dec]rementActivePageCount
* page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
    - incrementActivePageCount -> beginActivity
(WebCore::PageThrottler::~PageThrottler):
    - decrementActivePageCount -> endActivity
(WebCore::PageThrottler::throttlePage):
    - decrementActivePageCount -> endActivity
(WebCore::PageThrottler::unthrottlePage):
    - incrementActivePageCount -> beginActivity
* page/PageThrottler.h:
    - Added m_pageActivity.

Source/WebKit2:

* PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::PluginProcess):
    - added m_connectionActivity.
* PluginProcess/PluginProcess.h:
(WebKit::PluginProcess::connectionActivity):
    - added m_connectionActivity.
* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):
    - use connectionActivity
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess):
    - use a separate UserActivity for Java.
* Shared/ActivityAssertion.cpp:
(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):
* Shared/ActivityAssertion.h:
    - ChildProcess -> UserActivity
* Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
* Shared/ChildProcess.h:
    - remove m_activeTasks.
(WebKit::ChildProcess::processSuppressionEnabled):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
    - removed [inc|dec]rementActivePageCount

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago+[JSContext currentCallee] should return the currently executing JS function
mhahnenberg@apple.com [Fri, 7 Feb 2014 01:56:45 +0000 (01:56 +0000)]
+[JSContext currentCallee] should return the currently executing JS function
https://bugs.webkit.org/show_bug.cgi?id=122621

Reviewed by Geoffrey Garen.

It would be useful if there was a +[JSContext currentObject] API which was
callable from ObjC API callbacks. Its purpose would be to allow convenient
access to the JSValue wrapper for the currently-executing block callback.

* API/JSContext.h:
* API/JSContext.mm:
(+[JSContext currentCallee]):
(-[JSContext beginCallbackWithData:calleeValue:thisValue:argumentCount:arguments:]):
* API/JSContextInternal.h:
* API/ObjCCallbackFunction.mm:
(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):
* API/tests/testapi.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r163558.
commit-queue@webkit.org [Fri, 7 Feb 2014 01:55:24 +0000 (01:55 +0000)]
Unreviewed, rolling out r163558.
http://trac.webkit.org/changeset/163558
https://bugs.webkit.org/show_bug.cgi?id=128350

Breaks scrolling on certain websites (Requested by bfulgham on
#webkit).

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
* page/WheelEventDeltaTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] WebKit2 can't access the GPU
psolanki@apple.com [Fri, 7 Feb 2014 01:33:53 +0000 (01:33 +0000)]
[iOS] WebKit2 can't access the GPU
https://bugs.webkit.org/show_bug.cgi?id=128345
<rdar://problem/15976084>

Reviewed by Tim Horton.

Add an entitlement to allow web process to access GPU.

* Configurations/WebContent-iOS.entitlements: Added.
* Configurations/WebContentService.Development.xcconfig:
* Configurations/WebContentService.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS][WebKit2] Remove JoinExistingSession from plist
psolanki@apple.com [Fri, 7 Feb 2014 01:30:53 +0000 (01:30 +0000)]
[iOS][WebKit2] Remove JoinExistingSession from plist
https://bugs.webkit.org/show_bug.cgi?id=128318
<rdar://problem/15971612>

Reviewed by Tim Horton.

Remove JoinExistingSession key that is not available on iOS.

* NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
* NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Crash in WebCore::AXObjectCache::computedObjectAttributeCache
cfleizach@apple.com [Fri, 7 Feb 2014 01:29:33 +0000 (01:29 +0000)]
AX: Crash in WebCore::AXObjectCache::computedObjectAttributeCache
https://bugs.webkit.org/show_bug.cgi?id=128310

Reviewed by Alexey Proskuryakov.

Be more careful about using axObjectCache() directly since it can return null.
I audited the usage cases of this method and ensured the ptr was not null in cases
where I thought we might get hit by this.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::menuForMenuButton):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
(WebCore::AccessibilityObject::accessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::observableObject):
(WebCore::AccessibilityRenderObject::textChanged):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Rounded Insets Let Content Overlap Shape
zoltan@webkit.org [Fri, 7 Feb 2014 01:21:07 +0000 (01:21 +0000)]
[CSS Shapes] Rounded Insets Let Content Overlap Shape
https://bugs.webkit.org/show_bug.cgi?id=127852

Reviewed by Bem Jones-Bey.

Source/WebCore:

Using LengthSize to FloatSize conversion from LengthSize.h lead to miscalculated
inset border radius, when the border radius was defined by percentages. This patch
fixes the behavior and removes the incorrect conversion.

Test: fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html

* css/LengthFunctions.cpp:
(WebCore::floatSizeForLengthSize): Add new helper function for LengthSize to FloatSize conversion.
* css/LengthFunctions.h:
* platform/LengthSize.h: Remove floatSize conversion.
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): Use new helper function to calculate the right with for the inset border radius.

LayoutTests:

* fast/shapes/shape-outside-floats/shape-outside-rounded-inset-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix iOS builds after r163574
mhahnenberg@apple.com [Fri, 7 Feb 2014 01:18:38 +0000 (01:18 +0000)]
Fix iOS builds after r163574

* API/JSManagedValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegenerate JSTestObj now that ScriptArguments moved. Generator knows what to do.
joepeck@webkit.org [Fri, 7 Feb 2014 01:00:11 +0000 (01:00 +0000)]
Regenerate JSTestObj now that ScriptArguments moved. Generator knows what to do.

Rubber-stamped by Zalan Bujtas.

* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake adoption agency use the task queue
jpfau@apple.com [Fri, 7 Feb 2014 00:54:55 +0000 (00:54 +0000)]
Make adoption agency use the task queue
https://bugs.webkit.org/show_bug.cgi?id=109445

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/parser/adoption-agency-crash-01.html
       fast/parser/adoption-agency-crash-02.html
       fast/parser/adoption-agency-crash-03.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::insert):
(WebCore::executeInsertTask):
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):
(WebCore::executeTakeAllChildrenTask):
(WebCore::executeTask):
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reparent):
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild):
(WebCore::HTMLConstructionSite::takeAllChildren):
(WebCore::HTMLConstructionSite::fosterParent):
* html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSiteTask::HTMLConstructionSiteTask):
(WebCore::HTMLConstructionSiteTask::oldParent):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

* TestExpectations:
* fast/parser/adoption-agency-crash-01-expected.txt: Added.
* fast/parser/adoption-agency-crash-01.html: Added.
* fast/parser/adoption-agency-crash-02-expected.txt: Added.
* fast/parser/adoption-agency-crash-02.html: Added.
* fast/parser/adoption-agency-crash-03-expected.txt: Added.
* fast/parser/adoption-agency-crash-03.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Fri, 7 Feb 2014 00:51:18 +0000 (00:51 +0000)]
Fix build.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _remoteObjectRegistry]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the setter definition from r163514.
benjamin@webkit.org [Fri, 7 Feb 2014 00:50:32 +0000 (00:50 +0000)]
Fix the setter definition from r163514.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-06

* UIProcess/API/Cocoa/WKWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@163577 268f45cc-cd09-0410-ab3c-d52691b4dbfc