WebKit-https.git
13 years ago2006-09-21 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 21 Sep 2006 23:55:28 +0000 (23:55 +0000)]
2006-09-21  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim H.

        * platform/TextEncoding.cpp:
        (WebCore::TextEncoding::backslashAsCurrencySymbol):
        Add comment clarifying why backslashAsCurrencySymbol is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-21 Matt Lilek <pewtermoose@gmail.com>
bdash [Thu, 21 Sep 2006 22:36:08 +0000 (22:36 +0000)]
2006-09-21  Matt Lilek  <pewtermoose@gmail.com>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10975
        Update the blog template to valid HTML 4.01 Strict.

        * blog/wp-content/themes/webkit/comments-popup.php:
        * blog/wp-content/themes/webkit/comments.php:
        * blog/wp-content/themes/webkit/footer.php:
        * blog/wp-content/themes/webkit/header.php:
        * blog/wp-content/themes/webkit/style.css: Add missing semi-colon that the validator complained about.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adding more calls to layoutTestController.dumpChildFrameScrollPositions()
thatcher [Thu, 21 Sep 2006 22:05:43 +0000 (22:05 +0000)]
    Adding more calls to layoutTestController.dumpChildFrameScrollPositions()
        for tests that need to report child frame scroll positions.

        * http/tests/navigation/anchor-frames.html:
        * http/tests/navigation/anchor-subframeload.html:
        * http/tests/navigation/relativeanchor-frames.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFactored out get/release of HDC from cairo GraphicsContext.
seangies [Thu, 21 Sep 2006 21:58:40 +0000 (21:58 +0000)]
Factored out get/release of HDC from cairo GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by anders
justing [Thu, 21 Sep 2006 21:42:58 +0000 (21:42 +0000)]
    Reviewed by anders

        <rdar://problem/4426622>
        Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)

        * editing/htmlediting.cpp:
        (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
        aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
        Got rid of uses of DepricatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoHmm, forgot to commit kcanvas/ changes as part of linux build fixes.
rwlbuis [Thu, 21 Sep 2006 21:22:14 +0000 (21:22 +0000)]
Hmm, forgot to commit kcanvas/ changes as part of linux build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoToo tired too do it right :}
rwlbuis [Thu, 21 Sep 2006 21:18:32 +0000 (21:18 +0000)]
Too tired too do it right :}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 21:14:28 +0000 (21:14 +0000)]
    Reviewed by eseidel.

        Don't crash if no IconDatabase is available (ie. on Qt/Gdk)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 21:11:21 +0000 (21:11 +0000)]
    Reviewed by eseidel.

        Fix Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSet dumpChildFrameScrollPositions to NO before each test run.
thatcher [Thu, 21 Sep 2006 21:02:30 +0000 (21:02 +0000)]
Set dumpChildFrameScrollPositions to NO before each test run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
thatcher [Thu, 21 Sep 2006 20:43:37 +0000 (20:43 +0000)]
LayoutTests:

        Reviewed by Adam.

        Bug 10923: Frame scroll layout test failures on the buildbot
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10923

        Made this test call layoutTestController.dumpChildFrameScrollPositions().

        * fast/overflow/scrollRevealButton-expected.txt:
        * fast/overflow/scrollRevealButton.html:

WebKitTools:

        Reviewed by Adam.

        Bug 10923: Frame scroll layout test failures on the buildbot
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10923

        Added a new method that will toggle on the recursive dump of
        child frame scroll positions.

        * DumpRenderTree/DumpRenderTree.m:
        (dumpFrameScrollPosition):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpChildFrameScrollPositions]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Thu, 21 Sep 2006 19:56:56 +0000 (19:56 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 21 Sep 2006 19:31:56 +0000 (19:31 +0000)]
LayoutTests:

        Reviewed by john

        * editing/pasteboard/subframe-dragndrop-1-expected.checksum: Added.
        * editing/pasteboard/subframe-dragndrop-1-expected.png: Added.
        * editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
        * editing/pasteboard/subframe-dragndrop-1.html: Added.

WebCore:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
        TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe

        * editing/MoveSelectionCommand.cpp:
        (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
        to the position-to-move-to's document, not the fragment's document.  The
        fragment's document is the document used to create the fragment and is irrelavant.

WebKit:

        Reviewed by john

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
        TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe

        The top level WebHTMLView is responsible for performing dragging operations, but
        the inner view, the view that holds the drag caret, should be consulted to determine
        if the drag is a move drag.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.m:
        (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because
        it's only the top level WebHTMLView that performs this operation.
        (-[WebHTMLView _setInitiatedDrag:]): Added.
        (-[WebHTMLView _initiatedDrag]): Ditto.
        (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag,
        not the top level view.
        (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform
        a move drag, so don't ASSERT _isTopHTMLView.
        (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag.
        (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
        * WebView/WebHTMLViewInternal.h: Added two private SPI so that
        the top level WebHTMLView can set and get the initiatedDrag BOOL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEliminate a crash for all platforms without IconDatabase hooked up
beidson [Thu, 21 Sep 2006 19:01:36 +0000 (19:01 +0000)]
Eliminate a crash for all platforms without IconDatabase hooked up

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoYABF
beidson [Thu, 21 Sep 2006 17:18:46 +0000 (17:18 +0000)]
YABF

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-21 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 21 Sep 2006 09:39:35 +0000 (09:39 +0000)]
2006-09-21  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10966
        Bug 10966: Updates to website

        Resolves a few remaining validation issues, makes Bugzilla links consistent, and removes unneeded references to OpenDarwin.

        * coding/coding-style.html:
        * coding/lgpl-license.html:
        * contact.html:
        * index.html:
        * projects/css/index.html:
        * projects/editing/index.html:
        * projects/forms/index.html:
        * projects/html/index.html:
        * projects/index.html:
        * projects/javascript/index.html:
        * projects/svg/index.html:
        * projects/xslt/index.html:
        * webdevelopers/webkit_version.html:
        * webdevelopers/webkit_version_xl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
rwlbuis [Thu, 21 Sep 2006 07:29:08 +0000 (07:29 +0000)]
    Reviewed by eseidel.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
        new marker code draws end-marker in wrong place

        Keep track of the start of the subpath so we can handle
        closeTo/moveTo correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWheel scrolling prep for win32.
hyatt [Thu, 21 Sep 2006 07:18:47 +0000 (07:18 +0000)]
Wheel scrolling prep for win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-21 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Thu, 21 Sep 2006 06:27:36 +0000 (06:27 +0000)]
2006-09-21  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by TimH.

        Updates to make static pages validate as HTML 4.01 Strict.

        * building/build.html:
        * coding/coding-style.html:
        * header.inc:
        * index.html: Move <style> tag into the document head.
        * projects/cleanup/index.html:
        * projects/compat/index.html:
        * projects/css/index.html:
        * projects/documentation/index.html:
        * projects/editing/index.html:
        * projects/forms/index.html: Remove note about <label> not being implemented correctly.
        * projects/html/index.html:
        * projects/javascript/index.html:
        * projects/performance/index.html:
        * projects/portability/index.html: Change mention of Windows port to note that it is in progress rather than non-existant.
        * projects/printing/index.html:
        * projects/svg/index.html:
        * projects/xslt/index.html:
        * quality/bugwriting.html: Update WebKit version numbers to be accurate.  Move JS away from using innerHTML as W3C validator doesn't like it.
        * quality/reduction.html:
        * quality/reporting.html: Rename element IDs that start with numbers.  Update WebKit and Mac OS X version numbers to be accurate.
        * quality/testing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
thatcher [Thu, 21 Sep 2006 03:45:02 +0000 (03:45 +0000)]
    Reviewed by Hyatt.

        Bug 10917: REGRESSION (r16027): iFrame transparency broken
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

        Don't paint the base background color if we transparent.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by andersca.
aroben [Thu, 21 Sep 2006 00:54:02 +0000 (00:54 +0000)]
    Reviewed by andersca.

        * platform/FileChooser.h: Remove no-longer-necessary namespace std

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix up conditional.
seangies [Wed, 20 Sep 2006 23:52:06 +0000 (23:52 +0000)]
Fix up conditional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-20 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 23:37:33 +0000 (23:37 +0000)]
2006-09-20  Eric Seidel  <eric@eseidel.com>

        Reviewed by beth.

        Cleanup style in KCanvas.
        Remove extra white-space, unneeded arguments, etc.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasClipper.cpp:
        (WebCore::operator<<):
        (WebCore::KCanvasClipper::externalRepresentation):
        * kcanvas/KCanvasClipper.h:
        * kcanvas/KCanvasFilters.cpp:
        (WebCore::KCanvasFilter::externalRepresentation):
        (WebCore::operator<<):
        (WebCore::KCanvasFilterEffect::externalRepresentation):
        (WebCore::KCPointLightSource::externalRepresentation):
        (WebCore::KCSpotLightSource::externalRepresentation):
        (WebCore::KCDistantLightSource::externalRepresentation):
        (WebCore::KCanvasFEBlend::externalRepresentation):
        (WebCore::KCanvasFEColorMatrix::externalRepresentation):
        (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
        (WebCore::KCanvasFEComposite::externalRepresentation):
        (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
        (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
        (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
        (WebCore::KCanvasFEFlood::externalRepresentation):
        (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
        (WebCore::KCanvasFEImage::externalRepresentation):
        (WebCore::KCanvasFEMerge::externalRepresentation):
        (WebCore::KCanvasFEMorphology::externalRepresentation):
        (WebCore::KCanvasFEOffset::externalRepresentation):
        (WebCore::KCanvasFESpecularLighting::externalRepresentation):
        (WebCore::KCanvasFETile::externalRepresentation):
        (WebCore::KCanvasFETurbulence::externalRepresentation):
        * kcanvas/KCanvasFilters.h:
        (WebCore::KCanvasFEDiffuseLighting::lightSource):
        (WebCore::KCanvasFESpecularLighting::lightSource):
        * kcanvas/KCanvasImage.h:
        * kcanvas/KCanvasMarker.cpp:
        (WebCore::KCanvasMarker::externalRepresentation):
        * kcanvas/KCanvasMarker.h:
        * kcanvas/KCanvasResource.cpp:
        (WebCore::operator<<):
        * kcanvas/KCanvasResource.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        (WebCore::operator<<):
        (WebCore::writeIndent):
        (WebCore::writeStyle):
        (WebCore::write):
        (WebCore::writeRenderResources):
        * kcanvas/KCanvasTreeDebug.h:
        (WebCore::operator<<):
        * kcanvas/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::paint):
        * kcanvas/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        (WebCore::drawStartAndMidMarkers):
        * kcanvas/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * kcanvas/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::translateForAttributes):
        * kcanvas/RenderSVGImage.h:
        * kcanvas/device/KRenderingDevice.cpp:
        (WebCore::KRenderingDevice::currentContext):
        (WebCore::KRenderingDevice::popContext):
        (WebCore::KRenderingDevice::pushContext):
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/KRenderingFillPainter.h:
        * kcanvas/device/KRenderingPaintServer.h:
        (WebCore::KRenderingPaintServer::KRenderingPaintServer):
        (WebCore::KRenderingPaintServer::activeClient):
        (WebCore::KRenderingPaintServer::setActiveClient):
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (WebCore::operator<<):
        (WebCore::KRenderingPaintServerGradient::externalRepresentation):
        (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
        (WebCore::KRenderingPaintServerGradient::listener):
        (WebCore::KRenderingPaintServerGradient::setListener):
        (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        (WebCore::KRenderingPaintServerPattern::tile):
        (WebCore::KRenderingPaintServerPattern::setTile):
        (WebCore::KRenderingPaintServerPattern::listener):
        (WebCore::KRenderingPaintServerPattern::setListener):
        (WebCore::KRenderingPaintServerPattern::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerPattern.h:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        (WebCore::KRenderingPaintServerSolid::externalRepresentation):
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        (WebCore::KRenderingStrokePainter::strokeMiterLimit):
        (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
        * kcanvas/device/KRenderingStrokePainter.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::prepareFilter):
        * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
        * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
        (WebCore::KCanvasMaskerQuartz::applyMask):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        (WebCore::KCanvasImageQuartz::init):
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        (WebCore::KCanvasClipperQuartz::applyClip):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceQuartz::quartzContext):
        (WebCore::KRenderingDeviceQuartz::contextForImage):
        (WebCore::KRenderingDeviceQuartz::createPaintServer):
        (WebCore::KRenderingDeviceQuartz::createResource):
        (WebCore::KRenderingDeviceQuartz::createFilterEffect):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (WebCore::CGShadingRefForLinearGradient):
        (WebCore::CGShadingRefForRadialGradient):
        (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        (WebCore::KRenderingPaintServerGradientQuartz::teardown):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
        (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
        (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
        (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
        (WebCore::KRenderingPaintServerSolidQuartz::draw):
        (WebCore::KRenderingPaintServerSolidQuartz::setup):
        (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
        (WebCore::KRenderingPaintServerPatternQuartz::setup):
        (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
        (WebCore::KRenderingPaintServerPatternQuartz::teardown):
        * kcanvas/device/quartz/QuartzSupport.h:
        * kcanvas/device/quartz/QuartzSupport.mm:
        (WebCore::applyStrokeStyleToContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
andersca [Wed, 20 Sep 2006 22:45:13 +0000 (22:45 +0000)]
JavaScriptCore:

2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        * wtf/MathExtras.h:
        Get rid of lrint.

WebCore:

2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Dave Hyatt.

        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        Use lroundf instead of lround since deltas are floats.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-20 Julien Palmas <julien.palmas@gmail.com>
eseidel [Wed, 20 Sep 2006 22:38:59 +0000 (22:38 +0000)]
2006-09-20  Julien Palmas  <julien.palmas@gmail.com>

        Reviewed by eseidel.  Landed by eseidel.

        Test: svg/custom/pattern-y-offset.svg

        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerPatternQuartz::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add a new wheelEvent method to ScrollView. Platforms that wish
hyatt [Wed, 20 Sep 2006 22:37:28 +0000 (22:37 +0000)]
    Add a new wheelEvent method to ScrollView.  Platforms that wish
        to handle the wheel event for the scroll view themselves can then
        do so there.  (Mac lets the underlying NSScrollView do it for now.)

        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/ScrollView.h:
        (WebCore::ScrollView::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoSend debug messages to debugger console.
seangies [Wed, 20 Sep 2006 21:59:15 +0000 (21:59 +0000)]
Send debug messages to debugger console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix copyright year.
thatcher [Wed, 20 Sep 2006 21:44:11 +0000 (21:44 +0000)]
Fix copyright year.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 20 Sep 2006 21:32:59 +0000 (21:32 +0000)]
WebCore:

        Reviewed by Tim Omernick

        Part of fixing a crash Tim O showed me that I missed in a release build.
        WebKit should be able to call through the bridge to WebCore no matter what -
        Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
        (-[WebCoreIconDatabaseBridge isOpen]):
        (-[WebCoreIconDatabaseBridge removeAllIcons]):
        (-[WebCoreIconDatabaseBridge _isEmpty]):
        (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
        (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
        (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
        (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
        (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
        (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
        (-[WebCoreIconDatabaseBridge retainIconForURL:]):
        (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
        (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
        (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
        (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
        (-[WebCoreIconDatabaseBridge _setEnabled:]):
        (-[WebCoreIconDatabaseBridge _isEnabled]):

WebKit:

        Reviewed by Tim Omernick

        Fixing part of a crash Tim O showed me.  [WebIconDatabase init] should finish
        gracefully even if we can't open the database

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add an implementation of lrint for Win32.
hyatt [Wed, 20 Sep 2006 21:12:01 +0000 (21:12 +0000)]
    Add an implementation of lrint for Win32.

        Reviewed by anders

        * wtf/MathExtras.h:
        (lrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-20 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 20 Sep 2006 21:04:01 +0000 (21:04 +0000)]
2006-09-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        Add String::split which returns a Vector of Strings and use it instead of
        DeprecatedStringList.

        * bindings/js/kjs_events.cpp:
        (KJS::Clipboard::getValueProperty):
        * bindings/js/kjs_window.cpp:
        (KJS::parseModalDialogFeatures):
        * css/MediaList.cpp:
        (WebCore::MediaList::setMediaText):
        * dom/Clipboard.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formData):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::split):
        * platform/StringImpl.cpp:
        * platform/StringImpl.h:
        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::types):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim O.
thatcher [Wed, 20 Sep 2006 20:43:56 +0000 (20:43 +0000)]
    Reviewed by Tim O.

        <rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with

        * Misc/WebKitVersionChecks.h: Added.
        * Misc/WebKitVersionChecks.m: Added.
        (WebKitLinkedOnOrAfter): Added.
        (WebKitLinkTimeVersion): Added.
        (WebKitRunTimeVersion): Added.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
tomernic [Wed, 20 Sep 2006 20:31:30 +0000 (20:31 +0000)]
    Reviewed by Darin.

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        Fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 20 Sep 2006 19:20:33 +0000 (19:20 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/selection/editable-links.html: Added.
        * editing/selection/editable-links.html-disabled: Removed.

WebCore:

        Reviewed by harrison

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
        HTMLElement::isContentEditable just to check the Frame's editability, since
        it calls updateRenderering, which can get us into infinite recursion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 20 Sep 2006 19:12:08 +0000 (19:12 +0000)]
WebCore:

        Reviewed by Darin

        Cleaned up my last patch alot, and made the WebCore icon database disabled by default

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase): Disabled by default
        (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
        (WebCore::IconDatabase::iconForPageURL): Ditto
        (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
        (WebCore::IconDatabase::iconURLForPageURL): Ditto
        (WebCore::IconDatabase::retainIconForPageURL): Ditto
        (WebCore::IconDatabase::releaseIconForPageURL): Ditto
        (WebCore::IconDatabase::setIconDataForIconURL): Ditto
        (WebCore::IconDatabase::setIconURLForPageURL): Ditto
        (WebCore::IconDatabase::hasEntryForIconURL): Ditto
        (WebCore::IconDatabase::setEnabled): Fixed a big bug here!

WebKit:

        Reviewed by Darin

        Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by timothy.
aroben [Wed, 20 Sep 2006 18:33:10 +0000 (18:33 +0000)]
    Reviewed by timothy.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
        Test results for fast/js/window-properties.html should include
        children of window.document.body.firstChild

        * fast/js/window-properties-expected.txt: Regenerate results which now
        include window.document.body.firstChild.*
        * fast/js/window-properties.html: Print out 'null' for null objects
        instead of 'object' for more clarity

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
aroben [Wed, 20 Sep 2006 17:42:48 +0000 (17:42 +0000)]
WebCore:
        Reviewed by Adele.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
        REGRESSION: file upload control with direction:rtl or text-align:right
        draws button on top of filename/icon

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::setStyle): Force text-align to
        match direction
        (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
        the filename and icon in RTL

LayoutTests:
        Reviewed by Adele.

        Adding test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
        REGRESSION: file upload control with direction:rtl or text-align:right
        draws button on top of filename/icon

        * fast/forms/file-input-direction-expected.checksum: Added.
        * fast/forms/file-input-direction-expected.png: Added.
        * fast/forms/file-input-direction-expected.txt: Added.
        * fast/forms/file-input-direction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
aliceli1 [Wed, 20 Sep 2006 17:30:32 +0000 (17:30 +0000)]
    Reviewed by Adam Roben.

        fixed windows build

        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        changed lrint to lround

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build Fix. Adds isHorizontal attribute back to WheelEvent
weinig [Wed, 20 Sep 2006 14:23:03 +0000 (14:23 +0000)]
    Build Fix.  Adds isHorizontal attribute back to WheelEvent
        for the Objective-C bindings.  If it is found that isHorizontal
        is not used, we should remove it again but also remove it's
        declaration from PublicDOMInterfaces.h

        * dom/WheelEvent.h:
        (WebCore::WheelEvent::isHorizontal):
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 10945, WheelEvent should support two dimensions at once, since
hyatt [Wed, 20 Sep 2006 09:52:25 +0000 (09:52 +0000)]
    Fix for 10945, WheelEvent should support two dimensions at once, since
        MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
        to allow for diagonal scrolling.

        Reviewed by Eric

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchWheelEvent):
        * dom/WheelEvent.cpp:
        (WebCore::WheelEvent::WheelEvent):
        (WebCore::WheelEvent::initWheelEvent):
        * dom/WheelEvent.h:
        (WebCore::WheelEvent::wheelDelta):
        (WebCore::WheelEvent::wheelDeltaX):
        (WebCore::WheelEvent::wheelDeltaY):
        * dom/WheelEvent.idl:
        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::deltaX):
        (WebCore::PlatformWheelEvent::deltaY):
        (WebCore::PlatformWheelEvent::normalize):
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-20 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 09:38:23 +0000 (09:38 +0000)]
2006-09-20  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        Commit two test updates I forgot to commit with:
        Markers should clip to their viewport.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
        * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
        * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 09:20:39 +0000 (09:20 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        Split KCanvasResources.* into multiple files (and some other minor spacing changes).

        No tests were harmed in the making of this patch.

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvasClipper.cpp: Added.
        (WebCore::operator<<):
        * kcanvas/KCanvasClipper.h: Added.
        * kcanvas/KCanvasFilters.h:
        * kcanvas/KCanvasImage.h:
        * kcanvas/KCanvasMarker.cpp: Added.
        * kcanvas/KCanvasMarker.h: Added.
        * kcanvas/KCanvasMasker.cpp: Added.
        (WebCore::KCanvasMasker::KCanvasMasker):
        (WebCore::KCanvasMasker::setMask):
        (WebCore::KCanvasMasker::externalRepresentation):
        (WebCore::getMaskerById):
        * kcanvas/KCanvasMasker.h: Added.
        * kcanvas/KCanvasResource.cpp: Added.
        (WebCore::KCanvasResource::invalidate):
        (WebCore::KCanvasResource::externalRepresentation):
        (WebCore::getResourceById):
        (WebCore::getPaintServerById):
        * kcanvas/KCanvasResource.h: Added.
        * kcanvas/KCanvasResources.cpp: Removed.
        * kcanvas/KCanvasResources.h: Removed.
        * kcanvas/RenderPath.cpp:
        * kcanvas/RenderSVGContainer.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/RenderSVGText.cpp:
        * kcanvas/device/KRenderingPaintServer.h:
        * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 20 Sep 2006 07:16:10 +0000 (07:16 +0000)]
WebCore:

        Reviewed by Sarge Decker

        <rdar://problem/4739892> and <rdar://problem/4729797>
        - WebCore::IconDatabase needs to have and respect an enabled() flag
        - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari

        * bridge/mac/WebCoreIconDatabaseBridge.h:
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
        (-[WebCoreIconDatabaseBridge _isEnabled]): Added
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::IconDatabase):
        (WebCore::IconDatabase::open): Don't open if disabled
        (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
        (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
        (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
        (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
        (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
        (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::releaseIconURL):
        (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
        (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
        (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
        (WebCore::IconDatabase::setEnabled): Added
        * loader/icon/IconDatabase.h:
        (WebCore::IconDatabase::enabled): Added
        * page/Frame.cpp:
        (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
        * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include

WebKit:

        Reviewed by Sarge Decker

        <rdar://problem/4739892> and <rdar://problem/4729797>
        - WebCore::IconDatabase needs to have and respect an enabled() flag
        - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge
        (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Massage mouse wheel handling so that it is more cross-platform. Make
hyatt [Wed, 20 Sep 2006 07:06:57 +0000 (07:06 +0000)]
    Massage mouse wheel handling so that it is more cross-platform.  Make
        all the work happen in handleWheelEvent on the FrameView.

        Reviewed by bradee-oh

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::wheelEvent):
        * page/FrameView.cpp:
        (WebCore::FrameView::handleWheelEvent):
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::platformDelta):
        (WebCore::PlatformWheelEvent::delta):
        * platform/mac/WheelEventMac.mm:
        (WebCore::platformDeltaForEvent):
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scroll):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 05:37:18 +0000 (05:37 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by adele.

        Improve test output for filters with bounding-box relative sizes.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8585

        Many test results updated.

        * kcanvas/KCanvasFilters.cpp:
        (WebCore::KCanvasFilter::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Wed, 20 Sep 2006 05:26:46 +0000 (05:26 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by adele.

        Markers should clip to their viewport.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

        Test: svg/custom/marker-overflow-clip.svg

        * kcanvas/KCanvasResources.cpp:
        (WebCore::KCanvasMarker::KCanvasMarker):
        (WebCore::KCanvasMarker::setMarker):
        (WebCore::KCanvasMarker::draw):
        * kcanvas/KCanvasResources.h:
        (WebCore::KCanvasMasker::mask):
        * ksvg2/svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        (WebCore::SVGMarkerElement::parseMappedAttribute):
        (WebCore::SVGMarkerElement::canvasResource):
        (WebCore::SVGMarkerElement::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChecking the mail post-commit hook on the new server
beidson [Wed, 20 Sep 2006 03:57:18 +0000 (03:57 +0000)]
Checking the mail post-commit hook on the new server

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCheckin test on the new hardware!
beidson [Wed, 20 Sep 2006 03:46:03 +0000 (03:46 +0000)]
Checkin test on the new hardware!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 20 Sep 2006 01:57:03 +0000 (01:57 +0000)]
LayoutTests:

        Reviewed by eseidel

        Disabling this test temporarily.

        * editing/selection/editable-links.html: Removed.
        * editing/selection/editable-links.html-disabled: Added.

WebCore:

        Reviewed by eseidel

        Backing out my recent change.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin McCullough
beidson [Wed, 20 Sep 2006 00:53:48 +0000 (00:53 +0000)]
    Reviewed by Kevin McCullough

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
        Opening a PDF in a new tab/window creates a documentless-frame
        and we deref the document without checking its validity

        * page/Frame.cpp:
        (WebCore::Frame::iconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 19 Sep 2006 23:36:03 +0000 (23:36 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/selection/editable-links-expected.checksum: Added.
        * editing/selection/editable-links-expected.png: Added.
        * editing/selection/editable-links-expected.txt: Added.
        * editing/selection/editable-links.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4735272>
        Can not click into link in programmatically editable content

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
        userModify to implement document wide editability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoI totally LIED in the Changelog
beidson [Tue, 19 Sep 2006 23:25:56 +0000 (23:25 +0000)]
I totally LIED in the Changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and landed by Brady
beidson [Tue, 19 Sep 2006 23:24:37 +0000 (23:24 +0000)]
    Reviewed and landed by Brady

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
        Build broken when SVG is not enabled.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http://bugzilla.opendarwin.org/show_bug.cgi?id=8220
beidson [Tue, 19 Sep 2006 22:44:52 +0000 (22:44 +0000)]
    bugzilla.opendarwin.org/show_bug.cgi?id=8220
        Add the favicon.ico to the site.
        Notice, users of shipping Safari won't see the updated favicon
        unless they clear their icon cache - ToT users can manually reload
        the site and force the refresh  ;)

        * favicon.ico: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Tue, 19 Sep 2006 22:01:33 +0000 (22:01 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/pasteboard/pasting-tabs-expected.checksum: Added.
        * editing/pasteboard/pasting-tabs-expected.png: Added.
        * editing/pasteboard/pasting-tabs-expected.txt: Added.
        * editing/pasteboard/pasting-tabs.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces

        Pasting plain text results in a match style paste, and the insertion
        position is whitespace normal, which clobbers the whitespace:pre on
        tab spans.  Skip changes to the whitespace mode when computing a style
        change for tab spans or the text nodes inside tab spans.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init): Don't change the whitespace mode inside
        tab spans.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 5298, shape=default not supported for image maps. Implement
hyatt [Tue, 19 Sep 2006 21:31:59 +0000 (21:31 +0000)]
    Fix for bug 5298, shape=default not supported for image maps.  Implement
        support for it.

        Reviewed by timo

        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::getRegion):
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::mapMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim O.
ap [Tue, 19 Sep 2006 18:04:11 +0000 (18:04 +0000)]
    Reviewed by Tim O.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10661
        REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage initWithPath:]): On 32-bit PowerPC, don't bail out if
        the bundle is nil - it can be a CFM plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
aroben [Tue, 19 Sep 2006 17:25:21 +0000 (17:25 +0000)]
    Reviewed by Adele.

        Update tests for the new file upload control.

        * fast/forms/file-input-disabled-expected.txt:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/input-appearance-height-expected.txt:
        * fast/forms/input-value-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
aroben [Tue, 19 Sep 2006 17:23:54 +0000 (17:23 +0000)]
    Reviewed by Adele.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
        "no file selected" placeholder text missing from file upload control

        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderFileUploadControl.cpp: Remove class
        RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
        defaultWidthNumChars
        (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
        RenderBlock constructor instead of RenderFlexibleBox,
        (WebCore::RenderFileUploadControl::setStyle): Remove references to
        m_fileBox.
        (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
        instead of updateIconAndFileName() (which has been removed)
        (WebCore::RenderFileUploadControl::updateFromElement): Remove
        references to m_fileBox, don't call updateIconAndFilename()
        (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
        without using m_fileBox
        (WebCore::RenderFileUploadControl::createButtonStyle): Remove
        now-unnecessary display:box rule.
        (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
        to paintingDisabled() now that Icon::paint() does it, and add code to
        paint the filename directly.
        (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
        out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
        * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
        subclass of RenderBlock instead of RenderFlexibleBox, remove
        updateIconAndFilename() method, remove m_fileBox instance variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 19 Sep 2006 09:48:22 +0000 (09:48 +0000)]
2006-09-19  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10846

        No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
eseidel [Tue, 19 Sep 2006 09:39:15 +0000 (09:39 +0000)]
2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>

        Reviewed by eseidel.  Landed by eseidel.

        Detect that close button was pressed and exit cleanly.

        * GdkLauncher/main.cpp:
        (handle_event):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
eseidel [Tue, 19 Sep 2006 09:37:10 +0000 (09:37 +0000)]
2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>

        Reviewed by eseidel.  Landed by eseidel.

        Build fix only, no tests affected.

        * platform/gdk/FontPlatformDataGdk.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/gdk/FrameGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameGdk::isLoadTypeReload):
        (FrameGdk::originalRequestURL):
        (IconDatabase::setIconURLForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Refine the fix for 9805 to really get all the complex cases right.
hyatt [Tue, 19 Sep 2006 09:10:09 +0000 (09:10 +0000)]
    Refine the fix for 9805 to really get all the complex cases right.

        Reviewed by Eric

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::handleBottomOfBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand changes for margin collapsing fixes. Yank bad layout test.
hyatt [Tue, 19 Sep 2006 09:08:49 +0000 (09:08 +0000)]
Land changes for margin collapsing fixes. Yank bad layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for 9805, <hr> not positioned properly following a previous empty sibling
hyatt [Tue, 19 Sep 2006 06:23:39 +0000 (06:23 +0000)]
    Fix for 9805, <hr> not positioned properly following a previous empty sibling
        that had clear:both set on it.  Update self-collapsing block clearance
        behavior to match what is specified in the latest draft of CSS2.1.

        Reviewed by Eric

        Added fast/block/margin-collapse/empty-clear-blocks.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::handleBottomOfBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady, landed by Brady
beidson [Tue, 19 Sep 2006 02:36:51 +0000 (02:36 +0000)]
    Reviewed by Brady, landed by Brady

        Send receivedResponse callback to ResourceLoaderClient when loading
        file URLs.

        See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845

        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoader::fileLoadTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Tue, 19 Sep 2006 02:21:52 +0000 (02:21 +0000)]
WebCore:

        Reviewed by Anders

        <rdar://problem/3028061> - WebKit never updates favicon
        The WebKit enforced expiration date for icons has worked for some time, but the
        move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
        functionality.  This patch fixes that up, along with some other architectural improvements,
        the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

        * bridge/mac/FrameMac.h: Added isLoadTypeReload()
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
        * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
        * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
        * dom/Document.h: Added m_iconURL
        (WebCore::Document::iconURL): Added
        (WebCore::Document::setIconURL): Ditto
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
        * page/Frame.cpp:
        (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
        (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
        * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
        * page/FramePrivate.h: Nuked IconURL
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::isLoadTypeReload):

WebKit:

        Reviewed by Anders

        Implement a bridge method so WebCore can find the reload type of a frame load

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge isLoadTypeReload]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Mon, 18 Sep 2006 23:15:22 +0000 (23:15 +0000)]
    Reviewed by Tim H.

        - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
          it is it turns out that AppKit uses it.

        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMRGBColor.mm:
        (-[DOMRGBColor _color]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Mon, 18 Sep 2006 21:40:34 +0000 (21:40 +0000)]
WebCore:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
        Yet Another Objective-C Bindings Patch

        - Whitespace cleanup for IDLParser.pm

        - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
          and DOMAbstractView into their own files.

        - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
          it is not used and a public method is available now.

        - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
          as it not used.

        - Auto-generate method isContentEditable for DOMNode.

        - General cleanup of bindings code including removing unneeded #imports
          and whitespace cleanup

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (addElementClass):
        (elementClass):
        (-[DOMNode _initWithNode:WebCore::]):
        (+[DOMNode _nodeWith:WebCore::]):
        (-[DOMNode WebCore::]):
        (-[DOMNode KJS::Bindings::]):
        (-[DOMNode addEventListener:::]):
        (-[DOMNode removeEventListener:::]):
        (-[DOMNode dispatchEvent:]):
        (-[DOMElement image]):
        (-[DOMElement _font]):
        (-[DOMElement _imageTIFFRepresentation]):
        (-[DOMElement _getURLAttribute:]):
        (-[DOMElement _NPObject]):
        (-[DOMElement isFocused]):
        (-[DOMRange dealloc]):
        (-[DOMRange finalize]):
        (-[DOMRange description]):
        (-[DOMRange startContainer]):
        (-[DOMRange startOffset]):
        (-[DOMRange endContainer]):
        (-[DOMRange endOffset]):
        (-[DOMRange collapsed]):
        (-[DOMRange commonAncestorContainer]):
        (-[DOMRange setStart::]):
        (-[DOMRange setEnd::]):
        (-[DOMRange setStartBefore:]):
        (-[DOMRange setStartAfter:]):
        (-[DOMRange setEndBefore:]):
        (-[DOMRange setEndAfter:]):
        (-[DOMRange collapse:]):
        (-[DOMRange selectNode:]):
        (-[DOMRange selectNodeContents:]):
        (-[DOMRange compareBoundaryPoints::]):
        (-[DOMRange deleteContents]):
        (-[DOMRange extractContents]):
        (-[DOMRange cloneContents]):
        (-[DOMRange insertNode:]):
        (-[DOMRange surroundContents:]):
        (-[DOMRange cloneRange]):
        (-[DOMRange toString]):
        (-[DOMRange detach]):
        (-[DOMRange _initWithRange:WebCore::]):
        (+[DOMRange _rangeWith:WebCore::]):
        (-[DOMRange WebCore::]):
        (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
        (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
        (-[DOMNodeFilter WebCore::]):
        (-[DOMNodeFilter dealloc]):
        (-[DOMNodeFilter finalize]):
        (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
        (-[DOMNodeIterator WebCore::]):
        (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
        (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
        (-[DOMTreeWalker WebCore::]):
        (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
        (ObjCNodeFilterCondition::acceptNode):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        (ObjCEventListener::find):
        (ObjCEventListener::create):
        (ObjCEventListener::handleEvent):
        * bindings/objc/DOMAbstractView.h: Added.
        * bindings/objc/DOMAbstractView.mm: Added.
        (-[DOMAbstractView document]):
        (-[DOMAbstractView WebCore::]):
        (-[DOMAbstractView _initWithAbstractView:WebCore::]):
        (+[DOMAbstractView _abstractViewWith:WebCore::]):
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
        (+[DOMStyleSheet _styleSheetWith:WebCore::]):
        (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
        (-[DOMCSSRule _initWithRule:WebCore::]):
        (+[DOMCSSRule _CSSRuleWith:WebCore::]):
        (-[DOMCSSValue _initWithValue:WebCore::]):
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
        (-[DOMDocument getComputedStyle::]):
        (-[DOMDocument getMatchedCSSRules::]):
        * bindings/objc/DOMCore.h:
        * bindings/objc/DOMEventException.h: Added.
        * bindings/objc/DOMEvents.h:
        * bindings/objc/DOMEvents.mm:
        * bindings/objc/DOMException.h: Added.
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
        (viewForElement):
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        (-[DOMHTMLInputElement _selectedRange]):
        (-[DOMHTMLInputElement _setAutofilled:]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMObject.h:
        * bindings/objc/DOMPrivate.h:
        * bindings/objc/DOMRange.h:
        * bindings/objc/DOMRangeException.h: Added.
        * bindings/objc/DOMViews.h:
        * bindings/objc/DOMViews.mm: Removed.
        * bindings/objc/DOMXPath.h:
        * bindings/objc/DOMXPathException.h: Added.
        * bindings/scripts/IDLParser.pm:
        * dom/Node.idl:

WebKit:

        Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
        Yet Another Objective-C Bindings Patch

        * MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan.
harrison [Mon, 18 Sep 2006 21:37:08 +0000 (21:37 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

        Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.

        * WebView/WebDocumentInternal.h:
        Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _textSizeMultiplierChanged]):
        Send [self _updateTextSizeMultiplier].

        * WebView/WebPDFView.m:
        (-[WebPDFView _textSizeMultiplierChanged]):
        ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.

        * WebView/WebView.m:
        (-[WebView setTextSizeMultiplier:]):
        Send [self _notifyTextSizeMultiplierChanged];

        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
        Alter the _textSizeMultiplier directly so that notification is not sent.
        Minor formatting.

        (-[WebView _notifyTextSizeMultiplierChanged]):
        New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoACTUAL Windows build fix
beidson [Mon, 18 Sep 2006 20:42:51 +0000 (20:42 +0000)]
ACTUAL Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
beidson [Mon, 18 Sep 2006 20:32:07 +0000 (20:32 +0000)]
    Windows build fix

        * platform/win/TemporaryLinkStubs.cpp:
        (IconDatabase::setIconURLForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for float bug.
hyatt [Mon, 18 Sep 2006 19:20:41 +0000 (19:20 +0000)]
Add layout test for float bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 3969, hr width doesn't update when it clears a float. This
hyatt [Mon, 18 Sep 2006 19:12:44 +0000 (19:12 +0000)]
    Fix for bug 3969, hr width doesn't update when it clears a float.  This
        was also a problem with tables and overflow sections.

        Reviewed by Eric

        Added fast/block/float/width-update-after-clear.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:07:06 +0000 (19:07 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:06:14 +0000 (19:06 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:05:07 +0000 (19:05 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 19:00:54 +0000 (19:00 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate table layout test results.
hyatt [Mon, 18 Sep 2006 18:55:29 +0000 (18:55 +0000)]
Update table layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John
beidson [Mon, 18 Sep 2006 18:13:26 +0000 (18:13 +0000)]
    Reviewed by John

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
        REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly

        * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
        * bridge/win/FrameWin.h: Added originalRequestURL()
        * loader/icon/IconLoader.cpp:
        (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
        * page/Frame.cpp:
        (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
        (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
        (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
        * page/Frame.h: Added pure virtual originalRequestURL()
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::originalRequestURL): Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapV...
thatcher [Mon, 18 Sep 2006 18:11:29 +0000 (18:11 +0000)]
Build fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapValueCallBacks. Just make a new NSMapTableValueCallBacks of {NULL, NULL, NULL} to make it build on new or older systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis [Mon, 18 Sep 2006 09:25:48 +0000 (09:25 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
        REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

        Make sure the paint method is not exited without popping
        context and transparency layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-18 Graham Dennis <graham.dennis@gmail.com>
bdash [Mon, 18 Sep 2006 09:16:54 +0000 (09:16 +0000)]
2006-09-18  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Eric.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10896
        REGRESSION: WebKit can't be built with SVG disabled

        * bindings/scripts/CodeGeneratorObjC.pm:
        For each file generated add a #ifdef <something>_SUPPORT / #endif
        pair if the idl file has a Conditional extended attribute

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 06:45:54 +0000 (06:45 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Reviewed by ap.

        REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
        http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

        * bridge/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 06:14:46 +0000 (06:14 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Reviewed by hyatt.

        * fast/js/window-properties.html: make work in Firefox (hangs IE)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
ap [Mon, 18 Sep 2006 05:03:42 +0000 (05:03 +0000)]
    Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
        REGRESSION: Animated GIF ignores frame intervals and loops infinitely

        No test possible.

        * platform/Image.cpp:
        (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
        maybe the rest just hasn't been loaded yet.
        (WebCore::Image::startAnimation): Move the frame count check here - there is no need
        to start animating before we get at least two frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 18 Sep 2006 04:46:30 +0000 (04:46 +0000)]
2006-09-17  Eric Seidel  <eric@eseidel.com>

        Add a textual dump of the window object property tree.

        Reviewed by Sarge.

        * fast/js/window-properties-expected.txt: Added.
        * fast/js/window-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:48:19 +0000 (00:48 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:46:03 +0000 (00:46 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated tests for font changes.
hyatt [Mon, 18 Sep 2006 00:45:07 +0000 (00:45 +0000)]
Land updated tests for font changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sarge
beidson [Sun, 17 Sep 2006 23:17:33 +0000 (23:17 +0000)]
    Reviewed by Sarge

        IconLoader now gracefully handles the condition where there's no document in the frame
        (ie. PDFs)

        * loader/icon/IconLoader.cpp:
        (IconLoader::startLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 10899, rework how CSS keywords work to be smarter about
hyatt [Sun, 17 Sep 2006 23:06:47 +0000 (23:06 +0000)]
    Fix for bug 10899, rework how CSS keywords work to be smarter about
        using the correct size when generic families change (e.g., monospace to
        serif and vice versa).

        Reviewed by aroben

        Added fast/text/basic/generic-family-changes.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
        (WebCore::CSSStyleSelector::fontSizeForKeyword):
        * css/cssstyleselector.h:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle):
        * platform/FontDescription.h:
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::keywordSize):
        (WebCore::FontDescription::setKeywordSize):
        (WebCore::FontDescription::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adding layout test for bug 10899.
hyatt [Sun, 17 Sep 2006 23:04:09 +0000 (23:04 +0000)]
    Adding layout test for bug 10899.

        * fast/text/basic/generic-family-changes-expected.checksum: Added.
        * fast/text/basic/generic-family-changes-expected.png: Added.
        * fast/text/basic/generic-family-changes-expected.txt: Added.
        * fast/text/basic/generic-family-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by hyatt, sfalken.
aroben [Sun, 17 Sep 2006 21:39:49 +0000 (21:39 +0000)]
    Reviewed by hyatt, sfalken.

        Get DumpRenderTree compiling and limping along on Windows.

        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
        (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit
        (main): Add NULL argument to Page constructor.
        * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
        * Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
ap [Sun, 17 Sep 2006 20:18:46 +0000 (20:18 +0000)]
    Reviewed by Brady.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
        REGRESSION: Reproducible crash in XMLHttpRequest::abort()

        Test: http/tests/xmlhttprequest/xhr-onunload.html

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().

        * loader/icon/IconLoader.cpp:
        (IconLoader::startLoading): Fix a similar latent bug here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
aroben [Sun, 17 Sep 2006 19:37:26 +0000 (19:37 +0000)]
    Build fix.

        * loader/icon/IconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand updated results from font fix yesterday.
hyatt [Sun, 17 Sep 2006 19:24:08 +0000 (19:24 +0000)]
Land updated results from font fix yesterday.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-17 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 17 Sep 2006 18:36:23 +0000 (18:36 +0000)]
2006-09-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Brady.

        Add simplifyWhiteSpace and stripWhiteSpace to the String class.
        Change the XSLT Parameter Map to use Strings instead of StringImpls.
        General cleanup.

        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorProtoFunc::callAsFunction):
        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_window.cpp:
        (KJS::ScheduledAction::execute):
        * css/MediaList.cpp:
        (WebCore::MediaList::setMediaText):
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init):
        * html/HTMLDocument.cpp:
        (WebCore::parseDocTypeDeclaration):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::attach):
        (WebCore::HTMLObjectElement::setComplete):
        (WebCore::HTMLObjectElement::detach):
        (WebCore::HTMLObjectElement::recalcStyle):
        (WebCore::HTMLObjectElement::childrenChanged):
        (WebCore::HTMLObjectElement::isImageType):
        * html/HTMLObjectElement.h:
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::value):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::appendFormData):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::setRGBColor):
        * ksvg2/svg/SVGDescElement.cpp:
        (WebCore::SVGDescElement::description):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::stripWhiteSpace):
        (WebCore::String::simplifyWhiteSpace):
        * platform/StringImpl.cpp:
        (WebCore::isSpace):
        (WebCore::parseLength):
        (WebCore::StringImpl::stripWhiteSpace):
        (WebCore::StringImpl::simplifyWhiteSpace):
        (WebCore::StringImpl::toInt):
        * platform/StringImpl.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::cocoaTypeFromMIMEType):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunNormalizeSpace::doEvaluate):
        * xml/XPathGrammar.y:
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodeTestMatches):
        * xml/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::loadChildSheets):
        (WebCore::XSLStyleSheet::locateStylesheetSubResource):
        * xml/XSLTProcessor.cpp:
        (WebCore::xsltParamArrayFromParameterMap):
        (WebCore::XSLTProcessor::setParameter):
        (WebCore::XSLTProcessor::getParameter):
        (WebCore::XSLTProcessor::removeParameter):
        * xml/XSLTProcessor.h:
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::getStatusText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd fieldset layout test.
hyatt [Sun, 17 Sep 2006 15:28:22 +0000 (15:28 +0000)]
Add fieldset layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
hyatt [Sun, 17 Sep 2006 15:27:04 +0000 (15:27 +0000)]
    Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
        are declared right before the fieldsets.  It turns out fieldsets in other
        browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
        adding that behavior to fieldset fixes the bug.

        Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
        and fieldsets all subclass.

        Reviewed by anders

        Added fast/forms/float-before-fieldset.html

        * rendering/RenderFieldset.h:
        (WebCore::RenderFieldset::avoidsFloats):
        * rendering/RenderFlexibleBox.h:
        (WebCore::RenderFlexibleBox::avoidsFloats):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::avoidsFloats):
        * rendering/RenderObject.h:
        * rendering/RenderTable.h:
        (WebCore::RenderTable::avoidsFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16403 268f45cc-cd09-0410-ab3c-d52691b4dbfc