WebKit-https.git
8 years agoLayering Violation in ContextMenu - member variable of type HitTestResult
bweinstein@apple.com [Wed, 8 Dec 2010 19:26:05 +0000 (19:26 +0000)]
Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.

This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.

No change in behavior, no new tests.

* Android.mk: Removed ContextMenu.cpp.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
    of the ContextMenu.
(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
    variable.
(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
    This allowed us to move checkOrEnableIfNeeded from ContextMenu.

These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.

* page/ContextMenuController.h:
(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.

* platform/ContextMenu.cpp: Removed.
* platform/ContextMenu.h:
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
* platform/haiku/ContextMenuHaiku.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/mac/ContextMenuMac.mm:
(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
    the context menu.
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
* platform/wx/ContextMenuWx.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.

WebKit/chromium:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

WebKit/gtk:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):

WebKit/mac:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
(WebContextMenuClient::contextMenuItemSelected):
* WebView/WebHTMLView.mm:
(-[WebMenuTarget validateMenuItem:]):

WebKit/qt:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* Api/qwebpage.cpp:
(QWebPagePrivate::createContextMenu):
(QWebPage::updatePositionDependentActions):

WebKit/win:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
    ContextMenuController (from the page).
(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
* WebView.cpp:
(WebView::handleContextMenuEvent): Ditto.

WebKit2:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when
    the ContextMenuItem is added to the ContextMenu through the ContextMenuController.
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 8 Dec 2010 19:17:18 +0000 (19:17 +0000)]
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by John Sullivan.

        [GTK] Layering violation in ContextMenuGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=50676

        ContextMenuGtk accesses the page's ContextMenuController, which is a layering
        violation. This was fixed for Mac with change r73469. We make a similar fix here
        by moving the "activated" signal connection to the WebKit layer.

        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This
        is a layering violation.
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by John Sullivan.

        [GTK] Layering violation in ContextMenuGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=50676

        ContextMenuGtk accesses the page's ContextMenuController, which is a layering
        violation. This was fixed for Mac with change r73469. We make a similar fix here
        by moving the "activated" signal connection to the WebKit layer.

        * webkit/webkitwebview.cpp:
        (popupMenuItemActivated): Have ContextMenuController handle this signal.
        (webkit_web_view_forward_context_menu_event): For all items in the untouched
        context menu, connect their "activated" signal to the new popupMenuItemActivated
        handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Implement WebChromeClient::exceededDatabaseQuota
jberlin@webkit.org [Wed, 8 Dec 2010 19:06:42 +0000 (19:06 +0000)]
WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656

Reviewed by Adam Roben.

WebCore:

* WebCore.exp.in:
Export the symbol for SecurityOrigin::databaseIdentifier.

WebKit2:

The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
because the new quota is checked directly after exceededDatabaseQuota returns in order to
determine if the new Database can be created.

Pass all of the details from the WebProcess to the UIProcess in order to inform the
decision in the UIProcess about the new quota. In WebKit1, these details were
fetched through an additional call to the API detailsForDatabase (which is infeasible in
WebKit2 since exceededDatabaseQuota is a synchronous call).

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a version that takes 7 parameters.

* UIProcess/API/C/WKPage.h:

* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
Indicate that exceededDatabaseQuota is not implemented.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
Call the UIClient's exceededDatabaseQuota
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::exceededDatabaseQuota):
If the client does not implement exceededDatabaseQuota, return a the current quota.
* UIProcess/WebUIClient.h:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
given frame.

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
Indicate that exceededDatabaseQuota is not implemented.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
Ditto.
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
Ditto.
(WTR::TestController::initialize):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Csaba Osztrogon√°c <ossy@webkit.org>
ossy@webkit.org [Wed, 8 Dec 2010 19:02:23 +0000 (19:02 +0000)]
2010-12-08  Csaba Osztrogon√°c  <ossy@webkit.org>

        Unreviewed, rolling out r73521.
        http://trac.webkit.org/changeset/73521
        https://bugs.webkit.org/show_bug.cgi?id=50640

        It broke 90 layout tests

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::printErrorMessageForFrame):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=50576
hyatt@apple.com [Wed, 8 Dec 2010 18:31:33 +0000 (18:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline.  This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.

Added three new tests in fast/block/positioning.

WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

* fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
* fast/block/positioning/rtl-static-positioning.html: Added.
* fast/block/positioning/table-cell-static-position.html: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 8 Dec 2010 18:14:11 +0000 (18:14 +0000)]
2010-12-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix backward mouse wheeling not working when scroll position is below 0.
        https://bugs.webkit.org/show_bug.cgi?id=50370

        Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
               fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
2010-12-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix backward mouse wheeling not working when scroll position is below 0.
        https://bugs.webkit.org/show_bug.cgi?id=50370

        * fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * fast/dom/horizontal-scrollbar-in-rtl.html:
        * fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * fast/dom/vertical-scrollbar-in-rtl.html:
        * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
        * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
        * fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
        * fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
        * platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
        * platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
        * platform/gtk/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * platform/win/Skipped:
        * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, cleaning up test expectations after r7349.
antonm@chromium.org [Wed, 8 Dec 2010 18:01:13 +0000 (18:01 +0000)]
Unreviewed, cleaning up test expectations after r7349.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Wed, 8 Dec 2010 17:47:49 +0000 (17:47 +0000)]
2010-12-08  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        [Gtk] Populate DumpRenderTreeSupportGtk (part III)
        https://bugs.webkit.org/show_bug.cgi?id=48429

        WebKit/gtk:

        Adjusted some call sites of previously internal API declared
        webkitprivate.h that have moved to DumpRenderTreeSupportGtk.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects):
        (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread):
        (DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
        (DumpRenderTreeSupportGtk::layoutFrame):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:

        WebKitTools:

        Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
        * webkit_gc_collect_javascript_objects;
        * webkit_gc_collect_javascript_objects_on_alternate_thread;
        * webkit_gc_count_javascript_objects;
        * webkit_web_frame_layout.

        These were all only used by GTK+ DRT.

        * DumpRenderTree/gtk/EventSender.cpp:
        (dispatchEvent):
        * DumpRenderTree/gtk/GCControllerGtk.cpp:
        (GCController::collect):
        (GCController::collectOnAlternateThread):
        (GCController::getJSObjectCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 8 Dec 2010 17:37:32 +0000 (17:37 +0000)]
2010-12-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix pauseAnimation API to work with shorthand properties
        https://bugs.webkit.org/show_bug.cgi?id=50639

        The pause API is always called with a long-hand property, but that
        property may be animating via a shorthand. Detect this, and pause
        such shorthand animations.

        * page/animation/AnimationBase.cpp:
        (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector
        of wrappers used by a shorthand wrapper.

        (WebCore::gatherEnclosingShorthandProperties): Utility function that walks
        through the shorthand wrappers, keeping track of which can affect the given
        property.
        (WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
        of shorthand properties that can affect the given property.

        * page/animation/AnimationBase.h: New method.
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the
        property itself, check whether it's being animated via shorthands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885
hyatt@apple.com [Wed, 8 Dec 2010 16:55:08 +0000 (16:55 +0000)]
<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885

Reviewed by Beth Dakin.

Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.

* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 16:54:10 +0000 (16:54 +0000)]
2010-12-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
        for TimelineAgent functions.

        https://bugs.webkit.org/show_bug.cgi?id=50690

        * inspector/Inspector.idl:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted):
        (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 16:49:34 +0000 (16:49 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        Avoid emiting durationchanged in the case where the previous
        duration was 0 because that case is already handled by the
        HTMLMediaElement.

        Test: media/media-fullscreen*.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::durationChanged):

LayoutTests:

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        * platform/gtk/Skipped: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 16:22:18 +0000 (16:22 +0000)]
2010-12-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Remove WIN prefix for inspector's tests expectations.
        DumpRenderTree related patch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 8 Dec 2010 16:22:13 +0000 (16:22 +0000)]
2010-12-07  Darin Adler  <darin@apple.com>

        Reviewed by Geoffrey Garen.

        Move DOMWindow::setLocation logic into DOMWindow class and out of JavaScript binding
        https://bugs.webkit.org/show_bug.cgi?id=50640

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::printErrorMessageForFrame): Removed body; just call through to
        DOMWindow::printErrorMessage.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): Removed body;
        just call through to DOMWindow::crossDomainAccessErrorMessage.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation): Changed terminology to use activeFrame and
        firstFrame, rather than the older lexicalFrame and dynamicFrame. Removed most
        of the body and moved it into DOMWindow::setLocation.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setLocation): Added. Does all the same work that
        JSDOMWindow::setLocation used to do, but in a way that's not specific
        to JavaScript.
        (WebCore::DOMWindow::printErrorMessage): Added.
        (WebCore::DOMWindow::crossDomainAccessErrorMessage): Added.

        * page/DOMWindow.h: Added setLocation, printErrorMessage, and
        crossDomainAccessErrorMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip svg/custom/clip-path-referencing-use.svg on Windows
aroben@apple.com [Wed, 8 Dec 2010 16:07:08 +0000 (16:07 +0000)]
Skip svg/custom/clip-path-referencing-use.svg on Windows

The test fails when run under Aero. It seems that one of our Windows 7
bots has this turned on while the other doesn't.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 8 Dec 2010 16:02:20 +0000 (16:02 +0000)]
2010-12-08  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, rolling out r73494.
        http://trac.webkit.org/changeset/73494
        https://bugs.webkit.org/show_bug.cgi?id=50380

        The tests added are crashing in the debug bots (macn and gtk)

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::deselectItems):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::setSelectedIndexByUser):
        (WebCore::HTMLSelectElement::listBoxSelectItem):
        (WebCore::HTMLSelectElement::add):
        (WebCore::HTMLSelectElement::remove):
        (WebCore::HTMLSelectElement::restoreFormControlState):
        (WebCore::HTMLSelectElement::parseMappedAttribute):
        (WebCore::HTMLSelectElement::selectAll):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::updateListBoxSelection):
        (WebCore::HTMLSelectElement::setLength):
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::isOptionalFormControl):
        * html/HTMLSelectElement.idl:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::valueMissing):

2010-12-08  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, rolling out r73494.
        http://trac.webkit.org/changeset/73494
        https://bugs.webkit.org/show_bug.cgi?id=50380

        The tests added are crashing in the debug bots (macn and gtk)

        * fast/forms/ValidityState-valueMissing-001-expected.txt:
        * fast/forms/ValidityState-valueMissing-001.html:
        * fast/forms/ValidityState-valueMissing-002-expected.txt:
        * fast/forms/ValidityState-valueMissing-002.html:
        * fast/forms/ValidityState-valueMissing-003-expected.txt:
        * fast/forms/ValidityState-valueMissing-003.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
        * fast/forms/required-attribute-001-expected.txt:
        * fast/forms/required-attribute-001.html:
        * fast/forms/required-attribute-002-expected.txt:
        * fast/forms/required-attribute-002.html:
        * fast/forms/resources/select-live-pseudo-selectors.js: Removed.
        * fast/forms/script-tests/validationMessage.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt: Removed.
        * fast/forms/select-live-pseudo-selectors.html: Removed.
        * fast/forms/validationMessage-expected.txt:
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Removed.
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 15:34:31 +0000 (15:34 +0000)]
2010-12-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Just enable inspector's tests for chromium linux.
        This change is related to switching to DumpRenderTree.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLand Windows results for test added in 73423
aroben@apple.com [Wed, 8 Dec 2010 15:29:35 +0000 (15:29 +0000)]
Land Windows results for test added in 73423

* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate Windows results after r73488
aroben@apple.com [Wed, 8 Dec 2010 15:28:58 +0000 (15:28 +0000)]
Update Windows results after r73488

* platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 15:25:31 +0000 (15:25 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skipping failing test.

        [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
        https://bugs.webkit.org/show_bug.cgi?id=50687

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 8 Dec 2010 14:24:57 +0000 (14:24 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations. Remove some tests that are now consistently
        passing, assign bug numbers, and add one new expectation.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 14:17:38 +0000 (14:17 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskipping media/video-buffered.html on GTK because
        the bots are now running with latest GStreamer.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 13:52:26 +0000 (13:52 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskipped some more media tests.

        They are not crashing anymore, they also needed a rebaseline since
        the font tiling changes that happened while they were skipped.

        * platform/gtk/Skipped:
        * platform/gtk/media/controls-styling-expected.txt:
        * platform/gtk/media/video-layer-crash-expected.txt:
        * platform/gtk/media/video-transformed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 13:27:55 +0000 (13:27 +0000)]
2010-12-07  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector protocol cleanup task. Remove
        WebInspector wrappers for DOMAgent functions.

        There were a lot of wrappers in WebInspector namespace
        for different WebInspector agents functions. As far as we have a
        generic mechanic for such functions we can remove these
        wrappers and register domAgent instance as a handler for
        DOM domain notifications.

        https://bugs.webkit.org/show_bug.cgi?id=50626

        * inspector/Inspector.idl:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        (WebInspector.DOMAgent):
        (WebInspector.DOMAgent.prototype.attributesUpdated):
        (WebInspector.DOMAgent.prototype.characterDataModified):
        (WebInspector.DOMAgent.prototype.setDocument):
        (WebInspector.DOMAgent.prototype.setDetachedRoot):
        (WebInspector.DOMAgent.prototype.setChildNodes):
        (WebInspector.DOMAgent.prototype.childNodeCountUpdated):
        (WebInspector.DOMAgent.prototype.childNodeInserted):
        (WebInspector.DOMAgent.prototype.childNodeRemoved):
        (WebInspector.EventListeners.getEventListenersForNodeAsync):
        * inspector/front-end/inspector.js:
        (WebInspector.didCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 8 Dec 2010 12:52:22 +0000 (12:52 +0000)]
2010-12-08  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update test expectations after r73504.

        * http/tests/inspector/console-resource-errors-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 8 Dec 2010 12:31:08 +0000 (12:31 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations. Add two test flakinesses which was
        introduced at r73504.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 8 Dec 2010 12:14:57 +0000 (12:14 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations. Added a few failures which was found
        in Chromium main waterfall.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 8 Dec 2010 12:12:05 +0000 (12:12 +0000)]
2010-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        The storage for the subresources is a GHashTable which does not
        guarantee order, so we need to make our checking more resilient.

        * tests/testwebresource.c:
        (test_web_resource_sub_resource_loading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 8 Dec 2010 11:52:18 +0000 (11:52 +0000)]
2010-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        [GTK] Fails back to POST tests
        https://bugs.webkit.org/show_bug.cgi?id=50678

        Skip new tests that we are failing.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 8 Dec 2010 11:42:53 +0000 (11:42 +0000)]
2010-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Fix name of the Korean translation file.

        * kr.po -> ko.po: renamed to correct name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 8 Dec 2010 11:28:55 +0000 (11:28 +0000)]
2010-12-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove groupLevel counter from console messages
        https://bugs.webkit.org/show_bug.cgi?id=50672

        * inspector/console-tests-expected.txt:
2010-12-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove groupLevel counter from console messages
        https://bugs.webkit.org/show_bug.cgi?id=50672

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::startGroup):
        (WebCore::InspectorController::endGroup):
        * inspector/InspectorController.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.createFilterElement):
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype.filter):
        (WebInspector.ConsoleView.prototype.afterShow):
        (WebInspector.ConsoleView.prototype.addMessage):
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
        (WebInspector.ConsoleView.prototype.clearMessages):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.createTextMessage):
        (WebInspector.ConsoleMessage.prototype.toMessageElement):
        (WebInspector.ConsoleMessage.prototype._addMessageHeader):
        (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
        (WebInspector.ConsoleMessage.prototype.toString):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        (WebInspector.ConsoleGroup):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._checkWarning):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._addMessageToSource):
        * inspector/front-end/inspector.js:
        (WebInspector.addConsoleMessage):
        (WebInspector.log.logMessage):
        (WebInspector.log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add new tests introduced in r73484 to the Skipped list,
ossy@webkit.org [Wed, 8 Dec 2010 11:23:34 +0000 (11:23 +0000)]
Unreviewed. Add new tests introduced in r73484 to the Skipped list,
because layoutTestController.testRepaint() is unimplemented in Qt DRT.

* platform/qt/Skipped:
 - fast/repaint/table-writing-modes-h.html added
 - fast/repaint/table-writing-modes-v.html added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update Qt specific expected results after r73488.
ossy@webkit.org [Wed, 8 Dec 2010 11:17:50 +0000 (11:17 +0000)]
Unreviewed. Update Qt specific expected results after r73488.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum:
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
* platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Dec 2010 11:17:43 +0000 (11:17 +0000)]
2010-12-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce DebuggerModel class representing InspectorDebuggerAgent state.
        https://bugs.webkit.org/show_bug.cgi?id=50567

        Moved debugging-related code from BreakpointManager to DebuggerModel. Moved Breakpoint class to a separate file.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/Breakpoint.js: Added.
        (WebInspector.Breakpoint): Moved from BreakpointManager.js.
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager): Remove debugger-related methods.
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
        (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit):
        * inspector/front-end/DebuggerModel.js: Added.
        (WebInspector.DebuggerModel): Moved debugger-related methods from BreakpointManager.
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.continueToLine):
        (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._debuggerResumed):
        (WebInspector.ScriptsPanel.prototype.reset):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
        (WebInspector.SourceFrameDelegate.prototype.addBreakpoint):
        (WebInspector.SourceFrameDelegate.prototype.breakpoints):
        (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.createJSBreakpointsSidebarPane):
        (WebInspector.restoredBreakpoint):
        (WebInspector.pausedScript):
        (WebInspector.resumedScript):
        (WebInspector.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 11:07:36 +0000 (11:07 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, updated baselines of
        media/video-controls-rendering.html.

        * platform/gtk/media/video-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 8 Dec 2010 10:44:20 +0000 (10:44 +0000)]
2010-12-08  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: SourceFrame refactoring.
        https://bugs.webkit.org/show_bug.cgi?id=50223

        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-pause-on-breakpoint.html:
2010-12-08  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: SourceFrame refactoring.
        https://bugs.webkit.org/show_bug.cgi?id=50223

        SourceFrame should ask BreakpointManager about existing breakpoints instead of maintaining
        it's own storages. Move common code from ScriptView and SourceView to SourceFrame.

        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.findBreakpoints):
        (WebInspector.BreakpointManager.prototype.findBreakpoint):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        (WebInspector.Script.prototype.get linesCount):
        (WebInspector.Script.prototype.get source):
        (WebInspector.Script.prototype.set source):
        * inspector/front-end/ScriptView.js:
        (WebInspector.ScriptView):
        (WebInspector.ScriptView.prototype._scriptSourceChanged):
        (WebInspector.ScriptFrameDelegateImpl):
        (WebInspector.ScriptFrameDelegateImpl.prototype.canEditScripts):
        (WebInspector.ScriptFrameDelegateImpl.prototype.editLineComplete):
        (WebInspector.ScriptFrameDelegateImpl.prototype.scripts):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame): Add common methods of ScriptView and SourceView.
        (WebInspector.SourceFrameDelegate):
        (WebInspector.SourceFrameDelegate.prototype.canEditScripts):
        (WebInspector.SourceFrameDelegate.prototype.editLineComplete):
        (WebInspector.SourceFrameDelegate.prototype.scripts):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype._contentLoaded):
        (WebInspector.ResourceFrameDelegateImpl):
        (WebInspector.ResourceFrameDelegateImpl.prototype.canEditScripts):
        (WebInspector.ResourceFrameDelegateImpl.prototype.editLineComplete):
        (WebInspector.ResourceFrameDelegateImpl.prototype.scripts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 10:25:25 +0000 (10:25 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskipping media/video-controls-rendering.html on GTK.

        It should now not crash anymore because the GTK bots have been
        upgraded to latest GStreamer releases.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 8 Dec 2010 10:22:44 +0000 (10:22 +0000)]
2010-12-08  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Fix assertion in the API test, we are requesting the favicon and
        the subresource so we have to make sure we are assigning just the
        first subresource.

        * tests/testwebresource.c:
        (resource_request_starting_sub_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 8 Dec 2010 09:35:04 +0000 (09:35 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, rolling out r73492.
        http://trac.webkit.org/changeset/73492
        https://bugs.webkit.org/show_bug.cgi?id=49914

        Caused a lot of pixel test failures and broke Windows build.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::createGraphicsContextPrivate):
        (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
        (WebCore::GraphicsContext::save):
        (WebCore::GraphicsContext::restore):
        (WebCore::GraphicsContext::setStrokeThickness):
        (WebCore::GraphicsContext::setStrokeStyle):
        (WebCore::GraphicsContext::setStrokeColor):
        (WebCore::GraphicsContext::setShadow):
        (WebCore::GraphicsContext::clearShadow):
        (WebCore::GraphicsContext::getShadow):
        (WebCore::GraphicsContext::strokeThickness):
        (WebCore::GraphicsContext::strokeStyle):
        (WebCore::GraphicsContext::strokeColor):
        (WebCore::GraphicsContext::strokeColorSpace):
        (WebCore::GraphicsContext::fillRule):
        (WebCore::GraphicsContext::setFillRule):
        (WebCore::GraphicsContext::setFillColor):
        (WebCore::GraphicsContext::fillColor):
        (WebCore::GraphicsContext::fillColorSpace):
        (WebCore::GraphicsContext::setShouldAntialias):
        (WebCore::GraphicsContext::shouldAntialias):
        (WebCore::GraphicsContext::setStrokePattern):
        (WebCore::GraphicsContext::setFillPattern):
        (WebCore::GraphicsContext::setStrokeGradient):
        (WebCore::GraphicsContext::setFillGradient):
        (WebCore::GraphicsContext::fillGradient):
        (WebCore::GraphicsContext::strokeGradient):
        (WebCore::GraphicsContext::fillPattern):
        (WebCore::GraphicsContext::strokePattern):
        (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
        (WebCore::GraphicsContext::updatingControlTints):
        (WebCore::GraphicsContext::setUpdatingControlTints):
        (WebCore::GraphicsContext::setPaintingDisabled):
        (WebCore::GraphicsContext::paintingDisabled):
        (WebCore::GraphicsContext::textDrawingMode):
        (WebCore::GraphicsContext::setTextDrawingMode):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h: Added.
        (WebCore::GraphicsContextState::GraphicsContextState):
        (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::setPlatformFill):
        (WebCore::setPlatformStroke):
        (WebCore::drawPathShadow):
        (WebCore::fillCurrentCairoPath):
        (WebCore::strokeCurrentCairoPath):
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::setAlpha):
        (WebCore::GraphicsContext::getAlpha):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::applyStrokePattern):
        (WebCore::GraphicsContext::applyFillPattern):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::strokeRect):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 8 Dec 2010 08:43:36 +0000 (08:43 +0000)]
2010-12-08  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Added tests for require attributes, valueMissing and vadility check for select elements.

        * fast/forms/ValidityState-valueMissing-001-expected.txt:
        * fast/forms/ValidityState-valueMissing-001.html:
        * fast/forms/ValidityState-valueMissing-002-expected.txt:
        * fast/forms/ValidityState-valueMissing-002.html:
        * fast/forms/ValidityState-valueMissing-003-expected.txt:
        * fast/forms/ValidityState-valueMissing-003.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
        * fast/forms/required-attribute-001-expected.txt:
        * fast/forms/required-attribute-001.html:
        * fast/forms/required-attribute-002-expected.txt:
        * fast/forms/required-attribute-002.html:
        * fast/forms/resources/select-live-pseudo-selectors.js: Added.
        (makeInvalid):
        (appendOption):
        (backgroundOf):
        * fast/forms/script-tests/validationMessage.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
        * fast/forms/select-live-pseudo-selectors.html: Added.
        * fast/forms/validationMessage-expected.txt:
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
2010-12-08  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Test: fast/forms/select-live-pseudo-selectors.html
              platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
        (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
        (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
        (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
        (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
        (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
        * html/HTMLSelectElement.idl: Added a required attribute to select elements..
        * html/ValidityState.cpp:
        (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 8 Dec 2010 08:08:00 +0000 (08:08 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-08 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Wed, 8 Dec 2010 08:05:17 +0000 (08:05 +0000)]
2010-12-08  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        GraphicsContext: Merge m_common and m_data
        https://bugs.webkit.org/show_bug.cgi?id=49914

        Move data members from GraphicsContextPrivate into GraphicsContext. So GraphicsContextPlatform.h
        and m_common became unnecessary. They are removed.
        Add two methods to GraphicsContext: platformInit() and platformDestroy(), which
        make the constructor of GraphicsContext clearer.
        Besides add a getter to the private GraphicsContext::m_state member, because some inline
        functions in cairo need it.

        No new test is needed, because this is a refactoring.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::~GraphicsContext):
        (WebCore::GraphicsContext::save):
        (WebCore::GraphicsContext::restore):
        (WebCore::GraphicsContext::setStrokeThickness):
        (WebCore::GraphicsContext::setStrokeStyle):
        (WebCore::GraphicsContext::setStrokeColor):
        (WebCore::GraphicsContext::setShadow):
        (WebCore::GraphicsContext::clearShadow):
        (WebCore::GraphicsContext::getShadow):
        (WebCore::GraphicsContext::strokeThickness):
        (WebCore::GraphicsContext::strokeStyle):
        (WebCore::GraphicsContext::strokeColor):
        (WebCore::GraphicsContext::strokeColorSpace):
        (WebCore::GraphicsContext::fillRule):
        (WebCore::GraphicsContext::setFillRule):
        (WebCore::GraphicsContext::setFillColor):
        (WebCore::GraphicsContext::fillColor):
        (WebCore::GraphicsContext::fillColorSpace):
        (WebCore::GraphicsContext::setShouldAntialias):
        (WebCore::GraphicsContext::shouldAntialias):
        (WebCore::GraphicsContext::state):
        (WebCore::GraphicsContext::setStrokePattern):
        (WebCore::GraphicsContext::setFillPattern):
        (WebCore::GraphicsContext::setStrokeGradient):
        (WebCore::GraphicsContext::setFillGradient):
        (WebCore::GraphicsContext::fillGradient):
        (WebCore::GraphicsContext::strokeGradient):
        (WebCore::GraphicsContext::fillPattern):
        (WebCore::GraphicsContext::strokePattern):
        (WebCore::GraphicsContext::setShadowsIgnoreTransforms):
        (WebCore::GraphicsContext::updatingControlTints):
        (WebCore::GraphicsContext::setUpdatingControlTints):
        (WebCore::GraphicsContext::setPaintingDisabled):
        (WebCore::GraphicsContext::paintingDisabled):
        (WebCore::GraphicsContext::textDrawingMode):
        (WebCore::GraphicsContext::setTextDrawingMode):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * platform/graphics/GraphicsContextPrivate.h: Removed.
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::setPlatformFill):
        (WebCore::setPlatformStroke):
        (WebCore::drawPathShadow):
        (WebCore::fillCurrentCairoPath):
        (WebCore::strokeCurrentCairoPath):
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::setAlpha):
        (WebCore::GraphicsContext::getAlpha):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::applyStrokePattern):
        (WebCore::GraphicsContext::applyFillPattern):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::strokeRect):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clip):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        (WebCore::GraphicsContext::platformInit):
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::platformInit):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::platformInit):
        (WebCore::GraphicsContext::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 8 Dec 2010 06:45:55 +0000 (06:45 +0000)]
2010-12-07  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        Port http://trac.webkit.org/changeset/72819/ to v8-backed ports.
        https://bugs.webkit.org/show_bug.cgi?id=50246

        * bindings/v8/V8DOMMap.h:
        (WebCore::AbstractWeakReferenceMap::Visitor::startMap):
        (WebCore::AbstractWeakReferenceMap::Visitor::endMap):
        (WebCore::WeakReferenceMap::visit):
        * bindings/v8/V8GCController.cpp:
        (WebCore::GrouperItem::GrouperItem):
        (WebCore::GrouperItem::groupId):
        (WebCore::makeV8ObjectGroups):
        (WebCore::NodeGrouperVisitor::NodeGrouperVisitor):
        (WebCore::NodeGrouperVisitor::visitDOMWrapper):
        (WebCore::NodeGrouperVisitor::applyGrouping):
        (WebCore::DOMObjectGrouperVisitor::ObjectGrouperVisitor):
        (WebCore::DOMObjectGrouperVisitor::startMap):
        (WebCore::DOMObjectGrouperVisitor::endMap):
        (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
        (WebCore::V8GCController::gcPrologue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 8 Dec 2010 04:49:57 +0000 (04:49 +0000)]
2010-12-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Implement focus ring support for image maps
        https://bugs.webkit.org/show_bug.cgi?id=50371

        Implement GraphicsContext::drawFocusRing(const Path&, ...) so as to support
        drawing a focus ring for image maps.

        Tests: fast/images/imagemap-circle-focus-ring.html
               fast/images/imagemap-polygon-focus-ring.html

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::adjustFocusRingColor): Added.
        (WebCore::adjustFocusRingLineWidth): Added.
        (WebCore::focusRingStrokeStyle): Added.
        (WebCore::GraphicsContext::drawFocusRing): Moved code for determining focus ring- color,
        line width and stroke style into functions adjustFocusRingColor(), adjustFocusRingLineWidth(),
        and focusRingStrokeStyle(), respectively. Implemented GraphicsContext::drawFocusRing(const Path&, ...).
2010-12-07  Daniel Bates  <dbates@rim.com>

        Reviewed by Martin Robinson.

        Implement focus ring support for image maps
        https://bugs.webkit.org/show_bug.cgi?id=50371

        Tests to ensure that we support drawing a focus ring for an image map.
        In particular, that the GTK port can draw a focus ring for an image map.

        * fast/images/imagemap-circle-focus-ring.html: Added.
        * fast/images/imagemap-polygon-focus-ring.html: Added.
        * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.png: Added.
        * platform/gtk/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Rebase result since we
        now support drawing a focus ring for imagemaps.
        * platform/gtk/fast/images/imagemap-focus-ring-expected.png: Ditto.
        * platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
        * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
        * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
        * platform/gtk/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.
        * platform/mac/fast/images/imagemap-circle-focus-ring-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-circle-focus-ring-expected.png: Added.
        * platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt: Added.
        * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.png: Added.
        * platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Sergio Villar Senin <svillar@igalia.com>
commit-queue@webkit.org [Wed, 8 Dec 2010 04:33:10 +0000 (04:33 +0000)]
2010-12-07  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] WebKitSoupCache fails to load resources when cache contents are externally removed
        https://bugs.webkit.org/show_bug.cgi?id=50577

        Try to download cached resources again if they are no longer
        accesible by the cache.

        * platform/network/soup/cache/soup-request-http.c:
        (send_async_cb):
        (webkit_soup_request_http_send_async):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-05 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 8 Dec 2010 04:21:20 +0000 (04:21 +0000)]
2010-12-05  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        - Added a test case
        - Updated expectations to follow the change on the shadow structure.

        RenderIndicator subclasses should not change the render tree during layout.
        https://bugs.webkit.org/show_bug.cgi?id=50026

        * fast/dom/HTMLMeterElement/meter-element-crash-expected.txt: Added.
        * fast/dom/HTMLMeterElement/meter-element-crash.html: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2010-12-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        RenderIndicator subclasses should not change the render tree during layout.
        https://bugs.webkit.org/show_bug.cgi?id=50026

        The old code created shadow elements during a layout computation,
        that makes the layout state inconsisntent and cause an assertion failure.
        This change created shadow elements before the layout to avoid
        state inconsistencies.

        Instead of creating shadows on demand, RenderMeter and
        RenderProgress now create all necessary shadows before layouts,
        and change its visibilities during the layout: Changing
        visibilities doesn't trigger relayout and keep the state
        consistent.

        RenderMeter uses new HidablePartElement for shadow elements,
        which can toggle visibiliby between hidden and original value.

        Test: fast/dom/HTMLMeterElement/meter-element-crash.html

        * html/HTMLMeterElement.cpp:
        (WebCore::HTMLMeterElement::attach): Calling updateFromElement()
        * html/HTMLMeterElement.h:
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::attach): Calling updateFromElement()
        * html/HTMLProgressElement.h:
        * rendering/RenderIndicator.cpp:
        * rendering/RenderIndicator.h:
        * rendering/RenderMeter.cpp:
        (WebCore::MeterPartElement::MeterPartElement): Added to hold a restorable visibility.
        (WebCore::MeterPartElement::createForPart):
        (WebCore::MeterPartElement::hide):
        (WebCore::MeterPartElement::restoreVisibility):
        (WebCore::MeterPartElement::updateStyleForPart):
        (WebCore::MeterPartElement::saveVisibility):
        (WebCore::RenderMeter::~RenderMeter):
        (WebCore::RenderMeter::createPart): Extracted
        (WebCore::RenderMeter::updateFromElement): Had a shadow generation.
        (WebCore::RenderMeter::layoutParts): Removed shadow generation code.
        (WebCore::RenderMeter::shouldHaveParts):
        (WebCore::RenderMeter::valuePartRect): Adopted orientation.
        (WebCore::RenderMeter::orientation): Morphed from isHorizontal()
        (WebCore::RenderMeter::valuePseudoId): Adoptedn orientation
        (WebCore::RenderMeter::barPseudoId): Adopted orientation.
        * rendering/RenderMeter.h:
        (WebCore::RenderMeter::shadowAttached):
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::updateFromElement): Had a shadow generation.
        (WebCore::RenderProgress::layoutParts):
        * rendering/RenderProgress.h:
        * rendering/ShadowElement.cpp:
        (WebCore::ShadowBlockElement::createForPart): Extracted initAsPart().
        (WebCore::ShadowBlockElement::initAsPart): Extracted from createForPart().
        * rendering/ShadowElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 8 Dec 2010 02:44:11 +0000 (02:44 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Relax the matching tolerance to reduce flakiness.

        * transitions/border-radius-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-11-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 8 Dec 2010 02:32:41 +0000 (02:32 +0000)]
2010-11-29  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        returning to a POST result within a frame does a GET instead of a POST
        https://bugs.webkit.org/show_bug.cgi?id=10199

        Re-enable postredirect-frames-goback1.html and post-frames-goback1.html
        now that the big that made them be checked in disabled was fixed.

        The tests were also re-written to not be pixel tests, since that just
        adds extra per-platform baseline pain.

        Add fast/history/history-back-initial-vs-final-url.html since there did
        not appear to be any tests for whether we used the initial or final URL
        of a frame's history item (and this patch changes it from the former to
        the latter).

        * fast/history/history-back-initial-vs-final-url-expected.txt: Added.
        * fast/history/history-back-initial-vs-final-url.html: Added.
        * fast/history/resources/frame-final-url.html: Added.
        * fast/history/resources/frame-initial-url.html: Added.
        * http/tests/navigation/post-frames-goback1-expected.txt: Added.
        * http/tests/navigation/post-frames-goback1.html: Added.
        * http/tests/navigation/post-frames-goback1.html-disabled: Removed.
        * http/tests/navigation/post-frames.html:
        * http/tests/navigation/postredirect-frames-goback1-expected.txt: Added.
        * http/tests/navigation/postredirect-frames-goback1.html: Added.
        * http/tests/navigation/postredirect-frames-goback1.html-disabled: Removed.
        * http/tests/navigation/resources/form-target.pl:
        * http/tests/navigation/resources/redirect-to-go-back.pl: Added.
        * http/tests/navigation/resources/top-go-back.html: Added.
2010-11-29  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        returning to a POST result within a frame does a GET instead of a POST
        https://bugs.webkit.org/show_bug.cgi?id=10199

        FrameLoader::loadURLIntoChildFrame had a check for whether a frame
        had a HistoryItem, and if so used that item's URL. However, that did
        not handle the case where the HistoryItem had FormData and thus was the
        result of a POST request. FrameLoader::navigateToDifferentDocument (now
        renamed to loadDifferentDocumentItem) does all that, so just switch to
        using it instead.

        Besides the bug fix, the only difference in behavior is that we use the
        HistoryItem's URL instead of original URL when restoring it in a child
        frame. This seems desirable too (for consistency with other browsers, and
        so that we can avoid form double-submits for forms that that do
        POST-then-redirect), and is tested by
        fast/history/history-back-initial-vs-final-url.html.

        Tests: fast/history/history-back-initial-vs-final-url.html
               http/tests/navigation/post-frames-goback1.html
               http/tests/navigation/postredirect-frames-goback1.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadURLIntoChildFrame): Switch to using
            loadDifferentDocumentItem. Also cleaned up ordering slightly (if
            on the archive path, there's no need to do any of the other checks).
        (WebCore::FrameLoader::loadDifferentDocumentItem): Renamed from
            navigateToDifferentDocument so that calling it from loadItem and
            loadURLIntoChildFrame flows more easily.
        (WebCore::FrameLoader::loadSameDocumentItem): Similarly, renamed from
            navigateWithinDocument.
        (WebCore::FrameLoader::loadItem): Update callsites to the above methods.
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out r73477 and r73483 since they broke the Mac SnowLeopard build.
mrowe@apple.com [Wed, 8 Dec 2010 02:27:41 +0000 (02:27 +0000)]
Roll out r73477 and r73483 since they broke the Mac SnowLeopard build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore: Made tables repaint correctly in all writing modes
mitz@apple.com [Wed, 8 Dec 2010 01:37:57 +0000 (01:37 +0000)]
WebCore: Made tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

Tests: fast/repaint/table-writing-modes-h.html
       fast/repaint/table-writing-modes-v.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject): Compute the ranges of rows and
columns to repaint based on the logical extent of the repaint rect.

LayoutTests: Test that tables repaint correctly in all writing modes
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Darin Adler.

* fast/repaint/table-writing-modes-h-expected.checksum: Added.
* fast/repaint/table-writing-modes-h-expected.png: Added.
* fast/repaint/table-writing-modes-h-expected.txt: Added.
* fast/repaint/table-writing-modes-h.html: Added.
* fast/repaint/table-writing-modes-v-expected.checksum: Added.
* fast/repaint/table-writing-modes-v-expected.png: Added.
* fast/repaint/table-writing-modes-v-expected.txt: Added.
* fast/repaint/table-writing-modes-v.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 8 Dec 2010 01:17:49 +0000 (01:17 +0000)]
2010-12-07  Chris Marrin  <cmarrin@apple.com>

        Unreviewed.

        Fix build problem from http://trac.webkit.org/changeset/73477

        * platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Alexey Marinichev <amarinichev@chromium.org>
jamesr@google.com [Wed, 8 Dec 2010 00:53:12 +0000 (00:53 +0000)]
2010-12-07  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by James Robinson.

        [chromium] compositor lost context recovery fix
        https://bugs.webkit.org/show_bug.cgi?id=50614

        To test, load a page that triggers the compositor, kill the GPU
        process and hover over a link to redraw and thus restart the GPU
        process.  Without this patch it will assert in
        ContentLayerChromium::updateTextureRect; with this patch it will not.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::setNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 8 Dec 2010 00:41:13 +0000 (00:41 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, mark a test as flaky on chromium drt linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 8 Dec 2010 00:31:41 +0000 (00:31 +0000)]
2010-12-07  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
        https://bugs.webkit.org/show_bug.cgi?id=49388

        Added copy constructors and casting operators to go between
        TransformationMatrix and CATransform3D. Also added a copy
        constructor to go from CGAffineTransform to TransformationMatrix.
        Used these new methods to clean up platform CA code. This will
        make it easier to port to Windows.

        I also fixed a couple of build issues found when trying out a
        Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 8 Dec 2010 00:31:10 +0000 (00:31 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, adding chromium pixel results for
        fast/forms/caret-rtl.html after http://trac.webkit.org/changeset/73459

        * platform/chromium-linux/fast/forms/caret-rtl-expected.checksum:
        * platform/chromium-linux/fast/forms/caret-rtl-expected.png:
        * platform/chromium-mac/fast/forms/caret-rtl-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/caret-rtl-expected.png: Added.
        * platform/chromium-win/fast/forms/caret-rtl-expected.checksum:
        * platform/chromium-win/fast/forms/caret-rtl-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the last clang++ build error.
andersca@apple.com [Wed, 8 Dec 2010 00:26:21 +0000 (00:26 +0000)]
Fix the last clang++ build error.

* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::animationForKey):
Cast the returned animation to the correct type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some clang++ build errors.
andersca@apple.com [Tue, 7 Dec 2010 23:55:16 +0000 (23:55 +0000)]
Fix some clang++ build errors.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Remove unused variable.

* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
Fix constness of pointers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Dec 2010 23:37:32 +0000 (23:37 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Fix the Color -> CGColorRef conversions for the debug colors
        used for compositing layers.

        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (PlatformCALayer::setBackgroundColor):
        (PlatformCALayer::setBorderColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Dec 2010 23:31:29 +0000 (23:31 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, remove more passing tests (mac) from test_expecatations.txt
        after DRT switch.  Also remove a test that is passing because of
        crankshaft.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Dec 2010 23:13:43 +0000 (23:13 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, remove more passing tests (win) from test_expectations.txt
        after DRT switch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPart of Layering Violation in ContextMenu
bweinstein@apple.com [Tue, 7 Dec 2010 22:47:37 +0000 (22:47 +0000)]
Part of Layering Violation in ContextMenu
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible for wrapping
a ContextMenuItem, and calling through to the ContextMenuController to validate it
and call a function when it was selected.

It was a layering violation to have this class here, because ContextMenu can't know
about ContextMenuController.

This patch moves the class that wraps the ContextMenuItems to WebKit/mac/WebHTMLView.mm,
and sets up the menu targets there.

No change in behavior, no new tests.

* WebCore.exp.in: Added function that needs to be exported.
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anymore.
(WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this is done in WebKit now).
(WebCore::ContextMenu::insertItem): Ditto.

WebKit/mac:

Move WebMenuTarget from ContextMenuMac to here, because having it in ContextMenuMac
was a layering violation. Also, make sure we set the menu item targets for all menu
items before showing them, because the ContextMenu constructor doesn't do that anymore.

* WebView/WebHTMLView.mm:
(+[WebMenuTarget sharedMenuTarget]): Moved from ContextMenuMac.mm.
(-[WebMenuTarget WebCore::]): Ditto.
(-[WebMenuTarget setMenuController:WebCore::]): Ditto.
(-[WebMenuTarget forwardContextMenuAction:]): Ditto.
(-[WebMenuTarget validateMenuItem:]): Ditto.

(setMenuItemTarget): Sets the target of the NSMenuItem to the shared WebMenuTarget.
(setMenuTargets): Recursively iterates over all NSMenuItems in an NSMenu (including
    submenus), and calls setMenuItemTarget on them.
(-[WebHTMLView menuForEvent:]): Call setMenuTarget on all the menu items before adding
    them to the menu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Dec 2010 22:45:39 +0000 (22:45 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, remove passing tests (linux) from test_expectations
        after DRT switch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix follow up build fix.
andersca@apple.com [Tue, 7 Dec 2010 22:31:46 +0000 (22:31 +0000)]
Build fix follow up build fix.

* pcre/pcre_ucp_searchfuncs.cpp:
(jsc_pcre_ucp_othercase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Dec 2010 22:22:56 +0000 (22:22 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Unreviewed, update chromium test_expectations for DRT based
        on Linux bot cycles and debug try bot.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix clang++ build
andersca@apple.com [Tue, 7 Dec 2010 22:21:28 +0000 (22:21 +0000)]
Fix clang++ build
https://bugs.webkit.org/show_bug.cgi?id=50645

Reviewed by Darin Adler.

Explicitly cast offset to int.

* pcre/pcre_ucp_searchfuncs.cpp:
(jsc_pcre_ucp_othercase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-06 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 7 Dec 2010 22:07:57 +0000 (22:07 +0000)]
2010-12-06  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        Clean up fast/events/multiline-link-arrow-navigation.html
        https://bugs.webkit.org/show_bug.cgi?id=50616

        fast/events/multiline-link-arrow-navigation.html is setting both
        WebKitEnableCaretBrowsing and -webkit-user-modify CSS property. Since
        both work similarly for the purposes of this test, and the former is
        not support by Mac and Windows DRTs, lets stick with using the later
        only.

        * fast/events/multiline-link-arrow-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/loader/empty-embed-src-attribute.html asserts in debug builds
andersca@apple.com [Tue, 7 Dec 2010 22:05:29 +0000 (22:05 +0000)]
fast/loader/empty-embed-src-attribute.html asserts in debug builds
https://bugs.webkit.org/show_bug.cgi?id=50643

Reviewed by Sam Weinig.

Just always ignore attempts to load requests with empty URLs.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Dec 2010 22:03:11 +0000 (22:03 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        -webkit-transition Fails on Multiple text-shadow Shadows
        https://bugs.webkit.org/show_bug.cgi?id=42281

        When transitioning multiple shadows, the blend function for
        ShadowData dropped all but the first and last shadow because
        of a failure to append to the end of the list. Fixed.

        Test: transitions/multiple-text-shadow-transition.html

        * page/animation/AnimationBase.cpp:
        (WebCore::PropertyWrapperShadow::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Dec 2010 22:03:03 +0000 (22:03 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        CSS animation doesn't work for border-radius
        https://bugs.webkit.org/show_bug.cgi?id=48340

        Include CSSPropertyBorderRadius in the list of shorthand
        properties, so that the individual border-radius properties
        get animated.

        Test: transitions/border-radius-transition.html

        * page/animation/AnimationBase.cpp:
        (WebCore::addShorthandProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Dec 2010 22:02:53 +0000 (22:02 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Make use of pause API more explicit before landing fix for borer-radius animation.
        https://bugs.webkit.org/show_bug.cgi?id=48340

        * transitions/transition-test-helpers.js: Add some constants that
        we can use to make the tests more readable.
        Handle an extra value in the expected values arrays, to tell us if
        we should expect a property to be animated, and therefore whether
        we should try to pause it.
        * transitions/color-transition-all.html:
        * transitions/zero-duration-in-list.html:
        Adjust to make use of the above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 7 Dec 2010 22:01:58 +0000 (22:01 +0000)]
2010-12-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Kent Tamura.

        Implement HTML5 hidden attribute
        https://bugs.webkit.org/show_bug.cgi?id=40511

        * fast/forms/caret-rtl.html: Fixed a non-closed comment which added an "hidden" attribute.
        * fast/html/hidden-attr-expected.txt: Added.
        * fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.
2010-12-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Kent Tamura.

        Implement HTML5 hidden attribute
        https://bugs.webkit.org/show_bug.cgi?id=40511

        Test: fast/html/hidden-attr.html

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute.
        (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 7 Dec 2010 21:45:04 +0000 (21:45 +0000)]
2010-12-07  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix compilation of core web audio files on Windows
        https://bugs.webkit.org/show_bug.cgi?id=50603

        Added log2 definition to MathExtras.h on Windows platform.

        * wtf/MathExtras.h:
        (log2):
2010-12-07  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix compilation of core web audio files on Windows
        https://bugs.webkit.org/show_bug.cgi?id=50603

        Changed a few constructs using C99 features of math.h to use
        wtf/MathExtras.h instead. Changed inline definitions of a couple of
        const static doubles in classes to out-of-line. Built Chrome with
        web audio enabled on Windows and Mac OS X to test these changes.

        No new tests since audio API is not yet implemented.

        * WebCore.gypi:
        * platform/audio/AudioResampler.cpp:
        * platform/audio/Biquad.cpp:
        (WebCore::Biquad::setLowpassParams):
        (WebCore::Biquad::setHighpassParams):
        (WebCore::Biquad::setLowShelfParams):
        * platform/audio/Cone.cpp:
        (WebCore::ConeEffect::gain):
        * platform/audio/EqualPowerPanner.cpp:
        (WebCore::EqualPowerPanner::pan):
        * platform/audio/FFTFrame.cpp:
        (WebCore::FFTFrame::interpolateFrequencyComponents):
        (WebCore::FFTFrame::extractAverageGroupDelay):
        (WebCore::FFTFrame::addConstantGroupDelay):
        * platform/audio/HRTFKernel.cpp:
        * platform/audio/HRTFPanner.cpp:
        * webaudio/AudioBufferSourceNode.cpp:
        (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope):
        * webaudio/AudioPannerNode.cpp:
        (WebCore::AudioPannerNode::getAzimuthElevation):
        * webaudio/AudioParam.cpp: Added.
        (AudioParam::setValue):
        (AudioParam::smooth):
        * webaudio/AudioParam.h:
        * webaudio/RealtimeAnalyser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-11-25 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 7 Dec 2010 21:39:15 +0000 (21:39 +0000)]
2010-11-25  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] faster elements linking
        https://bugs.webkit.org/show_bug.cgi?id=50067

        Perform less checks during GStreamer elements linking if building
        against GStreamer >= 0.10.30.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        (WebCore::GStreamerGWorld::enterFullscreen):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Dec 2010 21:05:52 +0000 (21:05 +0000)]
2010-12-07  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] force NRWT to use DRT
        https://bugs.webkit.org/show_bug.cgi?id=50359

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 7 Dec 2010 21:00:31 +0000 (21:00 +0000)]
2010-12-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] clears the subresources prematurely
        https://bugs.webkit.org/show_bug.cgi?id=50634

        Make adding the main resource explicit, and only clear
        subresources when the new load is committed, avoid clearing them
        prematurely.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
        (WebKit::FrameLoaderClient::provisionalLoadStarted):
        (WebKit::FrameLoaderClient::prepareForDataSourceReplacement):
        (WebKit::postCommitFrameViewSetup):
        * tests/testwebdatasource.c:
        (notify_load_status_lifetime_cb):
        (test_webkit_web_data_source_lifetime):
        (main):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_add_main_resource):
        (webkit_web_view_add_resource):
        (webkit_web_view_clear_resources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 7 Dec 2010 20:47:00 +0000 (20:47 +0000)]
2010-12-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] ::buffered() should return multiple ranges in some cases
        https://bugs.webkit.org/show_bug.cgi?id=45101

        Improved the ::buffered() method thanks to the new buffering query
        support that landed in GStreamer 0.10.31. The method now
        queries the media buffered-ranges on the pipeline and queue2
        handles it if it's buffering the media to disk.

        The webkitwebsrc element also gained BYTES duration query
        support. This is needed in the rare cases where uridecodebin
        configures its queue before the HTTP server returns the media
        Content-Length.

        Test: http/tests/media/video-buffered.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::buffered):
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_init):
        (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries
        if it's aware of the media content-length.
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of
        the second and next buffered ranges.

LayoutTests:

        Reviewed by Gustavo Noronha Silva.

        [GStreamer] ::buffered() should return multiple ranges in some cases
        https://bugs.webkit.org/show_bug.cgi?id=45101

        New test for video.buffered attribute. The test is skipped for
        ports not returning multiple timeranges for video.buffered.

        * http/tests/media/video-buffered-expected.txt: Added.
        * http/tests/media/video-buffered.html: Added.
        * http/tests/resources/counting-captioned.mov: Added.
        * http/tests/media/video-throttled-load.cgi: added Range
        requests/responses support.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/mac/Skipped:
        * platform/qt-mac/Skipped:
        * platform/qt-win/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win-wk2/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Dec 2010 19:56:48 +0000 (19:56 +0000)]
2010-12-07  Simon Fraser  <simon.fraser@apple.com>

        Update Xcode project for newer Xcode.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpatial navigation not Working for Map and Area Tags
yael.aharon@nokia.com [Tue, 7 Dec 2010 19:04:10 +0000 (19:04 +0000)]
Spatial navigation not Working for Map and Area Tags
https://bugs.webkit.org/show_bug.cgi?id=47142

Reviewed by Antonio Gomes.

WebCore:

Give area elements special treatment in spatial navigation algorithm by getting the
rect of the area from the associated image. Since area elements are likely to overlap
if they are not rects, or if authors are not careful, we flatten the rect of area elements.

Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html
       fast/spatial-navigation/snav-imagemap-area-without-image.html
       fast/spatial-navigation/snav-imagemap-overlapped-areas.html
       fast/spatial-navigation/snav-imagemap-simple.html

* page/FocusController.cpp:
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::virtualRectForDirection):
(WebCore::virtualRectForAreaElementAndDirection):
* page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):

LayoutTests:

* fast/spatial-navigation/snav-imagemap-area-not-focusable-expected.txt: Added.
* fast/spatial-navigation/snav-imagemap-area-not-focusable.html: Added.
* fast/spatial-navigation/snav-imagemap-area-without-image-expected.txt: Added.
* fast/spatial-navigation/snav-imagemap-area-without-image.html: Added.
* fast/spatial-navigation/snav-imagemap-overlapped-areas-expected.txt: Added.
* fast/spatial-navigation/snav-imagemap-overlapped-areas.html: Added.
* fast/spatial-navigation/snav-imagemap-simple-expected.txt: Added.
* fast/spatial-navigation/snav-imagemap-simple.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Unreviewed.
jberlin@webkit.org [Tue, 7 Dec 2010 18:04:52 +0000 (18:04 +0000)]
Build fix. Unreviewed.

* WebKit2.pro:
Added WebDatabaseManagerQt.cpp.
* WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Added.
(WebKit::WebDatabaseManager::databaseDirectory):
Added a FIXME to implement and return an empty string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore: Try to fix V8 build.
darin@apple.com [Tue, 7 Dec 2010 17:52:23 +0000 (17:52 +0000)]
WebCore: Try to fix V8 build.

* bindings/generic/BindingDOMWindow.h:
(WebCore::BindingDOMWindow::createWindow): Pass security origin.

WebKit2: Get a bit closer to making Qt WebKit2 compile again.

* WebKit2.pro: Add the WebDatabaseManager source files.
Still missing: The Qt version of the databaseDirectory function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Need to set the location of the Databases directory when the WebProcess...
jberlin@webkit.org [Tue, 7 Dec 2010 17:27:10 +0000 (17:27 +0000)]
WebKit2: Need to set the location of the Databases directory when the WebProcess is initialized
https://bugs.webkit.org/show_bug.cgi?id=50604

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/WebDatabaseManager.cpp: Added.
(WebKit::WebDatabaseManager::shared):
(WebKit::WebDatabaseManager::WebDatabaseManager):
Initialize the DatabaseTracker with the Database directory.
* WebProcess/WebCoreSupport/WebDatabaseManager.h: Added.
* WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Added.
(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeDatabasesIfNecessary in WebKit/mac/Storage/WebDatabaseManager.mm.
* WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Added.
(WebKit::WebDatabaseManager::databaseDirectory):
Copied from WebKitInitializeWebDatabasesIfNecessary in WebKit/win/WebDatabaseManager.cpp.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
Make sure that the Databases directory has been set by calling WebDatabaseManager::shared().

* WebKit2.xcodeproj/project.pbxproj:
Add WebDatabaseManager.cpp/.h/Mac.cpp
* win/WebKit2.vcproj:
Add WebDatabaseManager.cpp/.h/Win.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Unreviewed.
jberlin@webkit.org [Tue, 7 Dec 2010 17:14:59 +0000 (17:14 +0000)]
Build fix. Unreviewed.

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother build fix.
darin@apple.com [Tue, 7 Dec 2010 16:40:31 +0000 (16:40 +0000)]
Another build fix.

* loader/CrossOriginAccessControl.cpp: Added a missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix build.
darin@apple.com [Tue, 7 Dec 2010 16:33:38 +0000 (16:33 +0000)]
Try to fix build.

* plugins/PluginView.cpp:
(WebCore::PluginView::start): Pass security origin.
(WebCore::PluginView::getURLNotify): Ditto.
(WebCore::PluginView::getURL): Ditto.
(WebCore::PluginView::handlePost): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix build.
darin@apple.com [Tue, 7 Dec 2010 16:30:34 +0000 (16:30 +0000)]
Try to fix build.

* Api/qwebpage.cpp:
(frameLoadRequest): Added missing parentheses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-06 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 7 Dec 2010 16:23:03 +0000 (16:23 +0000)]
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * src/ApplicationCacheHost.cpp:
        (WebCore::ApplicationCacheHost::selectCacheWithManifest): Pass security origin.
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchCreatePage): Ditto.
        (WebKit::FrameLoaderClientImpl::createFrame): Ditto.
        * src/WebPluginContainerImpl.cpp:
        (WebKit::WebPluginContainerImpl::loadFrameRequest): Ditto.
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * Api/qwebpage.cpp:
        (frameLoadRequest): Pass security origin.
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle): Pass security origin.
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Pass security origin.
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * bindings/generic/BindingDOMWindow.h:
        (WebCore::BindingDOMWindow::createWindow): Pass security origin.
        (WebCore::BindingDOMWindow::open): Ditto.
        * bindings/generic/BindingFrame.h:
        (WebCore::BindingFrame::navigateIfAllowed): Ditto.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation): Pass security origin.
        (WebCore::createWindow): Ditto.
        (WebCore::JSDOMWindow::open): Ditto.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation): Pass security origin.

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv): Pass security origin.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::openInInspectedWindow):
        Pass security origin.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation): Added a security origin
        argument, passed through to urlSelected.
        (WebCore::FrameLoader::urlSelected): Replaced the resource request
        and frame name arguments with a frame load request arguments in one
        overload, and changed the other overload to pass in the current
        frame's document for the security origin.
        (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay
        check before the referrer computation because it no longer needs
        to look at the referrer. Replaced the call to canDisplay that
        used the target frame's security origin and the call to
        deprecatedCanDisplay with a single call to canDisplay that uses
        the requester security origin.

        * loader/FrameLoader.h: Updated for argument changes above.

        * loader/NavigationScheduler.cpp:
        (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added
        a security origin.
        (WebCore::ScheduledURLNavigation::fire): Pass the security origin
        in to FrameLoader::changeLocation.
        (WebCore::ScheduledURLNavigation::securityOrigin): Added.
        (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security
        origin argument.
        (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto.
        (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto.
        (WebCore::ScheduledRefresh::fire): Pass the security origin in to
        FrameLoader::changeLocation.
        (WebCore::ScheduledFormSubmission::fire): Include the security
        origin when constructing form submission.
        (WebCore::NavigationScheduler::scheduleRedirect): Include the security
        origin when creating the scheduled navigation object.
        (WebCore::NavigationScheduler::scheduleLocationChange): Ditto.
        (WebCore::NavigationScheduler::scheduleRefresh): Ditto.

        * loader/NavigationScheduler.h: Added the security origin argument
        to scheduleLocationChange.

        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security
        origin when calling scheduleLocationChange.
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::selectCache): Ditto.

        * page/ContextMenuController.cpp:
        (WebCore::openNewWindow): Pass in the security origin.
        (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

        * page/FrameLoadRequest.h: Added a security origin called the requester
        to all FrameLoadRequest objects.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::findInRequest): Added the security origin.
2010-12-06  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Pass security origin to make local file decision correctly
        https://bugs.webkit.org/show_bug.cgi?id=48603

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::loadURL): Pass security origin.
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchCreatePage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Chyangwoo Ryu <cwryu@debian.org>
kov@webkit.org [Tue, 7 Dec 2010 16:13:42 +0000 (16:13 +0000)]
2010-12-07  Chyangwoo Ryu  <cwryu@debian.org>

        Reviewed by Gustavo Noronha.

        Korean message translation
        https://bugs.webkit.org/show_bug.cgi?id=42465

        * kr.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 7 Dec 2010 15:54:41 +0000 (15:54 +0000)]
2010-12-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] testwebdatasource - unreachable test is broken
        https://bugs.webkit.org/show_bug.cgi?id=50629

        Fix, and disable testwebdatasource's unreachable test (it is not
        passing now that it actually tests what it should). This also
        fixes the wait timer to actually work as expected.

        * tests/testwebdatasource.c:
        (notify_load_status_unreachable_cb):
        (notify_load_status_cb):
        (test_webkit_web_data_source):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 7 Dec 2010 15:20:05 +0000 (15:20 +0000)]
2010-12-07  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: avoid initializing Context on when creating attaching listener to ScriptDebugServer
        https://bugs.webkit.org/show_bug.cgi?id=50627

        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::addListener): don't try to collect already parsed scripts if context has
        not been initialized yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 7 Dec 2010 14:24:51 +0000 (14:24 +0000)]
2010-12-07  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: switch http/tests/inspector/console-resource-errors.html to inspector-tests2
        https://bugs.webkit.org/show_bug.cgi?id=50551

        We need to be sure that front-end has already opened by the time the messages are
        recorded in console because the data we collect for errors may differ depending
        on whether the front-end is open.

        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/console-tests2.js:
        (initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 7 Dec 2010 13:58:44 +0000 (13:58 +0000)]
Unreviewed.

Add Qt specific expected results for tests introduced in r73385 and r73398.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/html/marquee-scrollamount-expected.checksum: Added.
* platform/qt/fast/html/marquee-scrollamount-expected.png: Added.
* platform/qt/fast/html/marquee-scrollamount-expected.txt: Added.
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.png: Added.
* platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolling out r73421, because it made transitions/color-transition-all...
ossy@webkit.org [Tue, 7 Dec 2010 13:29:05 +0000 (13:29 +0000)]
Unreviewed. Rolling out r73421, because it made transitions/color-transition-all.html flakey.

WebCore:

* page/animation/AnimationBase.cpp:
(WebCore::addShorthandProperties):

LayoutTests:

* transitions/border-radius-transition-expected.txt: Removed.
* transitions/border-radius-transition.html: Removed.
* transitions/color-transition-all.html:
* transitions/transition-test-helpers.js:
(expected):
* transitions/zero-duration-in-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Dec 2010 12:40:54 +0000 (12:40 +0000)]
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::close):
        (WebCore::Document::lastModified):
        (WebCore::Document::finishedParsing):
        (WebCore::Document::initSecurityContext):
        (WebCore::Document::updateURLForPushOrReplaceState):
        * dom/Document.h:
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::scriptCharset):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::createDocumentStructure):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::commitData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::setFrame):
        * loader/DocumentLoader.h:
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::begin):
        * loader/DocumentWriter.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::finishedLoadingDocument):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::writer):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::requestPreload):
        * platform/network/FormDataBuilder.cpp:
        (WebCore::FormDataBuilder::encodingFromAcceptCharset):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::finishedLoading):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::loadJavaScriptURL):
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
        (WebKit::WebPageSerializerImpl::serialize):
        * src/WebSearchableFormData.cpp:
        (WebCore::GetFormEncoding):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::pageEncoding):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::finishedLoading):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_encoding):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * Api/qwebframe.cpp:
        (QWebFrame::setUrl):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::finishedLoading):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::finishedLoading):
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed, rolling out r73392.
        http://trac.webkit.org/changeset/73392
        https://bugs.webkit.org/show_bug.cgi?id=50489

        This commit caused crashes on the GTK+ bots

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::finishedLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Dec 2010 12:11:08 +0000 (12:11 +0000)]
2010-12-07  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline GTK+ results after r73385.

        * platform/gtk/css1/box_properties/margin-expected.txt:
        * platform/gtk/css1/box_properties/margin_right-expected.txt:
        * platform/gtk/css1/classification/white_space-expected.txt:
        * platform/gtk/css1/color_and_background/background_attachment-expected.txt:
        * platform/gtk/css1/color_and_background/background_repeat-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
        * platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
        * platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
        * platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
        * platform/gtk/fast/blockflow/block-level-images-expected.txt:
        * platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
        * platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt:
        * platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt:
        * platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt:
        * platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt:
        * platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
        * platform/gtk/fast/css/negative-leading-expected.txt:
        * platform/gtk/fast/forms/basic-textareas-expected.txt:
        * platform/gtk/fast/forms/file-input-direction-expected.txt:
        * platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
        * platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
        * platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
        * platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
        * platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/images/gif-large-checkerboard-expected.txt:
        * platform/gtk/fast/lists/001-vertical-expected.txt:
        * platform/gtk/fast/lists/003-vertical-expected.txt:
        * platform/gtk/fast/multicol/float-multicol-expected.txt:
        * platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
        * platform/gtk/fast/multicol/float-paginate-expected.txt:
        * platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
        * platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
        * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
        * platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
        * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
        * platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
        * platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
        * platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
        * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
        * platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
        * platform/gtk/svg/custom/text-zoom-expected.txt:
        * platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
        * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
        * platform/gtk/transforms/svg-vs-css-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 7 Dec 2010 11:11:37 +0000 (11:11 +0000)]
2010-12-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Remove WebKitGenerators
        https://bugs.webkit.org/show_bug.cgi?id=50445

        * CMakeLists.txt:
        * cmake/WebKitGenerators.cmake: Removed.
2010-12-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Remove WebKitGenerators
        https://bugs.webkit.org/show_bug.cgi?id=50445

        Move remaining logic into main CMakeLists.txt.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=50412
antti@apple.com [Tue, 7 Dec 2010 11:11:08 +0000 (11:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50412
http://www.wunderground.com/US/CA/Hayward.html causes big memory spike during page loading

Reviewed by Gavin Barraclough.

Creating a substring caused the original string be flattened if it was in the rope form. This could use
significant amount of memory by reducing buffer sharing between strings.

Add a rope specific substring function that constructs the substring by reusing the rope fibers
instead of flattening the rope.

No change observed in SunSpider.

* runtime/JSString.cpp:
(JSC::JSString::substringFromRope):
* runtime/JSString.h:
(JSC::jsSubstring):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Tue, 7 Dec 2010 10:44:05 +0000 (10:44 +0000)]
2010-12-07  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Clear old SVG cursor entry before adding a new one
        https://bugs.webkit.org/show_bug.cgi?id=50549

        Test: svg/css/cursor-replace.svg

        * css/CSSCursorImageValue.cpp:
        (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::~SVGCursorElement):
        (WebCore::SVGCursorElement::removeClient):
        (WebCore::SVGCursorElement::removeReferencedElement):
        * svg/SVGCursorElement.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::setCursorElement):
        (WebCore::SVGElement::cursorElementRemoved):
        (WebCore::SVGElement::setCursorImageValue):
        (WebCore::SVGElement::cursorImageElementRemoved):
        * svg/SVGElement.h:
2010-12-07  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Clear old SVG cursor entry before adding a new one
        https://bugs.webkit.org/show_bug.cgi?id=50549

        * svg/css/cursor-replace-expected.txt: Added.
        * svg/css/cursor-replace.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 7 Dec 2010 10:15:48 +0000 (10:15 +0000)]
2010-12-07  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Add Chromium-specific expected results for two tests.

        * platform/chromium-linux/css2.1/t040105-import-10-b-expected.checksum: Added.
        * platform/chromium-linux/css2.1/t040105-import-10-b-expected.png: Added.
        * platform/chromium-linux/media/controls-without-preload-expected.checksum: Added.
        * platform/chromium-linux/media/controls-without-preload-expected.png: Added.
        * platform/chromium-mac/media/controls-without-preload-expected.checksum: Added.
        * platform/chromium-mac/media/controls-without-preload-expected.png: Added.
        * platform/chromium-mac/media/controls-without-preload-expected.txt: Added.
        * platform/chromium-win/css2.1/t040105-import-10-b-expected.checksum: Added.
        * platform/chromium-win/css2.1/t040105-import-10-b-expected.png: Added.
        * platform/chromium-win/css2.1/t040105-import-10-b-expected.txt: Added.
        * platform/chromium-win/media/controls-without-preload-expected.checksum: Added.
        * platform/chromium-win/media/controls-without-preload-expected.png: Added.
        * platform/chromium-win/media/controls-without-preload-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-07 Kenichi Ishibashi <bashi@google.com>
tkent@chromium.org [Tue, 7 Dec 2010 09:40:23 +0000 (09:40 +0000)]
2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Introduces FormAssociatedElement class which would be a super class
        of form assocated elements. Some of member functions and variables of
        HTMLFormControlElement are migrated into this class.
        Following the HTML5 spec, HTMLFormControlElement class and
        HTMLObjectElement class are subclasses of it for now.

        Test: fast/forms/form-collection-elements-order.html

        * Android.mk: Added FormAssociatedElement.cpp
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Added FormAssociatedElement.{cpp,h}
        * WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedElement*)
        * WebCore.gypi: Added FormAssociatedElement.{cpp,h}
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * dom/CheckedRadioButtons.h: Fixed class forward declaration order.
        * dom/Document.cpp:
        (WebCore::Document::registerFormElementWithFormAttribute): Modified to
        use FormAssociatedElement instead of HTMLFormControlElement
        (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto.
        (WebCore::Document::resetFormElementsOwner):
        * dom/Document.h: Ditto.
        * html/DOMFormData.cpp: Ditto.
        (WebCore::DOMFormData::DOMFormData):
        * html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/HTMLFormControlElement.cpp.
        (WebCore::FormAssociatedElement::FormAssociatedElement):
        (WebCore::FormAssociatedElement::~FormAssociatedElement):
        (WebCore::FormAssociatedElement::validity):
        (WebCore::FormAssociatedElement::insertedIntoTree):
        (WebCore::FormAssociatedElement::removedFromTree):
        (WebCore::FormAssociatedElement::removeFromForm):
        (WebCore::FormAssociatedElement::resetFormOwner):
        (WebCore::FormAssociatedElement::formAttributeChanged):
        (WebCore::toHTMLElement):
        * html/FormAssociatedElement.h: Ditto.
        (WebCore::FormAssociatedElement::ref):
        (WebCore::FormAssociatedElement::deref):
        (WebCore::FormAssociatedElement::formDestroyed):
        (WebCore::FormAssociatedElement::setForm):
        * html/HTMLElement.h: Changed the access level of findFormAncestor().
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedElement
        instead of HTMLFormControlElement.
        (WebCore::HTMLFormCollection::getNamedFormItem): Ditto.
        (WebCore::HTMLFormCollection::updateNameCache): Ditto.
        * html/HTMLFormControlElement.cpp: Modified regarding with the change of class
        hierarchy.
        (WebCore::HTMLFormControlElement::HTMLFormControlElement):
        (WebCore::HTMLFormControlElement::~HTMLFormControlElement):
        (WebCore::HTMLFormControlElement::insertedIntoTree):
        (WebCore::HTMLFormControlElement::removedFromTree):
        (WebCore::HTMLFormControlElement::supportsFocus):
        (WebCore::HTMLFormControlElement::checkValidity):
        (WebCore::HTMLFormControlElement::virtualForm):
        (WebCore::HTMLFormControlElement::isDefaultButtonForForm):
        (WebCore::HTMLFormControlElement::attributeChanged):
        * html/HTMLFormControlElement.h: Ditto.
        (WebCore::HTMLFormControlElement::form):
        (WebCore::HTMLFormControlElement::disabled):
        (WebCore::HTMLFormControlElement::type):
        (WebCore::HTMLFormControlElement::refFormAssociatedElement):
        (WebCore::HTMLFormControlElement::derefFormAssociatedElement):
        * html/HTMLFormElement.cpp: Modified to use FormAssociatedElement
        instead of HTMLFormControlElement.
        (WebCore::HTMLFormElement::submitImplicitly):
        (WebCore::HTMLFormElement::validateInteractively):
        (WebCore::HTMLFormElement::submit):
        (WebCore::HTMLFormElement::reset):
        (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
        (WebCore::HTMLFormElement::formElementIndex):
        (WebCore::HTMLFormElement::registerFormElement):
        (WebCore::HTMLFormElement::removeFormElement):
        (WebCore::HTMLFormElement::defaultButton):
        (WebCore::HTMLFormElement::checkValidity):
        (WebCore::HTMLFormElement::collectUnhandledInvalidControls):
        (WebCore::HTMLFormElement::documentDidBecomeActive):
        * html/HTMLFormElement.h: Ditto.
        (WebCore::HTMLFormElement::associatedElements):
        * html/HTMLInputElement.cpp: Ditto.
        (WebCore::HTMLInputElement::updateCheckedRadioButtons):
        * html/HTMLObjectElement.cpp: Modified regarding with the change of class
        hierarchy.
        (WebCore::HTMLObjectElement::HTMLObjectElement):
        (WebCore::HTMLObjectElement::~HTMLObjectElement):
        (WebCore::HTMLObjectElement::create):
        (WebCore::HTMLObjectElement::attributeChanged):
        (WebCore::HTMLObjectElement::insertedIntoTree):
        (WebCore::HTMLObjectElement::removedFromTree):
        (WebCore::HTMLObjectElement::appendFormData):
        (WebCore::HTMLObjectElement::formControlName):
        * html/HTMLObjectElement.h: Ditto.
        (WebCore::HTMLObjectElement::form):
        (WebCore::HTMLObjectElement::isFormControlElement):
        (WebCore::HTMLObjectElement::isEnumeratable):
        (WebCore::HTMLObjectElement::refFormAssociatedElement):
        (WebCore::HTMLObjectElement::derefFormAssociatedElement):
        * html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag.
        * html/ValidationMessage.cpp: Modified to use FormAssociatedElement
        instead of HTMLFormControlElement.
        (WebCore::ValidationMessage::ValidationMessage):
        (WebCore::ValidationMessage::create):
        * html/ValidationMessage.h: Ditto.
        * html/ValidityState.cpp: Ditto.
        (WebCore::ValidityState::validationMessage):
        (WebCore::ValidityState::setCustomErrorMessage):
        (WebCore::ValidityState::valueMissing):
        (WebCore::ValidityState::typeMismatch):
        (WebCore::ValidityState::patternMismatch):
        (WebCore::ValidityState::tooLong):
        (WebCore::ValidityState::rangeUnderflow):
        (WebCore::ValidityState::rangeOverflow):
        (WebCore::ValidityState::stepMismatch):
        * html/ValidityState.h: Ditto.
        (WebCore::ValidityState::create):
        (WebCore::ValidityState::ValidityState):
        * loader/FormSubmission.cpp: Ditto.
        (WebCore::FormSubmission::create):

2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Modified to use FormAssociatedElement instead of HTMLFormControlElement.

        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::getFormControlElements): Modified to use
        FormAssociatedElement instead of HTMLFormControlElement.
        * src/WebPasswordFormUtils.cpp:
        (WebKit::findPasswordFormFields): Ditto.
        * src/WebSearchableFormData.cpp:
        (WebCore::GetButtonToActivate): Ditto.
        (WebCore::HasSuitableTextElement): Ditto.

2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Modified to use FormAssociatedElement instead of HTMLFormControlElement.

        * WebFrame.cpp:
        (WebFrame::elementWithName): Modified to use FormAssociatedElement
        instead of HTMLFormControlElement.
        (WebFrame::controlsInForm): Ditto.

2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Modified to use FormAssociatedElement instead of HTMLFormControlElement.

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation elementWithName:inForm:]): Modified to use
        FormAssociatedElement instead of HTMLFormControlElement.
        (-[WebHTMLRepresentation controlsInForm:]): Ditto.

2010-12-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Kent Tamura.

        Let HTMLObjectElement be a form associated element
        https://bugs.webkit.org/show_bug.cgi?id=48821

        Adds a test to ensure the order of form.elements attribute.
        Updates two tests to check whether object elements are handled
        correctly in form.elements attribute.

        * fast/forms/form-attribute-expected.txt: Updated.
        * fast/forms/form-collection-elements-order-expected.txt: Added.
        * fast/forms/form-collection-elements-order.html: Added.
        * fast/forms/script-tests/form-attribute.js: Updated.
        * fast/forms/script-tests/form-collection-elements-order.js: Added.
        (checkOrder):
        * fast/forms/script-tests/form-collection-elements.js: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2010-12-06 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 7 Dec 2010 07:31:12 +0000 (07:31 +0000)]
2010-12-06  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations for svg/custom/text-linking.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73429 268f45cc-cd09-0410-ab3c-d52691b4dbfc