WebKit-https.git
10 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 14:26:33 +0000 (14:26 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        All SVG *-expected.txt files contain wrong results
        https://bugs.webkit.org/show_bug.cgi?id=34703

        Finally dump meaningful information for SVG layout tests.
        Use 'absoluteClippedOverflowRect' which goes through the same code paths used
        to actually calculate repaint rects etc - instead of the legacy CSS-unaware
        code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
        Remove absoluteTransform() - a long standing TODO, finally not needed anymore.

        Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
        Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
        when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.

        As we're now dumping clipped overflow rects any problems with repaint rects will become
        immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
        element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
        Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.

        Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.

        * rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
        * rendering/RenderObject.h: Remove absoluteTransform() method.
        * rendering/RenderSVGHiddenContainer.h: Ditto.
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
                                                         along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
        (WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
        * rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method.
        (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
        * rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y.
        (WebCore::SVGRenderBase::isOverflowHidden):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()).
        (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
        * svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform().
        (WebCore::absoluteTransformForRenderer):
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSuppressed check-webkit-style's underscore check in Qt's autotests.
cjerdonek@webkit.org [Mon, 8 Feb 2010 13:26:01 +0000 (13:26 +0000)]
Suppressed check-webkit-style's underscore check in Qt's autotests.
Also made the path-specific filter check case-insensitive.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34574

* Scripts/webkitpy/style/checker.py:
  - Added a list element to _PATH_RULES_SPECIFIER for
    directories that should be excluded from the
    "readability/naming" category (the category that relates to
    underscores in identifiers, for example).

* Scripts/webkitpy/style/checker_unittest.py:
  - Added an "end-to-end" test for "WebKit/qt/tests/".

* Scripts/webkitpy/style/filter.py:
  - Altered FilterConfiguration's should_check() method to
    check for path substring matches case-insensitively.

* Scripts/webkitpy/style/filter_unittest.py:
  - Added a test to check case-insensitive path substring matching.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed the hard-coded "WebKit/gtk/webkit/" path reference
    since this is now taken care of by the _PATH_RULES_SPECIFIER
    configuration variable.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed the unit test for the GTK directory since this
    is now taken care of by the checker._PATH_RULES_SPECIFIER
    end-to-end tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix for make distcheck.
kov@webkit.org [Mon, 8 Feb 2010 13:21:38 +0000 (13:21 +0000)]
Build fix for make distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Feb 2010 13:06:34 +0000 (13:06 +0000)]
2010-02-08  Xan Lopez  <xlopez@igalia.com>

        Try to do some clean-up in our Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Feb 2010 12:47:19 +0000 (12:47 +0000)]
2010-02-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Generate new results for this test.

        * platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-08 Tony Chang <tony@chromium.org>
eric@webkit.org [Mon, 8 Feb 2010 11:04:37 +0000 (11:04 +0000)]
2010-02-08  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
        The test copies HTML to the text output, so it doesn't really need
        to dump the render tree.

        The test was added in r49985, but didn't include pixel results.
        https://bugs.webkit.org/show_bug.cgi?id=34625

        * platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-08 Leith Bade <leith@leithalweapon.geek.nz>
eric@webkit.org [Mon, 8 Feb 2010 10:48:17 +0000 (10:48 +0000)]
2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>

        Reviewed by Darin Adler.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
        Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
        environemnt variables when there is a space in the user's /home path.

        * Scripts/webkitdirs.pm:
         - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed RVCT build fix.
hausmann@webkit.org [Mon, 8 Feb 2010 09:33:12 +0000 (09:33 +0000)]
Unreviewed RVCT build fix.

Similar to r54391, don't import the cmath functions from std:: for RVCT.

* wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Feb 2010 00:42:00 +0000 (00:42 +0000)]
2010-02-07  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Fix 2 pixel test baselines that are incorrect but passing
        the fuzzy image diff.

        editing/deleting/5390681.html should show a cursor, but doesn't.
        In r42549, whitespace collapsing was changed but
        editing/pasteboard/5387578.html's result wasn't updated to
        reflect the collapsed whitespace.
        https://bugs.webkit.org/show_bug.cgi?id=34632

        * platform/mac/editing/deleting/5390681-2-expected.checksum:
        * platform/mac/editing/deleting/5390681-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.checksum:
        * platform/mac/editing/pasteboard/5387578-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 22:26:34 +0000 (22:26 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix Tiger layout test failure.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Tiger build.

        * platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 21:43:17 +0000 (21:43 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix layout test bots.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Leopard, Windows, and Qt ports.

        * platform/mac-leopard/fast/lists: Added.
        * platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 21:08:10 +0000 (21:08 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Implements all of the numeric CSS3 list-style-types as per
        section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.

        Test: fast/lists/w3-css3-list-styles-numeric.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in:
        * inspector/front-end/SourceCSSTokenizer.re2js:
        * platform/text/CharacterNames.h: Added constant hyphenMinus.
        * rendering/RenderListMarker.cpp:
        (WebCore::): Defined enum SequenceType.
        (WebCore::toAlphabeticOrNumeric): Added.
        (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric.
        (WebCore::toNumeric): Added.
        (WebCore::listMarkerSuffix):
        (WebCore::listMarkerText):
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/style/RenderStyle.h:
        (WebCore::):
        * rendering/style/RenderStyleConstants.h: Added numeric list style types
        and fixed indent level for the enum values.
        (WebCore::):
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Tests that all of the numeric CSS3 list-style-types are supported.

        * fast/lists/w3-css3-list-styles-numeric.html: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Ismail Donmez <ismail@namtrac.org>
eric@webkit.org [Sun, 7 Feb 2010 20:47:15 +0000 (20:47 +0000)]
2010-02-07  Ismail Donmez  <ismail@namtrac.org>

        Reviewed by Darin Adler.

        Include wtf/StringExtras.h for strdup definition, which
        is needed for WinCE.

        * bridge/IdentifierRep.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sun, 7 Feb 2010 12:52:21 +0000 (12:52 +0000)]
2010-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/console-dirxml-expected.txt:
        * inspector/console-dirxml.html:
2010-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-07 Jian Li <jianli@chromium.org>
eric@webkit.org [Sun, 7 Feb 2010 12:35:36 +0000 (12:35 +0000)]
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * platform/chromium/ChromiumDataObject.cpp:
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::hasData):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ChromiumDataObject.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::setData):
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * public/WebDragData.h:
        * src/WebDragData.cpp:
        (WebKit::WebDragData::downloadMetadata):
        (WebKit::WebDragData::setDownloadMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Sun, 7 Feb 2010 11:42:48 +0000 (11:42 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717

* fast/frames/flattening/resources: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 6 Feb 2010 20:18:51 +0000 (20:18 +0000)]
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 6 Feb 2010 19:02:34 +0000 (19:02 +0000)]
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Using inlines and function-level statics don't mix, according to gcc.
        https://bugs.webkit.org/show_bug.cgi?id=34663

        De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

        It appears that the initialization check, generated by gcc doesn't account
        for a possibility that the function may be inlined, resulting in lazy
        initialization failure for more than one inlined instance of the function.

        No behavior change, so no new tests.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::deviceRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChange UStringImpl::create to CRASH if the string cannot be allocated,
barraclough@apple.com [Sat, 6 Feb 2010 08:55:31 +0000 (08:55 +0000)]
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods.  In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Oliver Hunt.
ap@apple.com [Sat, 6 Feb 2010 06:32:07 +0000 (06:32 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=34670
        TestNetscapePlugin should work with Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
        browser doesn't tell what it supports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 6 Feb 2010 05:37:58 +0000 (05:37 +0000)]
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * platform/gtk/Skipped:
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded an ASSERT to catch an implausible but theoretically possible leak.
ggaren@apple.com [Sat, 6 Feb 2010 04:25:52 +0000 (04:25 +0000)]
Added an ASSERT to catch an implausible but theoretically possible leak.

Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.

This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved these special Windows expected results because they represented
ggaren@apple.com [Sat, 6 Feb 2010 02:50:44 +0000 (02:50 +0000)]
Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Sat, 6 Feb 2010 02:44:55 +0000 (02:44 +0000)]
2010-02-05  James Hawkins  <jhawkins@chromium.org>

        Reviewed by David Levin.

        [Chromium] Rename autocomplete* to suggestions* to prepare for the
        refactoring of AutocompletePopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=34664

        * public/WebView.h:
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::hideAutofillPopup):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::suggestionsPopupDidHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sat, 6 Feb 2010 02:28:06 +0000 (02:28 +0000)]
2010-02-05  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Define SYSTEM_MALLOC 1
        https://bugs.webkit.org/show_bug.cgi?id=34640

        Make BREWMP use system malloc because FastMalloc is not ported.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 6 Feb 2010 01:30:24 +0000 (01:30 +0000)]
2010-02-05  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed revert of r54454, until I can generate new results

        * media/video-loop-expected.txt:
        * media/video-loop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Fixed changed virtual function in GraphicsLayerCACF and call order issues
cmarrin@apple.com [Sat, 6 Feb 2010 01:10:58 +0000 (01:10 +0000)]
    Fixed changed virtual function in GraphicsLayerCACF and call order issues
        https://bugs.webkit.org/show_bug.cgi?id=34348

        The correct virtual function in GraphicsLayerCACF is now being
        called. We also fixed an issue in QTMovieWin where the size
        of the movie was not being set correctly because the call order
        was changed.

        I also changed the order of a couple of calls in QTMovieWin to account
        for changed calling order from the logic above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 6 Feb 2010 00:49:11 +0000 (00:49 +0000)]
2010-02-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=33671
        [GTK] media/video-loop.html fails intermittently on Gtk Bots

        Rewrite test to make it less timing dependent.

        * media/video-loop-expected.txt:
        * media/video-loop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 6 Feb 2010 00:41:31 +0000 (00:41 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add a simple test implementation and the WebKit Mac implementation
        for the layout_tests/port package. Also add a simple test driver of
        that interface.

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/driver_test.py: Added.
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/mac.py: Added.
        * Scripts/webkitpy/layout_tests/port/test.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 6 Feb 2010 00:01:04 +0000 (00:01 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        Refactor the port package into an object-oriented style and merge
        path_utils into it. We add a 'base' and a 'chromium' object to the
        port package; this will allow us to easily add new ports (like
        WebKit Mac).

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/rebaseline-chromium-webkit-tests:
        * Scripts/run-chromium-webkit-tests:
        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/base.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 23:11:12 +0000 (23:11 +0000)]
2010-02-05  James Hawkins  <jhawkins@chromium.org>

        Reviewed by David Levin.

        [Chromium] Remove an unused forward declaration in WebKitClient.h.

        https://bugs.webkit.org/show_bug.cgi?id=34622

        * public/WebKitClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Mark Rowe.
kdecker@apple.com [Fri, 5 Feb 2010 22:53:14 +0000 (22:53 +0000)]
    Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=34661
        <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
        * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
        (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHorizontal scrollbar works in reverse at milliondollarcu.be
enrica@apple.com [Fri, 5 Feb 2010 22:40:59 +0000 (22:40 +0000)]
Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848

Reviewed by Simon Fraser.

Added a manual test.

* manual-tests/win: Added.
* manual-tests/win/horizontal-scroll-composited.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 5 Feb 2010 22:24:29 +0000 (22:24 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

* platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 5 Feb 2010 22:04:11 +0000 (22:04 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Update expected results after r54441 to make buildbot happy.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 21:58:45 +0000 (21:58 +0000)]
2010-02-05  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        Implement WebInputElement::isActivatedSubmit().

        https://bugs.webkit.org/show_bug.cgi?id=34623

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::isActivatedSubmit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Ryan Leavengood <leavengood@gmail.com>
eric@webkit.org [Fri, 5 Feb 2010 21:37:28 +0000 (21:37 +0000)]
2010-02-05  Ryan Leavengood  <leavengood@gmail.com>

        Reviewed by David Levin.

        Implementation of GlyphPage::fill() for Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        Covered by existing tests.

        * platform/graphics/haiku/GlyphPageTreeNodeHaiku.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, missed in earlier commit.
kenneth@webkit.org [Fri, 5 Feb 2010 21:21:10 +0000 (21:21 +0000)]
Unreviewed, missed in earlier commit.

Add expected frame flattening results for Qt.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement flattening of framesets
kenneth@webkit.org [Fri, 5 Feb 2010 20:47:17 +0000 (20:47 +0000)]
Implement flattening of framesets
https://bugs.webkit.org/show_bug.cgi?id=32717

Reviewed by Dave Hyatt.

WebCore:

The following patch, builds ontop of Antti Koivisto's frameset
flattening code from the iPhone source, which itself is based on
the old Nokia Series 60 source.

Layout tests have been added to test the functionality and the original
code which has then been fixed to make these pass, as well as support
frameset grids.

Tests: fast/frames/flattening/frameset-flattening-advanced.html
       fast/frames/flattening/frameset-flattening-grid.html
       fast/frames/flattening/frameset-flattening-simple.html
       fast/frames/flattening/frameset-flattening-subframe-resize.html
       fast/frames/flattening/frameset-flattening-subframesets.html

* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameSetFlatteningEnabled):
* page/Settings.h:
(WebCore::Settings::frameSetFlatteningEnabled):
* rendering/RenderFrame.cpp:
(WebCore::RenderFrame::layoutWithFlattening):
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::flattenFrameSet):
(WebCore::RenderFrameSet::userResize):
* rendering/RenderFrameSet.h:

WebKit/qt:

Privately export the setFrameSetFlatteningEnabled setting for
use with the Qt DRT.

* Api/qwebpage.cpp:
(qt_drt_setFrameSetFlatteningEnabled):
(QWebPagePrivate::core):
* Api/qwebpage_p.h:

WebKitTools:

Add support for testing frame flattening with the Qt DRT

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameSetFlatteningEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Frameset flattening layout test, plus expected result for Qt.

* fast/frames/flattening/frameset-flattening-advanced.html: Added.
* fast/frames/flattening/frameset-flattening-grid.html: Added.
* fast/frames/flattening/frameset-flattening-simple.html: Added.
* fast/frames/flattening/frameset-flattening-subframe-resize.html: Added.
* fast/frames/flattening/frameset-flattening-subframesets.html: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProvided a way in check-webkit-style to specify filter rules
cjerdonek@webkit.org [Fri, 5 Feb 2010 20:44:45 +0000 (20:44 +0000)]
Provided a way in check-webkit-style to specify filter rules
on a per file or folder basis, via a configuration variable.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=33684

* Scripts/webkitpy/style/checker.py:
  - Added _PATH_RULES_SPECIFIER configuration variable.
  - In ProcessorOptions class--
    - Changed the CategoryFilter attribute to FilterConfiguration.
    - Added path parameter to is_reportable().
  - Renamed ArgumentDefaults filter_rules attribute to
    base_filter_rules.
  - Updated ArgumentPrinter class.
  - Added filter rule validation to ArgumentParser (instead of
    in CategoryFilter constructor).

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated unit tests as necessary.
  - Added unit tests for PATH_RULES_SPECIFIER.

* Scripts/webkitpy/style/error_handlers.py:
  - Updated DefaultStyleErrorHandler to use file path when
    calling is_reportable().

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated unit tests as necessary.

* Scripts/webkitpy/style/filter.py:
  - Marked CategoryFilter internal with an underscore.
  - Removed argument validation from CategoryFilter.
  - Added FilterConfiguration class.

* Scripts/webkitpy/style/filter_unittest.py:
  - Updated CategoryFilterTest class.
  - Added FilterConfigurationTest unit tests.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed _is_test_filename() code.
  - Removed hard-coded path checks from check_include_line().

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed three unit tests related to exempted files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 5 Feb 2010 19:50:24 +0000 (19:50 +0000)]
2010-02-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Changing display type of parent of input on focus causes input field to not receive key events
        https://bugs.webkit.org/show_bug.cgi?id=34620
        <rdar://problem/7584572>

        When layout affects a text input, the RenderTextControl gets destroyed and
        recreated, which in turn makes a new innerTextElement. However, if the text field was
        focused, the VisibleSelection is left pointing to the old innerTextElement, so text
        input no longer works.

        The fix is to call updateFocusAppearanceSoon() when attaching the input element,
        which will update the selection if necessary.

        Test: fast/forms/restore-selection-after-layout.html

        * dom/Document.h: Add a paramter to updateFocusAppearanceSoon() and a member variable,
        m_updateFocusAppearanceRestoresSelection, to store its value until the timer fires.
        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_updateFocusAppearanceRestoresSelection
        (WebCore::Document::updateFocusAppearanceSoon): New restorePreviousSelection parameter.
        (WebCore::Document::updateFocusAppearanceTimerFired): Pass m_updateFocusAppearanceRestoresSelection down.
        * dom/Element.cpp:
        (WebCore::Element::attach): Call updateFocusAppearanceSoon() with false.
        * dom/Element.h: The updateFocusAppearanceSoonAfterAttach() was undefined.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::attach): Call document()->updateFocusAppearanceSoon() with true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Apply the command line options as settings to the graphics system.
kenneth@webkit.org [Fri, 5 Feb 2010 19:46:19 +0000 (19:46 +0000)]
[Qt] Apply the command line options as settings to the graphics system.

Reviewed by Ariya Hidayat.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
* QtLauncher/webview.h:
(WebViewGraphicsBased::setItemCacheMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 5 Feb 2010 19:30:19 +0000 (19:30 +0000)]
2010-02-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: simplify cookies view, introduce DataGrid::autoSizeColumns.

        https://bugs.webkit.org/show_bug.cgi?id=34646

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.show):
        (WebInspector.CookieItemsView.prototype._update):
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
        (WebInspector.CookieItemsView.prototype._createDataGrid):
        (WebInspector.CookieItemsView.prototype._populateDataGrid.expiresCompare):
        (WebInspector.CookieItemsView.prototype._populateDataGrid):
        (WebInspector.CookieItemsView.prototype._createSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._populateSimpleDataGrid):
        (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
        (WebInspector.CookieItemsView.prototype._refreshButtonClicked):
        * inspector/front-end/DOMStorageItemsView.js:
        (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
        (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        (WebInspector.DataGrid.prototype.autoSizeColumns):
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryFinished):
        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype._queryFinished):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.dataGridForResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 5 Feb 2010 19:22:43 +0000 (19:22 +0000)]
2010-02-04  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: group cookies by frame, show total
        cookies size, allow sorting cookie table.

        https://bugs.webkit.org/show_bug.cgi?id=34617

        * English.lproj/localizedStrings.js:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::deleteCookie):
        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype._updateWithCookies):
        (WebInspector.CookieItemsView.prototype._cookiesForDomain):
        (WebInspector.CookieItemsView.prototype.dataGridForCookies):
        (WebInspector.CookieItemsView.prototype._createNodes):
        (WebInspector.CookieItemsView.prototype._sortData.localeCompare):
        (WebInspector.CookieItemsView.prototype._sortData.numberCompare):
        (WebInspector.CookieItemsView.prototype._sortData.expiresCompare):
        (WebInspector.CookieItemsView.prototype._sortData):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.showCookies):
        (WebInspector.CookieSidebarTreeElement):
        (WebInspector.CookieSidebarTreeElement.prototype.onselect):
        (WebInspector.CookieSidebarTreeElement.prototype.get subtitle):
        (WebInspector.CookieSidebarTreeElement.prototype.set subtitle):
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Maxime Simone <simon.maxime@gmail.com>
eric@webkit.org [Fri, 5 Feb 2010 19:08:07 +0000 (19:08 +0000)]
2010-02-05  Maxime Simone  <simon.maxime@gmail.com>

        Reviewed by David Levin.

        More robust conversion from BString to String for Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        Covered by existing tests.

        * platform/text/haiku/StringHaiku.cpp: Fixed include order, Improved coversion from BString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Fri, 5 Feb 2010 18:35:12 +0000 (18:35 +0000)]
Windows build fix.

Reviewed by Adam Roben.

* WebCore.vcproj/WebCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 5 Feb 2010 18:08:53 +0000 (18:08 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.
Reviewed by Dirk Schulze.

[Qt] Modifying SVG path dumping to equal to other ports
https://bugs.webkit.org/show_bug.cgi?id=33784

WebCore:

* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::debugString): Path dumping style is aproached to Mac.

LayoutTests:

Expected files updated.

* platform/qt/svg/css/arrow-with-shadow-expected.txt:
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
* platform/qt/svg/css/clippath-with-shadow-expected.txt:
* platform/qt/svg/css/mask-with-shadow-expected.txt:
* platform/qt/svg/css/path-with-shadow-expected.txt:
* platform/qt/svg/css/stars-with-shadow-expected.txt:
* platform/qt/svg/custom/empty-mask-expected.txt:
* platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
* platform/qt/svg/custom/marker-opacity-expected.txt:
* platform/qt/svg/custom/marker-referencePoint-expected.txt:
* platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
* platform/qt/svg/custom/mask-with-default-value-expected.txt:
* platform/qt/svg/custom/relative-sized-content-expected.txt:
* platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/qt/svg/custom/transformedMaskFails-expected.txt:
* platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/qt/svg/filters/feComposite-expected.txt:
* platform/qt/svg/filters/feGaussianBlur-expected.txt:
* platform/qt/svg/filters/feMerge-expected.txt:
* platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
* platform/qt/svg/filters/feOffset-expected.txt:
* platform/qt/svg/filters/feTile-expected.txt:
* platform/qt/svg/filters/shadow-on-filter-expected.txt:
* platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
* platform/qt/svg/filters/subRegion-one-effect-expected.txt:
* platform/qt/svg/filters/subRegion-two-effects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Kwang Yul Seo <skyul@company100.net>
ggaren@apple.com [Fri, 5 Feb 2010 17:46:45 +0000 (17:46 +0000)]
2010-02-05  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Alexey Proskuryakov.

        Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
        https://bugs.webkit.org/show_bug.cgi?id=34569

        With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
        if the return value of malloc and calloc is 0.

        However, these functions can return 0 when the request size is 0.
        Libc manual says, "If size is 0, then malloc() returns either NULL,
        or a unique pointer value that can later be successfully passed to free()."
        Though malloc returns a unique pointer in most systems,
        0 can be returned in some systems. For instance, BREW's MALLOC returns 0
        when size is 0.

        If malloc or calloc returns 0 due to allocation size, increase the size
        to 1 and try again.

        * wtf/FastMalloc.cpp:
        (WTF::fastMalloc):
        (WTF::fastCalloc):
2010-02-05  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=34317

        * GNUmakefile.am:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::doGstInit):
        * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gtk/WebKitWebSourceGStreamer.h:
        Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
        This makes sure that referer, cookies, authentication information
        and all kinds of other context are passed to GStreamer for websites
        like Vimeo or YouTube.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Sebastian Dröge <sebastian.droege@collabora.co.uk>
kov@webkit.org [Fri, 5 Feb 2010 17:24:58 +0000 (17:24 +0000)]
2010-02-05  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Reviewed by Gustavo Noronha.

        Add a GStreamer HTTP/HTTPS source, using WebKit infrastructure
        https://bugs.webkit.org/show_bug.cgi?id=34317

        * GNUmakefile.am:
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::doGstInit):
        * platform/graphics/gtk/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gtk/WebKitWebSourceGStreamer.h:
        Add a GStreamer HTTP/HTTPS source, using the WebKit infrastructure.
        This makes sure that referer, cookies, authentication information
        and all kinds of other context are passed to GStreamer for websites
        like Vimeo or YouTube.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix build on Windows
vestbo@webkit.org [Fri, 5 Feb 2010 16:41:10 +0000 (16:41 +0000)]
[Qt] Fix build on Windows

Reviewed by Kenneth Rohde Christiansen.

DerivedSources for our API headers failed on Windows,
due to Windows not accepting ; as a command separator,
not needing quotes for echo, and needing < and > escaped.

We now detect Windows and set these quote markers and
escape markers accordingly, as well as use && for separating
individual commands.

* Api/DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 5 Feb 2010 16:28:39 +0000 (16:28 +0000)]
2010-02-05  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Clean up code for getting a v8::FunctionTemplate.

        https://bugs.webkit.org/show_bug.cgi?id=34606

        * bindings/scripts/CodeGeneratorV8.pm: Making GetTemplate() public
        * bindings/v8/V8Binding.cpp:
        (WebCore::configureTemplate):
        * bindings/v8/V8DOMWrapper.cpp: Remove getTemplate(), use V8ClassIndex::getTemplate() instead.
        (WebCore::V8DOMWrapper::getConstructor):
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::lookupDOMWrapper):
        * bindings/v8/V8Index.cpp: Remove duplicate caching of FunctionTemplates.
        (WebCore::V8ClassIndex::getTemplate):
        * bindings/v8/V8Index.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::toV8):
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::v8HTMLAudioElementConstructorCallback):
        (WebCore::V8HTMLAudioElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::v8HTMLImageElementConstructorCallback):
        (WebCore::V8HTMLImageElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLImageElementConstructor.h:
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::v8HTMLOptionElementConstructorCallback):
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate):
        * bindings/v8/custom/V8HTMLOptionElementConstructor.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::createInjectedScriptHostV8Wrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Tor Arne Vestbø.
ossy@webkit.org [Fri, 5 Feb 2010 16:01:18 +0000 (16:01 +0000)]
Rubber-stamped by Tor Arne Vestbø.

[Qt] fast/css/dashboard-regions-attr-crash.html skipped,
because ENABLE_DASHBOARD_SUPPORT=0 is the default option.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Fri, 5 Feb 2010 15:09:17 +0000 (15:09 +0000)]
2010-02-05  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Add .gitattributes file to tell git about files with Windows linefeeds
        https://bugs.webkit.org/show_bug.cgi?id=34645

        On Windows git defaults to "true" for core.autocrlf, meaning all text
        files in the working directory are converted from CRLF to LF on checkin
        time. Some files present in the repository have been checked in with
        CRLF linefeeds and git should not try to convert them. The added
        .gitattributes file tells git to not do any CRLF conversion.

        * .gitattributes: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build break in QtWebkit on Symbian
hausmann@webkit.org [Fri, 5 Feb 2010 14:10:08 +0000 (14:10 +0000)]
[Qt] Build break in QtWebkit on Symbian
https://bugs.webkit.org/show_bug.cgi?id=34597

Patch by Siddharth Mathur <siddharth.mathur@nokia.com> on 2010-02-05
Reviewed by Ariya Hidayat.

* plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 5 Feb 2010 14:08:31 +0000 (14:08 +0000)]
2010-02-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        - Use SerializedScriptValue for passing data between injected script and
        inspector frontend.
        - Remove custom JSON implementation from the instpector utility script.
        - Make sure that only objects created in the same ScriptState can be values
        of ScriptObject/Array properties and arguments to ScriptFunctionCall. We don't
        want ScriptObjects to leak between contexts.
        - Use ScriptState of the 'this' object in ScriptFunctionCall instead of passing
        it as additional parameter.

        https://bugs.webkit.org/show_bug.cgi?id=33592

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
        * bindings/js/ScriptArray.cpp:
        (WebCore::ScriptArray::set):
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::ScriptFunctionCall):
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/js/ScriptFunctionCall.h:
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/js/ScriptValue.cpp:
        (WebCore::ScriptValue::serialize):
        (WebCore::ScriptValue::deserialize):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptArray.cpp:
        (WebCore::ScriptArray::set):
        * bindings/v8/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::ScriptFunctionCall):
        (WebCore::ScriptFunctionCall::appendArgument):
        * bindings/v8/ScriptFunctionCall.h:
        * bindings/v8/ScriptObject.cpp:
        (WebCore::ScriptObject::set):
        * bindings/v8/ScriptState.h:
        * bindings/v8/ScriptValue.cpp:
        (WebCore::ScriptValue::serialize):
        (WebCore::deserialize):
        * bindings/v8/ScriptValue.h:
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::dispatch):
        (WebCore::InjectedScript::callFrames):
        (WebCore::InjectedScript::wrapForConsole):
        (WebCore::InjectedScript::releaseWrapperObjectGroup):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::didEvaluateForTestInFrontend):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::InspectorFrontend):
        (WebCore::InspectorFrontend::newScriptArray):
        (WebCore::InspectorFrontend::newScriptObject):
        (WebCore::InspectorFrontend::populateFrontendSettings):
        (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
        (WebCore::InspectorFrontend::addConsoleMessage):
        (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::didGetResourceContent):
        (WebCore::InspectorFrontend::updateFocusedNode):
        (WebCore::InspectorFrontend::setAttachedWindow):
        (WebCore::InspectorFrontend::addRecordToTimeline):
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::addProfileHeader):
        (WebCore::InspectorFrontend::setRecordingProfile):
        (WebCore::InspectorFrontend::didGetProfileHeaders):
        (WebCore::InspectorFrontend::didGetProfile):
        (WebCore::InspectorFrontend::pausedScript):
        (WebCore::InspectorFrontend::setDocument):
        (WebCore::InspectorFrontend::setDetachedRoot):
        (WebCore::InspectorFrontend::setChildNodes):
        (WebCore::InspectorFrontend::childNodeCountUpdated):
        (WebCore::InspectorFrontend::childNodeInserted):
        (WebCore::InspectorFrontend::childNodeRemoved):
        (WebCore::InspectorFrontend::attributesUpdated):
        (WebCore::InspectorFrontend::didRemoveNode):
        (WebCore::InspectorFrontend::didGetChildNodes):
        (WebCore::InspectorFrontend::didApplyDomChange):
        (WebCore::InspectorFrontend::didGetEventListenersForNode):
        (WebCore::InspectorFrontend::didGetCookies):
        (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::selectDatabase):
        (WebCore::InspectorFrontend::didGetDatabaseTableNames):
        (WebCore::InspectorFrontend::addDOMStorage):
        (WebCore::InspectorFrontend::selectDOMStorage):
        (WebCore::InspectorFrontend::didGetDOMStorageEntries):
        (WebCore::InspectorFrontend::didSetDOMStorageItem):
        (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
        (WebCore::InspectorFrontend::updateDOMStorage):
        (WebCore::InspectorFrontend::addNodesToSearchResult):
        (WebCore::InspectorFrontend::contextMenuItemSelected):
        (WebCore::InspectorFrontend::evaluateForTestInFrontend):
        (WebCore::InspectorFrontend::callSimpleFunction):
        * inspector/InspectorFrontend.h:
        (WebCore::InspectorFrontend::scriptState):
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName.myCallback):
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/inspector.js:
        (WebInspector.pausedScript):
        (WebInspector.addConsoleMessage):

2010-02-05  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Remove unused inmport of ScriptFunctionCall.h

        https://bugs.webkit.org/show_bug.cgi?id=33592

        * Api/qwebelement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Generate convenience headers (QWebView, etc) using qmake
vestbo@webkit.org [Fri, 5 Feb 2010 13:23:15 +0000 (13:23 +0000)]
[Qt] Generate convenience headers (QWebView, etc) using qmake

Reviewed by Simon Hausmann.

In Qt this is done using syncqt, but we use a pro-file instead
that generates makefile-rules for each of the extra headers.

These extra headers are installed alongside the normal headers.

WebCore:

* WebCore.pro: Use headers.pri based on DerivedSources instead
of the one previously checked in in the source tree.

WebKit/qt:

* Api/DerivedSources.pro: Added. List of headers + pro file magic
* Api/headers.pri: Removed, list of headers is now in the above file

WebKitTools:

* Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
zoltan@webkit.org [Fri, 5 Feb 2010 12:27:35 +0000 (12:27 +0000)]
Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Patch by Kwang Yul Seo <skyul@company100.net> on 2010-02-05
Reviewed by Alexey Proskuryakov.

With USE_SYSTEM_MALLOC=1, fastMalloc and fastCalloc call CRASH()
if the return value of malloc and calloc is 0.

However, these functions can return 0 when the request size is 0.
Libc manual says, "If size is 0, then malloc() returns either NULL,
or a unique pointer value that can later be successfully passed to free()."
Though malloc returns a unique pointer in most systems,
0 can be returned in some systems. For instance, BREW's MALLOC returns 0
when size is 0.

If malloc or calloc returns 0 due to allocation size, increase the size
to 1 and try again.

* wtf/FastMalloc.cpp:
(WTF::fastMalloc):
(WTF::fastCalloc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Fri, 5 Feb 2010 12:20:15 +0000 (12:20 +0000)]
2010-02-05  Andras Becsi  <abecsi@webkit.org>

        Unreviewed typo fix.

        Fix wrong whitespace alignment introduced in r54342.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 12:05:37 +0000 (12:05 +0000)]
2010-02-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Enable JAVASCRIPT_DEBUGGER in chromium port.

        https://bugs.webkit.org/show_bug.cgi?id=34638

        * page/Console.cpp:
        * page/Console.h:
        * page/Console.idl:
2010-02-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Enable JAVASCRIPT_DEBUGGER in chromium port.

        https://bugs.webkit.org/show_bug.cgi?id=34638

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Oliver Hunt.
kenneth@webkit.org [Fri, 5 Feb 2010 11:45:55 +0000 (11:45 +0000)]
Rubberstamped by Oliver Hunt.

[Qt] Make it possible to choose whether the launcher should
use the traditional QWidget based QWebView or the newer
QGraphics based QGraphicsWebView on a QGraphicsView.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::eventFilter):
(LauncherWindow::loadStarted):
(LauncherWindow::print):
(LauncherWindow::screenshot):
(LauncherWindow::setEditable):
(LauncherWindow::setupUI):
(main):
* QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::resizeEvent):
(GraphicsWebView::mousePressEvent):
(GraphicsWebView::contextMenuEvent):
* QtLauncher/webview.h:
(WebViewTraditional::WebViewTraditional):
(GraphicsWebView::GraphicsWebView):
(WebViewGraphicsBased::setPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 10:50:42 +0000 (10:50 +0000)]
2010-02-05  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Tab width for javascript source is 8, should be 4

        https://bugs.webkit.org/show_bug.cgi?id=31248

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        * inspector/front-end/TextEditorModel.js:
        (WebInspector.TextEditorModel.prototype.set replaceTabsWithSpaces):
        (WebInspector.TextEditorModel.prototype._innerSetText):
        (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 09:37:37 +0000 (09:37 +0000)]
2010-02-05  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        send() should return false, after frame that opened a WebSokcet is detached
        https://bugs.webkit.org/show_bug.cgi?id=34630

        * websocket/tests/send-after-close-on-unload-expected.txt: Added.
        * websocket/tests/send-after-close-on-unload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-05 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 5 Feb 2010 09:23:06 +0000 (09:23 +0000)]
2010-02-05  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24872
        Add a test to make sure copying from a list and pasting into a list
        keeps the list at the same indention level rather than nesting.

        * editing/pasteboard/paste-list-002-expected.txt: Added.
        * editing/pasteboard/paste-list-002.html: Added.
2010-02-05  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24872
        When pasting a list into another list should not indent another level.
        If the cursor is at the beginning of the line, it should insert the
        list items before the current list item.  If the cursor is at the end
        of the line, it should insert the list items after the current list item.

        This matches Firefox and IE and makes the common activity of reordering a list
        work as expected.

        This also adds a small helper method (isListItem) to htmlediting.h.

        Test: editing/pasteboard/paste-list-002.html

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::insertAsListItems):
        * editing/ReplaceSelectionCommand.h:
        * editing/htmlediting.cpp:
        (WebCore::isListItem):
        (WebCore::appendedSublist):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make 'make -f Makefile.DerivedSources qmake' work
vestbo@webkit.org [Fri, 5 Feb 2010 07:45:31 +0000 (07:45 +0000)]
[Qt] Make 'make -f Makefile.DerivedSources qmake' work

Reviewed by Lars Knoll.

Previously this target ended up generating a file named
Makefile.DerivedSources.DerivedSources, and so on.

* DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Dan Bernstein.
mrowe@apple.com [Fri, 5 Feb 2010 07:34:45 +0000 (07:34 +0000)]
Rubber-stamped by Dan Bernstein.

Fix the ability to #include <WebKit/DOMFile.h>.

* MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 07:18:10 +0000 (07:18 +0000)]
2010-02-04  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Darin Fisher.

        Upstreaming gtests from chromium: UniscribeHelper and TransparencyWin
        https://bugs.webkit.org/show_bug.cgi?id=34509

        Resubmit: The previous commit (r54333) was rolled back.

        * WebKit.gyp:
        * tests/TransparencyWinTest.cpp: Added.
        (WebCore::RECTToFloatRect):
        (WebCore::drawNativeRect):
        (WebCore::getPixelAt):
        (WebCore::clearTopLayerAlphaChannel):
        (WebCore::clearTopLayerAlphaPixel):
        (WebCore::operator<<):
        (WebCore::TEST):
        * tests/UniscribeHelperTest.cpp: Added.
        (WebCore::UniscribeTest::UniscribeTest):
        (WebCore::UniscribeTest::MakeFont):
        (WebCore::UniscribeTest::SetUp):
        (WebCore::UniscribeTest::TearDown):
        (TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 06:15:22 +0000 (06:15 +0000)]
2010-02-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        should not crash when document opened websocket is unloaded
        https://bugs.webkit.org/show_bug.cgi?id=34562

        * websocket/tests/close-on-unload-and-force-gc-expected.txt: Added.
        * websocket/tests/close-on-unload-and-force-gc.html: Added.
        * websocket/tests/close-on-unload-reference-in-parent-expected.txt: Added.
        * websocket/tests/close-on-unload-reference-in-parent.html: Added.
        * websocket/tests/resources/close-on-unload-iframe-reference-in-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Remove a symbol corresponding to an inline function from the linker export
mrowe@apple.com [Fri, 5 Feb 2010 06:13:23 +0000 (06:13 +0000)]
Build fix.  Remove a symbol corresponding to an inline function from the linker export
file to prevent a weak external failure.

Reviewed by Timothy Hatcher.

JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj: Accommodate rename of script.

JavaScriptGlue:

* JavaScriptGlue.xcodeproj/project.pbxproj: Accommodate rename of script.

WebCore:

* WebCore.base.exp: Remove symbol.
* WebCore.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKit:

* WebKit.xcodeproj/project.pbxproj: Accommodate rename of script.

WebKitTools:

* Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
Teach the script how to detect weak external symbols so that these errors can be caught immediately
in the future.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 5 Feb 2010 05:59:44 +0000 (05:59 +0000)]
2010-02-04  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Shinichiro Hamaji.

        websocket/tests/close-on-unload.html failed on Mac Tiger
        https://bugs.webkit.org/show_bug.cgi?id=34563

        * platform/mac-tiger/Skipped: remove websocket/tests/close-on-unload*.html
        * websocket/tests/close-on-unload_wsh.py: use dict instead of set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 5 Feb 2010 05:33:55 +0000 (05:33 +0000)]
2010-02-04  Daniel Bates  <dbates@webkit.org>

        [Qt] Unreviewed, build fix for Qt bot.

        * runtime/JSStringBuilder.h: Changed #include <X.h> notation #include "X.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: export a header.
ggaren@apple.com [Fri, 5 Feb 2010 03:53:36 +0000 (03:53 +0000)]
Build fix: export a header.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: Added a forwarding header.
ggaren@apple.com [Fri, 5 Feb 2010 03:47:54 +0000 (03:47 +0000)]
Build fix: Added a forwarding header.

* ForwardingHeaders/runtime/WeakGCPtr.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
ggaren@apple.com [Fri, 5 Feb 2010 03:39:09 +0000 (03:39 +0000)]
WebCore: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

There were two bugs here:

1. A stale wrapper would invalidate a node's event listeners, even if
the node had a fresh wrapper keeping it alive.

The fix for this is for an event listener to keep a WeakGCPtr back-pointer
to the wrapper it expects to mark it. The wrapper destructor checks this
back-pointer, and only invalidates the event listener in the case of a match.

2. Conversely, a stale wrapper would not invalidate a node's event
listeners soon enough, if its destructor didn't have a chance to run
before an event fired on the node. (This can only happen in cases where
we've made some other error and failed to mark a wrapper that was circuitously
observable in the DOM. But we know we have edge case bugs like this, and
we don't want them to be crashes.)

The fix for this is to check the wrapper back-pointer before firing the
event listener. As long as the the wrapper back-pointer is not null,
it's safe to fire the listener.

* ForwardingHeaders/runtime/WeakGCPtr.h: Added. Appease build gods.

* bindings/js/JSAbstractWorkerCustom.cpp:
(WebCore::JSAbstractWorker::addEventListener):
(WebCore::JSAbstractWorker::removeEventListener):
* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::JSDOMApplicationCache::addEventListener):
(WebCore::JSDOMApplicationCache::removeEventListener):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::markChildren):
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::initializeJSFunction):
(WebCore::JSEventListener::invalidateJSFunction):
* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
(WebCore::JSEventListener::wrapper):
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
(WebCore::createJSAttributeEventListener): Implemented the back-pointer
described above. Refactored the jsFunction() accessor to return 0 if
the wrapper back-pointer is 0.

* bindings/js/JSEventSourceCustom.cpp:
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):
* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
* bindings/js/JSLazyEventListener.h:
(WebCore::JSLazyEventListener::create):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::markChildren):
(WebCore::JSMessagePort::addEventListener):
(WebCore::JSMessagePort::removeEventListener):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::addEventListener):
(WebCore::JSNode::removeEventListener):
(WebCore::JSNode::markChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::addEventListener):
(WebCore::JSSVGElementInstance::removeEventListener):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocket::addEventListener):
(WebCore::JSWebSocket::removeEventListener):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::markChildren):
(WebCore::JSWorkerContext::addEventListener):
(WebCore::JSWorkerContext::removeEventListener):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::markChildren):
(WebCore::JSXMLHttpRequest::addEventListener):
(WebCore::JSXMLHttpRequest::removeEventListener):
* bindings/js/JSXMLHttpRequestUploadCustom.cpp:
(WebCore::JSXMLHttpRequestUpload::markChildren):
(WebCore::JSXMLHttpRequestUpload::addEventListener):
(WebCore::JSXMLHttpRequestUpload::removeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.

* bindings/js/ScriptEventListener.cpp:
(WebCore::createAttributeEventListener): Updated to pass a wrapper
to the JSEventListener constructor.
(WebCore::getEventListenerHandlerBody): Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class.

* bindings/scripts/CodeGeneratorJS.pm: Updated for the fact that jsFunction()
is no longer a virtual accessor on the EventHandler base class. Added a "JS"
to invalidateEventListeners and markEventListeners to clarify that these
actions are for JS event listeners only. Added a wrapper parameter to
invalidateEventListeners for the back-pointer check explained above.

* dom/EventListener.h:
(WebCore::EventListener::invalidateJSFunction): ditto

* dom/EventTarget.h:
(WebCore::EventTarget::markJSEventListeners):
(WebCore::EventTarget::invalidateJSEventListeners): ditto

LayoutTests: REGRESSION (r52082): Missing event handlers on JQuery demo page (33383)
https://bugs.webkit.org/show_bug.cgi?id=33383
<rdar://problem/7559449>

Reviewed by Alexey Proskuryakov and Darin Adler.

* fast/events/bogus-event-listener-invalidation-expected.txt: Added.
* fast/events/bogus-event-listener-invalidation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 5 Feb 2010 03:05:15 +0000 (03:05 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 5 Feb 2010 03:03:44 +0000 (03:03 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Tony Chang <tony@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 02:38:21 +0000 (02:38 +0000)]
2010-02-04  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25002
        When inserting a new paragraph, avoid nesting empty divs.  When
        pasting near the end of a paragraph, this prevents each paste
        command for getting nested one level deeper.

        Three paste tests have been rebaselined since this causes the pasted
        content to be outside the last div instead of inside.  E.g.,
        <div>foo<div>bar</div>[pasted content]</div> is now
        <div>foo<div>bar</div></div><div>[pasted content]</div>

        The new test verifies this behavior.

        * editing/inserting/paragraph-outside-nested-divs-expected.txt: Added.
        * editing/inserting/paragraph-outside-nested-divs.html: Added.
        * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-017-expected.txt:
2010-02-04  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25002
        When inserting a new paragraph, avoid nesting empty divs.  When
        pasting near the end of a paragraph, this prevents each paste
        command for getting nested one level deeper.

        Test: editing/inserting/paragraph-outside-nested-divs.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::highestVisuallyEquivalentDiv):
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
barraclough@apple.com [Fri, 5 Feb 2010 02:31:35 +0000 (02:31 +0000)]
Add a JSStringBuilder class (similar-to, and derived-from StringBuilder) to
construct JSStrings, throwing a JS exception should we run out of memory whilst
allocating storage for the string.

Reviewed by Oliver Hunt.

Similarly, add jsMakeNontrivialString methods to use in cases where previously
we were calling makeString & passing the result to jsNontrivialString.  Again,
these new methods throw if we hit an out of memory condition.

Move throwOutOfMemoryError into ExceptionHelpers, to make it more widely available.

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/DateConstructor.cpp:
(JSC::callDate):
* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToGMTString):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
* runtime/ExceptionHelpers.h:
* runtime/JSStringBuilder.h: Added.
(JSC::JSStringBuilder::releaseJSString):
(JSC::jsMakeNontrivialString):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToPrecision):
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* runtime/Operations.cpp:
* runtime/Operations.h:
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringBuilder.h:
(JSC::StringBuilder::append):
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
dumi@chromium.org [Fri, 5 Feb 2010 02:09:21 +0000 (02:09 +0000)]
WebCore: 1. Fix a bug in SQLiteTransaction: do not assume that COMMIT always
succeeds.
2. Jump straight to the transaction error callback when a
statement fails in a way that makes sqlite automatically rollback
the transaction.
3. Fix the code that handles the "quota reached" failure, as it is
one of the failures that lead to an automatic transaction
rollback.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34280

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::isAutoCommitOn):
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::begin):
(WebCore::SQLiteTransaction::commit):
(WebCore::SQLiteTransaction::rollback):
(WebCore::SQLiteTransaction::transactionWasRolledBackBySqlite):
* platform/sql/SQLiteTransaction.h:
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):

LayoutTests: 1. Enhance quota-tracking.html: if sqlite automatically rolls back
a transaction because of a statement failure, make sure the rest
of the statements in the transaction are not executed.
2. Fix the expectations for quota-tracking.html. Sqlite cannot
recover from reaching a DB's max size.

Reviewed by Eric Seidel.

* storage/quota-tracking-expected.txt:
* storage/quota-tracking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, rollback.
pkasting@chromium.org [Fri, 5 Feb 2010 01:50:59 +0000 (01:50 +0000)]
Not reviewed, rollback.

Rollback r54387, it doesn't fix builds and Chromium doesn't want this behavior.

* platform/chromium/ScrollbarThemeChromiumMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Fri, 5 Feb 2010 01:41:34 +0000 (01:41 +0000)]
Windows build fix.

* wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 5 Feb 2010 01:01:45 +0000 (01:01 +0000)]
2010-02-04  Darin Adler  <darin@apple.com>

        Reviewed by David Levin.

        Make MathExtras.h compatible with <cmath>
        https://bugs.webkit.org/show_bug.cgi?id=34618

        * wtf/MathExtras.h: Include <cmath> instead of <math.h>.
        Use "using" as we do elsewhere in WTF for the four functions from <cmath>
        we want to use without the prefix. Later we could consider making the std
        explicit at call sites instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 5 Feb 2010 00:52:25 +0000 (00:52 +0000)]
2010-02-04  Stephen White  <senorblanco@chromium.org>

        Unreviewed, build fix.

        Fix for Chromium/Mac after palindromic scrollbar change (54345).

        Covered by many layout tests.

        * platform/chromium/ScrollbarThemeChromiumMac.h:
        (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Clemmitt Sigler <cmsigler@gmail.com>
eric@webkit.org [Fri, 5 Feb 2010 00:35:57 +0000 (00:35 +0000)]
2010-02-04  Clemmitt Sigler  <cmsigler@gmail.com>

        Reviewed by David Levin.

        WebKitGTK doesn't build GtkLauncher when --enable-mathml is specified.
        Updated WebCore/GNUmakefile.am to include needed files in build.

        https://bugs.webkit.org/show_bug.cgi?id=34387

        No new tests.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Fri, 5 Feb 2010 00:19:45 +0000 (00:19 +0000)]
2010-02-04  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by David Levin.

        Misc coding style fixes in Haiku port code.
        https://bugs.webkit.org/show_bug.cgi?id=34527

        No tests needed.

        * platform/haiku/ContextMenuItemHaiku.cpp: Trailing white space, NULL -> 0
        * platform/haiku/DragImageHaiku.cpp: Trailing white space.
        * platform/haiku/FileChooserHaiku.cpp: Sorted headers.
        * platform/haiku/LocalizedStringsHaiku.cpp: Needed to include NotImplemented.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed typo fix for r54379.
ossy@webkit.org [Thu, 4 Feb 2010 23:50:05 +0000 (23:50 +0000)]
Unreviewed typo fix for r54379.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Thu, 4 Feb 2010 23:43:20 +0000 (23:43 +0000)]
2010-02-04  Drew Wilson  <atwilson@chromium.org>

        Reviewed by David Levin.

        WorkerContext.close() does not work in the chromium port
        https://bugs.webkit.org/show_bug.cgi?id=34551

        Test: Adding new downstream test.

        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::workerContextClosedTask):
        Now shuts down the worker thread when WorkerContext::close() is invoked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoediting/pasteboard/drop-inputtext-acquires-style.html
ossy@webkit.org [Thu, 4 Feb 2010 23:36:32 +0000 (23:36 +0000)]
editing/pasteboard/drop-inputtext-acquires-style.html
introduced in r54368 skipped because of missing DnD support.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 4 Feb 2010 23:33:55 +0000 (23:33 +0000)]
2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add and cleanup return values of signals in view and frame
        https://bugs.webkit.org/show_bug.cgi?id=33484

        Add missing and cleanup return values of web frame and web view signals.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed crash on QT introduced with the fix for
enrica@apple.com [Thu, 4 Feb 2010 23:30:35 +0000 (23:30 +0000)]
Fixed crash on QT introduced with the fix for
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Csaba Osztrogonac.

The test has been added with the original patch.

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added missing allocation of m_writeData.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
alice.liu@apple.com [Thu, 4 Feb 2010 23:29:19 +0000 (23:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>

Reviewed by Jon Honeycutt.

* AccessibleBase.cpp:
(AccessibleBase::accSelect):
- Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
  aren't beneath listboxes or menupopups.  This was too restrictive since
  any element can be selectable.
- Correct the misinterpretation of MSDN's stipulation of situations involving
  adding, removing, and extending selection on single-select elements

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Christian Dywan <christian@twotasts.de>
christian@webkit.org [Thu, 4 Feb 2010 22:51:12 +0000 (22:51 +0000)]
2010-02-04  Christian Dywan  <christian@twotasts.de>

        Reviewed by Xan Lopez.

        Require either libsoup 2.28.2 or 2.29.90.

        * configure.ac:

2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Xan Lopez.

        Conditionalize third party cookie policy for libsoup 2.29.90.

        * platform/network/soup/CookieJarSoup.cpp:
        (WebCore::setCookies):
        * platform/network/soup/DNSSoup.cpp:
        (WebCore::prefetchDNS):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::startHttp):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 4 Feb 2010 22:50:59 +0000 (22:50 +0000)]
2010-02-04  Christian Dywan  <christian@twotoasts.de>

        Rubber-stamped by Gustavo Noronha Silva.

        Add ENABLE(VIDEO) guards around freeOwnedGPtr<GstElement> implementation.

        * platform/gtk/GOwnPtrGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrect a mistake in ChangeLog entry.
ap@apple.com [Thu, 4 Feb 2010 22:35:08 +0000 (22:35 +0000)]
Correct a mistake in ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 4 Feb 2010 22:12:56 +0000 (22:12 +0000)]
    Reviewed by Darin Adler.

        Assertion failure in CheckedRadioButtons::removeButton when using jQuery 1.4.1
        https://bugs.webkit.org/show_bug.cgi?id=34520

        Test: fast/dom/HTMLInputElement/cloned-input-checked-state.html

        * dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Copy non-attribute
        properties before attributes. Otherwise, copying "checked" property would make the cloned
        node checked, unchecking original (they share a name, and are thus in the same radio group).
        We do want the original to be unchecked, but we also want to know its original state in
        HTMLInputElement::copyNonAttributeProperties().

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties):
        Use setChecked instead of plain assignment to prevent m_checked getting out of sync with
        checkedRadioButtons. Also, copy field related to default checked state, so that m_checked
        won't be overridden when copying attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix after addition of Clipboard::writePlainText method.
kevino@webkit.org [Thu, 4 Feb 2010 22:12:02 +0000 (22:12 +0000)]
[wx] Build fix after addition of Clipboard::writePlainText method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoProperly handle margin settings when printing Plugins in WinCairo.
bfulgham@webkit.org [Thu, 4 Feb 2010 22:10:24 +0000 (22:10 +0000)]
Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::spoolPage): Adjust the GraphicsContext passed to the
  paintContents method so that the World Transform is properly
  positioned to account for margin settings at the time that
  PluginViewWin.cpp processes the drawing operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate auto-version.sh to better handle major version numbers with fewer than three...
mrowe@apple.com [Thu, 4 Feb 2010 22:07:14 +0000 (22:07 +0000)]
Update auto-version.sh to better handle major version numbers with fewer than three digits,
and the case when WEBKITLIBRARIESDIR is not set.

Reviewed by Steve Falkenburg.

* win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Dragging plain text into a styled text region does not acquire the correc...
enrica@apple.com [Thu, 4 Feb 2010 21:50:23 +0000 (21:50 +0000)]
REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info.
<rdar://problem/7595685>
https://bugs.webkit.org/show_bug.cgi?id=34609

Reviewed by Oliver Hunt.

WebCore:

Test: editing/pasteboard/drop-inputtext-acquires-style.html

The dragging code did not distinguish the case of dragging the content of an input control
as a special case. The markup placed in the pasteboard included the style information.
I've modified the Clipboard class interface adding a new method writePlainText to match the
behavior of the copy and cut commands and modified the drag code to detect the special case.
I've modified all the platform specific implementations of the Clipboard class.

* dom/Clipboard.h: Added writePlainText pure virtual function.
* editing/Editor.cpp:
(WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
(WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
* editing/htmlediting.cpp:
(WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
in Editor.cpp
* editing/htmlediting.h:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
* platform/Pasteboard.h:
* platform/android/ClipboardAndroid.cpp:
(WebCore::ClipboardAndroid::writePlainText): Added.
* platform/android/ClipboardAndroid.h:
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writePlainText): Added.
* platform/chromium/ClipboardChromium.h:
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writePlainText): Added.
* platform/gtk/ClipboardGtk.h:
* platform/haiku/ClipboardHaiku.cpp:
(WebCore::ClipboardHaiku::writePlainText): Added.
* platform/haiku/ClipboardHaiku.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writePlainText): Added.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writePlainText): Added helper function.
* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writePlainText): Added.
* platform/qt/ClipboardQt.h:
* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writePlainText): Added.
* platform/win/ClipboardWin.h:

LayoutTests:

* editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
* editing/pasteboard/drop-inputtext-acquires-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=34611
sullivan@apple.com [Thu, 4 Feb 2010 21:45:26 +0000 (21:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=34611
WebLocalizedString() could use an assertion that it is being called on the main thread

Reviewed by Tim Hatcher.

WebKit:

* WebKit.xcodeproj/project.pbxproj:
Updated for renamed file (WebLocalizableStrings.m -> WebLocalizableStrings.mm)

WebKit/mac:

* Misc/WebLocalizableStrings.m: Removed.
* Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
Renamed to use .mm extension so it can include a C++ header.
(WebLocalizedString):
Added an assertion that this is being called on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-02-04 Steve Block <steveblock@google.com>
eric@webkit.org [Thu, 4 Feb 2010 21:19:20 +0000 (21:19 +0000)]
2010-02-04  Steve Block  <steveblock@google.com>

        Reviewed by Nate Chapin.

        Fix bug in V8 convertNPVariantToJValue when converting float and double types
        https://bugs.webkit.org/show_bug.cgi?id=34593

        No new tests, build fix only.

        * bridge/jni/v8/JNIUtilityPrivate.cpp: Modified.
        (JSC::Bindings::convertNPVariantToJValue): Modified. Use correct members of 'result' enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54366 268f45cc-cd09-0410-ab3c-d52691b4dbfc