WebKit-https.git
9 years agoRemove an assertion that Windows was hitting on launch.
jberlin@webkit.org [Tue, 3 May 2011 02:00:32 +0000 (02:00 +0000)]
Remove an assertion that Windows was hitting on launch.

Rubber-stamped by Oliver Hunt.

* runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
* runtime/Structure.h:
(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Tue, 3 May 2011 01:51:28 +0000 (01:51 +0000)]
2011-05-02  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: adding and removing values
        https://bugs.webkit.org/show_bug.cgi?id=59953

        * storage/indexeddb/mozilla/object-store-remove-values-expected.txt: Added.
        * storage/indexeddb/mozilla/object-store-remove-values.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 May 2011 01:48:32 +0000 (01:48 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        The web process locks up when the plug-in process crashes
        https://bugs.webkit.org/show_bug.cgi?id=59999
        <rdar://problem/8889303>

        Add a hash map from plug-in paths to CoreIPC connections to PluginProcessConnectionManager.
        Add PluginProcessConnectionManager::pluginProcessCrashed and make it look up the corresponding
        CoreIPC connection and call postConnectionDidCloseOnConnectionWorkQueue on it.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
        * Platform/CoreIPC/Connection.h:
        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
        (WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
        (WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
        * WebProcess/Plugins/PluginProcessConnectionManager.h:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::pluginProcessCrashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 3 May 2011 01:46:46 +0000 (01:46 +0000)]
2011-05-02  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by James Robinson.

        REGRESSION(r84672): showTree doesn't work for input/textarea elements
        https://bugs.webkit.org/show_bug.cgi?id=60001

        When shadow is null, try retrieving the inner element of a render text control.

        * dom/Node.cpp:
        (WebCore::traverseTreeAndMark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
andersca@apple.com [Tue, 3 May 2011 01:34:51 +0000 (01:34 +0000)]
Try to fix Windows build.

* Scripts/webkit2/messages.py:
* Scripts/webkit2/messages_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 May 2011 01:19:07 +0000 (01:19 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Dispatch the PluginProcessCrashed on the connection work queue
        https://bugs.webkit.org/show_bug.cgi?id=59996

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initialize):
        Add the web process as a queue client.

        (WebKit::WebProcess::terminate):
        Remove the web process as a queue client.

        (WebKit::WebProcess::willProcessMessageOnClientRunLoop):
        Try calling willProcessWebProcessMessageOnClientRunLoop.

        * WebProcess/WebProcess.messages.in:
        Add the DispatchOnConnectionQueue attribute to PluginProcessCrashed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 May 2011 01:12:40 +0000 (01:12 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send a PluginProcessCrashed message to all web processes when a plug-in crashes
        https://bugs.webkit.org/show_bug.cgi?id=59994

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::didClose):
        Iterate over all contexts and send PluginProcessCrashed to all web processes in each context.

        (WebKit::PluginProcessProxy::didFinishLaunching):
        Call setShouldCloseConnectionOnMachExceptions on the CoreIPC connection.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::pluginProcessCrashed):
        Add empty stub.

        * WebProcess/WebProcess.messages.in:
        Add message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2
mrowe@apple.com [Tue, 3 May 2011 01:04:10 +0000 (01:04 +0000)]
<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2

Reviewed by Geoff Garen.

* Configurations/CompilerVersion.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 May 2011 01:02:42 +0000 (01:02 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Plug-in not completely repainted after a crash
        https://bugs.webkit.org/show_bug.cgi?id=59991

        Call Widget::invalidate().

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::pluginProcessCrashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 3 May 2011 00:53:03 +0000 (00:53 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Make PluginProcessConnectionManager a member of WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=59989

        * WebProcess/Plugins/PluginProcessConnectionManager.cpp:
        * WebProcess/Plugins/PluginProcessConnectionManager.h:
        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::initialize):
        * WebProcess/WebProcess.h:
        (WebKit::WebProcess::pluginProcessConnectionManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 00:43:32 +0000 (00:43 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Expectation for new test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item...
mrowe@apple.com [Tue, 3 May 2011 00:36:17 +0000 (00:36 +0000)]
<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item index when URLs are filtered from back/forward list

Reviewed by Brady Eidson.

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation): We need to update the current index to account for filtered items
for all items before the current item in the array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Tue, 3 May 2011 00:28:40 +0000 (00:28 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoARMv7 build fix.
barraclough@apple.com [Tue, 3 May 2011 00:24:22 +0000 (00:24 +0000)]
ARMv7 build fix.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 3 May 2011 00:20:46 +0000 (00:20 +0000)]
2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        Respect fixed text-indent on ::-webkit-input-placeholder
        https://bugs.webkit.org/show_bug.cgi?id=59825

        Placeholder text does not appear in the render tree
        dumps, so this is a pixel test for the position of
        the placeholder affected by text-indent.

        * fast/forms/input-placeholder-text-indent.html: Added.
        * platform/mac/fast/forms/input-placeholder-text-indent-expected.png: Added.
        * platform/mac/fast/forms/input-placeholder-text-indent-expected.txt: Added.

2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by David Kilzer.

        Respect fixed text-indent on ::-webkit-input-placeholder
        https://bugs.webkit.org/show_bug.cgi?id=59825

        Test: fast/forms/input-placeholder-text-indent.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::paintPlaceholder): indent by
        a fixed text-indent size specified on the placeholder style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Eric Uhrhane <ericu@chromium.org>
ericu@chromium.org [Tue, 3 May 2011 00:10:45 +0000 (00:10 +0000)]
2011-05-02  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Eric Seidel.

        Some FileWriter progress events should be queued
        https://bugs.webkit.org/show_bug.cgi?id=50846

        * fileapi/FileWriter.cpp:
        * fileapi/FileWriter.h:
        Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
2011-05-02  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Eric Seidel.

        Some FileWriter progress events should be queued
        https://bugs.webkit.org/show_bug.cgi?id=50846

        * fast/filesystem/resources/file-writer-events.js:
        (onWrite): Expect readyState at onwrite to be DONE now, not WRITING.
        * fast/filesystem/resources/file-writer-utils.js:
        Switch to using onwrite, now that it works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 2 May 2011 23:51:07 +0000 (23:51 +0000)]
2011-05-02  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: cursor mutation in object store
        https://bugs.webkit.org/show_bug.cgi?id=59933

        This is a test case *adapted* from a test in Mozilla's IndexedDB
        test suite. The original test checked cursor mutation while iterating
        an index cursor (tracked as bug 59822). This test checks whether the
        cursor mutation is successfully recognized while iterating a straight
        objectstore cursor. Specifically, it deletes a record that's already
        been iterated, then adds a record to the objectstore during iteration,
        then checks that no records were skipped and that the added record is
        eventually found during iteration.

        * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt: Added.
        * storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Mon, 2 May 2011 23:43:37 +0000 (23:43 +0000)]
2011-05-02  Jia Pu  <jpu@apple.com>

        Reviewed by Alexey Proskuryakov.

        [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
        https://bugs.webkit.org/show_bug.cgi?id=59836
        <rdar://problem/9275983>

        * platform/DefaultLocalizationStrategy.cpp:
        (WebCore::truncatedStringForLookupMenuItem):
        (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
oliver@apple.com [Mon, 2 May 2011 23:42:38 +0000 (23:42 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
beidson@apple.com [Mon, 2 May 2011 23:41:47 +0000 (23:41 +0000)]
<rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
In Aperture, a WebView might be dealloc'ed before it finishes loading.

Reviewed by Anders Carlsson.

../WebCore:

* WebCore.exp.in:
* platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
* platform/RuntimeApplicationChecks.h:

../WebKit/mac:

* WebView/WebView.mm:
(needsSelfRetainWhileLoadingQuirk):
(-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
(-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
(-[WebView _didFailLoadWithError:forFrame:]): Ditto.
(-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 23:40:31 +0000 (23:40 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add runtests_unittest.py
        https://bugs.webkit.org/show_bug.cgi?id=59955

        I forgot to add this file in a previous patch.

        * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Qt specific expected result after r85499.
ossy@webkit.org [Mon, 2 May 2011 23:28:00 +0000 (23:28 +0000)]
Update Qt specific expected result after r85499.

* platform/qt/fast/replaced/table-percent-height-expected.png:
* platform/qt/fast/replaced/table-percent-height-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 23:22:53 +0000 (23:22 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectation for new test.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Mon, 2 May 2011 23:19:36 +0000 (23:19 +0000)]
2011-05-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        crash in JSC::RegExp::match
        https://bugs.webkit.org/show_bug.cgi?id=58922

        New tests to check for proper clearing and chaining of backtrack
        data labels.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:
2011-05-02  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        crash in JSC::RegExp::match
        https://bugs.webkit.org/show_bug.cgi?id=58922

        Cleared chained backtrack data label when linking label even if that
        label doesn't chain itself.  This is needed so that subsequent
        backtrack data labels point to the next outer paren and not within
        the current paren.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 2 May 2011 23:18:32 +0000 (23:18 +0000)]
2011-05-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Avoid wasted cycles updating paths when popping the context stack
        https://bugs.webkit.org/show_bug.cgi?id=59967

        CanvasRenderingContext2D has to map the current path through
        transforms whenever the context stack is popped, which creates
        a lot of platform path objects. Avoid extra work here when the
        path is empty, or when the transform is identity.

        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 2 May 2011 23:13:25 +0000 (23:13 +0000)]
2011-05-02  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, rebaseline small scrollbar image differences after r85527
        https://bugs.webkit.org/show_bug.cgi?id=58907

        This could be tickling the same bug that is showing up in bug 58587.

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
        * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
        * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
        * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 23:12:37 +0000 (23:12 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Fix Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 23:05:51 +0000 (23:05 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Change the testing EWS to log failures explicitly to avoid an infinite loop.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 23:04:06 +0000 (23:04 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Fix Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoText does not split on white space when typing to the edge of window.
enrica@apple.com [Mon, 2 May 2011 22:46:06 +0000 (22:46 +0000)]
Text does not split on white space when typing to the edge of window.
https://bugs.webkit.org/show_bug.cgi?id=59968
<rdar://problem/9112683>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: editing/inserting/typing-at-end-of-line.html

This is a regression introduced when we converted the line box tree to
floating point in r78846. In findNextLineBreak, there was still one place where
the character width was treated as int and truncated and we were inconsistent
in the way we treated a character that did not fit entirely in the line.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

* editing/inserting/typing-at-end-of-line.html: Added.
* platform/mac/editing/inserting/typing-at-end-of-line-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 22:40:51 +0000 (22:40 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Test expectations for Chromium Mac port.

        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTiny bit of heap cleanup.
ggaren@apple.com [Mon, 2 May 2011 22:38:06 +0000 (22:38 +0000)]
Tiny bit of heap cleanup.

Reviewed by Oliver Hunt.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::contains): Tightened up an assertion and a comment.

* heap/MarkedSpace.h:
(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Moved inlines out of the class
definition, for better clarity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 2 May 2011 22:37:42 +0000 (22:37 +0000)]
2011-05-02  Tony Chang  <tony@chromium.org>

        Remove unused files.

        * platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed. This file differs from
            the value in the png file, but I assume that the png is correct (more recently generated).
        * platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Removed.
        * platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Removed.
        * platform/mac/fast/table/multiple-captions-display-expected.checksum: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 2 May 2011 22:30:32 +0000 (22:30 +0000)]
2011-05-02  Adrienne Walker  <enne@google.com>

        Unreviewed, fix misspelled contributor name.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Qt specific expected result after r85499.
ossy@webkit.org [Mon, 2 May 2011 22:23:55 +0000 (22:23 +0000)]
Update Qt specific expected result after r85499.

* platform/qt/fast/replaced/table-percent-height-expected.png:
* platform/qt/fast/replaced/table-percent-height-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Mon, 2 May 2011 22:20:21 +0000 (22:20 +0000)]
2011-05-02  Chang Shu  <cshu@webkit.org>

        Reviewed by Martin Robinson.

        [GTK][Qt] fast/events/keydown-1.html fails
        https://bugs.webkit.org/show_bug.cgi?id=59586

        Replace mac-specific keys with cross-platform keys to make the test
        pass on GTK and Qt platforms.

        * fast/events/keydown-1.html:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-27 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 2 May 2011 22:13:38 +0000 (22:13 +0000)]
2011-04-27  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        Add test for multiple invalidations of the same size.
        https://bugs.webkit.org/show_bug.cgi?id=58907

        This tests a bug in Chromium where canvas state was not being properly
        reset between draw calls and a cached canvas of the same size was
        being used to paint into that retained incorrect state.

        * compositing/repaint/same-size-invalidation-expected.txt: Added.
        * compositing/repaint/same-size-invalidation.html: Added.
        * platform/chromium-gpu/compositing/repaint/same-size-invalidation-expected.png: Added.
2011-04-19  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
        https://bugs.webkit.org/show_bug.cgi?id=58907

        Additionally, move the context save/restore logic to a place where it
        will reset the translation added in LayerTilerChromium.

        Test: compositing/repaint/same-size-invalidation.html

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerPainter::paint):
        * platform/graphics/chromium/PlatformCanvas.cpp:
        (WebCore::PlatformCanvas::resize):
        (WebCore::PlatformCanvas::Painter::Painter):
        (WebCore::PlatformCanvas::Painter::~Painter):
        * platform/graphics/chromium/PlatformCanvas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable strict OwnPtr for Qt
ossy@webkit.org [Mon, 2 May 2011 22:04:57 +0000 (22:04 +0000)]
Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

Unreviewed buildfix after r85343.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 21:55:23 +0000 (21:55 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Add test expectations for SVG changes.

        * platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
        * platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
        * platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
        * platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
        * platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
        * platform/chromium-mac-leopard/editing/style/5046875-1-expected.png:
        * platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
        * platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
        * platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
        * platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
        * platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png:
        * platform/chromium-mac/editing/selection/3690703-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/3690703-expected.png: Added.
        * platform/chromium-mac/editing/selection/3690719-expected.png: Added.
        * platform/chromium-mac/editing/selection/4975120-expected.png: Added.
        * platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
        * platform/chromium-mac/editing/style/5046875-1-expected.png: Added.
        * platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
        * platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
        * platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Added.
        * platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Added.
        * platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
        * platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
        * platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
        * platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
        * platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
        * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
        * platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 21:43:29 +0000 (21:43 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        cr-linux-ews should run tests
        https://bugs.webkit.org/show_bug.cgi?id=59272

        This patch turns on testing for the cr-linux-ews.  Yay!

        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 2 May 2011 21:36:57 +0000 (21:36 +0000)]
2011-05-02  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Correct marking of interpreter data in mixed mode builds
        https://bugs.webkit.org/show_bug.cgi?id=59962

        We had a few places in mixed mode builds where we would not
        track data used by the interpreter for marking.  This patch
        corrects the problem and adds a number of assertions to catch
        live Structures being collected.

        * JavaScriptCore.exp:
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::dump):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addPropertyAccessInstruction):
        (JSC::CodeBlock::addGlobalResolveInstruction):
        (JSC::CodeBlock::addStructureStubInfo):
        (JSC::CodeBlock::addGlobalResolveInfo):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitResolve):
        (JSC::BytecodeGenerator::emitResolveWithBase):
        (JSC::BytecodeGenerator::emitGetById):
        (JSC::BytecodeGenerator::emitPutById):
        (JSC::BytecodeGenerator::emitDirectPutById):
        * runtime/Structure.cpp:
        (JSC::Structure::materializePropertyMap):
        * runtime/Structure.h:
        (JSC::Structure::typeInfo):
        (JSC::Structure::previousID):
        (JSC::Structure::propertyStorageCapacity):
        (JSC::Structure::propertyStorageSize):
        (JSC::Structure::get):
        (JSC::Structure::materializePropertyMapIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 21:18:34 +0000 (21:18 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Add test expectations to accomodate new tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 2 May 2011 21:13:00 +0000 (21:13 +0000)]
2011-05-02  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Alexey Proskuryakov.

        Use native NullPtr when using GCC 4.6.0 and C++0x
        https://bugs.webkit.org/show_bug.cgi?id=59252

        GCC 4.6.0 has nullptr support, use it when possible.

        * wtf/NullPtr.cpp: include config.h to pull in Platform.h before
        NullPtr.h, since we need the GCC_VERSION_AT_LEAST definition.
        * wtf/NullPtr.h: check for GCC >= 4.6.0 and C++0x in order to
        use native nullptr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 21:05:47 +0000 (21:05 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Adjust test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 May 2011 21:04:58 +0000 (21:04 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Handle DispatchOnConnectionQueue for asynchronous messages
        https://bugs.webkit.org/show_bug.cgi?id=59959

        If any asynchronous messages have the DispatchOnConnectionQueue attribute,
        create a new willProcess{Receiver}MessageOnClientRunLoop.

        * Scripts/webkit2/messages.py:
        - Fix a regex bug where we would only parse attributes on synchronous messages.
        - Collect messages with the dispatch_on_connection_queue flag set. We only handle
          asynchronous messages currently; sync message support will be added when/if the
          need arises.

        * Scripts/webkit2/messages_unittest.py:
        Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 2 May 2011 21:04:42 +0000 (21:04 +0000)]
2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85483.
        http://trac.webkit.org/changeset/85483
        https://bugs.webkit.org/show_bug.cgi?id=59958

        Causes media test failures. (Requested by eric_carlson on
        #webkit).

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        (WebCore::HTMLMediaElement::prepareForLoad):
        (WebCore::HTMLMediaElement::seek):
        (WebCore::HTMLMediaElement::updatePlayState):
        * html/HTMLMediaElement.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
        (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
        (WebCore::MediaPlayerPrivateAVFoundation::load):
        (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
        (WebCore::MediaPlayerPrivateAVFoundation::paint):
        (WebCore::MediaPlayerPrivateAVFoundation::duration):
        (WebCore::MediaPlayerPrivateAVFoundation::seeking):
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
        (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
        (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
        (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
        (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
        (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
        (WebCore::MediaPlayerPrivateAVFoundation::repaint):
        (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
        (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 20:49:38 +0000 (20:49 +0000)]
2011-05-02  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: inline autoincrement key added on put
        https://bugs.webkit.org/show_bug.cgi?id=59936

        * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
        * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 2 May 2011 20:45:24 +0000 (20:45 +0000)]
2011-05-02  Martin Robinson  <mrobinson@igalia.com>

        Incorporate a review comment that I mistakenly omitted from my last commit.

        * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 20:37:15 +0000 (20:37 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59924

        * css/CSSGrammar.y:
        * platform/graphics/mac/SimpleFontDataMac.mm:
            - Memory management for the font cache is somewhat... complext.
              This will require some careful thought to sort out.
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59924

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::savePlatformDataToCachedFrame):
        * WebView/WebView.mm:
        (-[WebView _injectMailQuirksScript]):
        (-[WebView _injectOutlookQuirksScript]):
        (toStringVector):
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59924

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::sendSyncMessage):
        (CoreIPC::Connection::waitForSyncReply):
        (CoreIPC::Connection::dispatchSyncMessage):
        * Platform/CoreIPC/Connection.h:
        (CoreIPC::Connection::Message::releaseArguments):
            - The memory management for this class is very strange.  I wrote a
              large comment.  Hopefully a kind soul will come by and fix it.
        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::unload):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _setFindIndicator:fadeOut:]):
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::toStringVector):
        * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
        (WebKit::NetscapePluginStream::stop):
        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
        (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Mon, 2 May 2011 20:32:17 +0000 (20:32 +0000)]
2011-05-02  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        Port Mozilla's IndexedDB tests: inline autoincrement key added on put
        https://bugs.webkit.org/show_bug.cgi?id=59936

        * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
        * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 2 May 2011 20:23:21 +0000 (20:23 +0000)]
2011-05-02  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        showLineTree/showLineTreeForThis would make working with the line box tree easier
        https://bugs.webkit.org/show_bug.cgi?id=59662

        Adding a showLineTree/showLineTreeForThis method to help visualize and debug
        the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.

        No new tests since this is a debugging feature only and not compiled in release.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::showLineTreeForThis):
        (WebCore::InlineBox::showLineTreeAndMark):
        (WebCore::InlineBox::showBox):
        (showLineTree):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::showLineTreeAndMark):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::showBox):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::showLineTreeAndMark):
        * rendering/RenderBlock.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::showRenderTreeForThis):
        (WebCore::RenderObject::showLineTreeForThis):
        (showTree):
        (showLineTree):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 20:20:05 +0000 (20:20 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewd. Build fix.

        Adjust test expectations to make build bots happy.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 2 May 2011 20:19:12 +0000 (20:19 +0000)]
2011-05-02  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
        https://bugs.webkit.org/show_bug.cgi?id=59917

        Since default event handlers are not retargeted, we should always attempt ancestor
        traversal to find out whether the event.

        * html/MediaDocument.cpp:
        (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
        (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 20:02:52 +0000 (20:02 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        EWS should report the list of unexpected failures
        https://bugs.webkit.org/show_bug.cgi?id=59923

        We cache the results of the first layout test results run on the task
        so the EWS can grab them later.  Another option is to include them in
        the exception that's thrown, but this approach seemed slightly more
        aesthetic.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 2 May 2011 19:55:15 +0000 (19:55 +0000)]
2011-04-29  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Pages with accelerated compositing do not redraw unless scrolled
        https://bugs.webkit.org/show_bug.cgi?id=59851

        Added a setNeedDisplay on the non-composited content layer after
        the size is changed so it paints the full size of the layer. Called
        only for the areas newly exposed, if any.

        * WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
        (WebKit::LayerTreeHostCA::sizeDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the Leopard build.
weinig@apple.com [Mon, 2 May 2011 19:50:49 +0000 (19:50 +0000)]
Attempt to fix the Leopard build.

* platform/graphics/FontPlatformData.h:
* platform/graphics/mac/ComplexTextController.h:
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
* platform/mac/WebCoreSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alpha Lam <hclam@chromium.org>
hclam@chromium.org [Mon, 2 May 2011 19:49:20 +0000 (19:49 +0000)]
2011-05-02  Alpha Lam  <hclam@chromium.org>

        Not reviewed. Build fix.

        Rebaseline SVG layout tests for chromium port.

        * platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png:
        * platform/chromium-linux/editing/style/block-style-003-expected.png:
        * platform/chromium-linux/editing/style/create-block-for-style-005-expected.png:
        * platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
        * platform/chromium-linux/editing/style/create-block-for-style-010-expected.png:
        * platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
        * platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
        * platform/chromium-linux/editing/style/table-selection-expected.png:
        * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
        * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
        * platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
        * platform/chromium-linux/svg/text/text-align-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-align-02-b-expected.png:
        * platform/chromium-linux/svg/text/text-align-03-b-expected.png:
        * platform/chromium-linux/svg/text/text-align-04-b-expected.png:
        * platform/chromium-linux/svg/text/text-align-05-b-expected.png:
        * platform/chromium-linux/svg/text/text-align-06-b-expected.png:
        * platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
        * platform/chromium-linux/svg/text/text-path-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-text-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-text-03-b-expected.png:
        * platform/chromium-linux/svg/text/text-text-05-t-expected.png:
        * platform/chromium-linux/svg/text/text-text-06-t-expected.png:
        * platform/chromium-linux/svg/text/text-text-07-t-expected.png:
        * platform/chromium-linux/svg/text/text-text-08-b-expected.png:
        * platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
        * platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
        * platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
        * platform/chromium-linux/svg/text/textPathBoundsBug-expected.png:
        * platform/chromium-mac-leopard/editing/style/table-selection-expected.png:
        * platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png:
        * platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png:
        * platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png:
        * platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Removed.
        * platform/chromium-mac/editing/style/block-style-003-expected.png: Added.
        * platform/chromium-mac/editing/style/create-block-for-style-005-expected.png: Added.
        * platform/chromium-mac/editing/style/create-block-for-style-006-expected.png: Added.
        * platform/chromium-mac/editing/style/create-block-for-style-010-expected.png: Added.
        * platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Added.
        * platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Added.
        * platform/chromium-mac/editing/style/table-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/textPathBoundsBug-expected.png.
        * platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
        * platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png: Added.
        * platform/chromium-mac/svg/text/text-align-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-align-02-b-expected.png:
        * platform/chromium-mac/svg/text/text-align-03-b-expected.png:
        * platform/chromium-mac/svg/text/text-align-04-b-expected.png:
        * platform/chromium-mac/svg/text/text-align-05-b-expected.png:
        * platform/chromium-mac/svg/text/text-align-06-b-expected.png:
        * platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
        * platform/chromium-mac/svg/text/text-path-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-text-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-text-03-b-expected.png:
        * platform/chromium-mac/svg/text/text-text-05-t-expected.png:
        * platform/chromium-mac/svg/text/text-text-06-t-expected.png:
        * platform/chromium-mac/svg/text/text-text-07-t-expected.png:
        * platform/chromium-mac/svg/text/text-text-08-b-expected.png:
        * platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
        * platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
        * platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
        * platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
        * platform/chromium-mac/svg/text/textPathBoundsBug-expected.png:
        * platform/chromium-win/editing/style/block-style-003-expected.png:
        * platform/chromium-win/editing/style/create-block-for-style-005-expected.png:
        * platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
        * platform/chromium-win/editing/style/create-block-for-style-010-expected.png:
        * platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
        * platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
        * platform/chromium-win/editing/style/table-selection-expected.png:
        * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
        * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
        * platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.png:
        * platform/chromium-win/svg/text/text-align-01-b-expected.png:
        * platform/chromium-win/svg/text/text-align-02-b-expected.png:
        * platform/chromium-win/svg/text/text-align-03-b-expected.png:
        * platform/chromium-win/svg/text/text-align-04-b-expected.png:
        * platform/chromium-win/svg/text/text-align-05-b-expected.png:
        * platform/chromium-win/svg/text/text-align-06-b-expected.png:
        * platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
        * platform/chromium-win/svg/text/text-deco-01-b-expected.png:
        * platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
        * platform/chromium-win/svg/text/text-path-01-b-expected.png:
        * platform/chromium-win/svg/text/text-text-01-b-expected.png:
        * platform/chromium-win/svg/text/text-text-03-b-expected.png:
        * platform/chromium-win/svg/text/text-text-05-t-expected.png:
        * platform/chromium-win/svg/text/text-text-06-t-expected.png:
        * platform/chromium-win/svg/text/text-text-07-t-expected.png:
        * platform/chromium-win/svg/text/text-text-08-b-expected.png:
        * platform/chromium-win/svg/text/text-tref-01-b-expected.png:
        * platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
        * platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
        * platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
        * platform/chromium-win/svg/text/text-ws-01-t-expected.png:
        * platform/chromium-win/svg/text/text-ws-02-t-expected.png:
        * platform/chromium-win/svg/text/textPathBoundsBug-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 2 May 2011 19:43:48 +0000 (19:43 +0000)]
2011-05-02  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        convert manual-tests/bugzilla-6821.html to a layout test
        https://bugs.webkit.org/show_bug.cgi?id=59404

        * fast/css/hover-update-expected.txt: Added.
        * fast/css/hover-update.html: Added.
2011-05-02  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        convert manual-tests/bugzilla-6821.html to a layout test
        https://bugs.webkit.org/show_bug.cgi?id=59404

        Test: fast/css/hover-update.html

        * manual-tests/bugzilla-6821.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 19:42:27 +0000 (19:42 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add base case for a test-running EWS
        https://bugs.webkit.org/show_bug.cgi?id=59920

        Later I will subclass this to run the Chromium Linux EWS.

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 2 May 2011 19:41:26 +0000 (19:41 +0000)]
2011-05-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Need a way to handle CoreIPC messages on the connection work queue
        https://bugs.webkit.org/show_bug.cgi?id=59954

        Add a Connection::QueueClient abstract class. This class has a single pure virtual
        member function, willProcessMessageOnClientRunLoop which should return true if the message
        should be forwarded to the next Connection::QueueClient in the list or Connection::Client's
        run loop for processing and false otherwise. Users of Connection can use addQueueClient to
        add clients and all messages will be dispatched  to the queue clients first.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::addQueueClient):
        (CoreIPC::Connection::removeQueueClient):
        (CoreIPC::Connection::processIncomingMessage):
        * Platform/CoreIPC/Connection.h:
        (CoreIPC::Connection::QueueClient::~QueueClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 2 May 2011 19:24:26 +0000 (19:24 +0000)]
2011-05-02  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        WebKit2 thinks the web process is unresponsive when a plugin displays a context menu
        https://bugs.webkit.org/show_bug.cgi?id=59124
        <rdar://problem/9318600>

        This is the Windows version of <https://bugs.webkit.org/show_bug.cgi?id=58943>.

        Since we have no control over how long a plugin will take to handle an event, we need
        to tell the UI process to stop its responsive timer when we're about to send an event
        to the plugin. The downside of doing this is that if the plugin does become unresponsive,
        the user won't know this immediately until they click on the web page again.  At that point,
        if the web process is unresponsive because of a hung plugin, the responsiveness timer will fire.

        We're only doing this on Windows currently when running plugins in the web process (Anders fixed
        bug 58943 in a different way when running plugins in a separate plugin process on the Mac).

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::willSendEventToPlugin): Added, not used when running plugins in a separate process.
        * PluginProcess/PluginControllerProxy.h: Added willSendEventToPlugin().

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::stopResponsivenessTimer): Added.
        * UIProcess/WebPageProxy.h: Added stopResponsivenessTimer().
        * UIProcess/WebPageProxy.messages.in: Added StopResponsivenessTimer message.

        * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
        (WebKit::NetscapePlugin::platformPaint): Tell our controller when we're about to send an event to the plugin.
        (WebKit::NetscapePlugin::platformHandleMouseEvent): Ditto.
        (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Ditto.
        (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Ditto.

        * WebProcess/Plugins/PluginController.h: Added willSendEventToPlugin().
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::willSendEventToPlugin): Added, tell the UI process to stop its responsiveness timer.
        * WebProcess/Plugins/PluginView.h: Added willSendEventToPlugin().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 2 May 2011 19:11:17 +0000 (19:11 +0000)]
2011-05-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Prune ApplicationServices.h out of the headers
        https://bugs.webkit.org/show_bug.cgi?id=59952

        More forward declares are better.

        * html/canvas/CanvasRenderingContext2D.cpp:
        * html/canvas/CanvasRenderingContext2D.h:
        * platform/graphics/GlyphBuffer.h:
        * platform/graphics/cg/ImageBufferCG.cpp:
        * platform/graphics/cg/PDFDocumentImage.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/mac/ComplexTextController.h:
        * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
        * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
        * platform/mac/ScrollAnimatorMac.h:
        * platform/mac/ScrollAnimatorMac.mm:
        * platform/mac/ScrollbarThemeMac.h:
        * platform/mac/ScrollbarThemeMac.mm:
        * platform/mac/WebCoreNSStringExtras.h:
        * platform/mac/WebCoreSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Mon, 2 May 2011 19:09:42 +0000 (19:09 +0000)]
2011-05-02  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Remove passing tests after rebaselines from r85365.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7972529> Images with percentage based height/max-height are missing...
mitz@apple.com [Mon, 2 May 2011 18:50:41 +0000 (18:50 +0000)]
<rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
https://bugs.webkit.org/show_bug.cgi?id=58006

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
<http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
table cell as the immediate containing block, but any case where all containing block ancestors
up to and including a table cell are auto-or-percent height.

LayoutTests:

* fast/replaced/table-percent-height-expected.txt: Updated.
* fast/replaced/table-percent-height.html: Added a test case with a replaced object nested in an
auto-height block inside a table cell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
andersca@apple.com [Mon, 2 May 2011 18:38:59 +0000 (18:38 +0000)]
Build fix.

* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59950
barraclough@apple.com [Mon, 2 May 2011 18:30:03 +0000 (18:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59950
Clean up AssemblerBuffer to use a Vector internally.

Reviewed by Oliver Hunt.

AssemblerBuffer handles reallocing a byte array itself - stop that.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
* assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::~AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::isAligned):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::putByteUnchecked):
(JSC::AssemblerBuffer::putByte):
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putShort):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::putInt64):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::executableCopy):
(JSC::AssemblerBuffer::rewindToLabel):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):
* assembler/AssemblerBufferWithConstantPool.h:
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::linkCall):
* assembler/X86Assembler.h:
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid potential buffer overflow in WTFLog() and WTFLogVerbose()
jeffm@apple.com [Mon, 2 May 2011 18:20:03 +0000 (18:20 +0000)]
Avoid potential buffer overflow in WTFLog() and WTFLogVerbose()
https://bugs.webkit.org/show_bug.cgi?id=59949

Reviewed by Alexy Proskuryakov.

* wtf/Assertions.cpp: Check for 0 or empty format string in WTFLog() and WTFLogVerbose().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 2 May 2011 18:14:43 +0000 (18:14 +0000)]
2011-05-02  Daniel Bates  <dbates@webkit.org>

        Reviewed by Sam Weinig.

        Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
        https://bugs.webkit.org/show_bug.cgi?id=59379

        Make onblur-remove.html a DRT test. As of 04/25/2011 this test fails. See bug #59379
        for more details.

        * fast/events/onblur-remove-expected.txt: Added; expected failure results.
        * fast/events/onblur-remove.html: Copied from Source/WebCore/manual-tests/onblur-remove.html.
2011-05-02  Daniel Bates  <dbates@webkit.org>

        Reviewed by Sam Weinig.

        Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
        https://bugs.webkit.org/show_bug.cgi?id=59379

        Move manual test onblur-remove.html to LayoutTests/fast/events.

        Test: fast/events/onblur-remove.html

        * manual-tests/onblur-remove.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-29 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 2 May 2011 18:04:06 +0000 (18:04 +0000)]
2011-04-29  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej Stachowiak.

        Plug-in failed to initialize message should be called when Java fails to initialize
        https://bugs.webkit.org/show_bug.cgi?id=59856

        To match the WebKit1 behavior, WebKit2 should dispatch the plug-in failed
        to initialize message when we can't instantiate the Java plug-in.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createJavaAppletWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sailesh Agrawal <sail@chromium.org>
commit-queue@webkit.org [Mon, 2 May 2011 17:55:45 +0000 (17:55 +0000)]
2011-05-02  Sailesh Agrawal  <sail@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium Mac: Add scrollbar overlay drawing functions
        https://bugs.webkit.org/show_bug.cgi?id=59741

        These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.

        No new tests, since this code is only enabled on future versions of Mac OS X.

        * WebCore.gypi:
        * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
        * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
        (LookUpNSScrollerImpClass):
        (LookUpNSScrollerImpPairClass):
        (ScrollbarControlSizeToNSControlSize):
        (wkScrollbarPainterUsesOverlayScrollers):
        (wkScrollbarPainterIsHorizontal):
        (wkScrollbarPainterKnobAlpha):
        (wkScrollbarPainterSetOverlayState):
        (wkScrollbarPainterPaint):
        (wkScrollbarMinimumThumbLength):
        (wkScrollbarPainterSetDelegate):
        (wkScrollbarPainterTrackAlpha):
        (wkMakeScrollbarPainter):
        (wkScrollbarThickness):
        (wkScrollbarMinimumTotalLengthNeededForThumb):
        (wkVerticalScrollbarPainterForController):
        (wkHorizontalScrollbarPainterForController):
        (wkMakeScrollbarReplacementPainter):
        (wkSetPainterForPainterController):
        (wkSetScrollbarPainterControllerStyle):
        (wkScrollbarPainterKnobRect):
        (wkSetScrollbarPainterKnobAlpha):
        (wkSetScrollbarPainterTrackAlpha):
        (wkSetScrollbarPainterKnobStyle):
        (wkMakeScrollbarPainterController):
        (wkContentAreaScrolled):
        (wkContentAreaWillPaint):
        (wkMouseEnteredContentArea):
        (wkMouseExitedContentArea):
        (wkMouseMovedInContentArea):
        (wkWillStartLiveResize):
        (wkContentAreaResized):
        (wkWillEndLiveResize):
        (wkContentAreaDidShow):
        (wkContentAreaDidHide):
        (wkDidBeginScrollGesture):
        (wkDidEndScrollGesture):
        (wkScrollbarPainterForceFlashScrollers):
        (IsScrollbarOverlayAPIAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Alok Priyadarshi <alokp@chromium.org>
commit-queue@webkit.org [Mon, 2 May 2011 17:55:22 +0000 (17:55 +0000)]
2011-05-02  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Dimitri Glazkov.

        Chromium windows build is broken due to r85395
        https://bugs.webkit.org/show_bug.cgi?id=59945

        Include SecurityOrigin.h in IDBFactoryBackendProxy.cpp

        * src/IDBFactoryBackendProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Mon, 2 May 2011 17:54:33 +0000 (17:54 +0000)]
2011-05-02  Nico Weber  <thakis@chromium.org>

        Reviewed by Mihai Parparita.

        Add --no-webkit2 to the output of "build-webkit -h"
        https://bugs.webkit.org/show_bug.cgi?id=59942

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Mon, 2 May 2011 17:53:21 +0000 (17:53 +0000)]
2011-05-02  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement Length based CSS properties in CSSStyleApplyProperty
        https://bugs.webkit.org/show_bug.cgi?id=59314

        No new tests as no functionality changed.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyLength::ApplyPropertyLength):
        Added this class to handle all length types.
        Property specific behavior is handled through set of boolean parameters.
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Added calls to set up entries for the newly added length properties.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove property implementations mow implemented in CSSStyleApplyProperty.
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::rootElementStyle):
        Expose m_rootElementStyle via getter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 17:52:09 +0000 (17:52 +0000)]
2011-05-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
        https://bugs.webkit.org/show_bug.cgi?id=59828

        No new tests required, no functional change because seeking to time zero before playback
        begins has no effect.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
            HAVE_METADATA.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 2 May 2011 17:43:09 +0000 (17:43 +0000)]
2011-05-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
        https://bugs.webkit.org/show_bug.cgi?id=59943

        Disable the Ubuntu overlay scrollbar while testing, by injecting the
        LIBOVERLAY_SCROLLBAR=0 environment variable.

        * Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix extra whitespace in license in FocusDirection.h.
weinig@apple.com [Mon, 2 May 2011 17:39:24 +0000 (17:39 +0000)]
Fix extra whitespace in license in FocusDirection.h.

Reviewed by Gavin Barraclough.

* page/FocusDirection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 2 May 2011 17:35:11 +0000 (17:35 +0000)]
2011-05-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        Prune some #includes from DOMWindow.h
        https://bugs.webkit.org/show_bug.cgi?id=59907

        * Plugins/WebBaseNetscapePluginView.mm:
        * WebView/WebFrame.mm:
        Add now missing SecurityOrigin.h #includes.
2011-05-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        Prune some #includes from DOMWindow.h
        https://bugs.webkit.org/show_bug.cgi?id=59907

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setSecurityOrigin):
        * page/DOMWindow.h:
        Remove #includes of SecurityOrigin and MessagePort by forward declaring
        and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
        #include that was getting added by MessagePort.h.

        * bindings/js/JSCustomVoidCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMWindowCustom.h:
        * bindings/js/JSHistoryCustom.cpp:
        * bindings/js/ScriptController.h:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLMediaElement.cpp:
        * html/parser/XSSFilter.cpp:
        * inspector/InspectorDOMStorageResource.cpp:
        * loader/MainResourceLoader.cpp:
        * page/DragController.cpp:
        * page/EventSource.cpp:
        * page/Location.cpp:
        * websockets/WebSocket.cpp:
        * xml/XSLTProcessorLibxslt.cpp:
        Add now missing SecurityOrigin.h #includes.
2011-05-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        Prune some #includes from DOMWindow.h
        https://bugs.webkit.org/show_bug.cgi?id=59907

        * WebProcess/WebPage/WebFrame.cpp:
        Add now missing SecurityOrigin.h #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 17:21:34 +0000 (17:21 +0000)]
2011-05-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Brady Eidson.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/7508322>

        Tested manually with manual-tests/media-elements/video-preload.html.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
        (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
        (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
        (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
            because we need to have media data loaded to seek.
        (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
        * html/HTMLMediaElement.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove
            m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
        (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
        (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
            Move all preload logic to setPreload, call it from here.
        (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
            setPreload, call it.
        (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
            unlikely to be correct and isn't worth caching.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
            to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
            'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
            a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
            when the first frame is available.
        (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
            width, height, hasVideo, etc.
        (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
            in derived classes.
        (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
            AVAsset and AVPlayerItem here.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
            m_videoFrameHasDrawn.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
            videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
            if we have painted a frame to the context.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
            if necessary.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
            the buffer is full.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
            AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
            when we only have metadata.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
            when when we haven't allocated the AVPlayerItem yet so that we can report attributes
            when we only have metadata.
        (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
            we have allocated the AVPlayerItem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 16:52:44 +0000 (16:52 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        StringImpl::endsWith has some insane code
        https://bugs.webkit.org/show_bug.cgi?id=59900

        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::endsWith):
            - m_data shadows a member variable of the same name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 2 May 2011 16:23:09 +0000 (16:23 +0000)]
2011-05-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] editing/selection/select-out-of-editable.html failing after r83967
        https://bugs.webkit.org/show_bug.cgi?id=58667

        * platform/gtk/Skipped: Unskip a test which is now passing.
2011-05-02  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] editing/selection/select-out-of-editable.html failing after r83967
        https://bugs.webkit.org/show_bug.cgi?id=58667

        Do not trigger mouse down events when the EventSender knows that a mouse button is
        already down. These type of situations can confuse Xvfb and cause dragging failures.

        * DumpRenderTree/gtk/EventSender.cpp:
        (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
        is already down. This can interfere with drags in Xvfb.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 16:13:58 +0000 (16:13 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
        https://bugs.webkit.org/show_bug.cgi?id=59932

        Use gdk_window_get_width() and gdk_window_get_height() if
        available, instead of the deprecated gdk_drawable_get_size().

        No new tests, build fix only.

        * platform/gtk/WidgetRenderingContext.cpp:
        (WebCore::WidgetRenderingContext::WidgetRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
jberlin@webkit.org [Mon, 2 May 2011 16:09:16 +0000 (16:09 +0000)]
REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
https://bugs.webkit.org/show_bug.cgi?id=58657

Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.

* platform/win-xp/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 16:04:26 +0000 (16:04 +0000)]
2011-05-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Brady Eidson.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/7508322>

        Test manually with manual-tests/media-elements/video-preload.html.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
            attribute when preload is not "auto".
        (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
        (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
        (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
        (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
            a QTMovie.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update an exptected file after r85474.
ossy@webkit.org [Mon, 2 May 2011 15:59:13 +0000 (15:59 +0000)]
[Qt] Update an exptected file after r85474.

* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 2 May 2011 15:55:37 +0000 (15:55 +0000)]
2011-04-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Brady Eidson.

        The preload attribute of the video tag is not completely implemented
        https://bugs.webkit.org/show_bug.cgi?id=43673
        <rdar://problem/7508322>

        Manual test manual-tests/media-elements/video-preload.html added.

        * manual-tests/media-elements/video-preload.html: Added. New manual test for media element
            'preload' attribute because it is not possible to detect if a media engine supports
            "preload=metadata" in a way that lets us have per-platform layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 14:29:51 +0000 (14:29 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] Media tests relying on video-paint-test.js are still flaky
        https://bugs.webkit.org/show_bug.cgi?id=59934

        Dump the render tree after the video completed the seek. This is
        to avoid flake happening in the control slider not always being at
        beginning of the timeline.

        * media/video-paint-test.js:
        (init.document.addEventListener.):
        (init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>
commit-queue@webkit.org [Mon, 2 May 2011 14:27:31 +0000 (14:27 +0000)]
2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        DRT sideeffect revealed by r71268
        https://bugs.webkit.org/show_bug.cgi?id=48958

        * platform/qt/Skipped: Unskip svg/custom/text-zoom.xhtml
2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        DRT sideeffect revealed by r71268.
        https://bugs.webkit.org/show_bug.cgi?id=48958

        Reset QWebSettings::ZoomTextOnly attribute before all tests.

        Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
        PageZoomFactor too. It should be done before resetsettings()
        to guarantee resetting QWebSettings::ZoomTextOnly correctly.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 14:24:05 +0000 (14:24 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip flaky test on GTK.

        * platform/gtk/Skipped: Skip tables/mozilla_expected_failures/bugs/bug85016.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 2 May 2011 12:13:00 +0000 (12:13 +0000)]
2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r85469.
        http://trac.webkit.org/changeset/85469
        https://bugs.webkit.org/show_bug.cgi?id=59928

        Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
        bbandix on #webkit).

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Tomasz Morawski <t.morawski@samsung.com>
commit-queue@webkit.org [Mon, 2 May 2011 11:03:27 +0000 (11:03 +0000)]
2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        Cleanup EFL initialization/shutdown in the EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=59922

        Removed ecore_evas_init and edje_init form main function due to they
        are also called in the ewk_init. Moved ewk_shutdown to quit function.

        * EWebLauncher/main.c:
        (quit):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 10:54:08 +0000 (10:54 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, re-enable websocket tests on GTK. they moved over to a
        real http server and most of the flakiness went away.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 10:51:50 +0000 (10:51 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add base case for a test-running EWS
        https://bugs.webkit.org/show_bug.cgi?id=59920

        Later I will subclass this to run the Chromium Linux EWS.

        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 10:02:13 +0000 (10:02 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for new tests.

        * platform/gtk/fast/backgrounds/gradient-background-leakage-expected.png: Added.
        * platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
        * platform/gtk/fast/block/float/float-overhangs-root-expected.png: Added.
        * platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Added.
        * platform/gtk/fast/block/float/overhanging-tall-block-expected.png: Added.
        * platform/gtk/fast/block/float/overhanging-tall-block-expected.txt: Added.
        * platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
        * platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
        * platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Added.
        * platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
        * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
        * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.png: Added.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Added.
        * platform/gtk/fast/html/details-add-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-add-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-add-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-add-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-add-summary-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-add-summary-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-remove-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-remove-child-2-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-summary-child-1-expected.png: Added.
        * platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Added.
        * platform/gtk/fast/html/details-remove-summary-child-2-expected.png: Added.
        * platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Added.
        * platform/gtk/fast/table/auto-100-percent-width-expected.png: Added.
        * platform/gtk/fast/table/auto-100-percent-width-expected.txt: Added.
        * platform/gtk/fast/table/dynamic-caption-add-before-child-expected.png: Added.
        * platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
        * platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
        * platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
        * platform/gtk/fast/table/multiple-captions-display-expected.png: Added.
        * platform/gtk/fast/table/multiple-captions-display-expected.txt: Added.
        * platform/gtk/fast/text/selection-rect-rounding-expected.png: Added.
        * platform/gtk/fast/text/selection-rect-rounding-expected.txt: Added.
        * platform/gtk/svg/filters/feDropShadow-expected.png: Added.
        * platform/gtk/svg/filters/feDropShadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuildfix for ARM after r85448
loki@webkit.org [Mon, 2 May 2011 09:37:09 +0000 (09:37 +0000)]
Buildfix for ARM after r85448

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::loadBranchTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 2 May 2011 09:09:04 +0000 (09:09 +0000)]
2011-05-02  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline after r85355.

        * platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
        * platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 08:11:02 +0000 (08:11 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add the ability to skip python and perl unit tests on EC2
        https://bugs.webkit.org/show_bug.cgi?id=59918

        * Scripts/webkitpy/common/config/ports.py:
            - This is slightly ugly, but it's useful...
        * Scripts/webkitpy/common/config/ports_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 07:56:44 +0000 (07:56 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch --non-interactive is incompatible with new-run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=59919

        new-run-webkit-tests doesn't support --wait-for-httpd (because it
        always waits for HTTPD, as I understand things).  It turns out we're
        not really using this flag for anything, so we should just remove it.

        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 2 May 2011 07:53:08 +0000 (07:53 +0000)]
2011-05-01  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        The bots should learn from expected failures without having to retry
        https://bugs.webkit.org/show_bug.cgi?id=59279

        Rather than re-trying the whole patch, we can just check whether we now
        expect the failures we see with the patch applied, saving a lot of time.

        This patch also teaches the CommitQueue how to reject patches even
        when the tree is red using the new unexpected_failures() method on
        ExpectedFailures.

        Finally in testing we found a bug in ExpectedFailures where it would
        "trust" results which had many many failures, due to using an
        equal sign instead of a less-than sign.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
        * Scripts/webkitpy/tool/bot/expectedfailures.py
        * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
        * Scripts/webkitpy/tool/bot/patchanalysistask.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 07:17:32 +0000 (07:17 +0000)]
2011-05-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        workspace.py fails to import ScriptError
        https://bugs.webkit.org/show_bug.cgi?id=59915

        If the workspace fails to create a zip, webkitpy crashes instead of
        handling the error as expected.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 2 May 2011 06:29:40 +0000 (06:29 +0000)]
2011-05-01  Adam Barth  <abarth@webkit.org>

        Remove unadvertantly added file.

        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85461 268f45cc-cd09-0410-ab3c-d52691b4dbfc