From: graouts@webkit.org Date: Fri, 30 Mar 2018 18:45:54 +0000 (+0000) Subject: [Web Animations] CSSTransition objects should have fill: backwards to allow seeking... X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=d81911dbb8f1dec88a003dae39bc5b719c9c45df [Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time https://bugs.webkit.org/show_bug.cgi?id=184129 Reviewed by Dean Jackson. Source/WebCore: In order to allow a CSS Transition to be seeked prior to its start time, it needs to have its fill mode set to backwards. Adding code to set the fill mode in CSSTransition::initialize() yields early timing model invalidation and we could get in a situation where stylesWouldYieldNewCSSTransitionsBlendingKeyframes() was called before we had a chance to create blending keyframes for a CSS transitions, since the call to create blending keyframes is made after the call to initialize(), so we now cater for this case. * animation/CSSTransition.cpp: (WebCore::CSSTransition::initialize): * animation/CSSTransition.h: * animation/KeyframeEffectReadOnly.cpp: (WebCore::KeyframeEffectReadOnly::stylesWouldYieldNewCSSTransitionsBlendingKeyframes const): LayoutTests: Make one test opt into CSS Animations and CSS Transitions as Web Animations and fix expectations for a CSSTransition test which mistakenly assumes the fill to be "none". * transitions/transition-in-delay-phase.html: * webanimations/css-transitions.html: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230112 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 69a46a3..35c1952 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,16 @@ +2018-03-29 Antoine Quint + + [Web Animations] CSSTransition objects should have fill: backwards to allow seeking prior to start time + https://bugs.webkit.org/show_bug.cgi?id=184129 + + Reviewed by Dean Jackson. + + Make one test opt into CSS Animations and CSS Transitions as Web Animations and fix expectations for a CSSTransition + test which mistakenly assumes the fill to be "none". + + * transitions/transition-in-delay-phase.html: + * webanimations/css-transitions.html: + 2018-03-28 Ryan Haddad Mark imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_createIndex7-event_order.htm as flaky. diff --git a/LayoutTests/transitions/transition-in-delay-phase.html b/LayoutTests/transitions/transition-in-delay-phase.html index da3d3b7..903a81e 100644 --- a/LayoutTests/transitions/transition-in-delay-phase.html +++ b/LayoutTests/transitions/transition-in-delay-phase.html @@ -1,3 +1,4 @@ +