From: weinig@apple.com Date: Sun, 20 Sep 2020 23:07:51 +0000 (+0000) Subject: Performance.navigation and Performance.timing are incorrectly exposed to workers X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=b3c0f2d4893960e73cc0cec0ff2b0bfceeea3cc4;ds=inline Performance.navigation and Performance.timing are incorrectly exposed to workers https://bugs.webkit.org/show_bug.cgi?id=216732 Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/workers/worker-performance.worker-expected.txt: Update results now that Performance.navigation and Performance.timing are no longer exposed to workers. Source/WebCore: * page/Performance.idl: Only expose Performance.navigation and Performance.timing to the Window. LayoutTests: * TestExpectations: Remove flaky annotation for imported/w3c/web-platform-tests/workers/worker-performance.worker.html. The test was fixed in upstream WPT as dab9c45, and has since been updated in the WebKit tree as well. It now also passes. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267333 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index def7b5a..173b0ed 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,15 @@ +2020-09-20 Sam Weinig + + Performance.navigation and Performance.timing are incorrectly exposed to workers + https://bugs.webkit.org/show_bug.cgi?id=216732 + + Reviewed by Simon Fraser. + + * TestExpectations: + Remove flaky annotation for imported/w3c/web-platform-tests/workers/worker-performance.worker.html. The + test was fixed in upstream WPT as dab9c45, and has since been updated in the WebKit tree as well. + It now also passes. + 2020-09-20 Darin Adler Selection API: Further improvements to VisibleSelection, FrameSelection, and DOMSelection to preserve anchor and focus diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index 2f760d8..cb35402 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -2757,9 +2757,6 @@ webkit.org/b/158205 applicationmanifest/ [ Skip ] webkit.org/b/178785 perf/object-keys.html [ Pass Failure ] -# There is a bug in the test -imported/w3c/web-platform-tests/workers/worker-performance.worker.html [ Pass Failure ] - webkit.org/b/183390 http/wpt/html/browsers/history/the-location-interface/location-protocol-setter-non-broken-async-delegate.html [ Pass Failure ] webkit.org/b/172243 imported/w3c/web-platform-tests/IndexedDB/idbdatabase-createObjectStore-exception-order.htm [ Pass Failure ] diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog index 518fcce..d25c3bc 100644 --- a/LayoutTests/imported/w3c/ChangeLog +++ b/LayoutTests/imported/w3c/ChangeLog @@ -1,3 +1,14 @@ +2020-09-20 Sam Weinig + + Performance.navigation and Performance.timing are incorrectly exposed to workers + https://bugs.webkit.org/show_bug.cgi?id=216732 + + Reviewed by Simon Fraser. + + * web-platform-tests/workers/worker-performance.worker-expected.txt: + Update results now that Performance.navigation and Performance.timing are no longer + exposed to workers. + 2020-09-19 Sam Weinig Performance and PerformanceNavigation interfaces are missing toJSON operations diff --git a/LayoutTests/imported/w3c/web-platform-tests/workers/worker-performance.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/workers/worker-performance.worker-expected.txt index 3ad871a..0309244 100644 --- a/LayoutTests/imported/w3c/web-platform-tests/workers/worker-performance.worker-expected.txt +++ b/LayoutTests/imported/w3c/web-platform-tests/workers/worker-performance.worker-expected.txt @@ -9,8 +9,8 @@ PASS Can use clearMarks and clearMeasures in workers PASS Resource timing seems to work in workers PASS performance.clearResourceTimings in workers PASS performance.setResourceTimingBufferSize in workers -FAIL performance.timing is not available in workers assert_equals: performance.timing is undefined expected "undefined" but got "object" -FAIL performance.navigation is not available in workers assert_equals: performance.navigation is undefined expected "undefined" but got "object" -FAIL performance.toJSON is available in workers assert_equals: performance.toJSON is a function expected "function" but got "undefined" +PASS performance.timing is not available in workers +PASS performance.navigation is not available in workers +PASS performance.toJSON is available in workers PASS There are no navigation type performance entries in workers diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index f6e6544..24cd38d 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,5 +1,15 @@ 2020-09-20 Sam Weinig + Performance.navigation and Performance.timing are incorrectly exposed to workers + https://bugs.webkit.org/show_bug.cgi?id=216732 + + Reviewed by Simon Fraser. + + * page/Performance.idl: + Only expose Performance.navigation and Performance.timing to the Window. + +2020-09-20 Sam Weinig + Using [Exposed=Window] with [Default] object toJSON() doesn't work https://bugs.webkit.org/show_bug.cgi?id=216731 diff --git a/Source/WebCore/page/Performance.idl b/Source/WebCore/page/Performance.idl index c655e4a..cf3f20f 100644 --- a/Source/WebCore/page/Performance.idl +++ b/Source/WebCore/page/Performance.idl @@ -43,8 +43,8 @@ typedef double DOMHighResTimeStamp; [Default] object toJSON(); // https://w3c.github.io/navigation-timing/#extensions-to-the-performance-interface - readonly attribute PerformanceNavigation navigation; - readonly attribute PerformanceTiming timing; + [Exposed=Window] readonly attribute PerformanceNavigation navigation; + [Exposed=Window] readonly attribute PerformanceTiming timing; // https://w3c.github.io/performance-timeline/#extensions-to-the-performance-interface PerformanceEntryList getEntries();