From: darin@apple.com Date: Fri, 27 Mar 2009 18:27:16 +0000 (+0000) Subject: 2009-03-27 Darin Adler X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=995116b2b479dc25c7ecef4ac351038101ae508b 2009-03-27 Darin Adler Reviewed by Adam Roben. REGRESSION (r38629): Tab cycle in empty tab is broken * WebView/WebHTMLView.mm: (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42045 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/WebKit/mac/ChangeLog b/WebKit/mac/ChangeLog index 883a05d..985dd5f 100644 --- a/WebKit/mac/ChangeLog +++ b/WebKit/mac/ChangeLog @@ -1,5 +1,14 @@ 2009-03-27 Darin Adler + Reviewed by Adam Roben. + + REGRESSION (r38629): Tab cycle in empty tab is broken + + * WebView/WebHTMLView.mm: + (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame. + +2009-03-27 Darin Adler + Reviewed by John Sullivan and Anders Carlsson. Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services) diff --git a/WebKit/mac/WebView/WebHTMLView.mm b/WebKit/mac/WebView/WebHTMLView.mm index 34445d8..bcd69f8 100644 --- a/WebKit/mac/WebView/WebHTMLView.mm +++ b/WebKit/mac/WebView/WebHTMLView.mm @@ -4639,7 +4639,13 @@ static BOOL writingDirectionKeyBindingsEnabled() // support them via the key bindings mechanism. - (BOOL)_wantsKeyDownForEvent:(NSEvent *)event { - return YES; + bool haveWebCoreFrame = core([self _frame]); + + // If we have a frame, our keyDown method will handle key bindings after sending + // the event through the DOM, so ask AppKit not to do its early special key binding + // mapping. If we don't have a frame, just let things work the normal way without + // a keyDown. + return haveWebCoreFrame; } #else