From: simon.fraser@apple.com Date: Mon, 12 Nov 2018 17:58:56 +0000 (+0000) Subject: feFlood with alpha color doesn't work correctly X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=9777b7565bd8c9e43e8af9203d794654c1f51589 feFlood with alpha color doesn't work correctly https://bugs.webkit.org/show_bug.cgi?id=163666 Reviewed by Zalan Bujtas. Source/WebCore: FEFlood::platformApplySoftware() erroneously used colorWithOverrideAlpha() rather than multiplying the flood color with the flood opacity as other browsers do. Test: svg/filters/feFlood-with-alpha-color.html * platform/graphics/Color.cpp: (WebCore::Color::colorWithAlpha const): I tried using colorWithAlphaMultipliedBy() elsewhere, and it triggered a behavior change, so add a comment. * platform/graphics/filters/FEFlood.cpp: (WebCore::FEFlood::platformApplySoftware): * svg/SVGStopElement.cpp: (WebCore::SVGStopElement::stopColorIncludingOpacity const): LayoutTests: * svg/filters/feFlood-with-alpha-color-expected.html: Added. * svg/filters/feFlood-with-alpha-color.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238094 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 298fa83..cf70365 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,13 @@ +2018-11-12 Simon Fraser + + feFlood with alpha color doesn't work correctly + https://bugs.webkit.org/show_bug.cgi?id=163666 + + Reviewed by Zalan Bujtas. + + * svg/filters/feFlood-with-alpha-color-expected.html: Added. + * svg/filters/feFlood-with-alpha-color.html: Added. + 2018-11-12 Eric Carlson Require