From: ap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun, 4 Oct 2015 17:01:01 +0000 (+0000)
Subject: Fix some errors on bot watcher's dashboard
X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=8a6eaa44262f5e98115cca0ade87328af8360537

Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
index d9a1126..3e58e45 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
@@ -82,7 +82,11 @@ BuildbotTesterQueueView.prototype = {
                     // A crashes-only queue is a queue where we are only interested in crashes, e.g. a GuardMalloc or an ASan one.
                     // Currently, only layout tests are supported in such.
                     var layoutTestResults = iteration.layoutTestResults;
-                    if (layoutTestResults.tooManyFailures) {
+                    if (!layoutTestResults) {
+                        // Tests did not run.
+                        var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
+                        var status = new StatusLineView(messageElement, StatusLineView.Status.Danger, iteration.text, undefined, url);
+                    } else if (layoutTestResults.tooManyFailures) {
                         var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, "failure limit exceeded", undefined, iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
                         new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
                     } else if (layoutTestResults.errorOccurred) {
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 9c3e50b..95b0d5d 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,5 +1,16 @@
 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 
+        Fix some errors on bot watcher's dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=149789
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
+        tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
+
+2015-10-04  Alexey Proskuryakov  <ap@apple.com>
+
         Bot watcher's dashboard builders should turn yellow when svn fails
         https://bugs.webkit.org/show_bug.cgi?id=149791