From: ap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Sun, 4 Oct 2015 16:57:08 +0000 (+0000)
Subject: Bot watcher's dashboard builders should turn yellow when svn fails
X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=4d0a276c3e6caaaec722e81db532920722b89d86

Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
index 48b3285..ccc69cb 100644
--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js
@@ -75,7 +75,7 @@ BuildbotBuilderQueueView.prototype = {
                 && mostRecentFinishedIteration && mostRecentFinishedIteration.loaded) {
                 console.assert(!mostRecentFinishedIteration.successful);
                 var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
-                if (mostRecentFinishedIteration.failed) {
+                if (mostRecentFinishedIteration.failed && mostRecentFinishedIteration.productive) {
                     // Assume it was a build step that failed, and link directly to output.
                     var url = mostRecentFinishedIteration.failureLogURL("build log");
                     if (!url)
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 1b6d6eb..9c3e50b 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,14 @@
+2015-10-04  Alexey Proskuryakov  <ap@apple.com>
+
+        Bot watcher's dashboard builders should turn yellow when svn fails
+        https://bugs.webkit.org/show_bug.cgi?id=149791
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
+        (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
+        (BuildbotBuilderQueueView.prototype.update):
+
 2015-10-02  Daniel Bates  <dabates@apple.com>
 
         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard