From: utatane.tea@gmail.com <utatane.tea@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Mon, 7 Sep 2015 03:10:31 +0000 (+0000)
Subject: Unreviewed, disable module tests in Windows until name resolution is fixed
X-Git-Url: http://git.webkit.org/?p=WebKit-https.git;a=commitdiff_plain;h=1e934d19e54c0b851a1cd0b71a15ef16cef67e7a

Unreviewed, disable module tests in Windows until name resolution is fixed
https://bugs.webkit.org/show_bug.cgi?id=148689

Until bug[1] is fixed, we disable the module tests.
Since the local file system name resolution is just implemented in jsc.cpp and
is intended to be used for the module tests, it does not affect JSC framework
and WebKit itself.

[1]: https://bugs.webkit.org/show_bug.cgi?id=148917

* tests/modules.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index fce5ee1..a5a5529 100644
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,17 @@
+2015-09-06  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        Unreviewed, disable module tests in Windows until name resolution is fixed
+        https://bugs.webkit.org/show_bug.cgi?id=148689
+
+        Until bug[1] is fixed, we disable the module tests.
+        Since the local file system name resolution is just implemented in jsc.cpp and
+        is intended to be used for the module tests, it does not affect JSC framework
+        and WebKit itself.
+
+        [1]: https://bugs.webkit.org/show_bug.cgi?id=148917
+
+        * tests/modules.yaml:
+
 2015-09-06  Sukolsak Sakshuwong  <sukolsak@gmail.com>
 
         Simplify JIT::emit_op_mod()
diff --git a/Source/JavaScriptCore/tests/modules.yaml b/Source/JavaScriptCore/tests/modules.yaml
index ab478f1..6681e06 100644
--- a/Source/JavaScriptCore/tests/modules.yaml
+++ b/Source/JavaScriptCore/tests/modules.yaml
@@ -22,4 +22,13 @@
 # THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 - path: modules
-  cmd: runModules
+  cmd: |
+      # FIXME: ES6 Modules in the JSC shell now uses an absolute path as an unique key to each module.
+      # However, the length of the path name in Windows is limited and short; (_MAX_PATH = 260).
+      # As a result, JSC tests for modules in Windows fail because the current working directory path is truncated.
+      # https://bugs.webkit.org/show_bug.cgi?id=148917
+      if ($hostOS == "windows")
+          skip
+      else
+          runModules
+      end