[Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Aug 2014 18:36:03 +0000 (18:36 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Aug 2014 18:36:03 +0000 (18:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136229

Reviewed by Dean Jackson.

Source/WebInspectorUI:

* WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
flag to build-webinspectorui.pl.
* WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
the OFFICIAL_BUILD flag.

WebKitLibraries:

* win/tools/vsprops/common.props: Pass OFFICIAL_BUILD argument
from VS to child Make processes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@172929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.make
Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/common.props

index bd50971..61d7221 100644 (file)
@@ -1,3 +1,15 @@
+2014-08-25  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
+        https://bugs.webkit.org/show_bug.cgi?id=136229
+
+        Reviewed by Dean Jackson.
+
+        * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
+        flag to build-webinspectorui.pl.
+        * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
+        the OFFICIAL_BUILD flag.
+
 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
 
         The inspector should not use the "after" pseudo element with the compatibility syntax
index bb7b3f8..0b0e557 100644 (file)
@@ -1,6 +1,6 @@
 make:\r
        -mkdir "%ConfigurationBuildDir%\bin%PlatformArchitecture%\WebKit.resources\WebInspectorUI"\r
-       perl build-webinspectorui.pl "%ConfigurationBuildDir%" "%WebKit_Libraries%" windows "%PlatformArchitecture%"\r
+       perl build-webinspectorui.pl "%ConfigurationBuildDir%" "%WebKit_Libraries%" windows "%PlatformArchitecture%" "%OFFICIAL_BUILD%"\r
        if errorlevel 1 exit 1\r
 \r
        xcopy /y /e "..\Localizations\en.lproj\*" "%ConfigurationBuildDir%\bin%PlatformArchitecture%\WebKit.resources\WebInspectorUI"\r
index 16ddb8d..035cab1 100755 (executable)
@@ -46,7 +46,7 @@ $ENV{'XDSTROOT'} = $XDSTROOT;
 my $TARGET_BUILD_DIR = File::Spec->catdir($XDSTROOT, "bin$ARGV[3]", 'WebKit.resources');
 $ENV{'TARGET_BUILD_DIR'} = $TARGET_BUILD_DIR;
 my ($JAVASCRIPTCORE_PRIVATE_HEADERS_DIR, $WEBCORE_PRIVATE_HEADERS_DIR);
-if ($ENV{'OFFICIAL_BUILD'} eq '1') {
+if ($ARGV[4] eq '1') {
     $ARGV[1] =~ s/^\"//;
     $ARGV[1] =~ s/\"$//;
     my $Internal = Cwd::realpath($ARGV[1]);;
@@ -59,6 +59,7 @@ if ($ENV{'OFFICIAL_BUILD'} eq '1') {
 
 $ENV{'JAVASCRIPTCORE_PRIVATE_HEADERS_DIR'} = $JAVASCRIPTCORE_PRIVATE_HEADERS_DIR;
 $ENV{'WEBCORE_PRIVATE_HEADERS_DIR'} = $WEBCORE_PRIVATE_HEADERS_DIR;
+
 my $DERIVED_SOURCES_DIR = File::Spec->catdir($XDSTROOT, "obj$ARGV[3]", 'WebInspectorUI', 'DerivedSources');
 $ENV{'DERIVED_SOURCES_DIR'} = $DERIVED_SOURCES_DIR;
 
@@ -68,5 +69,17 @@ if (($TARGET_BUILD_DIR =~ /Release/) || ($TARGET_BUILD_DIR =~ /Production/)) {
     $ENV{'COMBINE_INSPECTOR_RESOURCES'} = 'YES';
 } 
 
+my $targetResourcePath = File::Spec->catdir($ENV{'TARGET_BUILD_DIR'}, $ENV{'UNLOCALIZED_RESOURCES_FOLDER_PATH'});
+my $protocolDir = File::Spec->catdir($targetResourcePath, 'Protocol');
+
+# Copy over dynamically loaded files from other frameworks, even if we aren't combining resources.
+my $jsFrom = File::Spec->catfile($ENV{'JAVASCRIPTCORE_PRIVATE_HEADERS_DIR'}, 'InspectorJSBackendCommands.js');
+my $jsTo = File::Spec->catfile($protocolDir, 'InspectorJSBackendCommands.js');
+print "Copying JavaScript bindings from $jsFrom to $jsTo\n";
+
+my $wcFrom = File::Spec->catfile($ENV{'WEBCORE_PRIVATE_HEADERS_DIR'}, 'InspectorWebBackendCommands.js');
+my $wcTo = File::Spec->catfile($protocolDir, 'InspectorWebBackendCommands.js');
+print "Copying WebCore bindings from $wcFrom to $wcTo\n";
+
 my $copyResourcesCommand = File::Spec->catfile($XSRCROOT, 'Scripts', 'copy-user-interface-resources.pl');
 do $copyResourcesCommand;
index 2a09eed..263633d 100644 (file)
@@ -1,3 +1,13 @@
+2014-08-25  Brent Fulgham  <bfulgham@apple.com>
+
+        [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
+        https://bugs.webkit.org/show_bug.cgi?id=136229
+
+        Reviewed by Dean Jackson.
+
+        * win/tools/vsprops/common.props: Pass OFFICIAL_BUILD argument
+        from VS to child Make processes.
+
 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
 
         [Win] Unreviewed build fix.
index 00df641..fd321cc 100644 (file)
@@ -15,12 +15,14 @@ if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%
 set CONFIGURATIONBUILDDIR=$(ConfigurationBuildDir)
 set PLATFORMARCHITECTURE=$(PlatformArchitecture)
 set WEBKIT_LIBRARIES=$(WEBKIT_LIBRARIES)
+set OFFICIAL_BUILD=$(OFFICIAL_BUILD)
 nmake /nologo -f $(ProjectName).make</NMakeBuildCommandLine>
     <NMakeReBuildCommandLine>%SystemDrive%\cygwin\bin\which.exe bash
 if errorlevel 1 set PATH=%SystemDrive%\cygwin\bin;%PATH%
 set CONFIGURATIONBUILDDIR=$(ConfigurationBuildDir)
 set PLATFORMARCHITECTURE=$(PlatformArchitecture)
 set WEBKIT_LIBRARIES=$(WEBKIT_LIBRARIES)
+set OFFICIAL_BUILD=$(OFFICIAL_BUILD)
 nmake /nologo -f $(ProjectName).make clean
 nmake /nologo -f $(ProjectName).make</NMakeReBuildCommandLine>
     <NMakeCleanCommandLine>%SystemDrive%\cygwin\bin\which.exe bash
@@ -241,4 +243,4 @@ cmd /c
       <EnvironmentVariable>true</EnvironmentVariable>
     </BuildMacro>
   </ItemGroup>
-</Project>
\ No newline at end of file
+</Project>