Unskip fast/text/system-font-synthetic-italic.html
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Sep 2017 00:27:46 +0000 (00:27 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Sep 2017 00:27:46 +0000 (00:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175944
Source/WebCore:

<rdar://problem/32864306>

Reviewed by Jon Lee.

Our buildbots now all have this symbol.

* platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
(WebCore::FontFamilySpecificationCoreText::fontRanges const):

Source/WebCore/PAL:

Reviewed by Jon Lee.

* pal/spi/cocoa/CoreTextSPI.h:

LayoutTests:

<rdar://problem/32864306>

Reviewed by Jon Lee.

* platform/mac-highsierra/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-highsierra/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/pal/spi/cocoa/CoreTextSPI.h
Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp

index d35aa6f..54d8f50 100644 (file)
@@ -1,3 +1,13 @@
+2017-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Unskip fast/text/system-font-synthetic-italic.html
+        https://bugs.webkit.org/show_bug.cgi?id=175944
+        <rdar://problem/32864306>
+
+        Reviewed by Jon Lee.
+
+        * platform/mac-highsierra/TestExpectations:
+
 2017-09-12  Michael Saboff  <msaboff@apple.com>
 
         String.prototype.replace() puts extra '<' in result when a named capture reference is used without named captures in the RegExp
index 1b21617..a28d988 100644 (file)
@@ -121,9 +121,6 @@ imported/blink/fast/gradients/gradient-transparency.html [ ImageOnlyFailure ]
 # <rdar://problem/32826391> LayoutTest imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm is failing on High Sierra
 imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm [ Failure ]
 
-# <rdar://problem/32864306> Unskip after bots have CTFontCopyPhysicalFont()
-fast/text/system-font-japanese-synthetic-italic.html [ Pass ImageOnlyFailure ]
-
 # This test makes sure that variation fonts are disabled on OSes which don't support them. So,
 # the test should be skipped on OSes which do support them. As soon as all OSes support them,
 # we should delete the test.
index 462daae..61d1f2f 100644 (file)
@@ -1,5 +1,18 @@
 2017-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
 
+        Unskip fast/text/system-font-synthetic-italic.html
+        https://bugs.webkit.org/show_bug.cgi?id=175944
+        <rdar://problem/32864306>
+
+        Reviewed by Jon Lee.
+
+        Our buildbots now all have this symbol.
+
+        * platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
+        (WebCore::FontFamilySpecificationCoreText::fontRanges const):
+
+2017-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
+
         ASSERTION FAILED: !m_valueOrException under FontFaceSet::completedLoading loading a Serious Eats page
         https://bugs.webkit.org/show_bug.cgi?id=175899
 
index 8e17cbf..efeb1b0 100644 (file)
@@ -1,3 +1,12 @@
+2017-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Unskip fast/text/system-font-synthetic-italic.html
+        https://bugs.webkit.org/show_bug.cgi?id=175944
+
+        Reviewed by Jon Lee.
+
+        * pal/spi/cocoa/CoreTextSPI.h:
+
 2017-09-12  Eric Carlson  <eric.carlson@apple.com>
 
         Switch MediaPlayerPrivateAVFoundation to release logging
index fd26af9..de8040f 100644 (file)
@@ -93,6 +93,7 @@ extern const CFStringRef kCTFrameMaximumNumberOfLinesAttributeName;
 bool CTFontDescriptorIsSystemUIFont(CTFontDescriptorRef);
 CTFontRef CTFontCreateForCSS(CFStringRef name, uint16_t weight, CTFontSymbolicTraits, CGFloat size);
 CTFontRef CTFontCreateForCharactersWithLanguage(CTFontRef currentFont, const UTF16Char *characters, CFIndex length, CFStringRef language, CFIndex *coveredLength);
+CTFontRef CTFontCopyPhysicalFont(CTFontRef);
 
 extern const CFStringRef kCTUIFontTextStyleShortHeadline;
 extern const CFStringRef kCTUIFontTextStyleShortBody;
index 430efc0..e95288a 100644 (file)
 #include "config.h"
 #include "FontFamilySpecificationCoreText.h"
 
+#include <pal/spi/cocoa/CoreTextSPI.h>
 #include "FontCache.h"
 #include "FontSelector.h"
-#include <CoreText/CoreText.h>
-#include <wtf/SoftLinking.h>
 
-#if USE_PLATFORM_SYSTEM_FALLBACK_LIST
-SOFT_LINK_FRAMEWORK(CoreText);
-SOFT_LINK_MAY_FAIL(CoreText, CTFontCopyPhysicalFont, CTFontRef, (CTFontRef font), (font));
-#endif
+#include <CoreText/CoreText.h>
 
 namespace WebCore {
 
@@ -55,10 +51,8 @@ FontRanges FontFamilySpecificationCoreText::fontRanges(const FontDescription& fo
 
     auto fontForSynthesisComputation = font;
 #if USE_PLATFORM_SYSTEM_FALLBACK_LIST
-    if (canLoadCTFontCopyPhysicalFont()) {
-        if (auto physicalFont = adoptCF(CTFontCopyPhysicalFont(font.get())))
-            fontForSynthesisComputation = physicalFont;
-    }
+    if (auto physicalFont = adoptCF(CTFontCopyPhysicalFont(font.get())))
+        fontForSynthesisComputation = physicalFont;
 #endif
 
     font = preparePlatformFont(font.get(), fontDescription, nullptr, nullptr, { }, fontDescription.computedSize());