Enable Unified Plan by default
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Sep 2018 17:11:17 +0000 (17:11 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Sep 2018 17:11:17 +0000 (17:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189675

Reviewed by Eric Carlson.

Source/WebCore:

RTCRtpTransceiver.currentDirection is now gated by the unified plan runtime flag.
This will allow easy feature detection of unified plan support.
Covered by updated test.

* Modules/mediastream/RTCRtpTransceiver.idl:

Source/WebKit:

* Shared/WebPreferences.yaml:

LayoutTests:

* webrtc/video-addLegacyTransceiver-expected.txt:
* webrtc/video-addLegacyTransceiver.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt
LayoutTests/webrtc/video-addLegacyTransceiver.html
Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml

index cfa11ae..4b81bc1 100644 (file)
@@ -1,3 +1,13 @@
+2018-09-18  Youenn Fablet  <youenn@apple.com>
+
+        Enable Unified Plan by default
+        https://bugs.webkit.org/show_bug.cgi?id=189675
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/video-addLegacyTransceiver-expected.txt:
+        * webrtc/video-addLegacyTransceiver.html:
+
 2018-09-18  Per Arne Vollan  <pvollan@apple.com>
 
         [WebVTT] change "middle" to "center" for consistency with CSS
index 8790e6b..332060d 100644 (file)
@@ -1,5 +1,6 @@
 
 
+PASS Expose currentDirection only for unified plan 
 PASS Setting up calls with addTransceiver but with no track 
 PASS Setting up calls with addTransceiver with a track 
 PASS Basic video exchange set up with addTransceiver 
index 3ca754c..e1c227c 100644 (file)
 if (window.testRunner)
     testRunner.setWebRTCUnifiedPlanEnabled(false);
 
+test(() => {
+    assert_equals(Object.keys(RTCRtpTransceiver.prototype).indexOf("currentDirection"), -1, "No currentDirection if unified plan is off");
+}, "Expose currentDirection only for unified plan");
+
 promise_test((test) => {
     var pc = new RTCPeerConnection();
     pc.addTransceiver("video");
index c2f73bf..320b069 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-18  Youenn Fablet  <youenn@apple.com>
+
+        Enable Unified Plan by default
+        https://bugs.webkit.org/show_bug.cgi?id=189675
+
+        Reviewed by Eric Carlson.
+
+        RTCRtpTransceiver.currentDirection is now gated by the unified plan runtime flag.
+        This will allow easy feature detection of unified plan support.
+        Covered by updated test.
+
+        * Modules/mediastream/RTCRtpTransceiver.idl:
+
 2018-09-18  Per Arne Vollan  <pvollan@apple.com>
 
         [WebVTT] change "middle" to "center" for consistency with CSS
index aa16602..157e05a 100644 (file)
@@ -40,7 +40,7 @@ typedef RTCRtpTransceiverDirection RtpTransceiverDirection;
     [SameObject] readonly attribute RTCRtpReceiver receiver;
     readonly attribute boolean stopped;
     readonly attribute RtpTransceiverDirection direction;
-    readonly attribute RTCRtpTransceiverDirection? currentDirection;
+    [EnabledAtRuntime=WebRTCUnifiedPlan] readonly attribute RTCRtpTransceiverDirection? currentDirection;
     void setDirection(RtpTransceiverDirection direction);
     void stop();
     // FIXME 169662: missing setCodecPreferences
index eb3d4c3..c95d8bf 100644 (file)
@@ -1,3 +1,12 @@
+2018-09-18  Youenn Fablet  <youenn@apple.com>
+
+        Enable Unified Plan by default
+        https://bugs.webkit.org/show_bug.cgi?id=189675
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferences.yaml:
+
 2018-09-18  Antti Koivisto  <antti@apple.com>
 
         REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac
index 3f83115..66f6158 100644 (file)
@@ -496,7 +496,7 @@ PeerConnectionEnabled:
 
 WebRTCUnifiedPlanEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
   webcoreBinding: RuntimeEnabledFeatures
   condition: ENABLE(WEB_RTC)
   humanReadableName: "WebRTC Unified Plan"