Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Sep 2018 22:47:35 +0000 (22:47 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Sep 2018 22:47:35 +0000 (22:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189928

Reviewed by Andy Estes.

Make building IOSurface.mm and PixelBufferResizer.mm deterministic regardless of
which bundle of unified sources they are built in.

* platform/graphics/cocoa/IOSurface.mm: Include headers HostWindow.h and PlatformScreen.h
since we make use of functionality from these headers.
* platform/graphics/cv/PixelBufferResizer.h: Include header IntSize.h since
we need the size of an IntSize for m_size.
* platform/graphics/cv/PixelBufferResizer.mm: Include header Logging.h since
this file makes use of logging facilities. Also substitute #import for #include
while I am here since this file is an Objective-C++ file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@236432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/cocoa/IOSurface.mm
Source/WebCore/platform/graphics/cv/PixelBufferResizer.h
Source/WebCore/platform/graphics/cv/PixelBufferResizer.mm

index 213da1a..fe508f3 100644 (file)
@@ -1,3 +1,21 @@
+2018-09-24  Daniel Bates  <dabates@apple.com>
+
+        Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
+        https://bugs.webkit.org/show_bug.cgi?id=189928
+
+        Reviewed by Andy Estes.
+
+        Make building IOSurface.mm and PixelBufferResizer.mm deterministic regardless of
+        which bundle of unified sources they are built in.
+
+        * platform/graphics/cocoa/IOSurface.mm: Include headers HostWindow.h and PlatformScreen.h
+        since we make use of functionality from these headers.
+        * platform/graphics/cv/PixelBufferResizer.h: Include header IntSize.h since
+        we need the size of an IntSize for m_size.
+        * platform/graphics/cv/PixelBufferResizer.mm: Include header Logging.h since
+        this file makes use of logging facilities. Also substitute #import for #include
+        while I am here since this file is an Objective-C++ file.
+
 2018-09-24  Andy Estes  <aestes@apple.com>
 
         [Payment Request] Events cleanup
index f821ee0..1040dbe 100644 (file)
 
 #import "GraphicsContext3D.h"
 #import "GraphicsContextCG.h"
+#import "HostWindow.h"
 #import "IOSurfacePool.h"
 #import "ImageBuffer.h"
 #import "ImageBufferDataCG.h"
 #import "Logging.h"
+#import "PlatformScreen.h"
 #import <pal/spi/cg/CoreGraphicsSPI.h>
 #import <pal/spi/cocoa/IOSurfaceSPI.h>
 #import <wtf/Assertions.h>
index db19536..3dcd4ab 100644 (file)
@@ -27,6 +27,7 @@
 
 #if USE(VIDEOTOOLBOX)
 
+#include "IntSize.h"
 #include <wtf/RetainPtr.h>
 
 typedef struct OpaqueVTPixelTransferSession* VTPixelTransferSessionRef;
index 9401844..6ba0948 100644 (file)
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "config.h"
-#include "PixelBufferResizer.h"
+#import "config.h"
+#import "PixelBufferResizer.h"
 
 #if USE(VIDEOTOOLBOX)
 
-#include <wtf/SoftLinking.h>
+#import "Logging.h"
+#import <wtf/SoftLinking.h>
 
-#include "CoreVideoSoftLink.h"
-#include "VideoToolboxSoftLink.h"
+#import "CoreVideoSoftLink.h"
+#import "VideoToolboxSoftLink.h"
 
 namespace WebCore {