Enabled dark mode CSS support by default.
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 02:27:32 +0000 (02:27 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 02:27:32 +0000 (02:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191609
rdar://problem/46046861

Reviewed by Megan Gardner.

Source/WebCore:

* page/RuntimeEnabledFeatures.h: Set m_isDarkModeCSSEnabled to true.

Source/WebKit:

* Shared/WebPreferences.yaml: Set DarkModeCSSEnabled's defaultValue to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/RuntimeEnabledFeatures.h
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml

index 95126ed..905785c 100644 (file)
@@ -1,5 +1,15 @@
 2018-11-14  Timothy Hatcher  <timothy@apple.com>
 
+        Enabled dark mode CSS support by default.
+        https://bugs.webkit.org/show_bug.cgi?id=191609
+        rdar://problem/46046861
+
+        Reviewed by Megan Gardner.
+
+        * page/RuntimeEnabledFeatures.h: Set m_isDarkModeCSSEnabled to true.
+
+2018-11-14  Timothy Hatcher  <timothy@apple.com>
+
         Default the view background color and text color to different values when in dark mode.
         https://bugs.webkit.org/show_bug.cgi?id=191607
         rdar://problem/46045854
index b3db249..ac79505 100644 (file)
@@ -381,7 +381,7 @@ private:
 #endif
 
 #if ENABLE(DARK_MODE_CSS)
-    bool m_isDarkModeCSSEnabled { false };
+    bool m_isDarkModeCSSEnabled { true };
 #endif
 
 #if ENABLE(INDEXED_DATABASE_IN_WORKERS)
index a32f302..f99d08d 100644 (file)
@@ -1,5 +1,15 @@
 2018-11-14  Timothy Hatcher  <timothy@apple.com>
 
+        Enabled dark mode CSS support by default.
+        https://bugs.webkit.org/show_bug.cgi?id=191609
+        rdar://problem/46046861
+
+        Reviewed by Megan Gardner.
+
+        * Shared/WebPreferences.yaml: Set DarkModeCSSEnabled's defaultValue to true.
+
+2018-11-14  Timothy Hatcher  <timothy@apple.com>
+
         Default the view background color and text color to different values when in dark mode.
         https://bugs.webkit.org/show_bug.cgi?id=191607
         rdar://problem/46045854
index 9e5cc25..d9be99c 100644 (file)
@@ -1323,7 +1323,7 @@ CSSCustomPropertiesAndValuesEnabled:
 
 DarkModeCSSEnabled:
   type: bool
-  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
+  defaultValue: true
   humanReadableName: "Dark Mode CSS Support"
   humanReadableDescription: "Enable Dark Mode CSS Support"
   webcoreBinding: RuntimeEnabledFeatures