2010-06-02 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jun 2010 10:45:42 +0000 (10:45 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 2 Jun 2010 10:45:42 +0000 (10:45 +0000)
        Reviewed by Adam Barth.

        Several layout tests needlessly use invalid HTML
        https://bugs.webkit.org/show_bug.cgi?id=39985

        This change does not change behavior or reduce test coverage.
        It only makes our test suite more clear by making our non-parser
        tests not bother to test parser quirks which are already covered
        by our parsing test suites.

        Two invalid cases which are already tested by
        the html5lib tests as well as others.
        - Unclosed <title> swallowing the document is covered by
          <!doctype html><title>foo/title><link></head><body>X
          and other subtests in html5lib/resources/tests16.dat
          Missing </title> is also covered by the (invalid) test:
          fast/js/missing-title-end-tag-js.html
        - Unclosed <tag swallowing the next tag is covered by:
          fast/invalid/016.html.  I suspect it's also covered by
          various html5lib tests but proved difficult to grep for.

        * css1/box_properties/float_elements_in_series.html:
         - Unclosed <td> tags swallow the following <img> tags.
           This parser quirk is tested by the HTML5 tests and is an
           intentional behavior change as part of HTML5.  No need
           for this test to depend on WebKit's old parser behavior.
        * editing/selection/inactive-selection.html:
         - Same as above. Here <div swallows the <script> tag.
        * editing/selection/select-text-overflow-ellipsis.html:
         - An unclosed <title> will swallow the whole document.
           Intentional HTML5 change, tested by HTML5 test suite and
           no need to depend on the old title behavior here.
        * fast/dom/title-content-write-set.html:
         - Again, no need to leave an unclosed title.
        * fast/forms/select-set-inner.html:
         - Unclosed <body swallows <p>
        * fast/js/exception-linenums-in-html-2.html:
         - Unclosed <title> swallows the document.
        * html5lib/resources/webkit01.dat:
         - Added a test for <img<img> to make sure it's covered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/css1/box_properties/float_elements_in_series.html
LayoutTests/editing/selection/inactive-selection.html
LayoutTests/editing/selection/select-text-overflow-ellipsis.html
LayoutTests/fast/dom/title-content-write-set.html
LayoutTests/fast/forms/select-set-inner.html
LayoutTests/fast/js/exception-linenums-in-html-2.html

index fae3834..1f91436 100644 (file)
@@ -1,3 +1,46 @@
+2010-06-02  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Several layout tests needlessly use invalid HTML
+        https://bugs.webkit.org/show_bug.cgi?id=39985
+
+        This change does not change behavior or reduce test coverage.
+        It only makes our test suite more clear by making our non-parser
+        tests not bother to test parser quirks which are already covered
+        by our parsing test suites.
+
+        Two invalid cases which are already tested by
+        the html5lib tests as well as others.
+        - Unclosed <title> swallowing the document is covered by
+          <!doctype html><title>foo/title><link></head><body>X
+          and other subtests in html5lib/resources/tests16.dat
+          Missing </title> is also covered by the (invalid) test:
+          fast/js/missing-title-end-tag-js.html
+        - Unclosed <tag swallowing the next tag is covered by:
+          fast/invalid/016.html.  I suspect it's also covered by
+          various html5lib tests but proved difficult to grep for.
+
+        * css1/box_properties/float_elements_in_series.html:
+         - Unclosed <td> tags swallow the following <img> tags.
+           This parser quirk is tested by the HTML5 tests and is an
+           intentional behavior change as part of HTML5.  No need
+           for this test to depend on WebKit's old parser behavior.
+        * editing/selection/inactive-selection.html:
+         - Same as above. Here <div swallows the <script> tag.
+        * editing/selection/select-text-overflow-ellipsis.html:
+         - An unclosed <title> will swallow the whole document.
+           Intentional HTML5 change, tested by HTML5 test suite and
+           no need to depend on the old title behavior here.
+        * fast/dom/title-content-write-set.html:
+         - Again, no need to leave an unclosed title.
+        * fast/forms/select-set-inner.html:
+         - Unclosed <body swallows <p>
+        * fast/js/exception-linenums-in-html-2.html:
+         - Unclosed <title> swallows the document.
+        * html5lib/resources/webkit01.dat:
+         - Added a test for <img<img> to make sure it's covered.
+
 2010-06-02  Andrey Kosyakov  <caseq@chromium.org>
 
         Reviewed by Pavel Feldman.
index 500ff02..64f2add 100644 (file)
@@ -59,7 +59,7 @@ TABLE {margin: 20px 0px;}
 <tr>
 <td width="20" style="background: black"><IMG SRC="blank.gif" width="20" height="1"></td>
 <td width=100 style="background: yellow"><IMG SRC="blank.gif" width="100" height="1"></td>
-<td width=20 style="background: black"<IMG SRC="blank.gif" width="20" height="1"></td>
+<td width=20 style="background: black"><IMG SRC="blank.gif" width="20" height="1"></td>
 
 <td width=20 style="background: white"><IMG SRC="blank.gif" width="20" height="1"></td>
 
@@ -110,7 +110,7 @@ TABLE {margin: 20px 0px;}
 <tr>
 <td width="20" style="background: black"><IMG SRC="blank.gif" width="20" height="1"></td>
 <td width=100 style="background: yellow"><IMG SRC="blank.gif" width="100" height="1"></td>
-<td width=20 style="background: black"<IMG SRC="blank.gif" width="20" height="1"></td>
+<td width=20 style="background: black"><IMG SRC="blank.gif" width="20" height="1"></td>
 
 <td width=20 style="background: white"><IMG SRC="blank.gif" width="20" height="1"></td>
 
index 9971c3c..6c19439 100644 (file)
@@ -6,7 +6,7 @@ after you've made a selection in another frame.</p>
 <iframe src="data:text/html, <div id='input' contenteditable='true'>should be an inactive selection</div>"></iframe>
 <br>
 <input id='input' type="text" value="random text">
-<div
+<div>
 <script>
 window.onload = function() {
     if (window.layoutTestController)
index f94fde3..6ce3155 100644 (file)
@@ -1,6 +1,6 @@
 <html>
   <head>
-    <title>Test for WebKit bug 29968: Selecting text with text-overflow ellipsis should not show cut off text</head>
+    <title>Test for WebKit bug 29968: Selecting text with text-overflow ellipsis should not show cut off text</title></head>
   <style type="text/css">
     .cutoff {
       width: 95px;
index bf4d5fe..acd8e19 100644 (file)
@@ -5,7 +5,7 @@ if (window.layoutTestController)
     layoutTestController.dumpAsText();
 document.write("<title>");
 document.title = "Property";
-document.write("Written");
+document.write("Written</title>");
 
 function test()
 {
index 89e2238..972a1dc 100644 (file)
@@ -24,7 +24,7 @@ function test()
 
 </html>
 
-<body onload="test()"
+<body onload="test()">
 
 <p>This tests a case where removing an option element from a select by using innerHTML would cause a crash.</p>
 
index 78dd59f..6a39aa0 100644 (file)
@@ -1,5 +1,5 @@
 <html>
-<head><title>title
+<head><title>title</title>
 <link rel="stylesheet" href="resources/js-test-style.css">
 <script src="resources/js-test-pre.js"></script>
 </head>