[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Mar 2013 13:56:40 +0000 (13:56 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Mar 2013 13:56:40 +0000 (13:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp

index 5ce203a..bdd3068 100644 (file)
@@ -1,3 +1,15 @@
+2013-03-14  Xan Lopez  <xlopez@igalia.com>
+
+        [GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
+        https://bugs.webkit.org/show_bug.cgi?id=112344
+
+        Reviewed by Philippe Normand.
+
+        Correct erroneous ASSERT, we want both member variables to exist.
+
+        * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
+        (WebCore::AudioDestinationGStreamer::stop):
+
 2013-03-14  Ilya Tikhonovsky  <loislo@chromium.org>
 
         Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
index ce48a1e..c674469 100644 (file)
@@ -196,7 +196,7 @@ void AudioDestinationGStreamer::start()
 void AudioDestinationGStreamer::stop()
 {
     ASSERT(m_wavParserAvailable && m_audioSinkAvailable);
-    if (!m_wavParserAvailable || m_audioSinkAvailable)
+    if (!m_wavParserAvailable || !m_audioSinkAvailable)
         return;
 
     gst_element_set_state(m_pipeline, GST_STATE_PAUSED);