[EFL][WK2] ewk_intent_request API test does not free Eina_List
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Aug 2012 15:58:58 +0000 (15:58 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Aug 2012 15:58:58 +0000 (15:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=94809

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-08-23
Reviewed by Kenneth Rohde Christiansen.

The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.

* UIProcess/API/efl/tests/test_ewk2_intents.cpp:
(onIntentReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_intents.cpp

index c848e9e..5d39221 100644 (file)
@@ -1,3 +1,15 @@
+2012-08-23  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
+
+        [EFL][WK2] ewk_intent_request API test does not free Eina_List
+        https://bugs.webkit.org/show_bug.cgi?id=94809
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        The used Eina_List should be freed due to ewk_intent_suggestions_get() documentation.
+
+        * UIProcess/API/efl/tests/test_ewk2_intents.cpp:
+        (onIntentReceived):
+
 2012-08-23  Andras Becsi  <andras.becsi@nokia.com>
 
         [Qt][WK2] Helper functions used by the raw webview tests should not be guarded by HAVE_QTQUICK
 2012-08-23  Andras Becsi  <andras.becsi@nokia.com>
 
         [Qt][WK2] Helper functions used by the raw webview tests should not be guarded by HAVE_QTQUICK
index fdf7fdf..be8b0ff 100644 (file)
@@ -92,6 +92,10 @@ static void onIntentReceived(void* userData, Evas_Object*, void* eventInfo)
         suggestions = eina_list_sort(suggestions, 2, stringSortCb);
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 0)), "http://service1.com/");
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 1)), "http://service2.com/");
         suggestions = eina_list_sort(suggestions, 2, stringSortCb);
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 0)), "http://service1.com/");
         EXPECT_STREQ(static_cast<const char*>(eina_list_nth(suggestions, 1)), "http://service2.com/");
+
+        void* listData = 0;
+        EINA_LIST_FREE(suggestions, listData)
+             eina_stringshare_del(static_cast<const char*>(listData));
     }
 }
 
     }
 }