Web Inspector: REGRESSION (r209882): Opening find banner in editor causes UI to hang
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2016 21:20:53 +0000 (21:20 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Dec 2016 21:20:53 +0000 (21:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=165967

Reviewed by Timothy Hatcher.

* UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype._findBannerDidShow):
Showing the find banner should cause search results to be refreshed only
if it contains query text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/ContentBrowser.js

index 0600d4b..17adb07 100644 (file)
@@ -1,5 +1,17 @@
 2016-12-16  Matt Baker  <mattbaker@apple.com>
 
+        Web Inspector: REGRESSION (r209882): Opening find banner in editor causes UI to hang
+        https://bugs.webkit.org/show_bug.cgi?id=165967
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ContentBrowser.js:
+        (WebInspector.ContentBrowser.prototype._findBannerDidShow):
+        Showing the find banner should cause search results to be refreshed only
+        if it contains query text.
+
+2016-12-16  Matt Baker  <mattbaker@apple.com>
+
         Web Inspector: Modernize find banner UI
         https://bugs.webkit.org/show_bug.cgi?id=165939
 
index 1035b86..37c63ce 100644 (file)
@@ -294,7 +294,8 @@ WebInspector.ContentBrowser = class ContentBrowser extends WebInspector.View
             return;
 
         currentContentView.automaticallyRevealFirstSearchResult = true;
-        currentContentView.performSearch(this._findBanner.searchQuery);
+        if (this._findBanner.searchQuery !== "")
+            currentContentView.performSearch(this._findBanner.searchQuery);
     }
 
     _findBannerDidHide(event)