[EFL] Turn on ENABLE_CSS_FILTERS
authorm.pakula@samsung.com <m.pakula@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 May 2014 18:22:28 +0000 (18:22 +0000)
committerm.pakula@samsung.com <m.pakula@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 May 2014 18:22:28 +0000 (18:22 +0000)
https://bugs.webkit.org/show_bug.cgi?id=133153

Reviewed by Gyuyoung Kim.

.:
* Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.

Source/WebKit2:
Make WebKit2 compile after r166741 when CSS_FILTERS are enabled.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):

LayoutTests:
Remove failure test expectations for tests passing after turning on CSS_FILTERS.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@169172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/efl-wk2/TestExpectations
LayoutTests/platform/efl/TestExpectations
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp
Source/cmake/OptionsEfl.cmake

index e95d5d4..cd40438 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2014-05-21  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
+
+        [EFL] Turn on ENABLE_CSS_FILTERS
+        https://bugs.webkit.org/show_bug.cgi?id=133153
+
+        Reviewed by Gyuyoung Kim.
+
+        * Source/cmake/OptionsEfl.cmake: Enable CSS_FILTERS as default option value.
+
 2014-05-16  Martin Robinson  <mrobinson@igalia.com>
 
         [CMake] Improve handling of LIB_INSTALL_DIR, EXEC_INSTALL_DIR, and LIBEXEC_INSTALL_DIR
index 0468e74..81c643a 100644 (file)
@@ -1,3 +1,15 @@
+2014-05-21  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
+
+        [EFL] Turn on ENABLE_CSS_FILTERS
+        https://bugs.webkit.org/show_bug.cgi?id=133153
+
+        Reviewed by Gyuyoung Kim.
+
+        Remove failure test expectations for tests passing after turning on CSS_FILTERS.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/efl/TestExpectations:
+
 2014-05-21  Zalan Bujtas  <zalan@apple.com>
 
         Unreviewed Mac gardening after r169161.
index a7892d5..4ca373b 100644 (file)
@@ -349,9 +349,6 @@ webkit.org/b/98743 plugins/evaluate-js-after-removing-plugin-element.html [ Fail
 webkit.org/b/98741 plugins/npruntime/browser-object-identity.html [ Failure ]
 webkit.org/b/98741 plugins/refcount-leaks.html [ Failure ]
 
-# New compositing tests introduced in r137051 that fail on WK2 EFL.
-webkit.org/b/104476 compositing/background-color/background-color-padding-change.html [ ImageOnlyFailure ]
-
 # These ref tests are failing because the text is blurry.
 webkit.org/b/105766 compositing/text-on-scaled-layer.html [ ImageOnlyFailure ]
 webkit.org/b/105766 compositing/text-on-scaled-surface.html [ ImageOnlyFailure ]
@@ -524,8 +521,6 @@ webkit.org/b/128734 plugins/netscape-destroy-plugin-script-objects.html [ Failur
 
 webkit.org/b/128737 fast/events/touch/basic-multi-touch-events.html [ Failure ]
 
-webkit.org/b/129731 css3/masking/clip-path-filter.html [ ImageOnlyFailure ]
-
 webkit.org/b/129734 fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html [ ImageOnlyFailure ]
 
 webkit.org/b/129735 fast/regions/box-decorations-over-region-padding.html [ ImageOnlyFailure ]
index 3bbfe13..49f3640 100644 (file)
@@ -1456,18 +1456,8 @@ webkit.org/b/120682 inspector-protocol/page/archive.html [ Failure ]
 
 webkit.org/b/124414 animations/cross-fade-background-image.html [ ImageOnlyFailure ]
 
-# ref test mismatch does not occur
-webkit.org/b/124417 fast/css/drop-shadow-viewport-height.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-vmax.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-vmin.html [ ImageOnlyFailure ]
-webkit.org/b/124417 fast/css/drop-shadow-viewport-width.html [ ImageOnlyFailure ]
-
 # CSS filters layout tests are failing
-webkit.org/b/124516 fast/filter-image/filter-image-animation.html [ Failure ]
-webkit.org/b/124517 fast/filter-image/filter-image-blur.html [ ImageOnlyFailure ]
 webkit.org/b/124518 fast/filter-image/filter-image-svg.html [ ImageOnlyFailure ]
-webkit.org/b/124519 fast/filter-image/filter-image.html [ ImageOnlyFailure ]
-webkit.org/b/124519 fast/filter-image/parse-filter-image.html [ Failure ]
 
 webkit.org/b/124582 fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ]
 
index 4255bd8..6a31539 100644 (file)
@@ -1,3 +1,15 @@
+2014-05-21  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
+
+        [EFL] Turn on ENABLE_CSS_FILTERS
+        https://bugs.webkit.org/show_bug.cgi?id=133153
+
+        Reviewed by Gyuyoung Kim.
+
+        Make WebKit2 compile after r166741 when CSS_FILTERS are enabled.
+
+        * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
+        (IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
+
 2014-05-21  Brady Eidson  <beidson@apple.com>
 
         Special handling of telephone number detection menu.
index bde0c8a..022fdc8 100644 (file)
@@ -139,7 +139,7 @@ bool ArgumentCoder<WebCore::FilterOperations>::decode(ArgumentDecoder& decoder,
             Length length;
             if (!ArgumentCoder<Length>::decode(decoder, length))
                 return false;
-            filter = BlurFilterOperation::create(length, type);
+            filter = BlurFilterOperation::create(length);
             break;
         }
         case FilterOperation::DROP_SHADOW: {
@@ -152,7 +152,7 @@ bool ArgumentCoder<WebCore::FilterOperations>::decode(ArgumentDecoder& decoder,
                 return false;
             if (!ArgumentCoder<Color>::decode(decoder, color))
                 return false;
-            filter = DropShadowFilterOperation::create(location, stdDeviation, color, type);
+            filter = DropShadowFilterOperation::create(location, stdDeviation, color);
             break;
         }
         default:
index ef2250f..575d9f5 100644 (file)
@@ -54,6 +54,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_DEVICE_ADAPTATION ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_FILTERS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_GRID_LAYOUT OFF)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_REGIONS ON)