Page Up and Page Down mappings are backwards on BlackBerry port.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Jan 2012 20:57:17 +0000 (20:57 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 25 Jan 2012 20:57:17 +0000 (20:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=77021

Fix Page Up and Page Down mappings as they are reversed.

Patch by Mike Fenton <mifenton@rim.com> on 2012-01-25
Reviewed by Antonio Gomes.

* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp

index fb34cf4..40b8d29 100644 (file)
@@ -1,3 +1,16 @@
+2012-01-25  Mike Fenton  <mifenton@rim.com>
+
+        Page Up and Page Down mappings are backwards on BlackBerry port.
+        https://bugs.webkit.org/show_bug.cgi?id=77021
+
+        Fix Page Up and Page Down mappings as they are reversed.
+
+        Reviewed by Antonio Gomes.
+
+        * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
+        (WebCore::keyIdentifierForBlackBerryCharacter):
+        (WebCore::windowsKeyCodeForBlackBerryCharacter):
+
 2012-01-25  Hajime Morita  <morrita@google.com>
 
         <content> should create HTMLContentElement object
index b8fc1ee..607126b 100644 (file)
@@ -73,10 +73,10 @@ static String keyIdentifierForBlackBerryCharacter(unsigned short character)
         return "Insert";
     case KEYCODE_PG_UP:
     case KEYCODE_KP_PG_UP:
-        return "PageDown";
+        return "PageUp";
     case KEYCODE_PG_DOWN:
     case KEYCODE_KP_PG_DOWN:
-        return "PageUp";
+        return "PageDown";
     case KEYCODE_END:
     case KEYCODE_KP_END:
         return "End";
@@ -299,10 +299,10 @@ static int windowsKeyCodeForBlackBerryCharacter(unsigned short character)
         return VK_INSERT;
     case KEYCODE_PG_UP:
     case KEYCODE_KP_PG_UP:
-        return VK_NEXT;
+        return VK_PRIOR;
     case KEYCODE_PG_DOWN:
     case KEYCODE_KP_PG_DOWN:
-        return VK_PRIOR;
+        return VK_NEXT;
     case KEYCODE_END:
     case KEYCODE_KP_END:
         return VK_END;