removei build warning (unused parameter )
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Apr 2013 12:43:55 +0000 (12:43 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Apr 2013 12:43:55 +0000 (12:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=114670

Patch by Xuefei Ren <xren@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.

remove warning (unused parameter ) in
Source/WebKit/blackberry/WebCoreSupport

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
(WebCore::ChromeClientBlackBerry::needTouchEvents):
(WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::checkSpellingOfString):
(WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
* WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
(WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
(WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::generateHTML):
* WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::UserMediaClientImpl::requestUserMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/blackberry/ChangeLog
Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp
Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp
Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp
Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp
Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp
Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp

index dd7a17e..e52a1f3 100644 (file)
@@ -1,3 +1,36 @@
+2013-04-18  Xuefei Ren  <xren@blackberry.com>
+
+        removei build  warning (unused parameter )
+        https://bugs.webkit.org/show_bug.cgi?id=114670
+
+        Reviewed by Rob Buis.
+
+        remove warning (unused parameter ) in
+        Source/WebKit/blackberry/WebCoreSupport
+
+        * WebCoreSupport/ChromeClientBlackBerry.cpp:
+        (WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
+        (WebCore::ChromeClientBlackBerry::needTouchEvents):
+        (WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
+        * WebCoreSupport/DatePickerClient.cpp:
+        (WebCore::DatePickerClient::setValue):
+        * WebCoreSupport/EditorClientBlackBerry.cpp:
+        (WebCore::EditorClientBlackBerry::checkSpellingOfString):
+        (WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
+        (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
+        (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
+        * WebCoreSupport/InspectorClientBlackBerry.cpp:
+        (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
+        * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
+        (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
+        (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
+        * WebCoreSupport/SelectPopupClient.cpp:
+        (WebCore::SelectPopupClient::generateHTML):
+        * WebCoreSupport/UserMediaClientImpl.cpp:
+        (WebCore::UserMediaClientImpl::requestUserMedia):
+
 2013-04-17  Nima Ghanavatian  <nghanavatian@blackberry.com>
 
         Clean up spellcheck state when changing focus.
index d81ff25..51f2a66 100644 (file)
@@ -445,7 +445,7 @@ IntRect ChromeClientBlackBerry::rootViewToScreen(const IntRect& windowRect) cons
     return windowPoint;
 }
 
-void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult& result, unsigned int modifierFlags)
+void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult&, unsigned)
 {
     notImplemented();
 }
@@ -667,12 +667,12 @@ PlatformPageClient ChromeClientBlackBerry::platformPageClient() const
 }
 
 #if ENABLE(TOUCH_EVENTS)
-void ChromeClientBlackBerry::needTouchEvents(bool value)
+void ChromeClientBlackBerry::needTouchEvents(bool)
 {
 }
 #endif
 
-void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t spaceNeeded)
+void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t)
 {
     notImplemented();
 }
index e178f1b..a651b19 100644 (file)
@@ -138,7 +138,7 @@ void DatePickerClient::setValueAndClosePopup(int, const String& value)
     closePopup();
 }
 
-void DatePickerClient::setValue(const String& value)
+void DatePickerClient::setValue(const String&)
 {
     notImplemented();
 }
index cf0cccb..337bcef 100644 (file)
@@ -563,12 +563,12 @@ void EditorClientBlackBerry::learnWord(const WTF::String&)
     notImplemented();
 }
 
-void EditorClientBlackBerry::checkSpellingOfString(const UChar* text, int textLength, int* misspellLocation, int* misspellLength)
+void EditorClientBlackBerry::checkSpellingOfString(const UChar*, int, int*, int*)
 {
     notImplemented();
 }
 
-WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String& misspelledWord)
+WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String&)
 {
     notImplemented();
     return WTF::String();
index ab52297..7a5a9b3 100644 (file)
@@ -264,7 +264,7 @@ void FrameLoaderClientBlackBerry::doPendingFragmentScroll()
     delayPolicyCheckUntilFragmentExists(fragment, function);
 }
 
-void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String& frameName)
+void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String&)
 {
     if (ScriptController::processingUserGesture() && !m_webPagePrivate->m_pluginMayOpenNewTab) {
         (m_frame->loader()->policyChecker()->*function)(PolicyIgnore);
@@ -503,7 +503,7 @@ void FrameLoaderClientBlackBerry::dispatchDidStartProvisionalLoad()
     m_wasProvisionalLoadTriggeredByUserGesture = ScriptController::processingUserGesture();
 }
 
-void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, const ResourceResponse& response)
+void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const ResourceResponse& response)
 {
     if (m_webPagePrivate->m_dumpRenderTree)
         m_webPagePrivate->m_dumpRenderTree->didReceiveResponseForFrame(m_frame, response);
@@ -1009,7 +1009,7 @@ void FrameLoaderClientBlackBerry::dispatchWillSendRequest(DocumentLoader* docLoa
     }
 }
 
-bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader* loader, long unsigned identifier)
+bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader*, long unsigned)
 {
 #if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
     if (m_frame->page()->settings()->privateBrowsingEnabled())
index 26c23f0..371fd08 100644 (file)
@@ -103,7 +103,7 @@ bool InspectorClientBlackBerry::supportsFrameInstrumentation()
     return true;
 }
 
-void InspectorClientBlackBerry::updateInspectorStateCookie(const String& cookie)
+void InspectorClientBlackBerry::updateInspectorStateCookie(const String&)
 {
     // If this is implemented, we should override and return true in InspectorStateClient::supportsInspectorStateUpdates().
     notImplemented();
index f12c6bb..423ff99 100644 (file)
@@ -99,7 +99,7 @@ bool NetworkInfoClientBlackBerry::metered() const
     return false;
 }
 
-void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType newInternalNetworkType)
+void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType)
 {
     if (m_isActive) {
         RefPtr<NetworkInfo> newNetworkInfo = NetworkInfo::create(bandwidth(), metered());
@@ -107,7 +107,7 @@ void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platfor
     }
 }
 
-void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType newCellularType)
+void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType)
 {
     // Only dispatch to listeners if the current type is cellular.
     if (BlackBerry::Platform::NetworkInfo::instance()->getCurrentNetworkType() == BlackBerry::Platform::NetworkTypeCellular && m_isActive) {
index a3e001e..266b647 100644 (file)
@@ -64,7 +64,7 @@ void SelectPopupClient::update(bool multiple, int size, const ScopeArray<BlackBe
     generateHTML(multiple, size, labels, enableds, itemType, selecteds);
 }
 
-void SelectPopupClient::generateHTML(bool multiple, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
+void SelectPopupClient::generateHTML(bool, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
     const int* itemType, bool* selecteds)
 {
     StringBuilder source;
index a7baf20..67f2379 100644 (file)
@@ -113,7 +113,7 @@ void UserMediaClientImpl::pageDestroyed()
     delete this;
 }
 
-void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector& audioSources, const MediaStreamSourceVector& videoSources)
+void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector&, const MediaStreamSourceVector&)
 {
     UserMediaRequest* request = prpRequest.get();
     OwnPtr<WebUserMediaRequestClientImpl> requestClient = adoptPtr(new WebUserMediaRequestClientImpl(prpRequest));