webkitpy: Missing PID in crashlog name should not be fatal
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jan 2019 18:26:05 +0000 (18:26 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 24 Jan 2019 18:26:05 +0000 (18:26 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193771

If we can't determine the PID of a crashlog, just ignore the crashlog instead
of raising an exception.

Reviewed by Lucas Forschler.

* Scripts/webkitpy/port/darwin.py:
(DarwinPort._merge_crash_logs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/darwin.py

index 2efd53b..d34f7fe 100644 (file)
@@ -1,3 +1,16 @@
+2019-01-24  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Missing PID in crashlog name should not be fatal
+        https://bugs.webkit.org/show_bug.cgi?id=193771
+
+        If we can't determine the PID of a crashlog, just ignore the crashlog instead
+        of raising an exception.
+
+        Reviewed by Lucas Forschler.
+
+        * Scripts/webkitpy/port/darwin.py:
+        (DarwinPort._merge_crash_logs):
+
 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
index 9c9ae99..ebaf5b2 100644 (file)
@@ -104,7 +104,7 @@ class DarwinPort(ApplePort):
                 else:
                     process_name = test.split('-')[0]
                     pid = int(test.split('-')[1])
-            except IndexError:
+            except IndexError, ValueError:
                 continue
             if not any(entry[1] == process_name and entry[2] == pid for entry in crashed_processes):
                 # if this is a new crash, then append the logs