AppScale: Use https URLs for subresources and links
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 5 Aug 2015 19:54:12 +0000 (19:54 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 5 Aug 2015 19:54:12 +0000 (19:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=147686

Reviewed by Ryosuke Niwa.

* QueueStatusServer/filters/webkit_extras.py:
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/treemap.js:
* TestResultServer/static-dashboards/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/filters/webkit_extras.py
Tools/TestResultServer/static-dashboards/dashboard_base.js
Tools/TestResultServer/static-dashboards/flakiness_dashboard.js
Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js
Tools/TestResultServer/static-dashboards/treemap.js
Tools/TestResultServer/static-dashboards/ui.js

index e1700f8..515366f 100644 (file)
@@ -1,3 +1,17 @@
+2015-08-05  Alexey Proskuryakov  <ap@apple.com>
+
+        AppScale: Use https URLs for subresources and links
+        https://bugs.webkit.org/show_bug.cgi?id=147686
+
+        Reviewed by Ryosuke Niwa.
+
+        * QueueStatusServer/filters/webkit_extras.py:
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+        * TestResultServer/static-dashboards/treemap.js:
+        * TestResultServer/static-dashboards/ui.js:
+
 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
 
         Rename Mutex to DeprecatedMutex
index 5b3c9b1..103269b 100644 (file)
@@ -40,7 +40,7 @@ patch_regexp = re.compile(r"patch (?P<patch_id>\d+)")
 @register.filter
 @stringfilter
 def webkit_linkify(value):
-    value = bug_regexp.sub(r'<a href="http://webkit.org/b/\g<bug_id>">bug \g<bug_id></a>', value)
+    value = bug_regexp.sub(r'<a href="https://webkit.org/b/\g<bug_id>">bug \g<bug_id></a>', value)
     value = patch_regexp.sub(r'<a href="https://bugs.webkit.org/attachment.cgi?id=\g<patch_id>&action=prettypatch">patch \g<patch_id></a>', value)
     return value
 
@@ -48,7 +48,7 @@ def webkit_linkify(value):
 @register.filter
 @stringfilter
 def webkit_bug_id(value):
-    return '<a href="http://webkit.org/b/%s">%s</a>' % (value, value)
+    return '<a href="https://webkit.org/b/%s">%s</a>' % (value, value)
 
 
 @register.filter
index 3d0c40e..4016f75 100644 (file)
@@ -73,7 +73,7 @@ var ONE_DAY_SECONDS = 60 * 60 * 24;
 var ONE_WEEK_SECONDS = ONE_DAY_SECONDS * 7;
 
 // These should match the testtype uploaded to webkit-test-results.webkit.org.
-// See http://webkit-test-results.webkit.org/testfile.
+// See https://webkit-test-results.webkit.org/testfile.
 var TEST_TYPES = [
     'layout-tests'
 ];
index e0519a7..41fb0b3 100644 (file)
@@ -33,8 +33,8 @@ var ALL = 'ALL';
 var FORWARD = 'forward';
 var BACKWARD = 'backward';
 var GTEST_MODIFIERS = ['FLAKY', 'FAILS', 'MAYBE', 'DISABLED'];
-var TEST_URL_BASE_PATH_TRAC = 'http://trac.webkit.org/browser/trunk/LayoutTests/';
-var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
+var TEST_URL_BASE_PATH_TRAC = 'https://trac.webkit.org/browser/trunk/LayoutTests/';
+var TEST_URL_BASE_PATH = "https://svn.webkit.org/repository/webkit/trunk/LayoutTests/";
 var EXPECTATIONS_URL_BASE_PATH = TEST_URL_BASE_PATH + "platform/";
 
 var PLATFORMS = {
@@ -1092,7 +1092,7 @@ function processMissingAndExtraExpectations(resultsForTest)
 }
 
 
-var BUG_URL_PREFIX = '<a href="http://';
+var BUG_URL_PREFIX = '<a href="https://';
 var BUG_URL_POSTFIX = '/$1">crbug.com/$1</a> ';
 var WEBKIT_BUG_URL_POSTFIX = '/$1">webkit.org/b/$1</a> ';
 var INTERNAL_BUG_REPLACE_VALUE = BUG_URL_PREFIX + 'b' + BUG_URL_POSTFIX;
@@ -1182,7 +1182,7 @@ function showPopupForBuild(e, builder, index, opt_testName)
     html += '<ul><li>' + linkHTMLToOpenWindow(buildBasePath, 'Build log') +
         '</li><li>' +
         createBlameListHTML(g_resultsByBuilder[builder].webkitRevision, index,
-            'http://trac.webkit.org/log/?verbose=on&rev=', '&stop_rev=',
+            'https://trac.webkit.org/log/?verbose=on&rev=', '&stop_rev=',
             'WebKit') +
         '</li>';
 
@@ -1857,14 +1857,14 @@ function addExpectationItem(expectationsContainers, parentContainer, platform, p
     };
 
     var url = base + platformPart + path;
-    if (isImage || !string.startsWith(base, 'http://svn.webkit.org')) {
+    if (isImage || !string.startsWith(base, 'https://svn.webkit.org')) {
         var dummyNode = document.createElement(isImage ? 'img' : 'script');
         dummyNode.src = url;
         dummyNode.onload = function() {
             var item;
             if (isImage) {
                 item = dummyNode;
-                if (string.startsWith(base, 'http://svn.webkit.org'))
+                if (string.startsWith(base, 'https://svn.webkit.org'))
                     maybeAddPngChecksum(item, url);
             } else {
                 item = document.createElement('iframe');
index 8e5d414..f202051 100644 (file)
@@ -400,7 +400,7 @@ test('htmlForIndividualTests', 4, function() {
 
     var tests = [test1, test2];
     equal(htmlForIndividualTests(tests),
-        '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
+        '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
         htmlForIndividualTestOnAllBuilders(test1) + 
         '<div class=expectations test=foo/nonexistant.html>' +
             '<div><span class=link onclick=\"g_history.setQueryParameter(\'showExpectations\', true)\">Show results</span> | ' +
@@ -408,7 +408,7 @@ test('htmlForIndividualTests', 4, function() {
             '<b>Only shows actual results/diffs from the most recent *failure* on each bot.</b></div>' +
         '</div>' +
         '<hr>' +
-        '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
+        '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
         htmlForIndividualTestOnAllBuilders(test2) +
         '<div class=expectations test=bar/nonexistant.html>' +
             '<div><span class=link onclick=\"g_history.setQueryParameter(\'showExpectations\', true)\">Show results</span> | ' +
@@ -427,14 +427,14 @@ test('htmlForIndividualTests', 4, function() {
     historyInstance.dashboardSpecificState.showChrome = true;
 
     equal(htmlForIndividualTests(tests),
-        '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
+        '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
         htmlForIndividualTestOnAllBuildersWithResultsLinks(test1));
 
     tests = [test1, test2];
     equal(htmlForIndividualTests(tests),
-        '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
+        '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/foo/nonexistant.html" target="_blank">foo/nonexistant.html</a></h2>' +
         htmlForIndividualTestOnAllBuildersWithResultsLinks(test1) + '<hr>' +
-        '<h2><a href="http://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
+        '<h2><a href="https://trac.webkit.org/browser/trunk/LayoutTests/bar/nonexistant.html" target="_blank">bar/nonexistant.html</a></h2>' +
         htmlForIndividualTestOnAllBuildersWithResultsLinks(test2));
 });
 
index db99b8a..b5e3779 100644 (file)
@@ -97,7 +97,7 @@ var treemapConfig = {
 var g_history = new history.History(treemapConfig);
 g_history.parseCrossDashboardParameters();
 
-var TEST_URL_BASE_PATH = "http://svn.webkit.org/repository/webkit/trunk/";
+var TEST_URL_BASE_PATH = "https://svn.webkit.org/repository/webkit/trunk/";
 
 function humanReadableTime(milliseconds)
 {
index c3c9d04..601de4e 100644 (file)
@@ -182,8 +182,8 @@ ui.html.webKitRevisionLink = function(results, index)
         results,
         index,
         WEBKIT_REVISIONS_KEY,
-        'http://trac.webkit.org/changeset/<rev>',
-        'http://trac.webkit.org/log/trunk/?rev=<rev1>&stop_rev=<rev2>&limit=100&verbose=on');
+        'https://trac.webkit.org/changeset/<rev>',
+        'https://trac.webkit.org/log/trunk/?rev=<rev1>&stop_rev=<rev2>&limit=100&verbose=on');
 }