Remove more i386 specific configurations
authorweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 31 Mar 2019 19:29:56 +0000 (19:29 +0000)
committerweinig@apple.com <weinig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 31 Mar 2019 19:29:56 +0000 (19:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196430

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

* Configurations/ToolExecutable.xcconfig:
ARC can be enabled unconditionally now.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebKit:

* Configurations/BaseTarget.xcconfig:
WK_HAVE_CORE_PREDICTION can now be enabled unconditionally.

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebKit/ChangeLog
Source/WebKit/Configurations/BaseTarget.xcconfig
Source/WebKit/Configurations/FeatureDefines.xcconfig
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

index e711256..3b151b0 100644 (file)
@@ -1,3 +1,16 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
+        * Configurations/ToolExecutable.xcconfig:
+        ARC can be enabled unconditionally now.
+
 2019-03-29  Yusuke Suzuki  <ysuzuki@apple.com>
 
         [JSC] JSWrapperMap should not use Objective-C Weak map (NSMapTable with NSPointerFunctionsWeakMemory) for m_cachedObjCWrappers
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
index 61f65ea..582107c 100644 (file)
@@ -43,7 +43,6 @@ SKIP_INSTALL_NO = YES;
 SKIP_INSTALL_YES = NO;
 
 CLANG_ENABLE_OBJC_ARC = YES;
-CLANG_ENABLE_OBJC_ARC[sdk=macosx*][arch=i386] = NO;
 
 OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
index 6c4c628..abaee66 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aestes@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
index d5abab0..39025fd 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
 
         Delete WebMetal implementation in favor of WebGPU
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
index 86f091d..d4aa525 100644 (file)
@@ -1,3 +1,16 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/BaseTarget.xcconfig:
+        WK_HAVE_CORE_PREDICTION can now be enabled unconditionally.
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aestes@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
index 0eabde2..c326814 100644 (file)
@@ -107,7 +107,6 @@ WK_INSTALL_PATH_PREFIX = $(WK_INSTALL_PATH_PREFIX_DEPLOYMENT_$(DEPLOYMENT_LOCATI
 WK_INSTALL_PATH_PREFIX_DEPLOYMENT_YES_MACOS_SINCE_1015_USE_STAGING_INSTALL_PATH_YES = $(PLATFORM_OOB_SYSTEM_CONTENT_DIR);
 
 WK_HAVE_CORE_PREDICTION = YES;
-WK_HAVE_CORE_PREDICTION[sdk=macosx*][arch=i386] = NO;
 
 WK_CORE_PREDICTION_DEFINES = $(WK_CORE_PREDICTION_DEFINES_$(WK_HAVE_CORE_PREDICTION));
 WK_CORE_PREDICTION_DEFINES_YES = HAVE_CORE_PREDICTION;
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
index fa12829..d19dcda 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
+
 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
 
         Delete WebMetal implementation in favor of WebGPU
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;
 
index aa1c6f3..c597c68 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-31  Sam Weinig  <weinig@apple.com>
+
+        Remove more i386 specific configurations
+        https://bugs.webkit.org/show_bug.cgi?id=196430
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+        ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
+
 2019-03-31  Andy Estes  <aestes@apple.com>
 
         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
index 5e05c65..1b0ab14 100644 (file)
@@ -396,12 +396,12 @@ ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
 ENABLE_WEB_AUTHN = $(ENABLE_WEB_AUTHN_$(WK_PLATFORM_NAME));
 ENABLE_WEB_AUTHN_iphoneos = ENABLE_WEB_AUTHN;
 ENABLE_WEB_AUTHN_iphonesimulator = ENABLE_WEB_AUTHN;
-ENABLE_WEB_AUTHN_macosx[arch=x86_64] = ENABLE_WEB_AUTHN;
+ENABLE_WEB_AUTHN_macosx = ENABLE_WEB_AUTHN;
 
 ENABLE_WEB_RTC = $(ENABLE_WEB_RTC_$(WK_PLATFORM_NAME));
 ENABLE_WEB_RTC_iphoneos = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC_iphonesimulator = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_macosx[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_macosx = ENABLE_WEB_RTC;
 
 ENABLE_WIRELESS_PLAYBACK_TARGET = ENABLE_WIRELESS_PLAYBACK_TARGET;