[EFL] Get rid of GeolocationServiceEfl
authorkubo@profusion.mobi <kubo@profusion.mobi@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Feb 2012 23:15:29 +0000 (23:15 +0000)
committerkubo@profusion.mobi <kubo@profusion.mobi@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Feb 2012 23:15:29 +0000 (23:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=79270

Reviewed by Adam Barth.

These were just a bunch of dummy files with no real functionality, and
removing them helps the preparation of bug 78853, which will make
client-based geolocation the default.

No new tests, this functionality was not used.

* PlatformEfl.cmake:
* platform/efl/GeolocationServiceEfl.cpp: Removed.
* platform/efl/GeolocationServiceEfl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/PlatformEfl.cmake
Source/WebCore/platform/efl/GeolocationServiceEfl.cpp [deleted file]
Source/WebCore/platform/efl/GeolocationServiceEfl.h [deleted file]

index 266f291..9edca0a 100644 (file)
@@ -1,3 +1,20 @@
+2012-02-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Get rid of GeolocationServiceEfl
+        https://bugs.webkit.org/show_bug.cgi?id=79270
+
+        Reviewed by Adam Barth.
+
+        These were just a bunch of dummy files with no real functionality, and
+        removing them helps the preparation of bug 78853, which will make
+        client-based geolocation the default.
+
+        No new tests, this functionality was not used.
+
+        * PlatformEfl.cmake:
+        * platform/efl/GeolocationServiceEfl.cpp: Removed.
+        * platform/efl/GeolocationServiceEfl.h: Removed.
+
 2012-02-22  Julien Chaffraix  <jchaffraix@webkit.org>
 
         Clean-up RenderTableSection::calcRowLogicalHeight
index ac4d1b4..5d98c89 100644 (file)
@@ -181,12 +181,6 @@ IF (WTF_USE_ICU_UNICODE)
   )
 ENDIF ()
 
-IF (ENABLE_GEOLOCATION)
-  LIST(APPEND WebCore_SOURCES
-    platform/efl/GeolocationServiceEfl.cpp
-  )
-ENDIF()
-
 IF (ENABLE_VIDEO)
   LIST(APPEND WebCore_INCLUDE_DIRECTORIES
     "${WEBCORE_DIR}/platform/graphics/gstreamer"
diff --git a/Source/WebCore/platform/efl/GeolocationServiceEfl.cpp b/Source/WebCore/platform/efl/GeolocationServiceEfl.cpp
deleted file mode 100644 (file)
index 975c720..0000000
+++ /dev/null
@@ -1,72 +0,0 @@
-/*
- * Copyright (C) 2008 Holger Hans Peter Freyther
- * Copyright (C) 2011 Samsung Electronics
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#include "config.h"
-#include "GeolocationServiceEfl.h"
-
-#if ENABLE(GEOLOCATION)
-#include "NotImplemented.h"
-#include "PositionOptions.h"
-#include <wtf/text/CString.h>
-
-namespace WebCore {
-
-#if !ENABLE(CLIENT_BASED_GEOLOCATION)
-GeolocationService::FactoryFunction* GeolocationService::s_factoryFunction = &GeolocationServiceEfl::create;
-#endif
-
-PassOwnPtr<GeolocationService> GeolocationServiceEfl::create(GeolocationServiceClient* client)
-{
-    return adoptPtr(new GeolocationServiceEfl(client));
-}
-
-GeolocationServiceEfl::GeolocationServiceEfl(GeolocationServiceClient* client)
-    : GeolocationService(client)
-{
-}
-
-GeolocationServiceEfl::~GeolocationServiceEfl()
-{
-    notImplemented();
-}
-
-bool GeolocationServiceEfl::startUpdating(PositionOptions* options)
-{
-    notImplemented();
-    return false;
-}
-
-void GeolocationServiceEfl::stopUpdating()
-{
-    notImplemented();
-}
-
-Geoposition* GeolocationServiceEfl::lastPosition() const
-{
-    return m_lastPosition.get();
-}
-
-PositionError* GeolocationServiceEfl::lastError() const
-{
-    return m_lastError.get();
-}
-
-}
-#endif // ENABLE(GEOLOCATION)
diff --git a/Source/WebCore/platform/efl/GeolocationServiceEfl.h b/Source/WebCore/platform/efl/GeolocationServiceEfl.h
deleted file mode 100644 (file)
index 0cd3e8b..0000000
+++ /dev/null
@@ -1,53 +0,0 @@
-/*
- * Copyright (C) 2008 Holger Hans Peter Freyther
- * Copyright (C) 2011 Samsung Electronics
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB.  If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- */
-
-#ifndef GeolocationServiceEfl_h
-#define GeolocationServiceEfl_h
-
-#if ENABLE(GEOLOCATION)
-#include "GeolocationService.h"
-#include "Geoposition.h"
-#include "PositionError.h"
-#include "RefPtr.h"
-
-namespace WebCore {
-
-class GeolocationServiceEfl : public GeolocationService {
-public:
-    static PassOwnPtr<GeolocationService> create(GeolocationServiceClient*);
-    ~GeolocationServiceEfl();
-
-    virtual bool startUpdating(PositionOptions*);
-    virtual void stopUpdating();
-
-    virtual Geoposition* lastPosition() const;
-    virtual PositionError* lastError() const;
-
-private:
-    GeolocationServiceEfl(GeolocationServiceClient*);
-
-    RefPtr<Geoposition> m_lastPosition;
-    RefPtr<PositionError> m_lastError;
-
-};
-
-}
-#endif // ENABLE(GEOLOCATION)
-#endif