[CSS Filters] Filters should render using sRGB until the specification says how it...
authorachicu@adobe.com <achicu@adobe.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Aug 2012 21:02:13 +0000 (21:02 +0000)
committerachicu@adobe.com <achicu@adobe.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Aug 2012 21:02:13 +0000 (21:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=94372

Reviewed by Dirk Schulze.

Source/WebCore:

The short-hand version of the CSS Filters should render using sRGB until a CSS property is added
to allow choosing the color space to be used when computing the filters.
For now I've just made all the CSS filters use sRGB by defualt. Note that this change has no effect on SVG filters.

Test: css3/filters/null-effect-check.html

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):

LayoutTests:

Added test to check that blur(0) grayscale(0) is the same as grayscale(0) blur(0).
Also rebaselined expected results on Safari Mac, Chromium Mac/Linux.

* css3/filters/filter-change-repaint-composited-expected.png:
* css3/filters/filter-change-repaint-expected.png:
* css3/filters/filter-repaint-blur-expected.png:
* css3/filters/filter-repaint-child-layers-expected.png:
* css3/filters/filter-repaint-composited-fallback-crash-expected.png:
* css3/filters/filter-repaint-composited-fallback-expected.png:
* css3/filters/filter-repaint-sepia-expected.png:
* css3/filters/filter-repaint-shadow-clipped-expected.png:
* css3/filters/filter-repaint-shadow-expected.png:
* css3/filters/filter-repaint-shadow-rotated-expected.png:
* css3/filters/null-effect-check-expected.html: Added.
* css3/filters/null-effect-check.html: Added.
* css3/filters/remove-filter-rendering-expected.png:
* platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-linux/css3/filters/effect-brightness-expected.png:
* platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png:
* platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
* platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
* platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
* platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
* platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-mac/css3/filters/effect-invert-expected.png:
* platform/chromium-mac/css3/filters/effect-opacity-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-mac/css3/filters/effect-saturate-expected.png:
* platform/chromium-mac/css3/filters/effect-sepia-expected.png:
* platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-expected.png:
* platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png.
* platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt: Added.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
* platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt: Added.
* platform/chromium-mac/css3/filters/filtered-inline-expected.png:
* platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium-mac/css3/filters/nested-filters-expected.png:
* platform/chromium-mac/css3/filters/regions-expanding-expected.png:
* platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
* platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
* platform/chromium-win/css3/filters/crash-filter-change-expected.png:
* platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-win/css3/filters/effect-blur-expected.png:
* platform/chromium-win/css3/filters/effect-combined-expected.png:
* platform/chromium-win/css3/filters/effect-contrast-expected.png:
* platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
* platform/chromium-win/css3/filters/effect-grayscale-expected.png:
* platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
* platform/chromium-win/css3/filters/effect-invert-expected.png:
* platform/chromium-win/css3/filters/effect-opacity-expected.png:
* platform/chromium-win/css3/filters/effect-reference-expected.png:
* platform/chromium-win/css3/filters/effect-reference-external-expected.png:
* platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
* platform/chromium-win/css3/filters/effect-saturate-expected.png:
* platform/chromium-win/css3/filters/effect-sepia-expected.png:
* platform/chromium-win/css3/filters/filter-repaint-expected.png:
* platform/chromium-win/css3/filters/filtered-inline-expected.png:
* platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
* platform/chromium-win/css3/filters/nested-filters-expected.png:
* platform/chromium-win/css3/filters/regions-expanding-expected.png:
* platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
* platform/chromium/TestExpectations: css3/filters directory needs rebaseline on Windows.
* platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
* platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
* platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png:
* platform/mac/TestExpectations: Unskipped old failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

101 files changed:
LayoutTests/ChangeLog
LayoutTests/css3/filters/filter-change-repaint-composited-expected.png
LayoutTests/css3/filters/filter-change-repaint-expected.png
LayoutTests/css3/filters/filter-repaint-blur-expected.png
LayoutTests/css3/filters/filter-repaint-child-layers-expected.png
LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png
LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png
LayoutTests/css3/filters/filter-repaint-sepia-expected.png
LayoutTests/css3/filters/filter-repaint-shadow-clipped-expected.png
LayoutTests/css3/filters/filter-repaint-shadow-expected.png
LayoutTests/css3/filters/filter-repaint-shadow-rotated-expected.png
LayoutTests/css3/filters/null-effect-check-expected.html [new file with mode: 0644]
LayoutTests/css3/filters/null-effect-check.html [new file with mode: 0644]
LayoutTests/css3/filters/remove-filter-rendering-expected.png
LayoutTests/platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png
LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png
LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png
LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-expected.png
LayoutTests/platform/chromium-mac/css3/filters/add-filter-rendering-expected.png
LayoutTests/platform/chromium-mac/css3/filters/crash-filter-change-expected.png
LayoutTests/platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png
LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-blur-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-combined-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-contrast-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-grayscale-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-invert-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-opacity-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-reference-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-reference-external-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-reference-hw-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-saturate-expected.png
LayoutTests/platform/chromium-mac/css3/filters/effect-sepia-expected.png
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-expected.png
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt [new file with mode: 0644]
LayoutTests/platform/chromium-mac/css3/filters/filtered-inline-expected.png
LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png
LayoutTests/platform/chromium-mac/css3/filters/nested-filters-expected.png
LayoutTests/platform/chromium-mac/css3/filters/regions-expanding-expected.png
LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png
LayoutTests/platform/chromium-win/css3/filters/add-filter-rendering-expected.png
LayoutTests/platform/chromium-win/css3/filters/crash-filter-change-expected.png
LayoutTests/platform/chromium-win/css3/filters/custom/effect-color-check-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-blur-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-combined-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-contrast-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-drop-shadow-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-invert-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-opacity-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-reference-external-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-reference-hw-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-reference-ordering-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-saturate-expected.png
LayoutTests/platform/chromium-win/css3/filters/effect-sepia-expected.png
LayoutTests/platform/chromium-win/css3/filters/filter-repaint-expected.png
LayoutTests/platform/chromium-win/css3/filters/filtered-inline-expected.png
LayoutTests/platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png
LayoutTests/platform/chromium-win/css3/filters/nested-filters-expected.png
LayoutTests/platform/chromium-win/css3/filters/regions-expanding-expected.png
LayoutTests/platform/chromium-win/css3/filters/simple-filter-rendering-expected.png
LayoutTests/platform/chromium/TestExpectations
LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-expected.png
LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png
LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png
LayoutTests/platform/mac/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/rendering/FilterEffectRenderer.cpp

index 5d4e3c3..cf3d29c 100644 (file)
@@ -1,3 +1,113 @@
+2012-08-27  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSS Filters] Filters should render using sRGB until the specification says how it works
+        https://bugs.webkit.org/show_bug.cgi?id=94372
+
+        Reviewed by Dirk Schulze.
+
+        Added test to check that blur(0) grayscale(0) is the same as grayscale(0) blur(0). 
+        Also rebaselined expected results on Safari Mac, Chromium Mac/Linux.
+
+        * css3/filters/filter-change-repaint-composited-expected.png:
+        * css3/filters/filter-change-repaint-expected.png:
+        * css3/filters/filter-repaint-blur-expected.png:
+        * css3/filters/filter-repaint-child-layers-expected.png:
+        * css3/filters/filter-repaint-composited-fallback-crash-expected.png:
+        * css3/filters/filter-repaint-composited-fallback-expected.png:
+        * css3/filters/filter-repaint-sepia-expected.png:
+        * css3/filters/filter-repaint-shadow-clipped-expected.png:
+        * css3/filters/filter-repaint-shadow-expected.png:
+        * css3/filters/filter-repaint-shadow-rotated-expected.png:
+        * css3/filters/null-effect-check-expected.html: Added.
+        * css3/filters/null-effect-check.html: Added.
+        * css3/filters/remove-filter-rendering-expected.png:
+        * platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png:
+        * platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
+        * platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
+        * platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
+        * platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
+        * platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png:
+        * platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
+        * platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
+        * platform/chromium-linux/css3/filters/effect-brightness-expected.png:
+        * platform/chromium-linux/css3/filters/filter-empty-element-crash-expected.png:
+        * platform/chromium-mac/css3/filters/add-filter-rendering-expected.png:
+        * platform/chromium-mac/css3/filters/crash-filter-change-expected.png:
+        * platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png:
+        * platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
+        * platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
+        * platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
+        * platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
+        * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
+        * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
+        * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
+        * platform/chromium-mac/css3/filters/effect-blur-expected.png:
+        * platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
+        * platform/chromium-mac/css3/filters/effect-brightness-expected.png:
+        * platform/chromium-mac/css3/filters/effect-combined-expected.png:
+        * platform/chromium-mac/css3/filters/effect-contrast-expected.png:
+        * platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png:
+        * platform/chromium-mac/css3/filters/effect-grayscale-expected.png:
+        * platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png:
+        * platform/chromium-mac/css3/filters/effect-invert-expected.png:
+        * platform/chromium-mac/css3/filters/effect-opacity-expected.png:
+        * platform/chromium-mac/css3/filters/effect-reference-expected.png:
+        * platform/chromium-mac/css3/filters/effect-reference-external-expected.png:
+        * platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
+        * platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png:
+        * platform/chromium-mac/css3/filters/effect-saturate-expected.png:
+        * platform/chromium-mac/css3/filters/effect-sepia-expected.png:
+        * platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-expected.png:
+        * platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png.
+        * platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png.
+        * platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt: Added.
+        * platform/chromium-mac/css3/filters/filtered-inline-expected.png:
+        * platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
+        * platform/chromium-mac/css3/filters/nested-filters-expected.png:
+        * platform/chromium-mac/css3/filters/regions-expanding-expected.png:
+        * platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png:
+        * platform/chromium-win/css3/filters/add-filter-rendering-expected.png:
+        * platform/chromium-win/css3/filters/crash-filter-change-expected.png:
+        * platform/chromium-win/css3/filters/custom/effect-color-check-expected.png:
+        * platform/chromium-win/css3/filters/effect-blur-expected.png:
+        * platform/chromium-win/css3/filters/effect-combined-expected.png:
+        * platform/chromium-win/css3/filters/effect-contrast-expected.png:
+        * platform/chromium-win/css3/filters/effect-drop-shadow-expected.png:
+        * platform/chromium-win/css3/filters/effect-grayscale-expected.png:
+        * platform/chromium-win/css3/filters/effect-hue-rotate-expected.png:
+        * platform/chromium-win/css3/filters/effect-invert-expected.png:
+        * platform/chromium-win/css3/filters/effect-opacity-expected.png:
+        * platform/chromium-win/css3/filters/effect-reference-expected.png:
+        * platform/chromium-win/css3/filters/effect-reference-external-expected.png:
+        * platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
+        * platform/chromium-win/css3/filters/effect-reference-ordering-expected.png:
+        * platform/chromium-win/css3/filters/effect-saturate-expected.png:
+        * platform/chromium-win/css3/filters/effect-sepia-expected.png:
+        * platform/chromium-win/css3/filters/filter-repaint-expected.png:
+        * platform/chromium-win/css3/filters/filtered-inline-expected.png:
+        * platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
+        * platform/chromium-win/css3/filters/nested-filters-expected.png:
+        * platform/chromium-win/css3/filters/regions-expanding-expected.png:
+        * platform/chromium-win/css3/filters/simple-filter-rendering-expected.png:
+        * platform/chromium/TestExpectations: css3/filters directory needs rebaseline on Windows.
+        * platform/chromium/css3/filters/blur-filter-page-scroll-expected.png:
+        * platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png:
+        * platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png:
+        * platform/mac/TestExpectations: Unskipped old failing tests.
+
 2012-08-28  Philip Rogers  <pdr@google.com>
 
         Rebaseline details-nested-2.html and clone-anonymous-block-non-inline-child-crash.html after 126789
index 518d3ab..1f6e698 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png and b/LayoutTests/css3/filters/filter-change-repaint-composited-expected.png differ
index 1337bab..205432a 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-change-repaint-expected.png and b/LayoutTests/css3/filters/filter-change-repaint-expected.png differ
index 9868969..51a010d 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-blur-expected.png and b/LayoutTests/css3/filters/filter-repaint-blur-expected.png differ
index 3c9b911..56a5256 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-child-layers-expected.png and b/LayoutTests/css3/filters/filter-repaint-child-layers-expected.png differ
index a8825f5..38f03c0 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png and b/LayoutTests/css3/filters/filter-repaint-composited-fallback-crash-expected.png differ
index ed1fe50..38f03c0 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png and b/LayoutTests/css3/filters/filter-repaint-composited-fallback-expected.png differ
index 2eb1df3..574cd7a 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-sepia-expected.png and b/LayoutTests/css3/filters/filter-repaint-sepia-expected.png differ
index aafd03b..8ed3ece 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-shadow-clipped-expected.png and b/LayoutTests/css3/filters/filter-repaint-shadow-clipped-expected.png differ
index 1c54ef6..9e8243f 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-shadow-expected.png and b/LayoutTests/css3/filters/filter-repaint-shadow-expected.png differ
index 013b875..05334ea 100644 (file)
Binary files a/LayoutTests/css3/filters/filter-repaint-shadow-rotated-expected.png and b/LayoutTests/css3/filters/filter-repaint-shadow-rotated-expected.png differ
diff --git a/LayoutTests/css3/filters/null-effect-check-expected.html b/LayoutTests/css3/filters/null-effect-check-expected.html
new file mode 100644 (file)
index 0000000..ea94f5f
--- /dev/null
@@ -0,0 +1,30 @@
+<style>
+div {
+    float: left;
+    display: block;
+    margin: 10px;
+    width: 50px;
+    height: 50px;
+    background: green;
+}
+br {
+    clear: left;
+}
+</style>
+
+<div></div>
+<div></div>
+<div></div>
+<div></div>
+<br />
+<div></div>
+<div></div>
+<div></div>
+<div></div>
+<br />
+<div></div>
+<div></div>
+<div></div>
+<div></div>
+<br />
+<div></div>
\ No newline at end of file
diff --git a/LayoutTests/css3/filters/null-effect-check.html b/LayoutTests/css3/filters/null-effect-check.html
new file mode 100644 (file)
index 0000000..c02e245
--- /dev/null
@@ -0,0 +1,47 @@
+<script>
+if (window.testRunner) {
+    // Force software rendering mode.
+    window.testRunner.overridePreference("WebKitAcceleratedCompositingEnabled", "0");
+    window.testRunner.dumpAsText(true);
+}
+</script>
+<style>
+div {
+    float:left;
+    display: block;
+    margin: 10px;
+    padding:0px;
+    width: 50px;
+    height: 50px;
+    background: green;
+}
+br {
+    clear: left;
+}
+</style>
+<!-- 
+    This test checks that a null filter will not affect the rendering of the box at all.
+    There should be 13 green boxes on screen. 
+-->
+<div style="-webkit-filter: blur(0)"></div>
+<div style="-webkit-filter: brightness(0)"></div>
+<div style="-webkit-filter: invert(0)"></div>
+<div style="-webkit-filter: contrast(1)"></div>
+
+<br />
+
+<div style="-webkit-filter: drop-shadow(0px 0px 0px rgba(0, 0, 0, 0))"></div>
+<div style="-webkit-filter: grayscale(0)"></div>
+<div style="-webkit-filter: hue-rotate(0)"></div>
+<div style="-webkit-filter: invert(0)"></div>
+
+<br />
+
+<div style="-webkit-filter: opacity(1)"></div>
+<div style="-webkit-filter: saturate(1)"></div>
+<div style="-webkit-filter: sepia(0)"></div>
+<div style="-webkit-filter: blur(0) grayscale(0)"></div>
+
+<br />
+
+<div style="-webkit-filter: grayscale(0) blur(0)"></div>
\ No newline at end of file
index 312fbe4..dda9832 100644 (file)
Binary files a/LayoutTests/css3/filters/remove-filter-rendering-expected.png and b/LayoutTests/css3/filters/remove-filter-rendering-expected.png differ
index 84158fd..aa625e4 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png differ
index 1b316dd..615303f 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png differ
index 894e63f..7449b5e 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png differ
index e2d9c6c..bda5e42 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/effect-custom-expected.png differ
index 37506ff..ba83c64 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-clipped-expected.png differ
index b721a31..5be6c6c 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-expected.png differ
index d355609..88807f3 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/custom/filter-repaint-custom-rotated-expected.png differ
index 022f4db..e2bd5b0 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png differ
index 6652244..02f6790 100644 (file)
Binary files a/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-expected.png and b/LayoutTests/platform/chromium-linux/css3/filters/effect-brightness-expected.png differ
index 8defd22..e480327 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/add-filter-rendering-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/add-filter-rendering-expected.png differ
index a41addf..056cb8f 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/crash-filter-change-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/crash-filter-change-expected.png differ
index 927854d..e5e0ba0 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png differ
index 5c08f10..90225f0 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png differ
index f863356..fba21f7 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png differ
index 8add609..4196a66 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png differ
index d01054e..10b8961 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/effect-custom-expected.png differ
index 5d528dd..4213bb9 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png differ
index 2276582..2afdc45 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png differ
index 64b5ebd..d8e1681 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png differ
index a761932..55f7ee1 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-blur-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-blur-expected.png differ
index 71862f1..0f2686b 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png differ
index f34e243..ecd02eb 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-brightness-expected.png differ
index 579b473..0063f96 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-combined-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-combined-expected.png differ
index f686cca..8820b4d 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-contrast-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-contrast-expected.png differ
index 42ef2c6..b7f8172 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-drop-shadow-expected.png differ
index c6bdb7c..d46a967 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-grayscale-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-grayscale-expected.png differ
index 01cbe3b..3775c23 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-hue-rotate-expected.png differ
index 75c88d7..a368e40 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-invert-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-invert-expected.png differ
index e3a39b8..8c38248 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-opacity-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-opacity-expected.png differ
index 9dc09e9..d2fb062 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-expected.png differ
index 407698f..12701d8 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-external-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-external-expected.png differ
index 9dc09e9..d2fb062 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-hw-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-hw-expected.png differ
index cc09f81..4710e30 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-reference-ordering-expected.png differ
index 60ca9fd..2f741cb 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-saturate-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-saturate-expected.png differ
index d53d00a..fc8b17a 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/effect-sepia-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/effect-sepia-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png
new file mode 100644 (file)
index 0000000..0ba0dd3
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-blur-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png
new file mode 100644 (file)
index 0000000..92af125
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-child-layers-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png
new file mode 100644 (file)
index 0000000..d605c50
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png
new file mode 100644 (file)
index 0000000..d605c50
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
index 24d488d..cc57a02 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png
new file mode 100644 (file)
index 0000000..1ff988c
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-sepia-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png
new file mode 100644 (file)
index 0000000..a53c81f
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-clipped-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png
new file mode 100644 (file)
index 0000000..5f4aca4
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png
new file mode 100644 (file)
index 0000000..eb65b03
Binary files /dev/null and b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.png differ
diff --git a/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt b/LayoutTests/platform/chromium-mac/css3/filters/filter-repaint-shadow-rotated-expected.txt
new file mode 100644 (file)
index 0000000..8b13789
--- /dev/null
@@ -0,0 +1 @@
+
index 82b3349..5fe6f52 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/filtered-inline-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/filtered-inline-expected.png differ
index cfe10ad..91de090 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png differ
index e080486..3c75c39 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/nested-filters-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/nested-filters-expected.png differ
index 28c2194..0312849 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/regions-expanding-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/regions-expanding-expected.png differ
index 8defd22..e480327 100644 (file)
Binary files a/LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png and b/LayoutTests/platform/chromium-mac/css3/filters/simple-filter-rendering-expected.png differ
index a2618b4..a38e040 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/add-filter-rendering-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/add-filter-rendering-expected.png differ
index f677ff9..7717878 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/crash-filter-change-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/crash-filter-change-expected.png differ
index d7d587e..017bee0 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/custom/effect-color-check-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/custom/effect-color-check-expected.png differ
index 3f4ff58..c0affdb 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-blur-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-blur-expected.png differ
index f7ab5df..34024fa 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-combined-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-combined-expected.png differ
index de70908..fd95e91 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-contrast-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-contrast-expected.png differ
index ad8b4b0..5f52499 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-drop-shadow-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-drop-shadow-expected.png differ
index 929d3bc..5be1e22 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-expected.png differ
index 4afbcbf..3674981 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-expected.png differ
index 0b0abe6..8ad67c5 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-invert-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-invert-expected.png differ
index 6b3bb8f..d8f0d43 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-opacity-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-opacity-expected.png differ
index 54f711d..d2b081b 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-reference-expected.png differ
index 7281c04..ef8d477 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-reference-external-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-reference-external-expected.png differ
index 54f711d..d2b081b 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-reference-hw-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-reference-hw-expected.png differ
index 59e3f3a..5b257c6 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-reference-ordering-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-reference-ordering-expected.png differ
index e391bae..6fc59d9 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-saturate-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-saturate-expected.png differ
index 34789f9..858a10c 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/effect-sepia-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/effect-sepia-expected.png differ
index e469f29..fd5b4ad 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/filter-repaint-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/filter-repaint-expected.png differ
index b4343bc..eae4652 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/filtered-inline-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/filtered-inline-expected.png differ
index 140325b..3358da3 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png differ
index a34663e..e020e77 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/nested-filters-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/nested-filters-expected.png differ
index e633f91..511aa77 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/regions-expanding-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/regions-expanding-expected.png differ
index a2618b4..a38e040 100644 (file)
Binary files a/LayoutTests/platform/chromium-win/css3/filters/simple-filter-rendering-expected.png and b/LayoutTests/platform/chromium-win/css3/filters/simple-filter-rendering-expected.png differ
index 103d3b2..c009581 100644 (file)
@@ -1234,8 +1234,6 @@ BUGWK80517 DEBUG : svg/dynamic-updates/SVGFESpecularLightingElement-remove-light
 BUGWK81217 : svg/custom/js-late-pattern-and-object-creation.svg = IMAGE
 BUGWK81217 : svg/hixie/perf/003.xml = PASS IMAGE
 
-BUGWK92758 : css3/filters/custom/effect-custom-parameters.html = PASS IMAGE CRASH
-
 BUGWK81240 MAC : svg/text/bidi-reorder-value-lists.svg = PASS IMAGE+TEXT
 
 BUGWK81243 : svg/repaint/repainting-after-animation-element-removal.svg = PASS IMAGE
@@ -2479,21 +2477,8 @@ BUGWK74137 WIN LINUX ANDROID LION : fast/regions/region-overflow-auto-overflow-h
 BUGWK74137 SNOWLEOPARD : fast/regions/region-overflow-auto-overflow-visible.html = PASS IMAGE+TEXT TIMEOUT
 BUGWK74137 WIN LINUX ANDROID LION : fast/regions/region-overflow-auto-overflow-visible.html = PASS MISSING
 
-BUGWK82783 : css3/filters/filter-change-repaint-composited.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-change-repaint.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-blur.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-child-layers.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-composited-fallback-crash.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-composited-fallback.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-shadow-clipped.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-shadow-rotated.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-shadow.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-with-transform.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/filter-repaint-sepia.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-BUGWK82783 : css3/filters/nested-filter.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
-// Please fix a line with BUGWK6033 above when BUGWK82783 is fixed.
-BUGWK82783 BUGWK6033 : css3/filters/blur-filter-page-scroll.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
+// CSS3 filters needs rebaselines on windows after 94372
+BUGWK82783 WIN : css3/filters/ = PASS IMAGE
 
 // CSS Regions tests for region styling and scoped styles
 BUGWK49142 : fast/regions/style-scoped-in-flow-override-container-style.html = PASS IMAGE IMAGE+TEXT TEXT MISSING
index 6cd23c5..b6e854c 100644 (file)
Binary files a/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-expected.png and b/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-expected.png differ
index 88c717d..8b5043a 100644 (file)
Binary files a/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png and b/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-parents-expected.png differ
index 2f0c709..fafdb73 100644 (file)
Binary files a/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png and b/LayoutTests/platform/chromium/css3/filters/blur-filter-page-scroll-self-expected.png differ
index 2354ddc..1486be1 100644 (file)
@@ -243,41 +243,6 @@ BUGWK85565 : fast/css/border-solid-single-edge-antialias.html = IMAGE
 BUGWK85689 SKIP : fast/animation/request-animation-frame-disabled.html = TEXT
 
 // Need rebaseline after https://bugs.webkit.org/show_bug.cgi?id=6033
-BUGWK6033 : css3/filters/add-filter-rendering.html = PASS IMAGE
-BUGWK6033 : css3/filters/blur-filter-page-scroll-parents.html = PASS IMAGE
-BUGWK6033 : css3/filters/blur-filter-page-scroll.html = PASS IMAGE
-BUGWK6033 : css3/filters/crash-filter-change.html = PASS IMAGE
-BUGWK6033 : css3/filters/crash-hw-sw-switch.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/custom-filter-shader-cache.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/effect-color-check.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/effect-custom-combined-missing.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/effect-custom.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/effect-custom-parameters.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/filter-repaint-custom-clipped.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/filter-repaint-custom-rotated.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/filter-repaint-custom.html = PASS IMAGE
-BUGWK6033 : css3/filters/custom/invalid-custom-filter-shader.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-blur.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-brightness-clamping.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-brightness.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-combined.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-contrast.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-drop-shadow.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-grayscale.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-hue-rotate.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-invert.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-opacity.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-reference-external.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-reference-hw.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-reference-ordering.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-reference.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-saturate.html = PASS IMAGE
-BUGWK6033 : css3/filters/effect-sepia.html = PASS IMAGE
-BUGWK6033 : css3/filters/filtered-inline.html = PASS IMAGE
-BUGWK6033 : css3/filters/multiple-filters-invalidation.html = PASS IMAGE
-BUGWK6033 : css3/filters/nested-filters.html = PASS IMAGE
-BUGWK6033 : css3/filters/regions-expanding.html = PASS IMAGE
-BUGWK6033 : css3/filters/simple-filter-rendering.html = PASS IMAGE
 BUGWK6033 : svg/filters/color-interpolation-filters.svg = PASS MISSING
 
 // Hits assert https://bugs.webkit.org/show_bug.cgi?id=86208
@@ -379,9 +344,6 @@ BUGWK89826 : fast/css/word-space-extra.html = TEXT
 BUGWK94008 : fast/css/word-spacing-characters.html = IMAGE
 BUGWK94003 : fast/css/word-spacing-characters-complex-text.html = IMAGE
 
-// (r125629): Newly added test css3/filters/custom/filter-fallback-to-software.html failing on mac
-BUGWK94169 : css3/filters/custom/filter-fallback-to-software.html = IMAGE
-
 // (r125790): Newly added test inspector/timeline/timeline-decode-resize.html is failing on mac
 BUGWK94374 : inspector/timeline/timeline-decode-resize.html = TEXT
 
index 2c944b2..96fc2c6 100644 (file)
@@ -1,3 +1,19 @@
+2012-08-27  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSS Filters] Filters should render using sRGB until the specification says how it works
+        https://bugs.webkit.org/show_bug.cgi?id=94372
+
+        Reviewed by Dirk Schulze.
+
+        The short-hand version of the CSS Filters should render using sRGB until a CSS property is added 
+        to allow choosing the color space to be used when computing the filters. 
+        For now I've just made all the CSS filters use sRGB by defualt. Note that this change has no effect on SVG filters.
+
+        Test: css3/filters/null-effect-check.html
+
+        * rendering/FilterEffectRenderer.cpp:
+        (WebCore::FilterEffectRenderer::build):
+
 2012-08-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r126914.
index 6d41199..f551380 100644 (file)
@@ -29,6 +29,7 @@
 
 #include "FilterEffectRenderer.h"
 
+#include "ColorSpace.h"
 #include "Document.h"
 #include "FEColorMatrix.h"
 #include "FEComponentTransfer.h"
@@ -349,6 +350,7 @@ bool FilterEffectRenderer::build(Document* document, const FilterOperations& ope
         if (effect) {
             // Unlike SVG, filters applied here should not clip to their primitive subregions.
             effect->setClipsToBounds(false);
+            effect->setColorSpace(ColorSpaceDeviceRGB);
             
             if (filterOperation->getOperationType() != FilterOperation::REFERENCE) {
                 effect->inputEffects().append(previousEffect);