REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
authorddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 Jan 2016 00:19:20 +0000 (00:19 +0000)
committerddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 1 Jan 2016 00:19:20 +0000 (00:19 +0000)
<https://bugs.webkit.org/show_bug.cgi?id=152601>

Ignore unknown pragmas on older clangs.  Fixes the following
build failure:

    Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
    #pragma clang diagnostic ignored "-Wself-move"
                                     ^
    1 error generated.

* TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@194473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp
Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp

index 6e15b9d..341086d 100644 (file)
@@ -1,3 +1,21 @@
+2015-12-31  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
+        <https://bugs.webkit.org/show_bug.cgi?id=152601>
+
+        Ignore unknown pragmas on older clangs.  Fixes the following
+        build failure:
+
+            Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
+            #pragma clang diagnostic ignored "-Wself-move"
+                                             ^
+            1 error generated.
+
+        * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
+        (TestWebKitAPI::TEST):
+
 2015-12-31  Andy Estes  <aestes@apple.com>
 
         Update the style checker to advise using WTFMove() instead of WTF::move()
index cd232e7..3105602 100644 (file)
@@ -181,6 +181,7 @@ TEST(WTF_NakedPtr, Assignment)
         ASSERT_EQ(&a, ptr.get());
 #if COMPILER(CLANG)
 #pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunknown-pragmas"
 #pragma clang diagnostic ignored "-Wself-move"
 #endif
         ptr = WTF::move(ptr);
index 36a8e6c..4238ee8 100644 (file)
@@ -272,6 +272,7 @@ TEST(WTF_RefPtr, Assignment)
         ASSERT_EQ(&a, ptr.get());
 #if COMPILER(CLANG)
 #pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunknown-pragmas"
 #pragma clang diagnostic ignored "-Wself-move"
 #endif
         ptr = WTF::move(ptr);