Fix a FIXMEs in WebFrameIOS
authormegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 12 Nov 2017 02:46:31 +0000 (02:46 +0000)
committermegan_gardner@apple.com <megan_gardner@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 12 Nov 2017 02:46:31 +0000 (02:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179510

Reviewed by Darin Adler.

Removed a function that does nothing and is not needed or used anywhere, linked to a radar that is in verify.
This is just some easy cleanup I found while investigating other things.

* WebCoreSupport/WebFrameIOS.h:
* WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKitLegacy/ios/ChangeLog
Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.h
Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm

index c618eb8..234ff64 100644 (file)
@@ -1,3 +1,17 @@
+2017-11-11  Megan Gardner  <megan_gardner@apple.com>
+
+        Fix a FIXMEs in WebFrameIOS
+        https://bugs.webkit.org/show_bug.cgi?id=179510
+
+        Reviewed by Darin Adler.
+
+        Removed a function that does nothing and is not needed or used anywhere, linked to a radar that is in verify.
+        This is just some easy cleanup I found while investigating other things.
+
+        * WebCoreSupport/WebFrameIOS.h:
+        * WebCoreSupport/WebFrameIOS.mm:
+        (-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Deleted.
+
 2017-10-11  Sam Weinig  <sam@webkit.org>
 
         Remove out-parameter variants of copyToVector
index 974bd3c..d719704 100644 (file)
@@ -88,8 +88,6 @@ typedef enum {
 
 - (BOOL)renderedCharactersExceed:(NSUInteger)threshold;
 
-- (CGImageRef)imageForNode:(DOMNode *)node allowDownsampling:(BOOL)allowDownsampling drawContentBehindTransparentNodes:(BOOL)drawContentBehindTransparentNodes;
-
 - (WebVisiblePosition *)previousUnperturbedDictationResultBoundaryFromPosition:(WebVisiblePosition *)position;
 - (WebVisiblePosition *)nextUnperturbedDictationResultBoundaryFromPosition:(WebVisiblePosition *)position;
 
index 83defbe..960eda8 100644 (file)
@@ -825,12 +825,6 @@ static VisiblePosition SimpleSmartExtendEnd(const VisiblePosition& start, const
     return frame->view()->renderedCharactersExceed(threshold);
 }
 
-- (CGImageRef)imageForNode:(DOMNode *)node allowDownsampling:(BOOL)allowDownsampling drawContentBehindTransparentNodes:(BOOL)drawContentBehindTransparentNodes
-{
-    // FIXME: implement: <rdar://problem/15808709>
-    return nullptr;
-}
-
 // Iterates backward through the document and returns the point at which untouched dictation results end.
 - (WebVisiblePosition *)previousUnperturbedDictationResultBoundaryFromPosition:(WebVisiblePosition *)position
 {