REGRESSION (r150516): Media controls are messed up on right-to-left webpages
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Aug 2013 23:00:38 +0000 (23:00 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Aug 2013 23:00:38 +0000 (23:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=120234

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-rtl.html

Make the media control panel explicitly direction:ltr. The captions menu and captions
display are unaffected, so rtl content will continue to appear rtl there.

* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

* media/video-rtl-expected.html: Added.
* media/video-rtl.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/video-rtl-expected.html [new file with mode: 0644]
LayoutTests/media/video-rtl.html [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/css/mediaControls.css

index 7d1b737..de0673d 100644 (file)
@@ -1,3 +1,13 @@
+2013-08-23  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r150516): Media controls are messed up on right-to-left webpages
+        https://bugs.webkit.org/show_bug.cgi?id=120234
+
+        Reviewed by Dan Bernstein.
+
+        * media/video-rtl-expected.html: Added.
+        * media/video-rtl.html: Added.
+
 2013-08-23  Eric Carlson  <eric.carlson@apple.com>
 
         [Mac] some track language tags are not recognized
diff --git a/LayoutTests/media/video-rtl-expected.html b/LayoutTests/media/video-rtl-expected.html
new file mode 100644 (file)
index 0000000..19bdd57
--- /dev/null
@@ -0,0 +1,18 @@
+<html>
+<head>
+    <script src=media-file.js></script>
+    <script>
+    var requirePixelDump = true;
+
+    function start() {
+        findMediaElement();
+        video.src = findMediaFile('audio', 'content/test');
+        video.addEventListener('canplaythrough', endTest, false);
+    }
+    </script>
+    <script src=video-test.js></script>
+</head>
+<body onload="start()">
+    <video controls></video>
+</body>
+</html>
\ No newline at end of file
diff --git a/LayoutTests/media/video-rtl.html b/LayoutTests/media/video-rtl.html
new file mode 100644 (file)
index 0000000..2c9fef0
--- /dev/null
@@ -0,0 +1,21 @@
+<html>
+<head>
+    <script src=media-file.js></script>
+    <script>
+    var requirePixelDump = true;
+
+    function start() {
+        findMediaElement();
+        video.src = findMediaFile('audio', 'content/test');
+        video.addEventListener('canplaythrough', endTest, false);
+    }
+    </script>
+    <script src=video-test.js></script>
+    <style>
+        video { direction: rtl; }
+    </style>
+</head>
+<body onload="start()">
+    <video controls></video>
+</body>
+</html>
\ No newline at end of file
index d46a1a6..2462d0c 100644 (file)
@@ -1,3 +1,18 @@
+2013-08-23  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r150516): Media controls are messed up on right-to-left webpages
+        https://bugs.webkit.org/show_bug.cgi?id=120234
+
+        Reviewed by Dan Bernstein.
+
+        Test: media/video-rtl.html
+
+        Make the media control panel explicitly direction:ltr. The captions menu and captions
+        display are unaffected, so rtl content will continue to appear rtl there.
+
+        * css/mediaControls.css:
+        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
+
 2013-08-23  Beth Dakin  <bdakin@apple.com>
 
         REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in 
index 462a2ac..2993f76 100644 (file)
@@ -45,6 +45,7 @@ audio {
 
 audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
     display: -webkit-flex;
+    direction: ltr;
     -webkit-flex-direction: row;
     -webkit-align-items: center;
     -webkit-user-select: none;