[Coverity] Address some uninitialized constructor values.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2012 00:37:41 +0000 (00:37 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2012 00:37:41 +0000 (00:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=82376

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org> on 2012-03-27
Reviewed by James Robinson.

Source/WebCore:

New tests are not required since I did not modify any code behavior.

* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):

Source/WebKit/chromium:

New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.

* src/WebCompositorInputHandlerImpl.cpp:
(WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
Source/WebCore/inspector/InspectorIndexedDBAgent.h
Source/WebCore/inspector/InspectorTimelineAgent.cpp
Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
Source/WebCore/platform/ScrollAnimatorNone.cpp
Source/WebCore/platform/chromium/DataTransferItemChromium.cpp
Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Source/WebCore/storage/StorageTask.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp

index 178d883..ba9ed2a 100644 (file)
@@ -1,3 +1,29 @@
+2012-03-27  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
+
+        [Coverity] Address some uninitialized constructor values.
+        https://bugs.webkit.org/show_bug.cgi?id=82376
+
+        Reviewed by James Robinson.
+
+        New tests are not required since I did not modify any code behavior.
+
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+        * inspector/InspectorIndexedDBAgent.h:
+        (InspectorIndexedDBAgent):
+        * inspector/InspectorTimelineAgent.cpp:
+        (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
+        * page/scrolling/ScrollingCoordinator.cpp:
+        (WebCore::ScrollingCoordinator::ScrollingCoordinator):
+        * platform/ScrollAnimatorNone.cpp:
+        (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
+        * platform/chromium/DataTransferItemChromium.cpp:
+        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
+        * platform/graphics/skia/ImageBufferSkia.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+        * storage/StorageTask.cpp:
+        (WebCore::StorageTask::StorageTask):
+
 2012-03-27  Alexis Menard  <alexis.menard@openbossa.org>
 
         Simplify CSSPropertyBorderSpacing parsing.
index 663e51f..bed2abb 100644 (file)
@@ -58,6 +58,7 @@ MediaControlRootElementChromium::MediaControlRootElementChromium(Document* docum
     , m_panel(0)
 #if ENABLE(VIDEO_TRACK)
     , m_textDisplayContainer(0)
+    , m_textTrackDisplay(0)
 #endif
     , m_opaque(true)
     , m_isMouseOverControls(false)
index b19ed6e..869c7ad 100644 (file)
@@ -70,7 +70,6 @@ private:
     InjectedScriptManager* m_injectedScriptManager;
     InspectorPageAgent* m_pageAgent;
     RefPtr<FrontendProvider> m_frontendProvider;
-    bool m_enabled;
 };
 
 } // namespace WebCore
index bdc36e3..3a12fc5 100644 (file)
@@ -436,6 +436,7 @@ void InspectorTimelineAgent::didCompleteCurrentRecord(const String& type)
 InspectorTimelineAgent::InspectorTimelineAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, InspectorType type)
     : InspectorBaseAgent<InspectorTimelineAgent>("Timeline", instrumentingAgents, state)
     , m_frontend(0)
+    , m_timestampOffset(0)
     , m_id(1)
     , m_maxCallStackDepth(5)
     , m_inspectorType(type)
index e5d954f..8c0cbf9 100644 (file)
@@ -60,6 +60,7 @@ ScrollingCoordinator::ScrollingCoordinator(Page* page)
     , m_scrollingTree(ScrollingTree::create(this))
     , m_scrollingTreeStateCommitterTimer(this, &ScrollingCoordinator::scrollingTreeStateCommitterTimerFired)
 #endif
+    , m_private(0)
 {
 }
 
index de330b4..50fedf6 100644 (file)
@@ -380,6 +380,7 @@ ScrollAnimatorNone::ScrollAnimatorNone(ScrollableArea* scrollableArea)
     : ScrollAnimator(scrollableArea)
     , m_horizontalData(this, &m_currentPosX, scrollableArea->visibleWidth())
     , m_verticalData(this, &m_currentPosY, scrollableArea->visibleHeight())
+    , m_startTime(0)
     , m_animationActive(false)
     , m_firstVelocity(0)
     , m_firstVelocitySet(false)
index 4d49df9..bced32b 100644 (file)
@@ -95,6 +95,7 @@ DataTransferItemChromium::DataTransferItemChromium(const String& kind, const Str
     : m_source(InternalSource)
     , m_kind(kind)
     , m_type(type)
+    , m_sequenceNumber(0)
 {
 }
 
index 8932046..4c9a85b 100644 (file)
@@ -127,6 +127,7 @@ static SkCanvas* createNonPlatformCanvas(const IntSize& size)
 ImageBuffer::ImageBuffer(const IntSize& size, ColorSpace, RenderingMode renderingMode, DeferralMode deferralMode, bool& success)
     : m_data(size)
     , m_size(size)
+    , m_resolutionScale(1)
 {
     OwnPtr<SkCanvas> canvas;
 
index 47aabe9..9764319 100644 (file)
@@ -52,12 +52,16 @@ StorageTask::StorageTask(Type type, StorageThread* thread)
 
 StorageTask::StorageTask(Type type)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
 {
     ASSERT(m_type == ImportOrigins || m_type == DeleteAllOrigins);
 }
 
 StorageTask::StorageTask(Type type, const String& originIdentifier)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
     , m_originIdentifier(originIdentifier)
 {
     ASSERT(m_type == DeleteOrigin);
@@ -65,6 +69,8 @@ StorageTask::StorageTask(Type type, const String& originIdentifier)
 
 StorageTask::StorageTask(Type type, const String& originIdentifier, const String& databaseFilename)
     : m_type(type)
+    , m_area(0)
+    , m_thread(0)
     , m_originIdentifier(originIdentifier)
     , m_databaseFilename(databaseFilename)
 {
index cb0048b..859d747 100644 (file)
@@ -1,3 +1,15 @@
+2012-03-27  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
+
+        [Coverity] Address some uninitialized constructor values.
+        https://bugs.webkit.org/show_bug.cgi?id=82376
+
+        Reviewed by James Robinson.
+
+        New tests are not required since I did not modify any code behavior. I just initialized the class member variables in the constructor.
+
+        * src/WebCompositorInputHandlerImpl.cpp:
+        (WebCore::PlatformGestureToCCGestureAdapter::PlatformGestureToCCGestureAdapter):
+
 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
 
         Roll chromium DEPS to r129300.
index 3c8db9c..9a14e8e 100644 (file)
@@ -76,6 +76,7 @@ public:
 private:
     PlatformGestureToCCGestureAdapter(PassOwnPtr<PlatformGestureCurve> curve)
         : m_curve(curve)
+        , m_target(0)
     {
     }