[ews-build] Add link to bug along with bug title
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Jan 2019 22:24:22 +0000 (22:24 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Jan 2019 22:24:22 +0000 (22:24 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193293

Reviewed by Lucas Forschler.

* BuildSlaveSupport/ews-build/steps.py:
(ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
(ConfigureBuild.add_bug_id_url): Deleted.
(ConfigureBuild.getBugURL): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-build/steps.py
Tools/ChangeLog

index 0a3b53f..111608d 100644 (file)
@@ -67,7 +67,6 @@ class ConfigureBuild(buildstep.BuildStep):
             self.setProperty("additionalArguments", self.additionalArguments, 'config.json')
 
         self.add_patch_id_url()
-        self.add_bug_id_url()
         self.finished(SUCCESS)
         return defer.succeed(None)
 
@@ -76,21 +75,11 @@ class ConfigureBuild(buildstep.BuildStep):
         if patch_id:
             self.addURL('Patch {}'.format(patch_id), self.getPatchURL(patch_id))
 
-    def add_bug_id_url(self):
-        bug_id = self.getProperty('bug_id', '')
-        if bug_id:
-            self.addURL('Bug {}'.format(bug_id), self.getBugURL(bug_id))
-
     def getPatchURL(self, patch_id):
         if not patch_id:
             return None
         return '{}attachment.cgi?id={}'.format(BUG_SERVER_URL, patch_id)
 
-    def getBugURL(self, bug_id):
-        if not bug_id:
-            return None
-        return '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)
-
 
 class CheckOutSource(git.Git):
     name = 'clean-and-update-working-directory'
@@ -310,6 +299,8 @@ class ValidatePatch(buildstep.BuildStep):
             self._addToLog('stdio', 'Unable to fetch bug {}.\n'.format(bug_id))
             return -1
 
+        bug_title = bug_json.get('summary')
+        self.addURL('Bug {} {}'.format(bug_id, bug_title), '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id))
         if bug_json.get('status') in self.bug_closed_statuses:
             return 1
         return 0
index c44890e..dac4e62 100644 (file)
@@ -1,5 +1,17 @@
 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
 
+        [ews-build] Add link to bug along with bug title
+        https://bugs.webkit.org/show_bug.cgi?id=193293
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
+        (ConfigureBuild.add_bug_id_url): Deleted.
+        (ConfigureBuild.getBugURL): Deleted.
+
+2019-01-09  Aakash Jain  <aakash_jain@apple.com>
+
         [ews-build] Use https for ews-build server
         https://bugs.webkit.org/show_bug.cgi?id=193193