Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html fails
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Feb 2020 08:48:02 +0000 (08:48 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Feb 2020 08:48:02 +0000 (08:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=190613

Reviewed by Wenson Hsieh.

Source/WebCore:

Check the input is a range control before trying to paint slider ticks.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):

LayoutTests:

Remove test expectations.

* TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@257623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/platform/gtk/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderTheme.cpp

index 0a2a70c..b43ee6d 100644 (file)
@@ -1,3 +1,15 @@
+2020-02-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=190613
+
+        Reviewed by Wenson Hsieh.
+
+        Remove test expectations.
+
+        * TestExpectations:
+        * platform/gtk/TestExpectations:
+
 2020-02-27  Doug Kelly  <dougk@apple.com>
 
         Hit test with clipPath referencing parent element causes infinite recursion
index 755c6a1..e948db0 100644 (file)
@@ -1949,8 +1949,6 @@ imported/w3c/web-platform-tests/css/css-multicol/multicol-span-all-children-heig
 
 webkit.org/b/148884 imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection.html [ Pass Failure ]
 
-webkit.org/b/190613 imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html [ Skip ]
-
 # Tests require WTR and disabling of user installed fonts. Reenabling them in supported platforms
 fast/text/user-installed-fonts/extended-character.html [ Skip ]
 fast/text/user-installed-fonts/extended-character-with-user-font.html [ Skip ]
index 3199565..6ddb52d 100644 (file)
@@ -4569,8 +4569,6 @@ webkit.org/b/175290 imported/w3c/web-platform-tests/css/css-ui/text-overflow-005
 
 webkit.org/b/139282 imported/mozilla/svg/image/image-filter-01.svg [ Pass ]
 
-imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html [ Pass ]
-
 imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate.html [ Pass ]
 
 imported/mozilla/svg/dynamic-textPath-02.svg [ Pass ]
index 5b5c0e1..4d25f03 100644 (file)
@@ -1,3 +1,15 @@
+2020-02-28  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html fails
+        https://bugs.webkit.org/show_bug.cgi?id=190613
+
+        Reviewed by Wenson Hsieh.
+
+        Check the input is a range control before trying to paint slider ticks.
+
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::paintSliderTicks):
+
 2020-02-27  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: allow use of dark mode theme independently from system-wide theme
index 2674335..2c87c2c 100644 (file)
@@ -1063,8 +1063,7 @@ void RenderTheme::paintSliderTicks(const RenderObject& o, const PaintInfo& paint
         return;
 
     auto& input = downcast<HTMLInputElement>(*o.node());
-
-    if (!input.list())
+    if (!input.isRangeControl() || !input.list())
         return;
 
     auto& dataList = downcast<HTMLDataListElement>(*input.list());