REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the...
authornvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Feb 2016 05:27:31 +0000 (05:27 +0000)
committernvasilyev@apple.com <nvasilyev@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Feb 2016 05:27:31 +0000 (05:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=154328
<rdar://problem/24692996>

Introduce a CSS variable to ensure that the quick console is the
same height as the bottom right section of the styles sidebar.

Reviewed by Timothy Hatcher.

* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
* UserInterface/Views/Variables.css:
(:root):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css
Source/WebInspectorUI/UserInterface/Views/QuickConsole.css
Source/WebInspectorUI/UserInterface/Views/Variables.css

index 34e7dec..0863322 100644 (file)
@@ -1,3 +1,22 @@
+2016-02-17  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
+        https://bugs.webkit.org/show_bug.cgi?id=154328
+        <rdar://problem/24692996>
+
+        Introduce a CSS variable to ensure that the quick console is the
+        same height as the bottom right section of the styles sidebar.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+        (.sidebar > .panel.details.css-style > .content ~ .options-container):
+        (.sidebar > .panel.details.css-style > .content ~ .class-list-container):
+        * UserInterface/Views/QuickConsole.css:
+        (.quick-console):
+        * UserInterface/Views/Variables.css:
+        (:root):
+
 2016-02-17  Devin Rousso  <dcrousso+webkit@gmail.com>
 
         Web Inspector: Add Context menu separators to Styles sidebar
index 3a733bd..005bdd3 100644 (file)
@@ -76,7 +76,7 @@
 
 .sidebar > .panel.details.css-style > .content ~ .options-container {
     bottom: 0;
-    height: 29px;
+    height: var(--console-prompt-min-height);
 }
 
 .sidebar > .panel.details.css-style > .content:not(.supports-new-rule, .has-filter-bar) ~ :matches(.options-container, .class-list-container) {
 
 .sidebar > .panel.details.css-style > .content ~ .class-list-container {
     flex-wrap: wrap;
-    bottom: 29px;
+    bottom: var(--console-prompt-min-height);
     max-height: 65px;
     padding: 3px 2px;
     overflow-y: scroll;
index becfa0f..d60b70d 100644 (file)
@@ -25,6 +25,7 @@
 
 .quick-console {
     position: relative;
+    min-height: var(--console-prompt-min-height);
 
     display: flex;
     align-items: flex-end;
index 931f6b9..499b1c5 100644 (file)
@@ -36,6 +36,7 @@
     --panel-background-color: hsl(0, 0%, 94%);
 
     --console-secondary-text-color: hsla(0, 0%, 0%, 0.33);
+    --console-prompt-min-height: 30px;
 
     --syntax-highlight-number-color: hsl(248, 100%, 40%);
     --syntax-highlight-boolean-color: hsl(309, 85%, 35%);