http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure...
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Oct 2017 17:16:41 +0000 (17:16 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Oct 2017 17:16:41 +0000 (17:16 +0000)
https://bugs.webkit.org/show_bug.cgi?id=178467

Reviewed by Andy Estes.

* http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
* http/tests/loading/basic-auth-resend-wrong-credentials.html:
* platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
Use setTimeout to make the loading order deterministic.
The important part of this test is that the passwords shown in the delegate callbacks are correct,
and this doesn't change that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt
LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html
LayoutTests/platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt

index da87e39..886c2a1 100644 (file)
@@ -1,3 +1,17 @@
+2017-10-18  Alex Christensen  <achristensen@webkit.org>
+
+        http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.
+        https://bugs.webkit.org/show_bug.cgi?id=178467
+
+        Reviewed by Andy Estes.
+
+        * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+        * http/tests/loading/basic-auth-resend-wrong-credentials.html:
+        * platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
+        Use setTimeout to make the loading order deterministic.
+        The important part of this test is that the passwords shown in the delegate callbacks are correct,
+        and this doesn't change that.
+
 2017-10-18  Ms2ger  <Ms2ger@igalia.com>
 
         [GTK] Test gardening.
index beb8ecf..39796b7 100644 (file)
@@ -1,8 +1,9 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
 main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
 main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
 http://127.0.0.1:8000/loading/resources/test2/protected-resource.php - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,9 +13,6 @@ frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
 http://127.0.0.1:8000/loading/resources/test2/basic-auth-testing.php?username=correctusername&password=correctpassword - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
 frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
 This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.
 
 
index ad025fd..290b7a9 100644 (file)
@@ -36,7 +36,7 @@ function makeIFrame() {
 
 </script>
 </head>
-<body onload="makeIFrame()">
+<body onload="setTimeout(makeIFrame, 0)">
 This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.<br>
 </body>
 </html>
index 4a57ed7..6ac16f6 100644 (file)
@@ -1,8 +1,9 @@
 main frame - didStartProvisionalLoadForFrame
 main frame - didCommitLoadForFrame
 main frame - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
 main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
 127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword
 frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
@@ -12,9 +13,6 @@ frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
 127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword
 frame "<!--framePath //<!--frame1-->-->" - didCommitLoadForFrame
 frame "<!--framePath //<!--frame1-->-->" - didFinishDocumentLoadForFrame
-frame "<!--framePath //<!--frame1-->-->" - didHandleOnloadEventsForFrame
-frame "<!--framePath //<!--frame1-->-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
 This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time.