Remove 'font' shorthand property special casing
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jan 2015 07:10:31 +0000 (07:10 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Jan 2015 07:10:31 +0000 (07:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=140577

Reviewed by Darin Adler.

Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.

* css/CSSPrimitiveValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@179105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/css/CSSPrimitiveValue.h

index ac4e884..7c32400 100644 (file)
@@ -1,3 +1,18 @@
+2015-01-25  Chris Dumez  <cdumez@apple.com>
+
+        Remove 'font' shorthand property special casing
+        https://bugs.webkit.org/show_bug.cgi?id=140577
+
+        Reviewed by Darin Adler.
+
+        Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
+        supposed to change. This also makes sure that m_value.fontFamily
+        gets copied instead of moved when constructing a clone in
+        CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
+        to fail on the bots.
+
+        * css/CSSPrimitiveValue.h:
+
 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
 
         Setting HTMLMarqueeElement.trueSpeed doesn't work
index 62e6ea0..1b480fd 100644 (file)
@@ -441,7 +441,7 @@ private:
         DashboardRegion* region;
         CSSBasicShape* shape;
         CSSCalcValue* calc;
-        CSSFontFamily* fontFamily;
+        const CSSFontFamily* fontFamily;
     } m_value;
 };