Clean up missing *explicit* keyword in ctors of WebCore/rendering.
authorgyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Jan 2013 03:52:02 +0000 (03:52 +0000)
committergyuyoung.kim@samsung.com <gyuyoung.kim@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Jan 2013 03:52:02 +0000 (03:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=107373

Reviewed by Darin Adler.

Need to add *explicit* keyword to avoid implicit type conversion.

* rendering/RenderApplet.h:
(RenderApplet):
* rendering/RenderArena.h:
(RenderArena):
* rendering/RenderBR.h:
(RenderBR):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderDetailsMarker.h:
(RenderDetailsMarker):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
* rendering/RenderFlowThread.h:
* rendering/RenderFullScreen.h:
(RenderFullScreen):
* rendering/RenderGeometryMap.h:
(WebCore::RenderGeometryMapStep::RenderGeometryMapStep):
* rendering/RenderGrid.h:
(RenderGrid):
* rendering/RenderImage.h:
(RenderImage):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
* rendering/RenderLayerModelObject.h:
(RenderLayerModelObject):
* rendering/RenderListBox.h:
(RenderListBox):
* rendering/RenderListMarker.h:
(RenderListMarker):
* rendering/RenderMedia.h:
(RenderMedia):
* rendering/RenderMeter.h:
(RenderMeter):
* rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderPart.h:
(RenderPart):
* rendering/RenderProgress.h:
(RenderProgress):
* rendering/RenderReplaced.h:
(RenderReplaced):
* rendering/RenderReplica.h:
(RenderReplica):
* rendering/RenderRuby.h:
(RenderRubyAsInline):
* rendering/RenderRubyBase.h:
(RenderRubyBase):
* rendering/RenderRubyRun.h:
(RenderRubyRun):
* rendering/RenderRubyText.h:
(RenderRubyText):
* rendering/RenderSearchField.h:
(RenderSearchField):
* rendering/RenderSlider.h:
(RenderSlider):
* rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
* rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
* rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
* rendering/RenderView.h:
(RenderView):
* rendering/RenderWidgetProtector.h:
(WebCore::RenderWidgetProtector::RenderWidgetProtector):
* rendering/RootInlineBox.h:
(RootInlineBox): Remove meaningless parameter name.
* rendering/TableLayout.h:
(WebCore::TableLayout::TableLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21 files changed:
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderApplet.h
Source/WebCore/rendering/RenderArena.h
Source/WebCore/rendering/RenderBR.h
Source/WebCore/rendering/RenderBlock.h
Source/WebCore/rendering/RenderBox.h
Source/WebCore/rendering/RenderLayerBacking.h
Source/WebCore/rendering/RenderLayerCompositor.h
Source/WebCore/rendering/RenderLayerModelObject.h
Source/WebCore/rendering/RenderListBox.h
Source/WebCore/rendering/RenderMedia.h
Source/WebCore/rendering/RenderMeter.h
Source/WebCore/rendering/RenderObject.h
Source/WebCore/rendering/RenderPart.h
Source/WebCore/rendering/RenderProgress.h
Source/WebCore/rendering/RenderSlider.h
Source/WebCore/rendering/RenderSnapshottedPlugIn.h
Source/WebCore/rendering/RenderView.h
Source/WebCore/rendering/RenderWidgetProtector.h
Source/WebCore/rendering/RootInlineBox.h
Source/WebCore/rendering/TableLayout.h

index 91acaf4..4962d1c 100644 (file)
@@ -1,3 +1,90 @@
+2013-01-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Clean up missing *explicit* keyword in ctors of WebCore/rendering.
+        https://bugs.webkit.org/show_bug.cgi?id=107373
+
+        Reviewed by Darin Adler.
+
+        Need to add *explicit* keyword to avoid implicit type conversion.
+
+        * rendering/RenderApplet.h:
+        (RenderApplet):
+        * rendering/RenderArena.h:
+        (RenderArena):
+        * rendering/RenderBR.h:
+        (RenderBR):
+        * rendering/RenderBlock.h:
+        (RenderBlock):
+        * rendering/RenderBox.h:
+        (RenderBox):
+        * rendering/RenderDetailsMarker.h:
+        (RenderDetailsMarker):
+        * rendering/RenderFlexibleBox.h:
+        (RenderFlexibleBox):
+        * rendering/RenderFlowThread.h:
+        * rendering/RenderFullScreen.h:
+        (RenderFullScreen):
+        * rendering/RenderGeometryMap.h:
+        (WebCore::RenderGeometryMapStep::RenderGeometryMapStep):
+        * rendering/RenderGrid.h:
+        (RenderGrid):
+        * rendering/RenderImage.h:
+        (RenderImage):
+        * rendering/RenderLayerBacking.h:
+        (RenderLayerBacking):
+        * rendering/RenderLayerCompositor.h:
+        (RenderLayerCompositor):
+        * rendering/RenderLayerModelObject.h:
+        (RenderLayerModelObject):
+        * rendering/RenderListBox.h:
+        (RenderListBox):
+        * rendering/RenderListMarker.h:
+        (RenderListMarker):
+        * rendering/RenderMedia.h:
+        (RenderMedia):
+        * rendering/RenderMeter.h:
+        (RenderMeter):
+        * rendering/RenderMultiColumnBlock.h:
+        (RenderMultiColumnBlock):
+        * rendering/RenderMultiColumnFlowThread.h:
+        (RenderMultiColumnFlowThread):
+        * rendering/RenderObject.h:
+        (RenderObject):
+        * rendering/RenderPart.h:
+        (RenderPart):
+        * rendering/RenderProgress.h:
+        (RenderProgress):
+        * rendering/RenderReplaced.h:
+        (RenderReplaced):
+        * rendering/RenderReplica.h:
+        (RenderReplica):
+        * rendering/RenderRuby.h:
+        (RenderRubyAsInline):
+        * rendering/RenderRubyBase.h:
+        (RenderRubyBase):
+        * rendering/RenderRubyRun.h:
+        (RenderRubyRun):
+        * rendering/RenderRubyText.h:
+        (RenderRubyText):
+        * rendering/RenderSearchField.h:
+        (RenderSearchField):
+        * rendering/RenderSlider.h:
+        (RenderSlider):
+        * rendering/RenderSnapshottedPlugIn.h:
+        (RenderSnapshottedPlugIn):
+        * rendering/RenderTextControlMultiLine.h:
+        (RenderTextControlMultiLine):
+        * rendering/RenderTextControlSingleLine.h:
+        (RenderTextControlSingleLine):
+        * rendering/RenderView.h:
+        (RenderView):
+        * rendering/RenderWidgetProtector.h:
+        (WebCore::RenderWidgetProtector::RenderWidgetProtector):
+        * rendering/RootInlineBox.h:
+        (RootInlineBox): Remove meaningless parameter name.
+        * rendering/TableLayout.h:
+        (WebCore::TableLayout::TableLayout):
+
 2013-01-20  Kent Tamura  <tkent@chromium.org>
 
         Re-layout child blocks when border/padding of the box-sizing:border-box parent is updated
index 1516600..881e21c 100644 (file)
@@ -30,7 +30,7 @@ class HTMLAppletElement;
 
 class RenderApplet : public RenderEmbeddedObject {
 public:
-    RenderApplet(HTMLAppletElement*);
+    explicit RenderApplet(HTMLAppletElement*);
     virtual ~RenderApplet();
 
 private:
index 5538eff..8f2ccfc 100644 (file)
@@ -46,7 +46,7 @@ static const size_t gMaxRecycledSize = 1024;
 class RenderArena {
     WTF_MAKE_NONCOPYABLE(RenderArena); WTF_MAKE_FAST_ALLOCATED;
 public:
-    RenderArena(unsigned arenaSize = 8192);
+    explicit RenderArena(unsigned arenaSize = 8192);
     ~RenderArena();
 
     // Memory management functions
index 25e90da..3a64075 100644 (file)
@@ -33,7 +33,7 @@ class Position;
 
 class RenderBR : public RenderText {
 public:
-    RenderBR(Node*);
+    explicit RenderBR(Node*);
     virtual ~RenderBR();
 
     virtual const char* renderName() const { return "RenderBR"; }
index 240e934..7450ea9 100644 (file)
@@ -88,7 +88,7 @@ public:
     template <class> friend struct ValueToString;
 #endif
 
-    RenderBlock(ContainerNode*);
+    explicit RenderBlock(ContainerNode*);
     virtual ~RenderBlock();
 
     static RenderBlock* createAnonymous(Document*);
index 272426c..b4d1f5e 100644 (file)
@@ -44,7 +44,7 @@ enum ShouldComputePreferred { ComputeActual, ComputePreferred };
 
 class RenderBox : public RenderBoxModelObject {
 public:
-    RenderBox(ContainerNode*);
+    explicit RenderBox(ContainerNode*);
     virtual ~RenderBox();
 
     // hasAutoZIndex only returns true if the element is positioned or a flex-item since
index 89474c5..58adf3a 100644 (file)
@@ -57,7 +57,7 @@ enum CompositingLayerType {
 class RenderLayerBacking : public GraphicsLayerClient {
     WTF_MAKE_NONCOPYABLE(RenderLayerBacking); WTF_MAKE_FAST_ALLOCATED;
 public:
-    RenderLayerBacking(RenderLayer*);
+    explicit RenderLayerBacking(RenderLayer*);
     ~RenderLayerBacking();
 
     RenderLayer* owningLayer() const { return m_owningLayer; }
index 85a0373..e9bb01a 100644 (file)
@@ -64,7 +64,7 @@ enum CompositingUpdateType {
 class RenderLayerCompositor : public GraphicsLayerClient, public GraphicsLayerUpdaterClient {
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    RenderLayerCompositor(RenderView*);
+    explicit RenderLayerCompositor(RenderView*);
     ~RenderLayerCompositor();
 
     // Return true if this RenderView is in "compositing mode" (i.e. has one or more
index 6c27ff4..ee9a1a9 100644 (file)
@@ -31,7 +31,7 @@ class RenderLayer;
 
 class RenderLayerModelObject : public RenderObject {
 public:
-    RenderLayerModelObject(ContainerNode*);
+    explicit RenderLayerModelObject(ContainerNode*);
     virtual ~RenderLayerModelObject();
 
     // Called by RenderObject::willBeDestroyed() and is the only way layers should ever be destroyed
index 349293b..a18d1ae 100644 (file)
@@ -40,7 +40,7 @@ class HTMLSelectElement;
 
 class RenderListBox : public RenderBlock, private ScrollableArea {
 public:
-    RenderListBox(Element*);
+    explicit RenderListBox(Element*);
     virtual ~RenderListBox();
 
     void selectionChanged();
index 4694cab..f86d1e3 100644 (file)
@@ -36,7 +36,7 @@ class HTMLMediaElement;
 
 class RenderMedia : public RenderImage {
 public:
-    RenderMedia(HTMLMediaElement*);
+    explicit RenderMedia(HTMLMediaElement*);
     RenderMedia(HTMLMediaElement*, const IntSize& intrinsicSize);
     virtual ~RenderMedia();
 
index b7c3ece..36c6a24 100644 (file)
@@ -32,7 +32,7 @@ class HTMLMeterElement;
 
 class RenderMeter : public RenderBlock {
 public:
-    RenderMeter(HTMLElement*);
+    explicit RenderMeter(HTMLElement*);
     virtual ~RenderMeter();
 
     HTMLMeterElement* meterElement() const;
index 69d6043..895f0d0 100644 (file)
@@ -155,7 +155,7 @@ class RenderObject : public CachedImageClient {
 public:
     // Anonymous objects should pass the document as their node, and they will then automatically be
     // marked as anonymous in the constructor.
-    RenderObject(Node*);
+    explicit RenderObject(Node*);
     virtual ~RenderObject();
 
     RenderTheme* theme() const;
index dffbbd5..3cd2cd3 100644 (file)
@@ -30,7 +30,7 @@ namespace WebCore {
 // Renderer for frames via RenderFrameBase, and plug-ins via RenderEmbeddedObject.
 class RenderPart : public RenderWidget {
 public:
-    RenderPart(Element*);
+    explicit RenderPart(Element*);
     virtual ~RenderPart();
 
     virtual void setWidget(PassRefPtr<Widget>);
index 6835e48..481426b 100644 (file)
@@ -30,7 +30,7 @@ class HTMLProgressElement;
 
 class RenderProgress : public RenderBlock {
 public:
-    RenderProgress(HTMLElement*);
+    explicit RenderProgress(HTMLElement*);
     virtual ~RenderProgress();
 
     double position() const { return m_position; }
index e94ef8f..75aeabb 100644 (file)
@@ -33,7 +33,7 @@ class RenderSlider : public RenderFlexibleBox {
 public:
     static const int defaultTrackLength;
 
-    RenderSlider(HTMLInputElement*);
+    explicit RenderSlider(HTMLInputElement*);
     virtual ~RenderSlider();
 
     bool inDragMode() const;
index 8206ed0..078b0fd 100644 (file)
@@ -37,7 +37,7 @@ class HTMLPlugInImageElement;
 
 class RenderSnapshottedPlugIn : public RenderEmbeddedObject {
 public:
-    RenderSnapshottedPlugIn(HTMLPlugInImageElement*);
+    explicit RenderSnapshottedPlugIn(HTMLPlugInImageElement*);
     virtual ~RenderSnapshottedPlugIn();
 
     enum LabelSize {
index 9289ba5..97d1483 100644 (file)
@@ -44,7 +44,7 @@ class CustomFilterGlobalContext;
 
 class RenderView : public RenderBlock {
 public:
-    RenderView(Document*);
+    explicit RenderView(Document*);
     virtual ~RenderView();
 
     bool hitTest(const HitTestRequest&, HitTestResult&);
index 8bf6ac9..35c7519 100644 (file)
@@ -33,7 +33,7 @@ namespace WebCore {
 class RenderWidgetProtector {
     WTF_MAKE_NONCOPYABLE(RenderWidgetProtector);
 public:
-    RenderWidgetProtector(RenderWidget* object)
+    explicit RenderWidgetProtector(RenderWidget* object)
         : m_object(object)
         , m_arena(object->ref())
     {
index f3ed366..472c125 100644 (file)
@@ -35,7 +35,7 @@ struct GapRects;
 
 class RootInlineBox : public InlineFlowBox {
 public:
-    RootInlineBox(RenderBlock* block);
+    explicit RootInlineBox(RenderBlock*);
 
     virtual void destroy(RenderArena*);
 
index 7507683..eb9276d 100644 (file)
@@ -31,7 +31,7 @@ class RenderTable;
 class TableLayout {
     WTF_MAKE_NONCOPYABLE(TableLayout); WTF_MAKE_FAST_ALLOCATED;
 public:
-    TableLayout(RenderTable* table)
+    explicit TableLayout(RenderTable* table)
         : m_table(table)
     {
     }