This change causes asserts on mac-wk1 debug testers
Reverted changeset:
"Fixed crash loading Mozilla layout test
editor/libeditor/crashtests/431086-1.xhtml."
https://bugs.webkit.org/show_bug.cgi?id=150252
http://trac.webkit.org/changeset/192181
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-11-09 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r192181.
+
+ This change causes asserts on mac-wk1 debug testers
+
+ Reverted changeset:
+
+ "Fixed crash loading Mozilla layout test
+ editor/libeditor/crashtests/431086-1.xhtml."
+ https://bugs.webkit.org/show_bug.cgi?id=150252
+ http://trac.webkit.org/changeset/192181
+
2015-11-09 Jiewen Tan <jiewen_tan@apple.com>
Crash when right clicking in input box with -webkit-user-select: none
+++ /dev/null
-This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252
+++ /dev/null
-<div id="150252" xmlns="http://www.w3.org/1999/xhtml">
-
-<script type="text/javascript">
-
-function boom()
-{
- if (window.testRunner)
- testRunner.dumpAsText();
-
- var r = document.documentElement;
- r.style.position = "absolute";
- r.contentEditable = "true";
- r.focus();
- r.contentEditable = "false";
- r.focus();
- r.contentEditable = "true";
- document.execCommand("subscript", false, null);
- r.contentEditable = "false";
- document.getElementById("150252").innerHTML = "This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252";
-}
-
-window.addEventListener("load", boom, false);
-
-</script>
-
-</div>
+++ /dev/null
-This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252
+++ /dev/null
-<div id="150252" xmlns="http://www.w3.org/1999/xhtml">
-
-<script>
-
-if (window.testRunner)
- testRunner.dumpAsText();
-
-document.documentElement.contentEditable = "true";
-document.documentElement.focus();
-document.execCommand("superscript", false, null);
-document.getElementById("150252").innerHTML = "This test passes if it doesn't crash. https://bugs.webkit.org/show_bug.cgi?id=150252";
-
-</script>
-
-</div>
+2015-11-09 Ryan Haddad <ryanhaddad@apple.com>
+
+ Unreviewed, rolling out r192181.
+
+ This change causes asserts on mac-wk1 debug testers
+
+ Reverted changeset:
+
+ "Fixed crash loading Mozilla layout test
+ editor/libeditor/crashtests/431086-1.xhtml."
+ https://bugs.webkit.org/show_bug.cgi?id=150252
+ http://trac.webkit.org/changeset/192181
+
2015-11-09 Jiewen Tan <jiewen_tan@apple.com>
Crash when right clicking in input box with -webkit-user-select: none
RenderStyle* style = styleForSelectionStart(&m_frame, nodeToRemove); // sets nodeToRemove
const Font* result = nullptr;
- if (style) {
+ if (style)
result = &style->fontCascade().primaryFont();
- if (nodeToRemove) {
- ExceptionCode ec;
- nodeToRemove->remove(ec);
- ASSERT(!ec);
- }
+
+ if (nodeToRemove) {
+ ExceptionCode ec;
+ nodeToRemove->remove(ec);
+ ASSERT(!ec);
}
return result;
RenderStyle* style = styleForSelectionStart(&m_frame, nodeToRemove); // sets nodeToRemove
const Font* result = nullptr;
- if (style) {
+ if (style)
result = &style->fontCascade().primaryFont();
- if (nodeToRemove)
- nodeToRemove->remove(ASSERT_NO_EXCEPTION);
- }
+
+ if (nodeToRemove)
+ nodeToRemove->remove(ASSERT_NO_EXCEPTION);
return result;
}