REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other revers...
authorhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 May 2014 06:44:54 +0000 (06:44 +0000)
committerhyatt@apple.com <hyatt@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 May 2014 06:44:54 +0000 (06:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=132419

Reviewed by Andreas Kling.

Source/WebCore:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
Don't flip here. The old code needed to do that, but the new code doesn't.

LayoutTests:
* platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
* platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png
LayoutTests/platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png
Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderMultiColumnSet.cpp

index 82ba3fc..32bb286 100644 (file)
@@ -1,3 +1,13 @@
+2014-04-30  David Hyatt  <hyatt@apple.com>
+
+        REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
+        https://bugs.webkit.org/show_bug.cgi?id=132419
+
+        Reviewed by Andreas Kling.
+
+        * platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
+        * platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
+
 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
 
         [iOS WK2] Some accerated overflow-scroll doesn't scroll correctly
index 3875cc6..6254052 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png and b/LayoutTests/platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png differ
index e187985..ee6f861 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png and b/LayoutTests/platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png differ
index 74cf72d..c1a5bec 100644 (file)
@@ -1,3 +1,14 @@
+2014-04-30  David Hyatt  <hyatt@apple.com>
+
+        REGRESSION (r168046): [New Multicolumn] LeftToRight-rl.html (and all the other reversed/block-axis pagination tests) fail
+        https://bugs.webkit.org/show_bug.cgi?id=132419
+
+        Reviewed by Andreas Kling.
+
+        * rendering/RenderMultiColumnSet.cpp:
+        (WebCore::RenderMultiColumnSet::initialBlockOffsetForPainting):
+        Don't flip here. The old code needed to do that, but the new code doesn't.
+
 2014-04-30  Alexey Proskuryakov  <ap@apple.com>
 
         Roll out fix for https://bugs.webkit.org/show_bug.cgi?id=131637:
index 3ac683d..802c640 100644 (file)
@@ -674,8 +674,6 @@ LayoutUnit RenderMultiColumnSet::initialBlockOffsetForPainting() const
     if (!progressionIsInline && progressionReversed) {
         LayoutRect colRect = columnRectAt(0);
         result = isHorizontalWritingMode() ? colRect.y() : colRect.x();
-        if (style().isFlippedBlocksWritingMode())
-            result = -result;
     }
     return result;
 }