[GTK] [WebKit2] CanHandleRequest API test fails
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 11:57:06 +0000 (11:57 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Oct 2013 11:57:06 +0000 (11:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=88453

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-10-25
Reviewed by Martin Robinson.

Source/WebKit2:

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):

Tools:

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
Tools/ChangeLog
Tools/Scripts/run-gtk-tests

index e6bb42c..49b4610 100644 (file)
@@ -1,3 +1,16 @@
+2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
+
+        [GTK] [WebKit2] CanHandleRequest API test fails
+        https://bugs.webkit.org/show_bug.cgi?id=88453
+
+        Reviewed by Martin Robinson.
+
+        Make WebPage::platformCanHandleRequest return false by default 
+        for unknown schemes.
+
+        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+        (WebKit::WebPage::platformCanHandleRequest):
+
 2013-10-25  Ryuan Choi  <ryuan.choi@samsung.com>
 
         [EFL][WK2] Build break after r157967 and r157972
index 2785a26..bf11f41 100644 (file)
@@ -141,7 +141,7 @@ String WebPage::cachedResponseMIMETypeForURL(const URL&)
 bool WebPage::platformCanHandleRequest(const ResourceRequest&)
 {
     notImplemented();
-    return true;
+    return false;
 }
 
 String WebPage::cachedSuggestedFilenameForURL(const URL&)
index 6fb0ffb..0476158 100644 (file)
@@ -1,3 +1,13 @@
+2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
+
+        [GTK] [WebKit2] CanHandleRequest API test fails
+        https://bugs.webkit.org/show_bug.cgi?id=88453
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner):
+
 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
 
         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
index 9693734..f76a8e5 100755 (executable)
@@ -69,7 +69,6 @@ class TestRunner:
         SkippedTest("WebKit2APITests/TestResources", "/webkit2/WebKitWebView/resources", "Test is flaky in GTK Linux 32-bit Release bot", 82868),
         SkippedTest("WebKit2APITests/TestWebKitWebView", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
         SkippedTest("WebKit2APITests/TestContextMenu", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
-        SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.CanHandleRequest", "Test fails", 88453),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
         SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutFrames", "Test fails", 85037),