[Curl] Remove unused AuthenticationManager static methods.
authorBasuke.Suzuki@sony.com <Basuke.Suzuki@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Jul 2018 19:33:26 +0000 (19:33 +0000)
committerBasuke.Suzuki@sony.com <Basuke.Suzuki@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 9 Jul 2018 19:33:26 +0000 (19:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187419

Reviewed by Yusuke Suzuki.

The file for curl port was added without implementation and never called from anyware.
Also interfaces only used by the curl port were removed from the shared header file.

* PlatformWin.cmake:
* Shared/Authentication/AuthenticationManager.h:
* Shared/Authentication/curl/AuthenticationManagerCurl.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/PlatformWin.cmake
Source/WebKit/Shared/Authentication/AuthenticationManager.h
Source/WebKit/Shared/Authentication/curl/AuthenticationManagerCurl.cpp [deleted file]

index 36e6c04..7a9d975 100644 (file)
@@ -1,3 +1,17 @@
+2018-07-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [Curl] Remove unused AuthenticationManager static methods.
+        https://bugs.webkit.org/show_bug.cgi?id=187419
+
+        Reviewed by Yusuke Suzuki.
+
+        The file for curl port was added without implementation and never called from anyware.
+        Also interfaces only used by the curl port were removed from the shared header file.
+
+        * PlatformWin.cmake:
+        * Shared/Authentication/AuthenticationManager.h:
+        * Shared/Authentication/curl/AuthenticationManagerCurl.cpp: Removed.
+
 2018-07-09  Stephan Szabo  <stephan.szabo@sony.com>
 
         Check that LayerTreeHost was created before use
index a03d03f..fd24563 100644 (file)
@@ -155,8 +155,6 @@ if (${WTF_PLATFORM_WIN_CAIRO})
 
         Shared/API/c/cairo/WKImageCairo.cpp
 
-        Shared/Authentication/curl/AuthenticationManagerCurl.cpp
-
         Shared/cairo/ShareableBitmapCairo.cpp
 
         Shared/curl/WebCoreArgumentCodersCurl.cpp
index df54ceb..aa9d5e7 100644 (file)
@@ -80,12 +80,6 @@ public:
 
     uint64_t outstandingAuthenticationChallengeCount() const { return m_challenges.size(); }
 
-    static void receivedCredential(const WebCore::AuthenticationChallenge&, const WebCore::Credential&);
-    static void receivedRequestToContinueWithoutCredential(const WebCore::AuthenticationChallenge&);
-    static void receivedCancellation(const WebCore::AuthenticationChallenge&);
-    static void receivedRequestToPerformDefaultHandling(const WebCore::AuthenticationChallenge&);
-    static void receivedChallengeRejection(const WebCore::AuthenticationChallenge&);
-
 private:
     struct Challenge {
         uint64_t pageID;
diff --git a/Source/WebKit/Shared/Authentication/curl/AuthenticationManagerCurl.cpp b/Source/WebKit/Shared/Authentication/curl/AuthenticationManagerCurl.cpp
deleted file mode 100644 (file)
index afc29be..0000000
+++ /dev/null
@@ -1,53 +0,0 @@
-/*
- * Copyright (C) 2017 Sony Interactive Entertainment Inc.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "AuthenticationManager.h"
-
-using namespace WebCore;
-
-namespace WebKit {
-
-void AuthenticationManager::receivedCredential(const AuthenticationChallenge&, const Credential&)
-{
-}
-
-void AuthenticationManager::receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&)
-{
-}
-
-void AuthenticationManager::receivedCancellation(const AuthenticationChallenge&)
-{
-}
-
-void AuthenticationManager::receivedRequestToPerformDefaultHandling(const AuthenticationChallenge&)
-{
-}
-
-void AuthenticationManager::receivedChallengeRejection(const AuthenticationChallenge&)
-{
-}
-
-}