[Autotools] Remove the Canvas Path configuration option
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2013 17:17:13 +0000 (17:17 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Jan 2013 17:17:13 +0000 (17:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=107537

Reviewed by Martin Robinson.

.:

* configure.ac: Remove the configuration option for the Canvas Path
feature as this is not in line with the new guidelines about feature
enablement in the autotools build system.

Source/WebCore:

No new tests - no new testable functionality.

* GNUmakefile.am: Remove the Automake conditional analysis, the related
configuration option is being removed as well.
* GNUmakefile.features.am.in: Add the ENABLE_CANVAS_PATH feature define,
defaulting to 0 in release builds (but is disabled in development builds
of the GTK port as well at the moment).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.features.am.in
configure.ac

index 63bb30e..b447874 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
 
+        [Autotools] Remove the Canvas Path configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=107537
+
+        Reviewed by Martin Robinson.
+
+        * configure.ac: Remove the configuration option for the Canvas Path
+        feature as this is not in line with the new guidelines about feature
+        enablement in the autotools build system.
+
+2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
+
         [Autotools] Place a warning in configure.ac about adding new configuration options
         https://bugs.webkit.org/show_bug.cgi?id=107559
 
index 239688f..5efe86b 100644 (file)
@@ -1,3 +1,18 @@
+2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
+
+        [Autotools] Remove the Canvas Path configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=107537
+
+        Reviewed by Martin Robinson.
+
+        No new tests - no new testable functionality.
+
+        * GNUmakefile.am: Remove the Automake conditional analysis, the related
+        configuration option is being removed as well.
+        * GNUmakefile.features.am.in: Add the ENABLE_CANVAS_PATH feature define,
+        defaulting to 0 in release builds (but is disabled in development builds
+        of the GTK port as well at the moment).
+
 2013-01-18  Stephen Chenney  <schenney@chromium.org>
 
         Asserts when textPath is used with no path
index f33d817..cc84de4 100644 (file)
@@ -144,15 +144,6 @@ webcoregtk_cppflags += \
 endif # END TARGET_WIN32
 
 # ----
-# Canvas Path
-# ----
-if ENABLE_CANVAS_PATH
-feature_defines_overrides += ENABLE_CANVAS_PATH=1
-else
-feature_defines_overrides += ENABLE_CANVAS_PATH=0
-endif # END ENABLE_CANVAS_PATH
-
-# ----
 # Gamepad support
 # ---
 if ENABLE_GAMEPAD
index 81b4df0..4d3665a 100644 (file)
@@ -3,6 +3,7 @@ feature_defines_defaults += \
        ENABLE_ACCELERATED_2D_CANVAS=0 \
        ENABLE_BATTERY_STATUS=0 \
        ENABLE_BLOB=1 \
+       ENABLE_CANVAS_PATH=0 \
        ENABLE_CANVAS_PROXY=0 \
        ENABLE_CHANNEL_MESSAGING=1 \
        ENABLE_CSP_NEXT=0 \
index 575cdd9..15b5603 100644 (file)
@@ -645,14 +645,6 @@ AC_ARG_ENABLE(accelerated_compositing,
             ])
 AC_MSG_RESULT([$enable_accelerated_compositing])
 
-# check whether to enable Canvas Path support
-AC_MSG_CHECKING([whether to enable Canvas Path support])
-AC_ARG_ENABLE(canvas-path,
-              AC_HELP_STRING([--enable-canvas-path],
-                             [enable Canvas Path support [default=no]]),
-              [],[enable_canvas_path="no"])
-AC_MSG_RESULT([$enable_canvas_path])
-
 # check whether to enable Gamepad support
 AC_MSG_CHECKING([whether to enable Gamepad support])
 AC_ARG_ENABLE(gamepad,
@@ -1171,7 +1163,6 @@ AM_CONDITIONAL([USE_FARSTREAM], [test "$have_farstream" = "yes"])
 AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug_features" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
 AM_CONDITIONAL([ENABLE_GAMEPAD],[test "$enable_gamepad" = "yes"])
-AM_CONDITIONAL([ENABLE_CANVAS_PATH],[test "$enable_canvas_path" = "yes"])
 AM_CONDITIONAL([ENABLE_XSLT],[test "$enable_xslt" = "yes"])
 AM_CONDITIONAL([ENABLE_GEOLOCATION], [test "$enable_geolocation" = "yes"])
 AM_CONDITIONAL([ENABLE_VIDEO],[test "$enable_video" = "yes"])
@@ -1187,7 +1178,6 @@ AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])
 AM_CONDITIONAL([ENABLE_SPELLCHECK],[test "$enable_spellcheck" = "yes"])
 AM_CONDITIONAL([ENABLE_CSS_FILTERS],[test "$enable_css_filters" = "yes"])
 AM_CONDITIONAL([ENABLE_CSS_SHADERS],[test "$enable_css_shaders" = "yes"])
-AM_CONDITIONAL([ENABLE_CANVAS_PATH],[test "$enable_canvas_path" = "yes"])
 
 # Gtk conditionals
 AM_CONDITIONAL([ENABLE_INTROSPECTION],[test "$enable_introspection" = "yes"])
@@ -1252,7 +1242,6 @@ Features:
  WebKit1 support                                          : $enable_webkit1
  WebKit2 support                                          : $enable_webkit2
  Accelerated Compositing                                  : $enable_accelerated_compositing
- Canvas Path                                              : $enable_canvas_path
  Gamepad support                                          : $enable_gamepad
  Geolocation support                                      : $enable_geolocation
  HTML5 video element support                              : $enable_video