HTTP 500 error between QueueStatusServer and bot(s)
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 07:00:11 +0000 (07:00 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Jan 2013 07:00:11 +0000 (07:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=107184

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-24
Reviewed by Adam Barth.

Removed the use of memcache which was the source of the exception.

* QueueStatusServer/handlers/updatestatus.py:
(UpdateStatus.post):
* QueueStatusServer/model/attachment.py:
(Attachment):
(Attachment.summary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/handlers/updatestatus.py
Tools/QueueStatusServer/model/attachment.py

index 5ad5793..e2b3ddd 100644 (file)
@@ -1,3 +1,18 @@
+2013-01-24  Alan Cutter  <alancutter@chromium.org>
+
+        HTTP 500 error between QueueStatusServer and bot(s)
+        https://bugs.webkit.org/show_bug.cgi?id=107184
+
+        Reviewed by Adam Barth.
+
+        Removed the use of memcache which was the source of the exception.
+
+        * QueueStatusServer/handlers/updatestatus.py:
+        (UpdateStatus.post):
+        * QueueStatusServer/model/attachment.py:
+        (Attachment):
+        (Attachment.summary):
+
 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r140653.
index a0e7194..b02e987 100644 (file)
@@ -67,5 +67,4 @@ class UpdateStatus(UpdateBase):
         RecordBotEvent.record_activity(queue_status.queue_name, queue_status.bot_id)
         if queue_status.active_patch_id:
             RecordPatchEvent.updated(queue_status.active_patch_id, queue_status.queue_name, queue_status.bot_id)
-        Attachment.dirty(queue_status.active_patch_id)
         self.response.out.write(queue_status.key().id())
index f98f265..83b441e 100644 (file)
@@ -28,8 +28,6 @@
 
 import re
 
-from google.appengine.api import memcache
-
 from model.queues import Queue
 from model.queuestatus import QueueStatus
 from model.workitems import WorkItems
@@ -37,10 +35,6 @@ from model.workitems import WorkItems
 
 class Attachment(object):
     @classmethod
-    def dirty(cls, attachment_id):
-        memcache.delete(str(attachment_id), namespace="attachment-summary")
-
-    @classmethod
     def recent(cls, limit=1):
         statuses = QueueStatus.all().order("-date")
         # Notice that we use both a set and a list here to keep the -date ordering.
@@ -66,11 +60,7 @@ class Attachment(object):
     def summary(self):
         if self._summary:
             return self._summary
-        self._summary = memcache.get(str(self.id), namespace="attachment-summary")
-        if self._summary:
-            return self._summary
         self._summary = self._fetch_summary()
-        memcache.set(str(self.id), self._summary, namespace="attachment-summary")
         return self._summary
 
     def state_from_queue_status(self, status):