Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that...
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Apr 2015 22:57:18 +0000 (22:57 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 13 Apr 2015 22:57:18 +0000 (22:57 +0000)
* runtime/InferredValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@182763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/runtime/InferredValue.h

index 4d87b69..e2b61d5 100644 (file)
@@ -1,5 +1,11 @@
 2015-04-13  Filip Pizlo  <fpizlo@apple.com>
 
+        Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that use FAST_ALLOCATED.
+
+        * runtime/InferredValue.h:
+
+2015-04-13  Filip Pizlo  <fpizlo@apple.com>
+
         Unreviewed, fix build. I introduced a new cell type at the same time as kling changed how new cell types are written.
 
         * runtime/InferredValue.h:
index b4b4d65..28318e9 100644 (file)
@@ -96,15 +96,10 @@ public:
     
     static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
     
-private:
-    InferredValue(VM&);
-    ~InferredValue();
-    
-    JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const FireDetail&);
-    JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const char* reason);
-    
     // We could have used Weak<>. But we want arbitrary JSValues, not just cells. It's also somewhat
     // convenient to have eager notification of death.
+    //
+    // Also note that this should be a private class, but it isn't because Windows.
     class ValueCleanup : public UnconditionalFinalizer {
         WTF_MAKE_FAST_ALLOCATED;
         
@@ -119,6 +114,13 @@ private:
         InferredValue* m_owner;
     };
     
+private:
+    InferredValue(VM&);
+    ~InferredValue();
+    
+    JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const FireDetail&);
+    JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const char* reason);
+    
     friend class ValueCleanup;
     
     InlineWatchpointSet m_set;