Fix some unused parameter warnings
authordon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2018 02:30:27 +0000 (02:30 +0000)
committerdon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 4 Dec 2018 02:30:27 +0000 (02:30 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192336

Reviewed by Fujii Hironori.

Source/WebCore:

* Modules/indexeddb/server/IDBSerialization.cpp:
(WebCore::isLegacySerializedIDBKeyData):
* platform/FileSystem.cpp:
(WebCore::FileSystem::openAndLockFile):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::bindVertexArray):
* platform/network/curl/CertificateInfo.h:
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):

Source/WTF:

* wtf/StackTrace.cpp:
(WTFGetBacktrace):
(WTF::StackTrace::demangle):
* wtf/generic/MemoryPressureHandlerGeneric.cpp:
(WTF::MemoryPressureHandler::holdOff):
(WTF::MemoryPressureHandler::respondToMemoryPressure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WTF/ChangeLog
Source/WTF/wtf/StackTrace.cpp
Source/WTF/wtf/generic/MemoryPressureHandlerGeneric.cpp
Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp
Source/WebCore/platform/FileSystem.cpp
Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
Source/WebCore/platform/network/curl/CertificateInfo.h

index 878d824..4cb8afa 100644 (file)
@@ -1,3 +1,17 @@
+2018-12-03  Don Olmstead  <don.olmstead@sony.com>
+
+        Fix some unused parameter warnings
+        https://bugs.webkit.org/show_bug.cgi?id=192336
+
+        Reviewed by Fujii Hironori.
+
+        * wtf/StackTrace.cpp:
+        (WTFGetBacktrace):
+        (WTF::StackTrace::demangle):
+        * wtf/generic/MemoryPressureHandlerGeneric.cpp:
+        (WTF::MemoryPressureHandler::holdOff):
+        (WTF::MemoryPressureHandler::respondToMemoryPressure):
+
 2018-12-01  Alexey Proskuryakov  <ap@apple.com>
 
         Modernize version check for _suppressedAutoAddedHTTPHeaders
index becf22a..c41dec0 100644 (file)
@@ -51,6 +51,7 @@ void WTFGetBacktrace(void** stack, int* size)
 #elif OS(WINDOWS)
     *size = RtlCaptureStackBackTrace(0, *size, stack, 0);
 #else
+    UNUSED_PARAM(stack);
     *size = 0;
 #endif
 }
@@ -100,6 +101,8 @@ auto StackTrace::demangle(void* pc) -> std::optional<DemangleEntry>
     }
     if (mangledName || cxaDemangled)
         return DemangleEntry { mangledName, cxaDemangled };
+#else
+    UNUSED_PARAM(pc);
 #endif
     return std::nullopt;
 }
index db897c6..4533873 100644 (file)
@@ -40,11 +40,11 @@ void MemoryPressureHandler::uninstall()
 {
 }
 
-void MemoryPressureHandler::holdOff(Seconds seconds)
+void MemoryPressureHandler::holdOff(Seconds)
 {
 }
 
-void MemoryPressureHandler::respondToMemoryPressure(Critical critical, Synchronous synchronous)
+void MemoryPressureHandler::respondToMemoryPressure(Critical, Synchronous)
 {
 }
 
index 256b672..aafb0e2 100644 (file)
@@ -1,3 +1,20 @@
+2018-12-03  Don Olmstead  <don.olmstead@sony.com>
+
+        Fix some unused parameter warnings
+        https://bugs.webkit.org/show_bug.cgi?id=192336
+
+        Reviewed by Fujii Hironori.
+
+        * Modules/indexeddb/server/IDBSerialization.cpp:
+        (WebCore::isLegacySerializedIDBKeyData):
+        * platform/FileSystem.cpp:
+        (WebCore::FileSystem::openAndLockFile):
+        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+        (WebCore::GraphicsContext3D::bindVertexArray):
+        * platform/network/curl/CertificateInfo.h:
+        (WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
+        (WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
+
 2018-12-03  Keith Rollin  <krollin@apple.com>
 
         Add .xcfilelist files
index 98d09be..a5f0292 100644 (file)
@@ -114,6 +114,9 @@ static bool isLegacySerializedIDBKeyData(const uint8_t* data, size_t size)
     GRefPtr<GBytes> bytes = adoptGRef(g_bytes_new(data, size));
     GRefPtr<GVariant> variant = g_variant_new_from_bytes(G_VARIANT_TYPE("a{sv}"), bytes.get(), FALSE);
     return g_variant_is_normal_form(variant.get());
+#else
+    UNUSED_PARAM(data);
+    UNUSED_PARAM(size);
 #endif
     return false;
 }
index a77998c..ed9d37a 100644 (file)
@@ -339,6 +339,8 @@ PlatformFileHandle openAndLockFile(const String& path, FileOpenMode openMode, Op
 #if USE(FILE_LOCK)
     bool locked = lockFile(handle, lockMode);
     ASSERT_UNUSED(locked, locked);
+#else
+    UNUSED_PARAM(lockMode);
 #endif
 
     return handle;
index d71711a..eb93bc0 100644 (file)
@@ -1579,6 +1579,8 @@ void GraphicsContext3D::bindVertexArray(Platform3DObject array)
     makeContextCurrent();
 #if (!USE(OPENGL_ES) && (PLATFORM(GTK) || PLATFORM(WIN))) || PLATFORM(COCOA)
     ::glBindVertexArray(array);
+#else
+    UNUSED_PARAM(array);
 #endif
 }
 
index 758ecba..eed863b 100644 (file)
@@ -71,12 +71,12 @@ namespace WTF {
 namespace Persistence {
 
 template<> struct Coder<WebCore::CertificateInfo> {
-    static void encode(Encoder& encoder, const WebCore::CertificateInfo& certificateInfo)
+    static void encode(Encoder&, const WebCore::CertificateInfo&)
     {
         notImplemented();
     }
 
-    static bool decode(Decoder& decoder, WebCore::CertificateInfo& certificateInfo)
+    static bool decode(Decoder&, WebCore::CertificateInfo&)
     {
         notImplemented();
         return false;