https://bugs.webkit.org/show_bug.cgi?id=171509
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
* Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
* Scripts/webkitpy/port/base_unittest.py: Ditto.
* Scripts/webkitpy/port/device.py: Ditto.
* Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
* Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
* Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
* Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
(ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
(ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2017-05-01 Aakash Jain <aakash_jain@apple.com>
+
+ fix check-webkit-style errors in webkitpy about two blank lines before class definitions
+ https://bugs.webkit.org/show_bug.cgi?id=171509
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
+ * Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
+ * Scripts/webkitpy/port/base_unittest.py: Ditto.
+ * Scripts/webkitpy/port/device.py: Ditto.
+ * Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
+ * Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
+ * Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
+ * Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
+ * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
+ (ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
+ (ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.
+
2017-04-25 Daniel Bates <dabates@apple.com>
[Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
from webkitpy.common.memoized import memoized
from webkitpy.common.system.filesystem import FileSystem
+
class Contributor(object):
def __init__(self, name, email_or_emails, irc_nickname_or_nicknames=None, alias_or_aliases=None, expertise=None):
assert(name)
Contributor.__init__(self, name, email_or_emails, irc_nickname, alias_or_aliases, expertise)
self.is_bot = True
+
class CommitterList(object):
# Committers and reviewers are passed in to allow easy testing
def test_uses_custom_device(self):
class MockCustomDevicePort(TestPort):
- CUSTOM_DEVICE_CLASSES = ['starship']
+ CUSTOM_DEVICE_CLASSES = ['starship']
+
def __init__(self, host):
super(MockCustomDevicePort, self).__init__(host)
manager = get_manager()
self.assertTrue(manager._custom_device_for_test('fast/test-starship/lasers.html') == 'starship')
-
self.keyboard_interrupted |= test_run_results.keyboard_interrupted
return self
+
class RunDetails(object):
def __init__(self, exit_code, summarized_results=None, initial_results=None, retry_results=None, enabled_pixel_tests_in_retry=False):
self.exit_code = exit_code
printer.cleanup()
return -1
+
def _set_up_derived_options(port, options):
"""Sets the options values that depend on other options values."""
if not options.child_processes:
self.assertTrue(port._filesystem.isdir(jhbuild_path))
self.assertTrue(port._should_use_jhbuild())
+
class NaturalCompareTest(unittest.TestCase):
def setUp(self):
self._port = TestPort(MockSystemHost())
import socket
+
class Device(object):
def __init__(self, platform_device):
self.platform_device = platform_device
import subprocess
import os
+
class GDBCrashLogGenerator(object):
def __init__(self, name, pid, newer_than, filesystem, path_to_driver):
self.name = name
"Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig",
]
+
class FeatureDefinesChecker(object):
categories = set(['featuredefines/new', 'featuredefines/equality'])
import re
from sets import Set
+
class JSONChecker(object):
"""Processes JSON lines for checking style."""
Exception.__init__(self)
self.patch = patch
+
class PatchAnalysisTaskDelegate(object):
def parent_command(self):
raise NotImplementedError("subclasses must implement")