fix check-webkit-style errors in webkitpy about two blank lines before class definitions
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 May 2017 21:49:28 +0000 (21:49 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 1 May 2017 21:49:28 +0000 (21:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=171509

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
* Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
* Scripts/webkitpy/port/base_unittest.py: Ditto.
* Scripts/webkitpy/port/device.py: Ditto.
* Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
* Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
* Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
* Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
(ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
(ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
Tools/Scripts/webkitpy/common/config/committers.py
Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Tools/Scripts/webkitpy/port/base_unittest.py
Tools/Scripts/webkitpy/port/device.py
Tools/Scripts/webkitpy/port/linux_get_crash_log.py
Tools/Scripts/webkitpy/style/checkers/featuredefines.py
Tools/Scripts/webkitpy/style/checkers/jsonchecker.py
Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py

index 2a4d1db..4ee3b1b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,23 @@
+2017-05-01  Aakash Jain  <aakash_jain@apple.com>
+
+        fix check-webkit-style errors in webkitpy about two blank lines before class definitions
+        https://bugs.webkit.org/show_bug.cgi?id=171509
+
+        Reviewed by Alexey Proskuryakov.
+
+        * Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
+        * Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
+        * Scripts/webkitpy/port/base_unittest.py: Ditto.
+        * Scripts/webkitpy/port/device.py: Ditto.
+        * Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
+        * Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
+        * Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
+        * Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
+        * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
+        (ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
+        (ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.
+
 2017-04-25  Daniel Bates  <dabates@apple.com>
 
         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
index 9ea95ca..66a0a65 100644 (file)
@@ -37,6 +37,7 @@ from webkitpy.common.editdistance import edit_distance
 from webkitpy.common.memoized import memoized
 from webkitpy.common.system.filesystem import FileSystem
 
+
 class Contributor(object):
     def __init__(self, name, email_or_emails, irc_nickname_or_nicknames=None, alias_or_aliases=None, expertise=None):
         assert(name)
@@ -171,6 +172,7 @@ class Bot(Contributor):
         Contributor.__init__(self, name, email_or_emails, irc_nickname, alias_or_aliases, expertise)
         self.is_bot = True
 
+
 class CommitterList(object):
 
     # Committers and reviewers are passed in to allow easy testing
index 7e64f8d..c92801b 100644 (file)
@@ -104,7 +104,8 @@ class ManagerTest(unittest.TestCase):
 
     def test_uses_custom_device(self):
         class MockCustomDevicePort(TestPort):
-            CUSTOM_DEVICE_CLASSES = ['starship']            
+            CUSTOM_DEVICE_CLASSES = ['starship']
+
             def __init__(self, host):
                 super(MockCustomDevicePort, self).__init__(host)
 
@@ -116,4 +117,3 @@ class ManagerTest(unittest.TestCase):
 
         manager = get_manager()
         self.assertTrue(manager._custom_device_for_test('fast/test-starship/lasers.html') == 'starship')
-        
index 26acee1..8987020 100644 (file)
@@ -120,6 +120,7 @@ class TestRunResults(object):
         self.keyboard_interrupted |= test_run_results.keyboard_interrupted
         return self
 
+
 class RunDetails(object):
     def __init__(self, exit_code, summarized_results=None, initial_results=None, retry_results=None, enabled_pixel_tests_in_retry=False):
         self.exit_code = exit_code
index 7c6ddc8..33a60cc 100755 (executable)
@@ -365,6 +365,7 @@ def _print_expectations(port, options, args, logging_stream):
         printer.cleanup()
         return -1
 
+
 def _set_up_derived_options(port, options):
     """Sets the options values that depend on other options values."""
     if not options.child_processes:
index 491978b..a9ba4a7 100644 (file)
@@ -405,6 +405,7 @@ class PortTest(unittest.TestCase):
         self.assertTrue(port._filesystem.isdir(jhbuild_path))
         self.assertTrue(port._should_use_jhbuild())
 
+
 class NaturalCompareTest(unittest.TestCase):
     def setUp(self):
         self._port = TestPort(MockSystemHost())
index 9f097c9..67820ff 100644 (file)
@@ -22,6 +22,7 @@
 
 import socket
 
+
 class Device(object):
     def __init__(self, platform_device):
         self.platform_device = platform_device
index c5e620c..d597024 100644 (file)
@@ -30,6 +30,7 @@
 import subprocess
 import os
 
+
 class GDBCrashLogGenerator(object):
     def __init__(self, name, pid, newer_than, filesystem, path_to_driver):
         self.name = name
index b8a26f3..84280a6 100644 (file)
@@ -37,6 +37,7 @@ FEATURE_DEFINE_FILES = [
     "Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig",
 ]
 
+
 class FeatureDefinesChecker(object):
     categories = set(['featuredefines/new', 'featuredefines/equality'])
 
index 63ac579..61b059b 100644 (file)
@@ -26,6 +26,7 @@ import json
 import re
 from sets import Set
 
+
 class JSONChecker(object):
     """Processes JSON lines for checking style."""
 
index 7761cc4..5de8386 100644 (file)
@@ -50,6 +50,7 @@ class PatchIsNotApplicable(Exception):
         Exception.__init__(self)
         self.patch = patch
 
+
 class PatchAnalysisTaskDelegate(object):
     def parent_command(self):
         raise NotImplementedError("subclasses must implement")