Layout Test editing/deleting/password-delete-performance.html is failing
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Nov 2013 04:50:45 +0000 (04:50 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Nov 2013 04:50:45 +0000 (04:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

* Interactive/DeletingInPasswordField.html: Added.
* Skipped:

LayoutTests:

Removed the test that has been timing out.

* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/editing/deleting/password-delete-performance.html [deleted file]
PerformanceTests/ChangeLog
PerformanceTests/Interactive/DeletingInPasswordField.html [new file with mode: 0644]
PerformanceTests/Skipped

index 938e3ea..ab5ceb3 100644 (file)
@@ -1,3 +1,15 @@
+2013-11-22  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Layout Test editing/deleting/password-delete-performance.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=124781
+
+        Reviewed by Alexey Proskuryakov.
+
+        Removed the test that has been timing out.
+
+        * TestExpectations:
+        * editing/deleting/password-delete-performance.html: Removed.
+
 2013-11-22  Brendan Long  <b.long@cablelabs.com>
 
         Fire "change" event on TextTrackList when a TextTrack's mode changes
index bf7e1aa..c72896b 100644 (file)
@@ -69,6 +69,3 @@ fast/mediastream/MediaStream-clone.html [ Skip ]
 # The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
 # Skipping it for now, then put it again when the spec decides it
 fast/mediastream/MediaStream-onended.html [ Skip ]
-
-# Times out on most runs
-webkit.org/b/124781 editing/deleting/password-delete-performance.html [ Skip ]
diff --git a/LayoutTests/editing/deleting/password-delete-performance.html b/LayoutTests/editing/deleting/password-delete-performance.html
deleted file mode 100644 (file)
index c98b367..0000000
+++ /dev/null
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<html>
-    <body>
-        <p id="description">This test ensures that deleting characters from a password field that follows large content blocks is not slow.
-        To run the test manually, delete the character from the password field. The user agent should not freeze.</p>
-
-        <div id="content" style="height:0px; overflow:hidden;"> </div>
-        <input id="field" type="password" value="A">
-
-        <script src="../editing.js"></script>
-        <script>
-            if (window.testRunner)
-                testRunner.dumpAsText();
-
-            var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
-            for (var i = 0; i < 15; i++) {
-                newContent += newContent;
-            }
-
-            var contentDiv = document.getElementById('content');
-            contentDiv.innerHTML = newContent;
-
-            document.getElementById("field").focus();
-            document.execCommand("Delete");
-
-            // We clear the content div to avoid having its content appear in the test harness output.
-            if (window.testRunner)
-                contentDiv.innerHTML = "";
-        </script>
-    </body>
-</html>
index 7e3f84c..debe36f 100644 (file)
@@ -1,3 +1,16 @@
+2013-11-22  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Layout Test editing/deleting/password-delete-performance.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=124781
+
+        Reviewed by Alexey Proskuryakov.
+
+        Add a new performance test to replace editing/deleting/password-delete-performance.html.
+        We skip this test by default since it's a micro benchmark.
+
+        * Interactive/DeletingInPasswordField.html: Added.
+        * Skipped:
+
 2013-11-18  Sergio Villar Senin  <svillar@igalia.com>
 
         [CSS Grid Layout] Improve content-sized track layout
diff --git a/PerformanceTests/Interactive/DeletingInPasswordField.html b/PerformanceTests/Interactive/DeletingInPasswordField.html
new file mode 100644 (file)
index 0000000..afc0fd1
--- /dev/null
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div id="content" style="height:0px; overflow:hidden;"> </div>
+<input id="field" type="password" value="">
+<script src="../resources/runner.js"></script>
+<script>
+var content = document.getElementById('content');
+var field = document.getElementById('field');
+
+var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
+for (var i = 0; i < 12; i++)
+    newContent += newContent;
+content.innerHTML = newContent;
+
+PerfTestRunner.measureTime({
+    unit: 'ms',
+    setup: function () {
+        field.value = 'A';
+    },
+    run: function () {
+        field.focus();
+        document.execCommand('Delete');
+    },
+    done: function () {
+        content.innerHTML = '';
+    }
+});
+
+</script>
+</body>
+</html>
index 64b7513..a921882 100644 (file)
@@ -2,6 +2,7 @@
 DOM/TraverseChildNodes.html
 Interactive/SelectAll.html
 Interactive/CopyAll.html
+Interactive/DeletingInPasswordField.html
 
 # Not enabled by default on some ports
 Mutation